1e2fcfb
Fix unnecessarily-specific struct pattern in rust outline query (#18297)
Click to expand commit body
Fixes https://github.com/zed-industries/zed/issues/18294
Release Notes:
- Fixed a recent regression where tuple and unit structs were omitted
from the outline view in Rust (#18294).
ce3a635
project search: Fix search results not being highlighted (#18273)
Click to expand commit body
Closes #18254
Closes #18219
Closes #17690
This fixes the project search not highlighting all results.
The problem was relatively simple, even though it took a while to find
it: we inserted multiple excerpts concurrently and the order in the
multi-buffer ended up being wrong. Sorting the resulting `match_ranges`
fixed the problem, but as it turns out, we can do a better job by moving
the concurrency into the method on the MultiBuffer.
Performance is the same, but now the problem is fixed.
Release Notes:
- Fixed search results in project-wide search not being highlighted
consistently and navigation sometimes being broken (#18254, #18219,
---------
Co-authored-by: Bennet <bennet@zed.dev>
Thorsten Ball
and
Bennet
created
15931d1
Bump release_notes to v2 endpoint (#18108)
Click to expand commit body
Partially addresses https://github.com/zed-industries/zed/issues/17527
<img width="1608" alt="SCR-20240919-rcik"
src="https://github.com/user-attachments/assets/25057731-7da6-4b36-b51b-021c67e8736b">
Release Notes:
- Enhanced the `auto update: view release notes locally` feature to
display release notes for each patch version associated with the
installed minor version.
Joseph T. Lyons
created
2a5925c
Fix bug where copying from assistant panel appends extra newline to clipboard (#18090)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/17661
Release Notes:
- Fixed a bug where copying from the assistant panel appended an
additional newline to the end of the clipboard contents.
Joseph T. Lyons
created
153fb9e
Properly use default search options in the buffer search bar (#18271)
Click to expand commit body
Only replace current search options if the search was dismissed and the
new options are different from the default ones.
Follow-up of https://github.com/zed-industries/zed/pull/17179
Closes https://github.com/zed-industries/zed/issues/18166
Release Notes:
- Fixed buffer search options toggling unexpectedly on redeploys
([#18166](https://github.com/zed-industries/zed/issues/18166))
Kirill Bulatov
created
2330f0d
vtsls: Move all default configuration to workspace_configuration (#18259)
Click to expand commit body
This fixes https://github.com/zed-industries/zed/issues/18014 by fixing
the regression that was introduced in
https://github.com/zed-industries/zed/pull/17757.
In short: after digging into the `vtsls` code, it looks like it
essentially doesn't need any `initialization_options`, it's all
workspace configuration, since it tries to use the built-in settings
from VS Code.
I tested the completions, the inlay hints, the max memory - all of it
now works after moving to `workspace_configuration`.
Closes #18014.
Release Notes:
- Fixed `vtsls` being initialized the wrong way, which would mean the
wrong options were used to enable completions or inlay hints.
Thorsten Ball
created
76b7c1d
editor: Improve rewrapping when working with comments at different indentation levels (cherry-pick #18146) (#18147)
Click to expand commit body
Cherry-picked editor: Improve rewrapping when working with comments at
different indentation levels (#18146)
This PR improves the `editor::Rewrap` command when working with comments
that were not all at the same indentation level.
We now use a heuristic of finding the most common indentation level for
each line, using the deepest indent in the event of a tie.
It also removes an `.unwrap()` that would previously lead to a panic in
this case. Instead of unwrapping we now log an error to the logs and
skip rewrapping for that selection.
Release Notes:
- Improved the behavior of `editor: rewrap` when working with a
selection that contained comments at different indentation levels.
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
gcp-cherry-pick-bot[bot]
and
Marshall Bowers
created
d2894ce
pane: Do not autopin new item created as a neighbour of pinned tab (#18072)
Click to expand commit body
When I used editor::NewFile or ProjectSearch from a pinned tab, the
resulting new tab would be pinned (and the last pinned tab would be
pushed off). This PR fixes it by always storing new tabs outside of the
pinned area if there's no destination index for the new tab.
Release Notes:
- Fixed tab bar not preserving pinned tab state when an editor::NewFile
action is executed.
Piotr Osiewicz
created
d91e625
assistant: Fix offset calculation not in char boundary (#18069)
Click to expand commit body
Closes #17825
Release Notes:
- N/A
CharlesChen0823
created
3d5c023
ci: Move collab deploys back to DigitalOcean runners (#18071)
Click to expand commit body
This PR moves the collab deployment steps in CI back to the DigitalOcean
runners temporarily, so that we can deploy collab.
Release Notes:
- N/A
Marshall Bowers
created
4338ff6
terminal: Add ability to open file from Git diff (#17446)
Click to expand commit body
- strip "a/" and "b/" prefix for potential paths.
Release Notes:
- Allow clicking on filepaths when using `git diff` inside the built-in
terminal
Casey Watson
created
23e1faa
assistant panel: Fix copying code when trailing newline is missing (#18067)
Click to expand commit body
Follow-up to #17853.
Apparently tree-sitter-md extends the range of the content node to
include the backticks when there is no newline.
Release Notes:
- N/A
Co-authored-by: Bennet <bennet@zed.dev>
Thorsten Ball
and
Bennet
created
1723713
Add ability to copy assistant code block to clipboard or insert into editor, without manual selection (#17853)
Click to expand commit body
Some notes:
- You can put the cursor on the start or end line with triple backticks,
it doesn't actually have to be inside the block.
- Placing the cursor outside of a code block does nothing.
- Code blocks are determined by counting triple backticks pairs from
either start or end of buffer, and nothing else.
- If you manually select something, the selection takes precedence over
any code blocks.
Release Notes:
- Added the ability to copy surrounding code blocks in the assistant
panel into the clipboard, or inserting them directly into the editor,
without manually selecting. Place cursor anywhere in a code block
(marked by triple backticks) and use the `assistant::CopyCode` action
(`cmd-k c` / `ctrl-k c`) to copy to the clipboard, or the
`assistant::InsertIntoEditor` action (`cmd-<` / `ctrl-<`) to insert into
editor.
---------
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Co-authored-by: Bennet <bennet@zed.dev>
This PR adds `system_id` to telemetry, which is contained within a new
`global` database (accessible by any release channel of Zed on a single
system). This will help us get a more accurate understanding of user
count, instead of relying on `installationd_id`, which is different per
release channel. This doesn't solve the problem of a user with multiple
machines, but it gets us closer.
Release Notes:
- N/A
Joseph T. Lyons
created
5e6d181
Add stray UI tweaks on the task picker (#18059)
Click to expand commit body
This PR adds tiny UI tweaks to the task picker. Just making sure it is
consistent with other pickers throughout Zed.
| Before | After |
|--------|--------|
| <img width="577" alt="Screenshot 2024-09-19 at 12 07 44 PM"
src="https://github.com/user-attachments/assets/c0f010a3-6e08-47ee-9997-9df2b203977c">
| <img width="577" alt="Screenshot 2024-09-19 at 12 07 09 PM"
src="https://github.com/user-attachments/assets/74baf191-4dd9-4765-b2fd-2390d4cb31c6">
|
Release Notes:
- N/A
Danilo Leal
created
1b61210
linux: Fix invalid check for denylisted dependencies (#18050)
eef44af
extension: Re-enable `test_extension_store_with_test_extension` test (#18046)
Click to expand commit body
The `test_extension_store_with_test_extension` test was disabled in
#15446, which got merged before re-enabling the test.
This PR re-enables that test.
Release Notes:
- N/A
Marshall Bowers
created
106ca50
Fix leak of LMDB connection in semantic index (#17992)
Click to expand commit body
Apparently, to close LMDB's file descriptors when using the `heed`
library, you need to explicitly call `prepare_for_closing`.
Release Notes:
- N/A
---------
Co-authored-by: Richard Feldman <oss@rtfeldman.com>
Co-authored-by: Jason <jason@zed.dev>
Max Brunsfeld
,
Richard Feldman
, and
Jason
created
2cd9a88
Clean up after `isahc_http_client` introduction (#18045)
Click to expand commit body
This PR does some clean up after #15446.
Release Notes:
- N/A
Marshall Bowers
created
a62e8f6
ci: Explicitly set cache-provider for swatinem/rust-cache (#18034)
Click to expand commit body
- Switches the Cache Dependencies step (`swatinem/rust-cache`) of Linux
tests to use buildjet as `cache-provider`. Explicitly add 'github' (the
default cache provider) to other uses of `swatinem/rust-cache` for
consistency.
Release Notes:
- N/A
Peter Tripp
created
2c8a6ee
remote_server: Remove dependency on libssl and libcrypto (#15446)
9016de5
Update Rust crate anyhow to v1.0.89 (#18031)
Click to expand commit body
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [anyhow](https://redirect.github.com/dtolnay/anyhow) |
workspace.dependencies | patch | `1.0.86` -> `1.0.89` |
---
### Release Notes
<details>
<summary>dtolnay/anyhow (anyhow)</summary>
###
[`v1.0.89`](https://redirect.github.com/dtolnay/anyhow/releases/tag/1.0.89)
[Compare
Source](https://redirect.github.com/dtolnay/anyhow/compare/1.0.88...1.0.89)
- Make anyhow::Error's `UnwindSafe` and `RefUnwindSafe` impl
consistently available between versions of Rust newer and older than
1.72
([#​386](https://redirect.github.com/dtolnay/anyhow/issues/386))
###
[`v1.0.88`](https://redirect.github.com/dtolnay/anyhow/releases/tag/1.0.88)
[Compare
Source](https://redirect.github.com/dtolnay/anyhow/compare/1.0.87...1.0.88)
- Documentation improvements
###
[`v1.0.87`](https://redirect.github.com/dtolnay/anyhow/releases/tag/1.0.87)
[Compare
Source](https://redirect.github.com/dtolnay/anyhow/compare/1.0.86...1.0.87)
- Support more APIs, including `Error::new` and `Error::chain`, in
no-std mode on Rust 1.81+
([#​383](https://redirect.github.com/dtolnay/anyhow/issues/383))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
Release Notes:
- N/A
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Makes our nightly script for Linux x86 (broken) match the steps for Linux ARM (working).
Peter Tripp
created
71b6f73
Pin actions/checkout action to 692973e (#18030)
Click to expand commit body
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [actions/checkout](https://redirect.github.com/actions/checkout) |
action | pinDigest | -> `692973e` |
---
### Configuration
📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
Release Notes:
- N/A
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Run `apt-get update` before `apt-get install` on Linux. Hopefully will fix building on Linux Arm.
Peter Tripp
created
97dc1d1
Use `@tag.doctype` for HTML doctype highlights (#18024)
Click to expand commit body
This PR updates the following extensions to use the `@tag.doctype`
selector for highlighting HTML doctypes:
- Astro
- Elixir (HEEx)
- HTML
Additionally, it also changes the base selector for HTML tags from
`@keyword` to `@tag`.
| Before | After |
|
-------------------------------------------------------------------------------------------------------------------------------------------------
|
-------------------------------------------------------------------------------------------------------------------------------------------------
|
| <img width="308" alt="Screenshot 2024-09-18 at 2 04 41 PM"
src="https://github.com/user-attachments/assets/818d98ba-fce7-4683-b67f-61c86543831c">
| <img width="358" alt="Screenshot 2024-09-18 at 2 05 00 PM"
src="https://github.com/user-attachments/assets/5071db7c-e0bf-44df-8959-38275833833b">
|
Extracted this from https://github.com/zed-industries/zed/pull/16723.
Release Notes:
- N/A
---------
Co-authored-by: 狐狸 <134658521+Huliiiiii@users.noreply.github.com>
Marshall Bowers
and
狐狸
created
772bda5
Move remaining self-hosted jobs to BuildJet (#18018)
Peter Tripp
created
fb7a7a5
ssh remoting: open settings locally (#18020)
Click to expand commit body
Release Notes:
- ssh remoting: Open settings files in a non-remote window.
eda7e88
nix: Fix (potential) glibc errors in dev shell (#17974)
Click to expand commit body
Previously the rustc and cargo did were not declared dependencies
supplied to devshell. This means that shell relied some impure cargo and
rustc version found in the system. This lead to issues with GLIBC
version on systems which have different GLIBC version globally.
This package exposes nixpkgs rustc and cargo version into the shell
preventing issues with incompatibility.
Release Notes:
- N/A
373a17a
Add ability to display backgrounds for inlay hints (#18010)
Click to expand commit body
This PR adds the ability to display backgrounds for inlay hints within
the editor.
This is controlled by the new `inlay_hints.show_background` setting.
This setting defaults to `false`.
To enable the setting, add the following to your `settings.json`:
```json
{
"inlay_hints": {
"enabled": true,
"show_background": true
}
}
```
When enabled, the inlay hint backgrounds will use the `hint.background`
color from the theme.
| Disabled | Enabled |
|
--------------------------------------------------------------------------------------------------------------------------------------------------
|
--------------------------------------------------------------------------------------------------------------------------------------------------
|
| <img width="1624" alt="Screenshot 2024-09-17 at 4 21 53 PM"
src="https://github.com/user-attachments/assets/5534d09b-1e22-4c6f-9d82-314796ed7d22">
| <img width="1624" alt="Screenshot 2024-09-17 at 4 21 43 PM"
src="https://github.com/user-attachments/assets/6ec58cde-6115-4db4-be95-97c5f2f54b2d">
|
Related issues:
- #12485
- #17392
Release Notes:
- Added an `inlay_hints.show_background` setting to allow displaying
backgrounds for inlay hints in the editor.
- This setting defaults to `false`.
- If enabled, the inlay hint backgrounds will use the `hint.background`
color from the theme.
3b153a5
docs: Improve dark mode syntax highlighting (#18002)
Click to expand commit body
This PR introduces [GitHub
Light](https://github.com/highlightjs/highlight.js/blob/main/src/styles/github.css)
and [GitHub
Dark](https://github.com/highlightjs/highlight.js/blob/main/src/styles/github-dark.css)
as the syntax highlighting themes for the corresponding modes.
Release Notes:
- N/A
This PR is a quick follow-up to
https://github.com/zed-industries/zed/pull/1795. 😊
Release Notes:
- N/A
Danilo Leal
created
a149a50
docs: Fix links on the Telemetry page (#17995)
Click to expand commit body
This PR tweaks some broken links in the Telemetry page as well as
capitalizing instances of "Zed".
Release Notes:
- N/A
Danilo Leal
created
f68f4ab
docs: Add tweaks to the REPL page (#18000)
Click to expand commit body
Just capitalizing some things, making sure URLs are clickable links, and
using the note blockquote callout when appropriate.
Release Notes:
- N/A
Danilo Leal
created
aae26ee
go: Fix tasks when running tests/benchs in packages (#17998)
Click to expand commit body
Turns out that #17645 reintroduced another regression and didn't catch
all the regressions in #17108.
Releases Notes:
- Fixed Go tasks not working properly when running tests or benchmarks
in subfolders/packages.
Co-authored-by: Piotr <piotr@zed.dev>
Thorsten Ball
and
Piotr
created
550ceec
docs: Update Ruby docs to provide more complete examples (#17987)