a23e381
assistant: Pass up tool results in LLM request messages (#17656)
Click to expand commit body
This PR makes it so we pass up the tool results in the `tool_results`
field in the request message to the LLM.
This required reworking how we track non-text content in the context
editor.
We also removed serialization of images in context history, as we were
never deserializing it, and thus it was unneeded.
Release Notes:
- N/A
---------
Co-authored-by: Antonio <antonio@zed.dev>
ae3880e
Add ability to open files with system default application (#17231)
KorigamiK
created
06142f9
Use the configured UI font size for the inline assistant (#17542)
Niklas Haas
created
fb9d01b
assistant: Add display_name for OpenAI and Gemini (#17508)
Peter Tripp
created
85f4c96
Ubuntu 22 (Linux arm runner) fixes (#17643)
Click to expand commit body
Our GitHub Actions Linux ARM hosted runner was running Ubuntu 20 was EOL'd.
This gets builds working on the Ubuntu 22 Linux ARM runner which have spun to replace the EOL'd one. It pushes forward our Glibc requirement for Linux ARM users (was >= 2.29, now >= 2.35; sorry!) but also uses a newer version of clang/llvm (was 10, now 15; yay!).
Peter Tripp
created
0b0cd90
assistant: Fix file slash command not allowing to select multiple files when pressing tab (#17652)
Click to expand commit body
Release Notes:
- Allow to add multiple files in a single `/file` command when pressing
tab
Bennet Bo Fenner
created
5f61e31
Fix vim surround behavior around text objects (#17603)
Click to expand commit body
Performing `ysa")` on `"Hello World"` should produce `("Hello World")`.
Instead it places the parens inside the quotes (i.e. `"(Hello World)"`).
This PR fixes the behavior by preserving the `around` flag from the
operator sequence.
Closes #12976 and partially fixes #13841
Release Notes:
- Fixed the behavior of surrounding a text object in vim.
Eric Andres
created
d5498c5
assistant: Fix terminal inline assistant not showing retry on error (#17651)
Click to expand commit body
Release Notes:
- Fixed an issue where a failed inline assistant prompt could not be
restarted
a078cb1
Disable definition lists in Markdown (#17648)
Click to expand commit body
This PR disables definition list support in `pulldown_cmark`, as it is
has been causing a number of issues.
I opened an issue upstream with the panic we were seeing:
https://github.com/pulldown-cmark/pulldown-cmark/issues/957.
Release Notes:
- N/A
Marshall Bowers
created
93b3520
assistant: Prevent possible execution of generated terminal commands (#17647)
Click to expand commit body
Closes #17424
Release Notes:
- Fixed an issue where commands generated by the terminal command could
sometimes be executed without confirmation
Bennet Bo Fenner
created
bf64c08
go: Fix regression by restoring regex to match tests (#17645)
Click to expand commit body
This fixes a regression that snuck in with #17108.
When running a single test with `go test` the
regex wouldn't be used anymore.
This restores the old behavior.
Release Notes:
- Fixed a regression when running Go tests. A recent change dropped the
regex used to match single test names when using `go test` in tasks to
run tests. That could lead to more or the wrong tests being run. This
restores the old behavior.
Thorsten Ball
created
929eff8
project panel: Get rid of unwrap in autofolding code (#17641)
Click to expand commit body
@WeetHet spotted a crash in recently-introduced project panel
autofolding that relates to unwrapping.
Release Notes:
- N/A
Piotr Osiewicz
created
75256bd
lsp: Add support for workspace/workspaceFolders request (#17639)
Click to expand commit body
Related to: #17574
Release Notes:
- N/A
Piotr Osiewicz
created
56bc3c3
project search: make sorting comparator comply with Ord preconditions (#17604)
2fc74a1
Update doc comments with tabs.file_icons default (#17629)
Click to expand commit body
The diff only contains doc comments changes, however I expect this also
fixes generating JSON Schema which generated by
[schemars](https://github.com/GREsau/schemars/blob/092dc17ae4831d42974653588cebcc089d07493e/docs/examples/6-doc_comments.md).
This default value is actually true at first.
1818fef32f24f24f082c6f34a4c3100add6d328c
However, it was changed in the following commit.
bf7e474bbcc2fadf002adb273e2584c77c1573e3
Closes #17628
Release Notes:
- N/A
Kenichi Kamiya
created
f71cb14
Add ',' to word chars for line wrapping (#17590)
Click to expand commit body
Closes #16407
Adds ',' to the is_word_char() matches for line wrapping, so that commas
aren't wrapped to the start of a new line.
Release Notes:
- N/A
ZZzzaaKK
created
da9601c
markdown: Handle definition lists in parser (#17617)
Click to expand commit body
Resolves https://github.com/zed-industries/zed/issues/17607.
This PR makes it so the Markdown parser can handle Markdown containing
definition lists.
Note that this is just parser support, we aren't yet doing anything with
the definition lists themselves.
Release Notes:
- N/A
Marshall Bowers
created
c119387
Fix blurry cursor on Wayland at a scale other than 100% (#17496)
Click to expand commit body
Closes #13258
Release Notes:
- Fixed blurry mouse cursor on wayland when the screen scale is other
than 100%
Before:

After:

Addresses parts of feedback from
https://www.jacobcolling.com/friction-log/zed-friction-log
Release Notes:
- "Assistant::NewContext" now automatically does quote selection as well
- "Assistant::QuoteSelection" now handles multicursor selections,
inserting multiple excerpts.
Piotr Osiewicz
created
dd257b8
project panel: Do not allow collapsing auto-folded directory past the list of ancestors (#17594)
Click to expand commit body
Closes #ISSUE
Release Notes:
- N/A
Piotr Osiewicz
created
fcf79c0
assistant: Support copy/pasting creases (#17490)
Click to expand commit body
https://github.com/user-attachments/assets/78a2572d-8e8f-4206-9680-dcd884e7bbbd
Release Notes:
- Added support for copying and pasting slash commands in the assistant
panel
---------
Co-authored-by: Thorsten <thorsten@zed.dev>
Related to #17179.
Simplify handling of search settings since there is no requirement to
watch for settings.json changes and update search panels while they are
opened.
Attn: @SomeoneToIgnore
Per our discussion. Ran test on search crate. Ran `cargo fmt`.
Release Notes:
- N/A
thataboy
created
63188b6
Fix parenthesis matching for file links in terminal (#17512)
Click to expand commit body
Closes #17391
Release Notes:
- Fixed parenthesis matching for file links in terminal
([#17391](https://github.com/zed-industries/zed/issues/17391))
saahityaedams
created
65961b8
Add a way to configure default search options (#17179)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/4646
```json
// Search options to enable by default when opening new project and buffer searches.
"search": {
"whole_word": false,
"case_sensitive": false,
"include_ignored": false,
"regex": false
}
```
Release Notes:
- Added `search` settings section to configure default options enabled
in buffer and project searches
([#4646](https://github.com/zed-industries/zed/issues/4646))
---------
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
thataboy
and
Kirill Bulatov
created
8985fd8
Fix different kinds values used for `worktree_id` (#17523)
Kirill Bulatov
created
47aec5e
Improve popup menu to leave some margin with window edges (#17159)
Click to expand commit body
Release Notes:
- Improved popup menu to leave some margin with window edges.
## Updates in GPUI
- gpui: Add `snap_to_window_with_margin` method to `anchored` to support
leave margin to window edges.
## Before
<img width="609" alt="before-snap-to-window 2024-08-30 222506"
src="https://github.com/user-attachments/assets/62bb6791-7c89-4558-9484-5c7b31f5e91e">
## After
<img width="698" alt="snap-to-window1 2024-08-30 222506"
src="https://github.com/user-attachments/assets/51634e79-2a95-42fe-8362-a3c7003648eb">
<img width="622" alt="snap-to-window 2024-08-30 222506"
src="https://github.com/user-attachments/assets/43a865d6-d238-4fdc-ae9d-8160b9ba7953">
Jason Lee
created
b401f69
pane: Add tooltips to close/unpin buttons (#17521)
Click to expand commit body
These tooltips also showcase keybinds when the tab is an active one. /cc
@danilo-leal
Release Notes:
- N/A
This PR adds some tiny design tweaks to the git blame tooltip. I guess
the most "notable", so to speak, thing is the addition of a divider
between the pull request and commit hash buttons. I was motivated to do
that because, at first, I was unsure what the copy button would copy
(the PR number or the hash?). From the position only, you eventually
figure out, but hopefully, the divider will help bumping this affordance
a bit more. I experimented with adding a labeled "Copy commit hash"
button, but that'd clutter the design too much. Additionally, the top
border on the footer should also slightly help indicating the commit
message area is scrollable.
| Before | After |
|--------|--------|
| <img width="518" alt="Screenshot 2024-09-06 at 4 54 41 PM"
src="https://github.com/user-attachments/assets/68d8335d-946d-4149-b241-6892c0b9577e">
| <img width="513" alt="Screenshot 2024-09-06 at 4 55 26 PM"
src="https://github.com/user-attachments/assets/1dc1b47c-1b7f-4e94-a2c1-7e54b9940689">
|
---
Release Notes:
- N/A
Danilo Leal
created
c90ae3d
vim: Fix matching brackets with 1 offset in normal mode (#17396)
f91bf7f
blade: Update to e142a3a to fix crash (#17510)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/17005
Like https://github.com/zed-industries/zed/pull/17319, but based on
https://github.com/kvark/blade/pull/144.
This should be cherry-picked into preview if possible 🙂
Release Notes:
- Linux: Fixed crash when closing windows on Wayland.
apricotbucket28
created
832e3e7
chore: Revert changes made to ui crate structure (#17516)
Click to expand commit body
As a part of https://github.com/zed-industries/zed/pull/17488 I
flattened module structure of ui crate to fix module_inception lint.
However, that's actually unnecessary as we can pass that lint via a
custom knob for clippy.
Closes #ISSUE
Release Notes:
- N/A
Piotr Osiewicz
created
986e011
docs: Add copywriting and design tweaks (#17514)
Click to expand commit body
Follow up to https://github.com/zed-industries/zed/pull/17505. This one
contains a bit more copywriting adjustments. Figured we were using the
"You can do x..." sentence shape quite frequently, so tried to kickstart
reducing that slightly. There are also more images not loading in
complement to the one I removed, but I'm not fully sure why that's the
case.
---
Release Notes:
- N/A
Danilo Leal
created
0b17c72
Minor improvements to release tooling (#17502)
Click to expand commit body
- bump-version.sh: Push tag before branch; speeds up release action runs (built from tag).
- get-changes: Fetch GITHUB_ACCESS_TOKEN via `gh auth token` if env var unset.
We accidentally do not accept prompts with an empty list of arguments,
as opposed to non given arguments list. We need to allow these. We also
not really supporting non required arguments, despite the protocol
describing it. This is a first iteration on fixing this as well.
Release Notes:
- N/A
This PR adds several design tweaks to elements of the documentation,
most notably swapping the heading title font from `PPAgrandir` to
`Lora`, which makes the docs consistent with the new website. Aside from
this, there's also some tiny, low-hanging content adjustments to a few
pages.
---
Release Notes:
- N/A
Makes YAML language server configurable under `lsp.yaml-language-server`:
- Add support for `initialization_options`
- Add support for custom `bin` specification
Peter Tripp
created
903f920
lsp: Watch paths outside of worktrees at language servers request (#17499)
Click to expand commit body
Another stab at https://github.com/zed-industries/zed/pull/17173, this
time fixing the segfault found in
https://github.com/zed-industries/zed/pull/17206
Release Notes:
- Improved language server reliability in multi-worktree projects and
monorepo. We now notify the language server more reliably about which
files have changed.
**UPDATE**: Response so far seems to be that this fixes the performance
issues on Intel MacBooks. So we're going to go ahead and merge it.
This reverts the FPS counter added in 11753914d (#16422) because in this
issue someone bisected recent performance regressions down to this
commit:
- https://github.com/zed-industries/zed/issues/16729
Another issue that's possibly related:
-
https://github.com/zed-industries/zed/issues/17305#issuecomment-2332316242
We're reverting this in a PR to create a bundle that people can try out.
Assets:
- Universal Binary:
https://github.com/zed-industries/zed/actions/runs/10735702994/artifacts/1900460781
- x86/Intel:
https://github.com/zed-industries/zed/actions/runs/10735702994/artifacts/1900461236
- Apple Silicon:
https://github.com/zed-industries/zed/actions/runs/10735702994/artifacts/1900460978
Release Notes:
- Removed the recently-added FPS counter since the changes it made to
the Metal renderer on macOS could lead to performance regressions on
Intel MacBooks.
Co-authored-by: Bennet <bennet@zed.dev>
Thorsten Ball
and
Bennet
created
54dd408
Fix `Workspace` references being leaked (#17497)
Click to expand commit body
We noticed that the `Workspace` was never released (along with the
`Project` and everything that comes along with that) when closing a
window.
After playing around with the LeakDetector and debugging with
`cx.on_release()` callbacks, we found two culprits: the inline assistant
and the outline panel.
Both held strong references to `View<Workspace>` after PR #16589 and PR
#16845.
This PR changes both references to `WeakView<Workspace>` which fixes the
leak but keeps the behaviour the same.
Release Notes:
- N/A
Co-authored-by: Bennet <bennet@zed.dev>