Commits in v0.156.0 | Zed (mirror)

Commit log

`3fafdeb` gpui: Fix blur region on Plasma/Wayland (#18465)

Click to expand commit body

Once again aping after what winit does - since we always want to have
the whole window blurred there is apparently no need to specify a blur
region at all. Rounded corners would be the exception, but that is not
possible with the current protocol (it is planned for the vendor-neutral
version though!)

This eliminates the problem where only a fixed region of the window
would get blurred if the window was resized to be larger than at launch.
Also a drive-by comment grammar fix :wink:

Release Notes:

- Fixed blur region handling on Plasma/Wayland

jansol created 1 year ago

`898d48a` php: Add syntax highlighting inside heredoc strings (#18368)

Click to expand commit body

PHP heredoc strings make it easy to define string literals over multiple
lines:

```php
    $someString = <<<EOT
        multiline
        text
        EOT;
```

That `EOT` identifier can be anything else, and it is actually being
used in Sublime Text and VS Code to inject syntax highlighting for
another language in said string, depending on the identifier. For
instance, if the identifier is SQL, SQL syntax highlighting will be
applied to the contents of the string. Likewise if the identifier is CSS
or JS.

```php
    $someString = <<<SQL
        SELECT *
        FROM my_table
        SQL;
```

This PR changes the PHP extension so that it supports that feature too.

Release Notes:

- php: Added syntax highlighting inside heredoc strings

Sylvain Brunerie created 1 year ago

`5b40deb` Don't stop loading the env if direnv call fails (#18473)

Click to expand commit body

Before this we we would stop loading the environment if the call to
direnv failed, which is not necessary in any way
cc @mrnugget

Release Notes:

- Fixed the environment not loading if `direnv` mode is set to `direct`
and `.envrc` is not allowed

Stanislav Alekseev created 1 year ago

`e39695b` docs: Update msys2 section in development/windows (#18385)

Click to expand commit body

merge after
https://packages.msys2.org/packages/mingw-w64-clang-x86_64-zed is
available. alternatively you can check the
[queue](https://packages.msys2.org/queue) for build status

Zed now compiles and runs under msys2/CLANG64 environment, so change the
docs to give the users a choice of their environment

Release Notes:

- N/A

Maksim Bondarenkov created 1 year ago

`77df7e5` settings: Make external formatter arguments optional (#18340)

Click to expand commit body

If specifying a formatter in the settings like this:

    "languages": {
      "foo": {
        "formatter": {
          "external": {
            "command": "/path/to/foo-formatter"
          }
        }
      }
    }

Zed will show an error like this:

    Invalid user settings file
    data did not match any variant of untagged enum SingleOrVec

This is because the arguments are not optional. The error is hard to
understand, so let's make the arguments actually optional, which makes
the above settings snippet valid.

Release Notes:

- Make external formatter arguments optional

Tom Wieczorek created 1 year ago

`250f2e7` tasks: Display runnables at the start of folds (#18526)

Click to expand commit body

Release Notes:

- Fixed task indicators not showing up at the starts of folds.

Piotr Osiewicz created 1 year ago

`5f35fa5` Associate `uv.lock` files with TOML (#18426)

Click to expand commit body

The `uv` python package manager uses the TOML for it's `uv.lock` file,
see https://docs.astral.sh/uv/guides/projects/#uvlock.

Ref #7808

Release Notes:

- associate `uv.lock` files with the TOML language

Thorben Kröger created 1 year ago

`84ce81c` Pass `Summary::Context` to `Item::summarize` (#18510)

Click to expand commit body

We are going to use this in the multi-buffer to produce a summary for an
`Excerpt` that contains a `Range<Anchor>`.

Release Notes:

- N/A

Co-authored-by: Nathan <nathan@zed.dev>

Antonio Scandurra and Nathan created 1 year ago

`8aeab48` Continue to redirect to GitHub commits for nightly and dev release notes (#18487)

Click to expand commit body

We are now using the `view release notes locally` action when clicking
on the update toast - the endpoint for this action does not currently
return anything for valid for these channels, as we don't have support
yet for diffing between these builds, so for now, [continue to do what
the `view release notes` action did and just send the user to the commit
view on
GitHub](https://github.com/zed-industries/zed/blob/caffb2733f8e859637050e3708dbd10b6e409762/crates/auto_update/src/auto_update.rs#L255-L260).
It is a bit counterintuitive to send the user to the browser when using
the "local" action, but this is just a patch in the interim.

If we make adjustments to our channels to keep the nightly tag stable
and add some sort of unique suffix, like a timestamp, we can then adjust
things to return these in the request body and show them in the editor.

Release Notes:

- N/A

Joseph T. Lyons created 1 year ago

`1021f0e` Show release notes locally when showing update notification (#18486)

Click to expand commit body

Closes https://github.com/zed-industries/zed/issues/17527

I think we are ok to switch to using the local action now. There are a
few things we don't support, like media, but we don't include media
directly too often, and I think this might help push the community to
maybe add support for it. That being said, I updated the markdown coming
back from the endpoint to include links to the web version of the
release notes, so they can always hop over to that version, if they
would like.


https://github.com/user-attachments/assets/b4d207a7-1640-48f1-91d0-94537f74116c

All forming of the Markdown happens in the endpoint, so if someone with
a better eye wants to update this, you can do that here:


https://github.com/zed-industries/zed.dev/blob/0e5923e3e7d1caa8b4bf32d0a7f8999b34dbe64c/src/pages/api/release_notes/v2/%5Bchannel_type%5D/%5Bversion%5D.ts#L50-L62

Release Notes:

- Changed the `view the release notes` button in the update toast to
trigger the local release notes action.

Joseph T. Lyons created 1 year ago

`675673e` Fine-tune hunk control spacing (#18463)

Click to expand commit body

<img width="900" alt="Screenshot 2024-09-28 at 1 09 35 AM"
src="https://github.com/user-attachments/assets/0b9d744f-3b92-488a-bc74-987f5a9d8c6c">

---

Release Notes:

- N/A

Danilo Leal created 1 year ago

`3737d4e` Add tooltip for code actions icon button (#18461)

Click to expand commit body

I have just recently discovered this keybinding myself out of talking to
folks, ha. The tooltip here might ease the discovery for other folks in
the future.

<img width="700" alt="Screenshot 2024-09-27 at 11 04 28 PM"
src="https://github.com/user-attachments/assets/844d3b55-15af-47f7-a8db-5c8832ceba29">

---

Release Notes:

- N/A

Danilo Leal created 1 year ago

`0daa070` More git hunk highlighting fixes (#18459)

Click to expand commit body

Follow-up to https://github.com/zed-industries/zed/pull/18454

Release Notes:

- N/A

Max Brunsfeld created 1 year ago

`689da9d` Move git hunk controls to the left side (#18460)

Click to expand commit body

![Screenshot 2024-09-27 at 1 05
14 PM](https://github.com/user-attachments/assets/260a7d05-daa8-4a22-92bc-3b956035227f)

Release Notes:

- N/A

Max Brunsfeld created 1 year ago

`1c5be9d` Capitalize tooltip labels on buffer search (#18458)

Click to expand commit body

For consistency, as this seems to be the pattern we're using overall for
labels and buttons.

---

Release Notes:

- N/A

Danilo Leal created 1 year ago

`d5f6740` Install cargo-edito without extra features (#18457)

Click to expand commit body

https://github.com/killercup/cargo-edit/pull/907 removed the feature
from the crate

Release Notes:

- N/A

Kirill Bulatov created 1 year ago

`c3075df` Fix bugs in diff hunk highlighting (#18454)

Click to expand commit body

Fixes https://github.com/zed-industries/zed/issues/18405

In https://github.com/zed-industries/zed/pull/18313, we introduced a
problem where git addition highlights might spuriously return when
undoing certain changes. It turned out, there were already some cases
where git hunk highlighting was incorrect when editing at the boundaries
of expanded diff hunks.

In this PR, I've introduced a test helper method for more rigorously
(and readably) testing the editor's git state. You can assert about the
entire state of an editor's diff decorations using a formatted diff:

```rust
    cx.assert_diff_hunks(
        r#"
        - use some::mod1;
          use some::mod2;
          const A: u32 = 42;
        - const B: u32 = 42;
          const C: u32 = 42;
          fn main() {
        -     println!("hello");
        +     //println!("hello");
              println!("world");
        +     //
        +     //
          }
          fn another() {
              println!("another");
        +     println!("another");
          }
        - fn another2() {
              println!("another2");
          }
        "#
        .unindent(),
    );
```

This will assert about the editor's actual row highlights, not just the
editor's internal hunk-tracking state.

I rewrote all of our editor diff tests to use these more high-level
assertions, and it caught the new bug, as well as some pre-existing bugs
in the highlighting of added content.

The problem was how we *remove* highlighted rows. Previously, it relied
on supplying exactly the same range as one that we had previously
highlighted. I've added a `remove_highlighted_rows(ranges)` APIs which
is much simpler - it clears out any row ranges that intersect the given
ranges (which is all that we need for the Git diff use case).

Release Notes:

- N/A

Max Brunsfeld created 1 year ago

`caaa9a0` Remove Qwen2 model (#18444)

Click to expand commit body

Removed deprecated Qwen2 7B Instruct model from zed.dev provider (staff
only).

Release Notes:

- N/A

Richard Feldman created 1 year ago

`ffd1083` vim: Command selection fixes (#18424)

Click to expand commit body

Release Notes:

- vim: Fixed cursor position after `:{range}yank`.
- vim: Added `:fo[ld]`, `:foldo[pen]` and `:foldc[lose]`

Conrad Irwin created 1 year ago

`6d4ecac` Add a `get-release-notes-since` script (#18445)

Click to expand commit body

Release Notes:

- N/A

Joseph T. Lyons created 1 year ago

`dc5ffe6` Fix GoToDefinition changing the viewport unnecessarily (#18441)

Click to expand commit body

Closes #10738.

Release Notes:

- Fixed `GoToDefinition` changing the viewport (scrolling up/down) even when the definition is already within the viewport. ([#10738](https://github.com/zed-industries/zed/issues/10738))

Ömer Sinan Ağacan created 1 year ago

`03c7f08` docs: Ollama api_url improvements (#18440)

Peter Tripp created 1 year ago

`73ff8c0` Fix missing tooltips for selected buttons (#18435)

Click to expand commit body

Reverts #13857. Hiding tooltips for selected buttons prevents tooltips
like "Close x dock" from showing up, see #14938 for an example.
The intention of the original PR was to hide the "Show application menu"
tooltip, while the context menu is open.
In order to fix this without breaking other UI elements, we track the
state of the context menu using `PopoverMenuHandle` now, which allows us
to prevent the tooltip from showing up while the context menu is open.

Closes #14938

Release Notes:

- Fixed an issue where some tooltips would not show up

Bennet Bo Fenner created 1 year ago

`1c5d9c2` Add missing shortcuts in tooltips (#18282)

Click to expand commit body

Fixes some missing shortcuts from Tooltips like the project search,
buffer search, quick action bar, ....


https://github.com/user-attachments/assets/d3a0160a-8d6e-4ddc-bf82-1fabeca42d59

This should hopefully help new users learn and discover some nice
keyboard shortcuts

Release Notes:

- Display keyboard shortcuts inside tooltips in the project search,
buffer search etc.

Bennet Bo Fenner created 1 year ago

`a1d2e11` assistant: Fix copy/cut not working when selection is empty (#18403)

Click to expand commit body

Release Notes:

- Fixed copy/cut/paste not working in the assistant panel when selection
was empty

Bennet Bo Fenner created 1 year ago

`568a21a` Fix the numeration in line wrap docs (#18428)

Click to expand commit body

Follow-up of https://github.com/zed-industries/zed/pull/18412

Release Notes:

- N/A

Co-authored-by: Thorsten Ball <thorsten@zed.dev>

Kirill Bulatov and Thorsten Ball created 1 year ago

`5199135` ssh remoting: Show error if opening connection timed out (#18401)

Click to expand commit body

This shows an error if opening a connection to a remote host didn't work
in the timeout of 10s (maybe we'll need to make that configurable in the
future? for now it seems fine.)

![screenshot-2024-09-26-18 01
07@2x](https://github.com/user-attachments/assets/cbfa0e9f-9c29-4b6c-bade-07fdd7393c9d)


Release Notes:

- N/A

---------

Co-authored-by: Bennet <bennet@zed.dev>
Co-authored-by: Conrad <conrad@zed.dev>

Thorsten Ball , Bennet , and Conrad created 1 year ago

`8559731` project: Fix worktree store event missing in remote projects (#18376)

Click to expand commit body

Release Notes:

- N/A

CharlesChen0823 created 1 year ago

`02d0561` Fix read timeout for ollama (#18417)

Click to expand commit body

Supercedes: #18310

Release Notes:

- Fixed `low_speed_timeout_in_seconds` for Ollama

Conrad Irwin created 1 year ago

`1be3c44` vim: Support za (#18421)

Click to expand commit body

Closes #6822
Updates #5142 

Release Notes:

- Added new fold actions to toggle folds (`cmd-k cmd-l`), fold every
fold (`cmd-k cmd-0`) unfold every fold (`cmd-k cmd-j`) to fold
recursively (`cmd-k cmd-[`) and unfold recursively (`cmd-k cmd-]`).
- vim: Added `za` to toggle fold under cursor.
- vim: Added `zO`/`zC`/`zA` to open, close and toggle folds recursively
(and fixed `zc` to not recurse into selections).
- vim: Added `zR`/`zM` to open/close all folds in the buffer.

Conrad Irwin created 1 year ago

`32605e9` Fix register selection in visual mode (#18418)

Click to expand commit body

Related to #12895

Release Notes:

- vim: Fix register selection in visual yank

Conrad Irwin created 1 year ago

`c83d007` Remove non-wrapping settings from the language configuration (#18412)

Click to expand commit body

Closes https://github.com/zed-industries/zed/issues/17736

Those are limited with 1024 symbols before wrapping still, and were
introduced for git diff deleted hunks display.
Instead of confusing people with actually wrapping, restores behavior
that was before https://github.com/zed-industries/zed/pull/11080

Release Notes:

- Removed confusing soft wrap option behavior
([#17736]https://github.com/zed-industries/zed/issues/17736)

Kirill Bulatov created 1 year ago

`48c6eb9` Add script to generate license dependencies as csv (#18411)

Click to expand commit body

Co-authored-by: Joseph T. Lyons <JosephTLyons@gmail.com>

Peter Tripp and Joseph T. Lyons created 1 year ago

`e28496d` Stop leaking isahc assumption (#18408)

Click to expand commit body

Users of our http_client crate knew they were interacting with isahc as
they set its extensions on the request. This change adds our own
equivalents for their APIs in preparation for changing the default http
client.

Release Notes:

- N/A

Conrad Irwin created 1 year ago

`c1a039a` Remove old project search code path, bump min-supported zed version for collaboration (#18404)

Click to expand commit body

Release Notes:

- N/A

Max Brunsfeld created 1 year ago

`71da81c` SSH Remoting: Fix bugs in worktree syncing (#18406)

Click to expand commit body

Release Notes:

- N/A

---------

Co-authored-by: conrad <conrad@zed.dev>

Mikayla Maki and conrad created 1 year ago

`1105876` Add ability to separately set background color for highlighted brackets (#17566)

Click to expand commit body

Closes https://github.com/zed-industries/zed/issues/16380

Currently brackets are highlighted with
`editor.document_highlight.read_background`. This commit adds a separate
`editor.document_highlight.bracket_background` theme setting so bracket
highlights can be made more prominent without doing the same to other
highlights, making the display too busy.

(My own theme)


https://github.com/user-attachments/assets/29a8c05e-2f1a-4c16-9be8-a4b4cb143548

I set defaults for light and dark theme that I hope are sensible and not
too obnoxious, but noticeable so people can change it if they don't like
it.

Release Notes:

- Added `editor.document_highlight.bracket_background` field to the
theme to set background color of highlighted brackets.
- This will fall back to `editor.document_highlight.read_background`, if
not set.

<img width="355" alt="Screenshot 2024-09-08 at 8 46 57 AM"
src="https://github.com/user-attachments/assets/3270bb4d-19f5-4b34-8003-982377b2ceb6">
<img width="444" alt="Screenshot 2024-09-08 at 9 03 27 AM"
src="https://github.com/user-attachments/assets/3b12d84d-913c-4bde-9132-9b10f4a8d49b">

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>

thataboy and Marshall Bowers created 1 year ago