a15b109
Add ssh initialization events (#18831)
Click to expand commit body
Release Notes: - N/A
Joseph T. Lyons created
a15b109
Add ssh initialization events (#18831)
Release Notes: - N/A
Joseph T. Lyons created
5387a6f
Fix an issue where LLM requests would block forever (#18830)
Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Mikayla Maki and Marshall Bowers created
8cdb9d6
Fix a bug where HTTP errors where being reported incorrectly (#18828)
Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Mikayla Maki and Marshall Bowers created
7d380e9
Temporarily prevent deploying collab to production (#18825)
This PR adds a temporary measure to prevent deploying collab to production, while we investigate some issues stemming from the HTTP client change. Release Notes: - N/A
Marshall Bowers created
60c12a8
ssh: Remove old dev servers code paths (#18823)
Closes #ISSUE Release Notes: - N/A
Piotr Osiewicz created
11206a8
ui: Fix avatar indicators getting cut off (#18821)
This PR fixes an issue introduced in #18810 that was causing the avatar indicators to get cut off. Release Notes: - N/A
Marshall Bowers created
c83690f
storybook: Wire up HTTP client (#18818)
This PR wires up the HTTP client in the Storybook. Release Notes: - N/A
Marshall Bowers created
d1a7587
php: Bump to v0.2.1 (#18815)
This PR bumps the PHP extension to v0.2.1. Changes: - https://github.com/zed-industries/zed/pull/18368 - https://github.com/zed-industries/zed/pull/18774 Release Notes: - N/A
Marshall Bowers created
7c71515
proto: Bump to v0.2.0 (#18814)
This PR bumps the Protobuf extension to v0.2.0. Changes: - https://github.com/zed-industries/zed/pull/18763 Release Notes: - N/A
Marshall Bowers created
a3b6344
ssh: Do not cancel connection process if user is typing password (#18812)
Previously, the connection process would be cancelled after 10 seconds, even if the connection was established successfully but the user was still typing in a password. We know recognize when the user is prompted for a password, and cancel the timeout task. Co-Authored-by: Thorsten <thorsten@zed.dev> Release Notes: - N/A --------- Co-authored-by: Thorsten <thorsten@zed.dev>
Bennet Bo Fenner and Thorsten created
65c9b15
Remove avatar shape (#18810)
This PR re-removes `AvatarShape` as it is unused. The previous time it was removed incorrectly, resulting in square avatars! Release Notes: - N/A
Nate Butler created
25a97a6
ssh: Detect timeouts when server is unresponsive (#18808)
To detect connection timeouts we ping the remote server every X seconds and attempt to reconnect if the server failed to respond. Next up is showing some feedback in the UI to make this visible to the user, and stop reconnecting after X amount of retries. Release Notes: - N/A --------- Co-authored-by: Thorsten <thorsten@zed.dev>
Bennet Bo Fenner and Thorsten created
5aa165c
ssh: Overhaul remoting UI (#18727)
Release Notes: - N/A --------- Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Piotr Osiewicz and Danilo Leal created
9c5bec5
formatting: Use project environment to find external formatters (#18611)
Closes #18261 This makes sure that we find external formatters in the project environment. TODO: - [x] Use a different type for the triplet of `(buffer_handle, buffer_path, buffer_env)`. Something like `FormattableBuffer`. - [x] Test this!! Release Notes: - Fixed external formatters not being found, even when they were available in the `$PATH` of a project. --------- Co-authored-by: Bennet <bennet@zed.dev>
Thorsten Ball and Bennet created
c03b8d6
ssh remoting: Enable reconnecting after connection losses (#18586)
Release Notes: - N/A --------- Co-authored-by: Bennet <bennet@zed.dev>
Thorsten Ball and Bennet created
67fbdbb
Put back code that makes the avatar rounded (#18799)
Follow-up to https://github.com/zed-industries/zed/pull/18768 --- Release Notes: - N/A
Danilo Leal created
03c8446
chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795)
While this lint is allow-by-default, it seems pretty useful to get rid of mutable borrows when they're not needed. Closes #ISSUE Release Notes: - N/A
Piotr Osiewicz created
59f0f4a
Fix script/linux on RHEL/Fedora (#18788)
- Add missing `/etc/os-release` from a grep call - Remove typo `grep grep` from another. Co-authored-by: Peter Tripp <peter@zed.dev>
Agustin Gomes and Peter Tripp created
bd74614
ci: Make docs-only PRs only trigger docs-related tests (#18744)
This should speed up any docs-only PRs so that they don't have to run the full 5 minute battery of tests. Release Notes: - N/A
Peter Tripp created
1b06c70
Fix alt-t context (#18783)
- Fix incorrect context introduced in https://github.com/zed-industries/zed/pull/18749/ Release Notes: - N/A
Peter Tripp created
06bd243
proto: Add language server support (#18763)
Closes #18762 Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Peter and Marshall Bowers created
200b2bf
php: Add syntax highlighting for Intelephense completions (#18774)
Release Notes: - N/A This PR introduces syntax highlighting for intelephense autocomple. The styling was selected to roughly match PHPStorm's default scheme. Please note that I'm not very familiar with writing Rust, but I'm happy to adapt to any requested changes! ## Examples ### Object attributes, methods and constants   ### Typed enum members   ### Variables Includes altered highlighting for [reserved variable names](https://www.php.net/manual/en/reserved.variables.php).  --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Roman Zipp and Marshall Bowers created
8376dd2
`ui` crate docs & spring cleaning (#18768)
Similar to https://github.com/zed-industries/zed/pull/18690 & https://github.com/zed-industries/zed/pull/18695, this PR enables required docs for `ui` and does some cleanup. Changes: - Enables the `deny(missing_docs)` crate-wide. - Adds `allow(missing_docs)` on many modules until folks pick them up to document them - Documents some modules (all in `ui/src/styles`) - Crate root-level organization: Traits move to `traits`, other misc organization - Cleaned out a bunch of unused code. Note: I'd like to remove `utils/format_distance` but the assistant panel uses it. To move it over to use the `time_format` crate we may need to update it to use `time` instead of `chrono`. Needs more investigation. Release Notes: - N/A
Nate Butler created
c9bee9f
docs: Note the need for Rust when developing extensions (#18753)
Chris Boette created
1f31022
Compare migrations formatted uniformly (#18760)
Otherwise old migrations may be formatted differently than new migrations, causing comparison errors. Follow-up of https://github.com/zed-industries/zed/pull/18676 Release Notes: - N/A
Kirill Bulatov created
7608000
Fix option-t and option-shift-t in terminal (#18749)
Peter Tripp created
8f27ffd
gpui: Fix uniform list horizon offset for non-horizontal scrollable lists (#18748)
Closes #18739 /cc @osiewicz /cc @maxdeviant I'm not sure why the `+ padding.left` was added, but this was the cause of the issue. I also tested removing the extra left padding but didn't seem to see a difference inside the project panel. So we can maybe even remove it? **Before:**  **After:** <img width="294" alt="Screenshot 2024-10-04 at 21 49 05" src="https://github.com/user-attachments/assets/8cc84170-a86b-46b8-91c9-39def64f0bd0"> Release Notes: - Fix code action list not horizontal aligned correctly
Remco Smits created
cee019b
editor: Qualify `RangeExt::overlaps` call to prevent phantom diagnostics (#18743)
This PR qualifies a call to `RangeExt::overlaps` to avoid some confusion in rust-analyzer not being able to distinguish between `RangeExt::overlaps` and `AnchorRangeExt::overlaps` and producing phantom diagnostics. We may also want to consider renaming the method on `AnchorRangeExt` to disambiguate them. Release Notes: - N/A
Marshall Bowers created
01ad226
telemetry: Add `language_name` and `model_provider` (#18640)
This PR adds a bit more metadata for assistant logging. Release Notes: - Assistant: Added `language_name` and `model_provider` fields to telemetry events. --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com> Co-authored-by: Max <max@zed.dev>
Boris Cherny , Marshall Bowers , and Max created
dfe1e43
docs: Linux XDG desktop secrets portals
Peter Tripp created
e3a6f89
Make `report_assistant_event` take an `AssistantEvent` struct (#18741)
This PR makes the `report_assistant_event` method take an `AssistantEvent` struct instead of all of the struct fields as individual parameters. Release Notes: - N/A
Marshall Bowers created
07e808d
Document File Scan Exclusions (#18738)
Release Notes: - N/A
Peter Tripp created
2f7430a
c: Add runnable for main function (#18720)
Release Notes:
- Added Runnable for C main function
This tags can then be used in tasks, for example:
```json
[
{
"label": "Run ${ZED_STEM}",
"command": "gcc",
"args": [
"$ZED_FILE",
"-o",
"${ZED_DIRNAME}/${ZED_STEM}.out",
"&&",
"${ZED_DIRNAME}/${ZED_STEM}.out"
],
"tags": ["c-main"]
}
]
```
Muhammad Talal Anwar created
d012e35
Update Rust crate parking to v2.2.1 (#18664)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [parking](https://redirect.github.com/smol-rs/parking) | dependencies | patch | `2.2.0` -> `2.2.1` | --- ### Release Notes <details> <summary>smol-rs/parking (parking)</summary> ### [`v2.2.1`](https://redirect.github.com/smol-rs/parking/blob/HEAD/CHANGELOG.md#Version-221) [Compare Source](https://redirect.github.com/smol-rs/parking/compare/v2.2.0...v2.2.1) - Specify the reason for using `parking` in the docs. ([#​25](https://redirect.github.com/smol-rs/parking/issues/25)) </details> --- ### Configuration π **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzguOTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot] and renovate[bot] created
d695de4
tab_switcher: Use git-aware colors for file icons (#18733)
Release Notes: - Fixed tab switcher icons not respecting the `tabs.git_status` setting. Fixes an issue mentioned in https://github.com/zed-industries/zed/pull/17115#issuecomment-2378966170 - file icons in the tab switcher weren't colored according to git status, even if `tabs.git_status` was set to true. I used a similar approach I saw in other places of the project to get the project entry and its git status, but maybe we could move the coloring logic entirely to `tab_icon()`? Wouldn't this break anything? --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Daste and Marshall Bowers created
9702310
Update Rust crate sqlformat to v0.2.6 (#18676)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [sqlformat](https://redirect.github.com/shssoichiro/sqlformat-rs) | dependencies | patch | `0.2.4` -> `0.2.6` | --- ### Release Notes <details> <summary>shssoichiro/sqlformat-rs (sqlformat)</summary> ### [`v0.2.6`](https://redirect.github.com/shssoichiro/sqlformat-rs/blob/HEAD/CHANGELOG.md#Version-026) [Compare Source](https://redirect.github.com/shssoichiro/sqlformat-rs/compare/v0.2.5...v0.2.6) - fix: ON UPDATE with two many blank formatted incorrectly ([#​46](https://redirect.github.com/shssoichiro/sqlformat-rs/issues/46)) - fix: `EXCEPT` not handled well - fix: REFERENCES xyz ON UPDATE .. causes formatter to treat the remaining as an UPDATE statement - fix: Escaped strings formatted incorrectly - fix: RETURNING is not placed on a new line - fix: fix the issue of misaligned comments after formatting ([#​40](https://redirect.github.com/shssoichiro/sqlformat-rs/issues/40)) ### [`v0.2.5`](https://redirect.github.com/shssoichiro/sqlformat-rs/compare/v0.2.4...v0.2.5) [Compare Source](https://redirect.github.com/shssoichiro/sqlformat-rs/compare/v0.2.4...v0.2.5) </details> --- ### Configuration π **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzguOTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot] and renovate[bot] created
bafd7ed
gpui: Store measure functions as context of taffy nodes (#18732)
Taffy maintains a mapping of NodeId <-> Context anyways (and does the lookup), so it's redundant for us to store it separately. Tl;dr: we get rid of one map and one map lookup per layout request. Release Notes: - N/A
Piotr Osiewicz created
37ded19
gpui: Use taffy to retrieve the parent for a given layout node (#18730)
Again. https://github.com/zed-industries/zed/pull/4070 Let's see how it goes this time around. The only thing that might've been related to that revert on our Slack was about crashing in collab panel. Release Notes: - N/A
Piotr Osiewicz created
a99750f
chore: Bump taffy to 0.5.2 (#18729)
Release Notes: - N/A
Piotr Osiewicz created
e264702
Add vim::MoveTo{Next,Prev} flags for regex and case sensitive search (#18429)
This makes the hard-coded regex and case-sensitive search flags in
`vim::MoveToNext` and `vim::MoveToPrev` commands configurable in key
bindings.
Example:
```json
{
"context": "VimControl && !menu",
"bindings": {
"*": ["vim::MoveToNext", { "regex": false, "caseSensitive": false }],
"#": ["vim::MoveToPrev", { "regex": false, "caseSensitive": false }]
}
}
```
Closes #15837.
Release Notes:
- Added `regex` and `caseSensitive` arguments to `vim::MoveToNext` and
`vim ::MoveToPrev` commands, for toggling regex and case sensitive
search.
Γmer Sinan AΔacan created
6635758
vcs_menu: Streamline branch creation from branch selector (#18712)
This PR streamlines the branch creation from the branch selector when searching for a branch that does not exist. The branch selector will show the available branches, as it does today: <img width="576" alt="Screenshot 2024-10-03 at 4 01 25β―PM" src="https://github.com/user-attachments/assets/e1904f5b-4aad-4f88-901d-ab9422ec18bb"> When entering the name of a branch that does not exist, the picker will be populated with an entry to create a new branch: <img width="570" alt="Screenshot 2024-10-03 at 4 01 37β―PM" src="https://github.com/user-attachments/assets/07f8d12c-9422-4fd8-a6dc-ae450e297a13"> Selecting that entry will create the branch and switch to it. Release Notes: - Streamlined creating a new branch from the branch selector.
Marshall Bowers created
8d6fa95
windows: Fix sometimes log error messages don't show the crate name (#18706)
On windows, path could be something like `C:\path\to\the\crate`. Hence,
`split('/')` would refuse to work in this case.
### Before

### After

Release Notes:
- N/A
Junkui Zhang created
fd22c9b
editor: Use predefined `rounding` value for color swatches (#18708)
This PR updates the color swatches added in #18665 to use a predefined `rounding` value instead of a literal value. The underlying values are the same, but we don't want to diverge from our design system. Release Notes: - N/A
Marshall Bowers created
43d05a4
Close stale issues out after 7 days (#18707)
Closes #ISSUE Release Notes: - N/A
Joseph T. Lyons created
cac98b7
Show color swatches for LSP completions (#18665)
Closes #11991 Release Notes: - Added support for color swatches for language server completions. <img width="502" alt="Screenshot 2024-10-02 at 19 02 22" src="https://github.com/user-attachments/assets/57e85492-3760-461a-9b17-a846dc40576b"> <img width="534" alt="Screenshot 2024-10-02 at 19 02 48" src="https://github.com/user-attachments/assets/713ac41c-16f0-4ad3-9103-d2c9b3fa8b2e"> This implementation is mostly a port of the VSCode version of the ColorExtractor. It seems reasonable the we should support _at least_ what VSCode does for detecting color swatches from LSP completions. This implementation could definitely be better perf-wise by writing a dedicated color parser. I also think it would be neat if, in the future, Zed handled _more_ color formats β especially wide-gamut colors. There are a few differences to the regexes in the VSCode implementation but mainly so simplify the implementation : - The hex vs rgb/hsl regexes were split into two parts - The rgb/hsl regexes allow 3 or 4 color components whether hsla/rgba or not and the parsing implementation accepts/rejects colors as needed --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Jordan Pittman and Marshall Bowers created
cddd787
Extract Protocol Buffers support into an extension (#18704)
This PR extracts the Protocol Buffers support into an extension. Release Notes: - Removed built-in support for Protocol Buffers, in favor of making it available as an extension. The Protocol Buffers extension will be suggested for download when you open a `.proto` file.
Marshall Bowers created
8c95b8d
`theme` crate spring cleaning (#18695)
This PR does some spring cleaning on the `theme` crate: - Removed two unused stories and the story dep - Removed the `one` theme family (from the `theme` crate, not the app), this is now `zed_default_themes`. - This will hopefully remove some confusion caused by this theme we started in rust but didn't end up using - Removed `theme::prelude` (it just re-exported scale colors, which we don't use outside `theme`) - Removed completely unused `zed_pro` themes (we started on these during the gpui2 port and didn't finish them.) Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Nate Butler and Marshall Bowers created
a9f816d
telemetry_events: Update crate-level docs (#18703)
This PR updates the `telemetry_events` crate to use module-level documentation for its crate-level docs. Release Notes: - N/A
Marshall Bowers created
f7b3680
Update Rust crate pretty_assertions to v1.4.1 (#18668)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pretty_assertions](https://redirect.github.com/rust-pretty-assertions/rust-pretty-assertions) | workspace.dependencies | patch | `1.4.0` -> `1.4.1` | --- ### Release Notes <details> <summary>rust-pretty-assertions/rust-pretty-assertions (pretty_assertions)</summary> ### [`v1.4.1`](https://redirect.github.com/rust-pretty-assertions/rust-pretty-assertions/blob/HEAD/CHANGELOG.md#v141) [Compare Source](https://redirect.github.com/rust-pretty-assertions/rust-pretty-assertions/compare/v1.4.0...v1.4.1) #### Fixed - Show feature-flagged code in documentation. Thanks to [@​sandydoo](https://redirect.github.com/sandydoo) for the fix! ([#​130](https://redirect.github.com/rust-pretty-assertions/rust-pretty-assertions/pull/130)) #### Internal - Bump `yansi` version to `1.x`. Thanks to [@​SergioBenitez](https://redirect.github.com/SergioBenitez) for the update, and maintaining this library! ([#​121](https://redirect.github.com/rust-pretty-assertions/rust-pretty-assertions/pull/121)) </details> --- ### Configuration π **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzguOTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot] and renovate[bot] created
ded3d3f
Update Python to v3.12.7 (#18652)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [python](https://redirect.github.com/containerbase/python-prebuild) | dependencies | patch | `3.12.6` -> `3.12.7` | --- ### Release Notes <details> <summary>containerbase/python-prebuild (python)</summary> ### [`v3.12.7`](https://redirect.github.com/containerbase/python-prebuild/releases/tag/3.12.7) [Compare Source](https://redirect.github.com/containerbase/python-prebuild/compare/3.12.6...3.12.7) ##### Bug Fixes - **deps:** update dependency python to v3.12.7 </details> --- ### Configuration π **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzguOTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot] and renovate[bot] created