Commit log

fc9db97 client: Remove unused `fs` dependency (#18324)

Click to expand commit body
CI bot notified me about that in
https://github.com/zed-industries/zed/pull/18323


Release Notes:

- N/A

Thorsten Ball created

e9bc9ed remote_server: Fix opening a new remote project not refreshing the project panel (#18262)

Click to expand commit body
Currently, when open new remote project, project_panel not refresh, we
must `ctrl-p` and select an file to refresh the project_panel. After
that, project_panel will refresh when remote project window active.

Release Notes:

- Fixed remote projects not restoring previous locations and not
refreshing the project panel on open.

CharlesChen0823 created

9a86012 docs: Add example of TOML/taplo LSP settings (#18293)

Peter Tripp created

d336005 ssh remoting: Fix cmd-o (#18308)

Click to expand commit body
Release Notes:

- ssh-remoting: Cmd-O now correctly opens files on the remote host

---------

Co-authored-by: Mikayla <mikayla@zed.dev>

Conrad Irwin and Mikayla created

fdb03d3 Move DisplayDiffHunk into hunk_diff module (#18307)

Click to expand commit body
Release Notes:

- N/A

Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld and Marshall created

c4e0f5e Rebuild buffer store to be aware of remote/local distinction (#18303)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Mikayla <mikayla@zed.dev>

Conrad Irwin and Mikayla created

da1ef13 Fix detection that a diff hunk is expanded (#18302)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld and Marshall created

5045f98 Tidy up some broken menu items (#18306)

Click to expand commit body
Release Notes:

- ssh-remoting: Don't show "reveal in finder" in menu

Conrad Irwin created

2d71c36 Allow clearning activity indicators on click (#18305)

Click to expand commit body
All indicators without the click action are now could be hidden with a click.

Sometimes, I see a few language server updates statuses get stuck due to npm desperately attempting to access its registry (3 times per each package, with the timeout a bit under 1 minute per each request).
So, while the message seems stuck, npm desperately tries to do some work in the background.

https://docs.npmjs.com/cli/v10/using-npm/config has options for timeouts & retries for __package fetching__ but that does not include the actual __registry access attempts__.

It's unclear how to proceed with npm on this case now, but at least we should allow hiding these redundant messages.

Release Notes:

- Improved activity indicators' UX by allowing more of them to be hidden on click

Kirill Bulatov created

d2ffad0 collab: Seed GitHub users from static data (#18301)

Click to expand commit body
This PR updates the collab seed script to seed the GitHub users from a
set of static data.

This removes the need to hit the GitHub API to retrieve these users.

Release Notes:

- N/A

Marshall Bowers created

692590b collab: Fix GitHub user retrieval in seed script (#18296)

Click to expand commit body
This PR fixes the GitHub user retrieval in the database seed script.

The users returned from the [list
users](https://docs.github.com/en/rest/users/users?apiVersion=2022-11-28#list-users)
endpoint don't have a `created_at` timestamp, so we need to fetch them
individually.

I want to rework this further at a later date, this is just a bandaid to
get things working again.

Release Notes:

- N/A

Marshall Bowers created

87ac4cf Update close_stale_issues configuration (#18298)

Click to expand commit body
@notpeter and I decided on these things:

- Give users 10 days to respond
- Only run once a week: Tuesday @7AM ET

Release Notes:

- N/A

Joseph T. Lyons created

9606858 Fix unnecessarily-specific struct pattern in rust outline query (#18297)

Click to expand commit body
Fixes https://github.com/zed-industries/zed/issues/18294

Release Notes:

- Fixed a recent regression where tuple and unit structs were omitted
from the outline view in Rust (#18294).

Max Brunsfeld created

f39e54d Start work on reload buffers (#18245)

Click to expand commit body
Release Notes:

- Fixed: ssh-remote reload buffers

---------

Co-authored-by: Mikayla <mikayla@zed.dev>

Conrad Irwin and Mikayla created

8a7ef4d ollama: Add max tokens for qwen2.5-coder (#18290)

John Cummings created

fd07fef Fix proxy settings retrieval on startup (#18171)

Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/18155

Release Notes:

- N/A

ClanEver created

4a4d8c1 vim: Add ability to spawn multicursors at beginning/end of line (#18183)

Click to expand commit body
Closes #17842

Release Notes:

- Added the ability to spawn multiple cursors through the g-A and g-I
motions while in visual select mode.

Sergio C. created

b69c6ee Exclude initialization failed errors from slack (#18232)

Click to expand commit body
Release Notes:

- N/A

Conrad Irwin created

0e86ba0 Fix get_cached_binary for eslint (#18286)

Click to expand commit body
Release Notes:

- Fixed running ESLint offline.

Conrad Irwin created

5e62bbf Run system npm directly (#18280)

Click to expand commit body
Release Notes:

- N/A

Conrad Irwin created

21be70f Improve diff hunks (#18283)

Click to expand commit body
This PR improves the display of diff hunks:

- Deleted hunks now show a regular line indicator in the gutter when
expanded
- The rounding on the diff indicators in the gutter has been removed.

We also did some refactoring to ensure the sizing of the diff indicators
in the gutter were consistent.

#### Collapsed

<img width="1624" alt="Screenshot 2024-09-24 at 11 13 26 AM"
src="https://github.com/user-attachments/assets/f864dc83-cbbc-4d81-a62b-65c406ed310a">

#### Expanded

<img width="1624" alt="Screenshot 2024-09-24 at 11 13 35 AM"
src="https://github.com/user-attachments/assets/04d382ca-e0e6-4f1c-92eb-cd1e3a031c2c">


Release Notes:

- Improved the appearance of diff hunks in the editor.

---------

Co-authored-by: Max <max@zed.dev>

Marshall Bowers and Max created

2470db4 Reuse buffer search queries on tab switch (#18281)

Click to expand commit body
Before this change, with a large chunk of text as a search query (N*10^5
in my experiments) and the buffer search bar visible, switching between
editor tabs was very slow, even if the editors were N*10^2 lines long.

The slow switch was caused by Zed always re-creating the Aho-Corasick
queries, which is now reused.

Release Notes:

- Improved buffer search performance when switching tabs

Co-authored-by: Piotr Osiewicz <piotr@zed.dev>

Kirill Bulatov and Piotr Osiewicz created

e87d6da Implement grapheme support for supermaven completions (#18279)

Click to expand commit body
Closes [#18278](https://github.com/zed-industries/zed/issues/18278)

Release Notes:

- Fixed a panic when graphemes are included in supermaven completions

Sebastijan Kelnerič created

437bcc0 ssh project: Handle multiple paths and worktrees correctly (#18277)

Click to expand commit body
This makes SSH projects work with `ssh_connections` that have multiple
paths:

```json
{
  "ssh_connections": [
    {
      "host": "127.0.0.1",
      "projects": [
        {
          "paths": [
            "/Users/thorstenball/work/projs/go-proj",
            "/Users/thorstenball/work/projs/rust-proj"
          ]
        }
      ]
    }
  ]
}
```

@ConradIrwin @mikayla-maki since this wasn't really released yet, we
didn't create a full-on migration, so old ssh projects that were already
serialized need to either be manually deleted from the database, or the
whole local DB wiped.

Release Notes:

- N/A

---------

Co-authored-by: Bennet <bennet@zed.dev>

Thorsten Ball and Bennet created

3a2f065 Bump operations-per-run parameter in stale issues action (#18276)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

336b4a5 Tweak close stale issues configuration (#18275)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

93a4295 project search: Fix search results not being highlighted (#18273)

Click to expand commit body
Closes #18254
Closes #18219
Closes #17690

This fixes the project search not highlighting all results.

The problem was relatively simple, even though it took a while to find
it: we inserted multiple excerpts concurrently and the order in the
multi-buffer ended up being wrong. Sorting the resulting `match_ranges`
fixed the problem, but as it turns out, we can do a better job by moving
the concurrency into the method on the MultiBuffer.

Performance is the same, but now the problem is fixed.

Release Notes:

- Fixed search results in project-wide search not being highlighted
consistently and navigation sometimes being broken (#18254, #18219,
#17690)

---------

Co-authored-by: Bennet <bennet@zed.dev>

Thorsten Ball and Bennet created

f019ad5 Don't highlight Python function arguments as variables (#18252)

Click to expand commit body
Works on 
- #14892

Follow up to 
- #17473
-
https://github.com/zed-industries/zed/pull/17984#issuecomment-2369815207

Release Notes:

- N/A

Boris Verkhovskiy created

399e094 Properly use default search options in the buffer search bar (#18271)

Click to expand commit body
Only replace current search options if the search was dismissed and the
new options are different from the default ones.

Follow-up of https://github.com/zed-industries/zed/pull/17179
Closes https://github.com/zed-industries/zed/issues/18166


Release Notes:

- Fixed buffer search options toggling unexpectedly on redeploys
([#18166](https://github.com/zed-industries/zed/issues/18166))

Kirill Bulatov created

dbc325e vtsls: Move all default configuration to workspace_configuration (#18259)

Click to expand commit body
This fixes https://github.com/zed-industries/zed/issues/18014 by fixing
the regression that was introduced in
https://github.com/zed-industries/zed/pull/17757.

In short: after digging into the `vtsls` code, it looks like it
essentially doesn't need any `initialization_options`, it's all
workspace configuration, since it tries to use the built-in settings
from VS Code.

I tested the completions, the inlay hints, the max memory - all of it
now works after moving to `workspace_configuration`.

Closes #18014.

Release Notes:

- Fixed `vtsls` being initialized the wrong way, which would mean the
wrong options were used to enable completions or inlay hints.

Thorsten Ball created

6b56530 lua: Bump to v0.1.0 (#18246)

Click to expand commit body
This PR bumps the Lua extension to v0.1.0

- https://github.com/zed-industries/zed/pull/18199
- https://github.com/zed-industries/zed/pull/16955

Peter Tripp created

20c0654 SSH Remoting: Add the ability to resolve file paths on the remote host (#18250)

Click to expand commit body
Release Notes:

- N/A

Mikayla Maki created

d989183 Remove `Debug` constraint on `SumTree` (and its related traits/structs) (#18248)

Click to expand commit body
Release Notes:

- N/A

Co-authored-by: Nathan <nathan@zed.dev>

Antonio Scandurra and Nathan created

3ba071b Allow using system node (#18172)

Click to expand commit body
Release Notes:

- (Potentially breaking change) Zed will now use the node installed on
your $PATH (if it is more recent than v18) instead of downloading its
own. You can disable the new behavior with `{"node":
{"disable_path_lookup": true}}` in your settings. We do not yet use
system/project-local node_modules.

---------

Co-authored-by: Mikayla <mikayla@zed.dev>

Conrad Irwin and Mikayla created

e4080ef Move formatting to LSP store (#18242)

Click to expand commit body
Release Notes:

- ssh-remoting: Fixed format on save

---------

Co-authored-by: Mikayla <mikayla@zed.dev>

Conrad Irwin and Mikayla created

e95e1c9 Add '?plain=1' to Permalinks on GitLab/GitHub for md files (#18241)

Click to expand commit body
Improve our Permalinks to markdown files.
GitHub/GitLab supports the same URL syntax.

Peter Tripp created

1ff10b7 lua: Add auto-close for single quote strings and highlight escape sequences (#18199)

Click to expand commit body
- Add auto close to single quote string
- Add syntax highlights to escape sequence

狐狸 created

7051bc0 Add "Fix with Assistant" code action on lines with diagnostics (#18163)

Click to expand commit body
Release Notes:

- Added a new "Fix with Assistant" action on code with errors or
warnings.

---------

Co-authored-by: Nathan <nathan@zed.dev>

Antonio Scandurra and Nathan created

1efe870 Update stale issues configuration to use 180 days (#18238)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

11953bb Disable debug mode for stale issue action (#18237)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

65bb989 gpui: Update doc comment for `SharedString::new_static` (#18234)

Click to expand commit body
This PR updates the doc comment for `SharedString::new_static`.

Release Notes:

- N/A

Marshall Bowers created

2082633 update stale issue configuration to use `any-of-issue-labels` (#18236)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

3c95a64 Add a rather-conservative stale issue action in dry-run mode (#18233)

Click to expand commit body
Zed is becoming more popular and our issue tracker is only growing
larger and larger. I realize that a stale issue action can be
controversial, but the way we currently manage issues hasn't scaled well
and it will only get worse. We need some crowd-sourced system. Let's ask
those who have opened issues if their issues are still valid. This is
rather conservative and only targets bugs and crashes. I'll run it in
debug mode, report the results, and enable it if it feels right. We can
always turn this off if users end up really not liking it.

My original rules were:

```txt
If an issue is old enough (12 months or older)
AND if there are no recent comments from the team (last dev comment is older than 6 months)
AND it has less than X upvotes (5)
AND it does not have an open PR linked to it
AND is a "defect" or "panic / crash"
AND does not have a "ignore top-ranking issues" label
AND was not opened by a org member
AND is open
AND is issue (not a pull request)

THEN close the issue with a kind message.
```

But only some of these were actually supported in the configuration.

Release Notes:

- N/A

Joseph T. Lyons created

bc751d6 Don't highlight Python import names as type (#17984)

Click to expand commit body
Works on #14892

Follow up to #17473

Boris Verkhovskiy created

a36706a Fix up/down project_id confusion (#18099)

Click to expand commit body
Release Notes:

- ssh remoting: Fix LSP queries run over collab

Conrad Irwin created

35a80f0 docs: Split vim mode documentation into two pages, edit for clarity (#17614)

Click to expand commit body
Closes #17215

Release Notes:

- N/A

---

This PR builds upon the vim mode documentation page and aims bring the
following improvements:

- Separate vim mode-specific configuration from introducing vim mode.
- Reformat some lists of provided commands and keymaps from code blocks
to sub-sections containing tables.
- Flesh out the text a little bit to make it more explicit in some
parts.
- Generally format notes and a couple of other things closer to some
other docs pages.

Checking the diff doesn't give a good idea of the changes, so here are
some before after images for quick examples of the kinds of changes
brought by this PR.

**Introducing the key differences of Zed's vim mode**

Before


![2024-09-09_22-12](https://github.com/user-attachments/assets/447418cb-a6e6-4f9c-8d4b-6d941126979e)

After


![2024-09-09_22-16](https://github.com/user-attachments/assets/be69f2d9-c3ae-4b34-978a-344130bee37c)

---

**Zed-specific vim key bindings**

Before


![2024-09-09_22-17](https://github.com/user-attachments/assets/88fdc512-a50b-487d-85d1-5988f15c2a6f)

After


![2024-09-09_22-18](https://github.com/user-attachments/assets/3b77c2f6-0ffa-4afc-a86d-1210ac706c8c)

Nathan Lovato created

2ff8dde Use fenix toolchain in nix shell (#18227)

Click to expand commit body
In #17974 we explicitly depend on rustc/cargo for the nix devShell,
however the fenix overlay that contains the latest stable versions was
not being applied to that shell. This led to the shell inheriting
whatever rustc/cargo was on nixos-unstable from nixpkgs, which sometimes
lags behind. This change fixes that, and also restructures the flake to
ensure that all outputs rely on the overlaid `pkgs`.

Release Notes:

- N/A

jvmncs created

d784e72 docs: Add Rego language (#18217)

Click to expand commit body
Release Notes:

- N/A

---------

Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
Co-authored-by: Charlie Egan <charlieegan3@users.noreply.github.com>
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>

Charlie Egan , Charlie Egan , and Marshall Bowers created

8a36278 docs: Fix long code blocks overflow (#18208)

Click to expand commit body
Closes #18207

Release Notes:

- N/A

| Before | After |
|--------|-------|
| <img width="1640" alt="image"
src="https://github.com/user-attachments/assets/b7c76ec9-85bd-4001-b19f-6a8e26d04254">
| <img width="1640" alt="image"
src="https://github.com/user-attachments/assets/cd932e33-0429-43b1-9b4b-25df5890a3cf">
|

moshyfawn created

05d1832 Resolve completions properly (#18212)

Click to expand commit body
Related to https://github.com/rust-lang/rust-analyzer/pull/18167

* Declare more completion item fields in the client completion resolve
capabilities
* Do resolve completions even if their docs are present
* Instead, do not resolve completions that could not be resolved when
handling the remote client resolve requests
* Do replace the old lsp completion data with the resolved one

Release Notes:

- Improved completion resolve mechanism

Kirill Bulatov created