3f2de17
collab: Set cached token values when initially creating lifetime usage records (#18865)
Click to expand commit body
This PR fixes an issue where we weren't setting the cached token fields
when initially creating a lifetime usage record.
Release Notes:
- N/A
Marshall Bowers
created
77bf2ad
Add is_via_ssh field to edit events (#18867)
Click to expand commit body
Release Notes:
- N/A
Joseph T. Lyons
created
3da1902
worktree: Depend on `rpc` with `test-support` feature in tests (#18866)
Click to expand commit body
This PR updates the `worktree` crate to depend on `rpc` with the
`test-support` feature flag when running tests.
This fixes an issue I was seeing locally when trying to run tests in the
`worktree` crate:
```
λ cargo test -p worktree -- test_repository_subfolder_git_status
Compiling worktree v0.1.0 (/Users/maxdeviant/projects/zed/crates/worktree)
error[E0432]: unresolved import `rpc::AnyProtoClient`
--> crates/worktree/src/worktree.rs:39:18
|
39 | use rpc::{proto, AnyProtoClient};
| ^^^^^^^^^^^^^^ no `AnyProtoClient` in the root
For more information about this error, try `rustc --explain E0432`.
error: could not compile `worktree` (lib test) due to 1 previous error
```
Release Notes:
- N/A
Marshall Bowers
created
4139e2d
In proposed change editors, apply diff hunks in batches (#18841)
Click to expand commit body
Release Notes:
- N/A
Max Brunsfeld
created
ff7aa02
remote server on macOS: Sign with entitlements (#18863)
Click to expand commit body
This does two things:
- Prevent feature unification
- Sign the remote-server binary with the same entitlements we use for
Zed because we saw this in crash report:
Crashed Thread: 4 Dispatch queue: com.apple.root.user-initiated-qos
Exception Type: EXC_BAD_ACCESS (SIGKILL (Code Signature Invalid))
Exception Codes: UNKNOWN_0x32 at 0x0000000103636644
Exception Codes: 0x0000000000000032, 0x0000000103636644
Termination Reason: Namespace CODESIGNING, Code 2 Invalid Page
VM Region Info: 0x103636644 is in 0x103634000-0x103638000; bytes after
start: 9796 bytes before end: 6587
REGION TYPE START - END [ VSIZE] PRT/MAX SHRMOD REGION DETAIL
VM_ALLOCATE 103630000-103634000 [ 16K] r--/rwx SM=ZER
---> VM_ALLOCATE 103634000-103638000 [ 16K] r-x/rwx SM=COW
VM_ALLOCATE 103638000-103640000 [ 32K] r--/rwx SM=ZER
Which sounds a lot like codesigning/jit/entitlements stuff.
Release Notes:
- N/A
Co-authored-by: Piotr <piotr@zed.dev>
Co-authored-by: Bennet <bennet@zed.dev>
910a773
Display environment loading failures in the activity indicator (#18567)
Click to expand commit body
As @maan2003 noted in #18473, we should warn the user if direnv call
fails
Release Notes:
- Show a notice in the activity indicator if an error occurs while
loading the shell environment
Stanislav Alekseev
created
87cc208
docs: Fix ollama available_models example (#18842)
Peter Tripp
created
b0a16a7
Fix bugs with applying hunks from branch buffers (#18721)
3c91184
collab: Drop mistakenly-added columns from the `usages` table (#18835)
Click to expand commit body
This PR drops the `cache_creation_input_tokens_this_month ` and
`cache_read_input_tokens_this_month ` columns from the `usages` table in
the LLM database.
We mistakenly added these in #18834, but these aren't necessary due to
the structure of the `usages` table. We weren't actually using these
columns anywhere.
Release Notes:
- N/A
Marshall Bowers
created
d55f025
collab: Track cache writes/reads in LLM usage (#18834)
Click to expand commit body
This PR extends the LLM usage tracking to support tracking usage for
cache writes and reads for Anthropic models.
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Antonio <antonio@zed.dev>
Marshall Bowers
,
Antonio Scandurra
, and
Antonio
created
c5d252b
collab: Add missing `cmake` dependency to Dockerfile (#18832)
Click to expand commit body
This PR adds the missing `cmake` dependency to the Docker image that is
now needed in order to build collab.
Release Notes:
- N/A
7d380e9
Temporarily prevent deploying collab to production (#18825)
Click to expand commit body
This PR adds a temporary measure to prevent deploying collab to
production, while we investigate some issues stemming from the HTTP
client change.
Release Notes:
- N/A
Marshall Bowers
created
60c12a8
ssh: Remove old dev servers code paths (#18823)
Click to expand commit body
Closes #ISSUE
Release Notes:
- N/A
Piotr Osiewicz
created
11206a8
ui: Fix avatar indicators getting cut off (#18821)
Click to expand commit body
This PR fixes an issue introduced in #18810 that was causing the avatar
indicators to get cut off.
Release Notes:
- N/A
This PR bumps the Protobuf extension to v0.2.0.
Changes:
- https://github.com/zed-industries/zed/pull/18763
Release Notes:
- N/A
Marshall Bowers
created
a3b6344
ssh: Do not cancel connection process if user is typing password (#18812)
Click to expand commit body
Previously, the connection process would be cancelled after 10 seconds,
even if the connection was established successfully but the user was
still typing in a password.
We know recognize when the user is prompted for a password, and cancel
the timeout task.
Co-Authored-by: Thorsten <thorsten@zed.dev>
Release Notes:
- N/A
---------
Co-authored-by: Thorsten <thorsten@zed.dev>
This PR re-removes `AvatarShape` as it is unused. The previous time it
was removed incorrectly, resulting in square avatars!
Release Notes:
- N/A
Nate Butler
created
25a97a6
ssh: Detect timeouts when server is unresponsive (#18808)
Click to expand commit body
To detect connection timeouts we ping the remote server every X seconds
and attempt to reconnect if the server failed to respond.
Next up is showing some feedback in the UI to make this visible to the
user, and stop reconnecting after X amount of retries.
Release Notes:
- N/A
---------
Co-authored-by: Thorsten <thorsten@zed.dev>
9c5bec5
formatting: Use project environment to find external formatters (#18611)
Click to expand commit body
Closes #18261
This makes sure that we find external formatters in the project
environment.
TODO:
- [x] Use a different type for the triplet of `(buffer_handle,
buffer_path, buffer_env)`. Something like `FormattableBuffer`.
- [x] Test this!!
Release Notes:
- Fixed external formatters not being found, even when they were
available in the `$PATH` of a project.
---------
Co-authored-by: Bennet <bennet@zed.dev>
Thorsten Ball
and
Bennet
created
c03b8d6
ssh remoting: Enable reconnecting after connection losses (#18586)
200b2bf
php: Add syntax highlighting for Intelephense completions (#18774)
Click to expand commit body
Release Notes:
- N/A
This PR introduces syntax highlighting for intelephense autocomple. The
styling was selected to roughly match PHPStorm's default scheme.
Please note that I'm not very familiar with writing Rust, but I'm happy
to adapt to any requested changes!
## Examples
### Object attributes, methods and constants


### Typed enum members


### Variables
Includes altered highlighting for [reserved variable
names](https://www.php.net/manual/en/reserved.variables.php).

---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Roman Zipp
and
Marshall Bowers
created
8376dd2
`ui` crate docs & spring cleaning (#18768)
Click to expand commit body
Similar to https://github.com/zed-industries/zed/pull/18690 &
https://github.com/zed-industries/zed/pull/18695, this PR enables
required docs for `ui` and does some cleanup.
Changes:
- Enables the `deny(missing_docs)` crate-wide.
- Adds `allow(missing_docs)` on many modules until folks pick them up to
document them
- Documents some modules (all in `ui/src/styles`)
- Crate root-level organization: Traits move to `traits`, other misc
organization
- Cleaned out a bunch of unused code.
Note: I'd like to remove `utils/format_distance` but the assistant panel
uses it. To move it over to use the `time_format` crate we may need to
update it to use `time` instead of `chrono`. Needs more investigation.
Release Notes:
- N/A
Nate Butler
created
c9bee9f
docs: Note the need for Rust when developing extensions (#18753)
Otherwise old migrations may be formatted differently than new
migrations, causing comparison errors.
Follow-up of https://github.com/zed-industries/zed/pull/18676
Release Notes:
- N/A
Kirill Bulatov
created
7608000
Fix option-t and option-shift-t in terminal (#18749)
Peter Tripp
created
8f27ffd
gpui: Fix uniform list horizon offset for non-horizontal scrollable lists (#18748)
Click to expand commit body
Closes #18739
/cc @osiewicz
/cc @maxdeviant
I'm not sure why the `+ padding.left` was added, but this was the cause
of the issue. I also tested removing the extra left padding but didn't
seem to see a difference inside the project panel. So we can maybe even
remove it?
**Before:**

**After:**
<img width="294" alt="Screenshot 2024-10-04 at 21 49 05"
src="https://github.com/user-attachments/assets/8cc84170-a86b-46b8-91c9-39def64f0bd0">
Release Notes:
- Fix code action list not horizontal aligned correctly
Remco Smits
created
cee019b
editor: Qualify `RangeExt::overlaps` call to prevent phantom diagnostics (#18743)
Click to expand commit body
This PR qualifies a call to `RangeExt::overlaps` to avoid some confusion
in rust-analyzer not being able to distinguish between
`RangeExt::overlaps` and `AnchorRangeExt::overlaps` and producing
phantom diagnostics.
We may also want to consider renaming the method on `AnchorRangeExt` to
disambiguate them.
Release Notes:
- N/A
Marshall Bowers
created
01ad226
telemetry: Add `language_name` and `model_provider` (#18640)
Click to expand commit body
This PR adds a bit more metadata for assistant logging.
Release Notes:
- Assistant: Added `language_name` and `model_provider` fields to
telemetry events.
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Co-authored-by: Max <max@zed.dev>
e3a6f89
Make `report_assistant_event` take an `AssistantEvent` struct (#18741)
Click to expand commit body
This PR makes the `report_assistant_event` method take an
`AssistantEvent` struct instead of all of the struct fields as
individual parameters.
Release Notes:
- N/A