c12a9f2
Add fold_at_level test (#19800)
Joseph T. Lyons created
c12a9f2
Add fold_at_level test (#19800)
Joseph T. Lyons created
0798c64
Restore horizontal scrollbar checks (#19767)
Closes https://github.com/zed-industries/zed/issues/19637 Follow-up of https://github.com/zed-industries/zed/pull/18927 , restores the condition that removed the horizontal scrollbar when panel's items are not long enough. Release Notes: - Fixed horizontal scrollbar not being hidden ([#19637](https://github.com/zed-industries/zed/issues/19637))
Kirill Bulatov created
2e32f1c
Restore horizontal scrollbar checks (#19767)
Closes https://github.com/zed-industries/zed/issues/19637 Follow-up of https://github.com/zed-industries/zed/pull/18927 , restores the condition that removed the horizontal scrollbar when panel's items are not long enough. Release Notes: - Fixed horizontal scrollbar not being hidden ([#19637](https://github.com/zed-industries/zed/issues/19637))
Kirill Bulatov created
03a1c8d
markdown preview: Fix infinite loop in parser when parsing list items (#19785)
Release Notes: - Fixed an issue with the markdown parser when opening a markdown preview file that contained HTML tags inside a list item
Bennet Bo Fenner created
d7a2776
Fix a few Windows tests (#19773)
Kirill Bulatov created
fc8a72c
WIP: ssh remoting: Add `upload_binary` field to SshConnections (#19748)
This removes the old `remote_server { "download_binary_on_host": bool }`
field and replaces it with a `upload_binary: bool` on every
`ssh_connection`.
@ConradIrwin it compiles, it connects, but I haven't tested it really
yet
Release Notes:
- N/A
---------
Co-authored-by: Conrad <conrad@zed.dev>
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Thorsten Ball , Conrad , and Conrad Irwin created
1acebb3
Remove another false-positive Danger message (#19769)
Follow-up of https://github.com/zed-industries/zed/pull/19151 Ignores any URLs aftrer `Release Notes:` (if present) and after `Follow-up of` and `Part of` words. Release Notes: - N/A
Kirill Bulatov created
78ed0c9
vim: Copy comment to new lines with o/O (#19766)
Co-Authored-By: Kurt Wolf <kurtwolfbuilds@gmail.com> Closes: #4691 Closes #ISSUE Release Notes: - vim: o/O now respect `extend_comment_on_newline`
Conrad Irwin created
6281df9
Update outline panel representation when a theme is changed (#19747)
Release Notes: - N/A
Kirill Bulatov created
c248d15
Properly deserialize active pane in the workspace (#19744)
Without setting the active pane metadata, no center pane events are emitted on start before the pane is focused manually, which breaks deserialization of other components like outline panel, which should show the active pane's active item outlines on start. Release Notes: - N/A Co-authored-by: Thorsten Ball <thorsten@zed.dev>
Kirill Bulatov and Thorsten Ball created
98d2e5f
Quote fixes (#19765)
Closes #19372 Release Notes: - Fixed autoclosing quotes when the string is already open. - Added autoclosing of rust multiline strings --------- Co-authored-by: Kurt Wolf <kurtwolfbuilds@gmail.com>
Conrad Irwin and Kurt Wolf created
4325819
Fix more failure cases of assistant edits (#19653)
* Make `description` optional (since we describe it as optional in the prompt, and we're currently not showing it) * Fix fuzzy location bug that neglected the cost of deleting prefixes of the query. * Make auto-indent work for single-line edits. Previously, auto-indent would not occur when overwriting a single line (without inserting or deleting a newline) Release Notes: - N/A
Max Brunsfeld created
c19c89e
collab: Include `checkout_complete` query parameter after checking out (#19763)
This PR updates the checkout flow to include the `?checkout_complete=1` query parameter after successfully checking out. We'll use this on the account page to adapt the UI accordingly. Release Notes: - N/A
Marshall Bowers created
507929c
Add `editor: fold at level <level>` commands (#19750)
Closes https://github.com/zed-industries/zed/issues/5142 Note that I only moved the cursor to the top of the file so it wouldn't jump - the commands work no matter where you are in the file. https://github.com/user-attachments/assets/78c74ca6-5c17-477c-b5d1-97c5665e44b0 Also, is VS Code doing this right thing here? or is it busted? https://github.com/user-attachments/assets/8c503b50-9671-4221-b9f8-1e692fe8cd9a Release Notes: - Added `editor: fold at level <level>` commands. macOS: `cmd-k, cmd-<number>`, Linux: `ctrl-k, ctrl-<number>`. --------- Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
Joseph T. Lyons and Piotr Osiewicz created
07612cf
Revert "Show invisibles in editor (#19298)"
This reverts commit 6dcec47235fa85f0e416b9230e2fedc61de510ee.
Conrad Irwin created
7d0a7af
Fix condition for re-using highlights when seeking buffer chunks iterator (#19760)
Fixes a syntax highlighting regression introduced in https://github.com/zed-industries/zed/pull/19531, which caused syntax highlighting to be missing after any block. Release Notes: - N/A
Max Brunsfeld created
92ba183
Properly deserialize active pane in the workspace (#19744)
Without setting the active pane metadata, no center pane events are emitted on start before the pane is focused manually, which breaks deserialization of other components like outline panel, which should show the active pane's active item outlines on start. Release Notes: - N/A Co-authored-by: Thorsten Ball <thorsten@zed.dev>
Kirill Bulatov and Thorsten Ball created
6de5ace
Update outline panel representation when a theme is changed (#19747)
Release Notes: - N/A
Kirill Bulatov created
c9db1b9
Add keybindings for accepting hunks (#19749)
I went with Cmd-Shift-Y on macOS (Ctrl-Shift-Y on Linux) for "yes accept this individual hunk" - both are currently unused. I went with Cmd-Shift-A on macOS (Ctrl-Alt-A on Linux) for "accept all hunks" - both are unused. (Ctrl-Shift-A on Linux was taken, as is Ctrl-Alt-Y, so although the pairing of Ctrl-Shift-Y and Ctrl-Alt-A isn't necessarily obvious, the letters seem intuitive - "yes" and "all" - and those key combinations don't conflict with anything.) Release Notes: - Added keybindings for applying hunks in Proposed Changes <img width="247" alt="Screenshot 2024-10-25 at 12 47 00 PM" src="https://github.com/user-attachments/assets/d6355621-ba80-4ee2-8918-b7239a4d29be">
Richard Feldman created
24cb694
Update placeholder text with key bindings to focus context panel and navigate history (#19447)
Hopefully, this will help people understand how easy it is to add context to an inline transformation.  @as-cii @maxdeviant @rtfeldman could somebody update this to display the actual correct key bindings and ship it. I have them hard coded for now. Release Notes: - Updated placeholder text with key bindings to focus context panel and navigate history. --------- Co-authored-by: Richard Feldman <oss@rtfeldman.com>
Nathan Sobo and Richard Feldman created
85bdd93
Revert "Show invisibles in editor (#19298)" (#19752)
Closes: #19714 This reverts commit 6dcec47235fa85f0e416b9230e2fedc61de510ee. Release Notes: - (preview only) Fixes a crash when rendering invisibles
Conrad Irwin created
d40ea8f
Make macOS bundle script compatible with GNU sed (#19745)
Closes https://github.com/zed-industries/zed/issues/19742 Release Notes: - N/A
Kirill Bulatov created
5f9a148
assistant: Make `/file` emit events as they occur (#19743)
This PR updates the `/file` command to emit its `SlashCommandEvent`s in a way that can actually be streamed. Previously it was buffering up all of the events and then returning them all at once. Note that we still don't yet support streaming in the context editor on `main`, so there won't be any visible changes just yet. Release Notes: - N/A
Marshall Bowers created
5c2238c
ssh remoting: Use matching versions of remote server binary (#19740)
This changes the download logic to not fetch the latest version, but to fetch the version matching the current version of Zed. Release Notes: - Changed the update logic of the SSH remote server to not fetch the latest version for a current channel, but to fetch the version matching the current Zed version. If Zed is updated, the server is updated too. If the server is newer than the Zed version an error will be displayed.
Thorsten Ball created
5769065
project panel: Persist full filename when renaming auto-folded entries (#19728)
This fixes a debug-only panic when processing filenames. The underflow that happens in Preview/Stable shouldn't cause any issues (other than maybe unmarking an entry in the project panel). /cc @notpeter Closes #ISSUE Release Notes: - N/A
Piotr Osiewicz created
0173479
ssh remoting: Lock file becomes stale if connection drops & no update if binary is running (#19724)
Release Notes: - Changed the update process of the remote server binary to not attempt an update if we can detect that the current binary is used by another process. - Changed the update process of the remote server binary to mark the lock file as stale in case the SSH connection of the process that created the lock file isn't open anymore.
Thorsten Ball created
08a3c54
Allow editor blocks to replace ranges of text (#19531)
This PR adds the ability for editor blocks to replace lines of text, but does not yet use that feature anywhere. We'll update assistant patches to use replace blocks on another branch: https://github.com/zed-industries/zed/tree/assistant-patch-replace-blocks Release Notes: - N/A --------- Co-authored-by: Antonio Scandurra <me@as-cii.com> Co-authored-by: Richard Feldman <richard@zed.dev> Co-authored-by: Marshall Bowers <marshall@zed.dev> Co-authored-by: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld , Antonio Scandurra , Richard Feldman , Marshall Bowers , and Nathan Sobo created
3617873
project panel: Fix interactions with auto-folded directories (#19723)
Closes https://github.com/zed-industries/zed/issues/19566 Release Notes: - N/A --------- Co-authored-by: Peter Tripp <peter@zed.dev>
Piotr Osiewicz and Peter Tripp created
6eb6788
image viewer: Reuse existing tabs (#19717)
Co-authored-by: Kirill <kirill@zed.dev> Co-authored-by: Mikayla <mikayla@zed.dev> Fixes #9896 Release Notes: - Fixed an issue where clicking on an image inside the project panel would not re-use an existing image tab Co-authored-by: Kirill <kirill@zed.dev> Co-authored-by: Mikayla <mikayla@zed.dev>
Bennet Bo Fenner , Kirill , and Mikayla created
ebc3031
Inline initialization (#19711)
This restores all the init behaviour into main again. This means we never need to call init_ui (and so we can't call it more than once). Release Notes: - (Nightly only) fixes a panic when using the cli to open another file in a running zed.
Conrad Irwin created
42a7402
assistant: Use a labeled button for the slash command menu (#19703)
This should help a bit more the discoverability of the slash commands. Release Notes: - N/A
Danilo Leal created
6cd5c9e
assistant: Tweak the model selector design (#19704)
Exploring using the UI font for it, as it is more common for dropdowns and popovers throughout the app. Feeling like it makes it lighter and also shorter in width! | Before | After | |--------|--------| | <img width="1296" alt="Screenshot 2024-10-24 at 16 39 04" src="https://github.com/user-attachments/assets/0412f922-77a9-4d83-adf9-5632534d6c5b"> | <img width="1296" alt="Screenshot 2024-10-24 at 16 38 26" src="https://github.com/user-attachments/assets/8bf52ba7-fda7-4437-b53e-903c282f2931"> | Release Notes: - N/A
Danilo Leal created
d45b830
SSH connection pooling (#19692)
Co-Authored-By: Max <max@zed.dev> Closes #ISSUE Release Notes: - SSH Remoting: Reuse connections across hosts --------- Co-authored-by: Max <max@zed.dev>
Conrad Irwin and Max created
7ad9f1b
Fix partial downloads of ssh remote server (#19700)
Release Notes: - SSH Remoting: fix a bug where inerrrupting ssh connecting could leave your local binary cached in an invalid state
Conrad Irwin created
3a9c071
Fix partial downloads of ssh remote server (#19700)
Release Notes: - SSH Remoting: fix a bug where inerrrupting ssh connecting could leave your local binary cached in an invalid state
Conrad Irwin created
ca861bb
ui: Fix swapped element background colors (#19701)
This PR fixes an issue introduced in https://github.com/zed-industries/zed/pull/18768 where the element backgrounds colors for `ElevationIndex::ElevatedSurface` and `ElevationIndex::Surface` were swapped. Release Notes: - N/A
Marshall Bowers created
c1fedde
Fix ssh project history (#19683)
Use `Fs` instead of `std::fs` and do entry existence checks better: * first, check the worktree entry existence without any FS checks * then, only for local cases, use `Fs` to check for abs_path existence of items, in case those came from single-filed worktrees that got closed and removed. Remote entries do not get file existence checks, so might try opening previously removed buffers for now. Release Notes: - N/A
Kirill Bulatov created
454d3dd
Fix ssh project history (#19683)
Use `Fs` instead of `std::fs` and do entry existence checks better: * first, check the worktree entry existence without any FS checks * then, only for local cases, use `Fs` to check for abs_path existence of items, in case those came from single-filed worktrees that got closed and removed. Remote entries do not get file existence checks, so might try opening previously removed buffers for now. Release Notes: - N/A
Kirill Bulatov created
3ec015b
docs: Example theme_overrides for docstrings as italic (#19694)
Peter Tripp created
0271828
Remove dev servers (#19638)
TODO: - [ ] Check that workspace migration worked - [ ] Add server migrations and make sure SeaORM files are in sync (maybe?) Release Notes: - N/A --------- Co-authored-by: Conrad <conrad@zed.dev> Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Mikayla Maki , Conrad , and Conrad Irwin created
2f030e3
assistant: Add implementation for `/delta` argument completion (#19693)
This PR fixes a panic that could occur when trying to complete arguments for the `/delta` slash command. We were using `unimplemented!()` instead of providing a default no-op implementation like we do for other slash commands that do not support completing arguments. Closes https://github.com/zed-industries/zed/issues/19686. Release Notes: - Fixed a panic that could occur when trying to complete arguments with the `/delta` command.
Marshall Bowers created
b5f816d
assistant: Add implementation for `/delta` argument completion (#19693)
This PR fixes a panic that could occur when trying to complete arguments for the `/delta` slash command. We were using `unimplemented!()` instead of providing a default no-op implementation like we do for other slash commands that do not support completing arguments. Closes https://github.com/zed-industries/zed/issues/19686. Release Notes: - Fixed a panic that could occur when trying to complete arguments with the `/delta` command.
Marshall Bowers created
391243d
zed 0.159.1
Peter Tripp created
80da78b
ssh: Capitalize error and connection strings (#19675)
Another tiny PR for the sake of consistency :) Release Notes: - N/A
Danilo Leal created
3b3477c
ssh remoting: Fix wrong working directory for SSH terminals (#19672)
Before this change, we would save the working directory *on the client* of each shell that was running in a terminal. While it's technically right, it's wrong in all of these cases where `working_directory` was used: - in inline assistant - when resolving file paths in the terminal output - when serializing the current working dir and deserializing it on restart Release Notes: - Fixed terminals opened on remote hosts failing to deserialize with an error message after restarting Zed.
Thorsten Ball created
8e80ce8
ssh remoting: Fix version check (#19668)
This snuck in when Bennet and I were debugging why our connection to the SSH host would break. We suspected that somewhere something was logging to STDOUT and, I guess, we changed all `println!` to `eprintln!`. Now, two weeks later, I'm sitting here, wondering why the version check doesn't work anymore. The server always reports a version of `""`. Turns out we take the command's STDOUT and not STDERR, which is correct. But it also turns out we started to print the version to STDERR, which breaks the version check. One-character bug & one-character fix. Release Notes: - N/A
Thorsten Ball created
1b18726
Use zstd without dynamic linking due to musl usage (#19627)
Due to leaning towards `musl` builds, unit features for `zstd` and link it statically too for Zed. https://github.com/gyscos/zstd-rs/blob/bfe1e34f593c2427e9dc35f1b98d06788174711f/zstd-safe/zstd-sys/build.rs#L260 shows that `ZSTD_SYS_USE_PKG_CONFIG` env var can be used to return this behavior. Release Notes: - N/A
Kirill Bulatov created
ac5cb8b
Switch to Anthropic -latest tags (#19615)
- Closes: https://github.com/zed-industries/zed/issues/19609 Switches us to using `-latest` tags with Anthropic models instead of pinning to a specific date version. See: [Anthropic Model Docs](https://docs.anthropic.com/en/docs/about-claude/models) This is a no-op for: - Claude 3 Opus (`claude-3-opus-20240229`) - Claude 3 Sonnet (`claude-3-sonnet-20240229`) - Claude 3 Haiku (`claude-3-haiku-20240307`) For Claude 3.5 Sonnet this will update us from `claude-3-5-sonnet-20240620` to `claude-3-5-sonnet-20241022`. We will also pickup any subsequent model updates automatically when Anthropic updates the `latest` tag. This matches the behavior for OpenAI where use `gpt-4o` as the model_name and not `gpt-4o-2024-08-06`.
Peter Tripp created
c4060fe
Fix crash in collab when sending worktree updates (#19678)
This pull request does a couple of things: - In 29c2df73e1448bb510aebfbc954deb067fc88032, we introduced a safety guard that prevents this crash from happening again in the future by returning an error instead of panicking when the payload is too large. - In 3e7a2e5c3067c53bb12cd0c76c6e7b09af7c8fcf, we introduced chunking for updates coming from SSH servers (previously, we were sending the whole changeset and initial set of paths in their entirety). - In 122b5b4, we introduced a panic hook that sends panics to Axiom. For posterity, this is how we figured out what the panic was: ``` kubectl logs current-pod-name --previous --namespace=production ``` Release Notes: - N/A --------- Co-authored-by: Thorsten <thorsten@zed.dev> Co-authored-by: Bennet <bennet@zed.dev> Co-authored-by: Kirill <kirill@zed.dev>
Antonio Scandurra , Thorsten , Bennet , and Kirill created
499e145
Fix crash in collab when sending worktree updates (#19678)
This pull request does a couple of things: - In 29c2df73e1448bb510aebfbc954deb067fc88032, we introduced a safety guard that prevents this crash from happening again in the future by returning an error instead of panicking when the payload is too large. - In 3e7a2e5c3067c53bb12cd0c76c6e7b09af7c8fcf, we introduced chunking for updates coming from SSH servers (previously, we were sending the whole changeset and initial set of paths in their entirety). - In 122b5b4, we introduced a panic hook that sends panics to Axiom. For posterity, this is how we figured out what the panic was: ``` kubectl logs current-pod-name --previous --namespace=production ``` Release Notes: - N/A --------- Co-authored-by: Thorsten <thorsten@zed.dev> Co-authored-by: Bennet <bennet@zed.dev> Co-authored-by: Kirill <kirill@zed.dev>
Antonio Scandurra , Thorsten , Bennet , and Kirill created