03bd954
docs: Add diagram to remote development docs (#19827)
Click to expand commit body
Release Notes: - N/A
Thorsten Ball created
03bd954
docs: Add diagram to remote development docs (#19827)
Release Notes: - N/A
Thorsten Ball created
177dfdf
Declare RUSTFLAGS env var for all CI jobs (#19826)
Follow-up of https://github.com/zed-industries/zed/pull/19149 Makes RUSTFLAGS propagation uniform, to ensure all `cargo ...` jobs get the same RUSTFLAGS env set. Release Notes: - N/A
Kirill Bulatov created
2ab0b3b
remote server: Fix language servers not starting (#19821)
PR #19653 change the code in this diff, which lead to the remote_server binary trying to load language grammars, which in turn failed, and stopped languages from being loaded correctly. That then lead to language servers not starting up. This change reintroduces what #19653 removed, so that we don't load the grammar on the remote_server, by ignoring the grammar name from the config. The tests still all work. Release Notes: - N/A Co-authored-by: Bennet <bennet@zed.dev>
Thorsten Ball and Bennet created
888fec9
outline panel: Add indent guides (#19719)
See #12673 | File | Search | |--------|--------| | <img width="302" alt="image" src="https://github.com/user-attachments/assets/44b8d5f9-8446-41b5-8c0f-e438050f0ac9"> | <img width="301" alt="image" src="https://github.com/user-attachments/assets/a2e6f77b-6d3b-4f1c-8fcb-16bd35274807"> | Release Notes: - Added indent guides to the outline panel
Bennet Bo Fenner created
e86b096
docs: Add `indent_guides` setting to project panel docs (#19819)
Follow up to #18260 Release Notes: - N/A
Bennet Bo Fenner created
fd3b5ff
Fix the tests
These tests were removed in Preview, but that commit was not yet cherry-picked here.
Kirill Bulatov created
ffe36c9
Remove hosted projects (#19754)
Release Notes: - N/A
Mikayla Maki created
9517964
Fixed outline panel panicking on filtering (#19811)
Closes https://github.com/zed-industries/zed/issues/19732 Release Notes: - Fixed outline panel panicking on filtering ([#19732](https://github.com/zed-industries/zed/issues/19732))
Kirill Bulatov created
2d16d2d
Fixed outline panel panicking on filtering (#19811)
Closes https://github.com/zed-industries/zed/issues/19732 Release Notes: - Fixed outline panel panicking on filtering ([#19732](https://github.com/zed-industries/zed/issues/19732))
Kirill Bulatov created
c69da2d
Add support for git branches on remote projects (#19755)
Release Notes: - Fixed a bug where the branch switcher could not be used remotely.
Mikayla Maki created
5506669
windows: Fix more windows platform test (#19802)
Release Notes: - N/A --------- Co-authored-by: Kirill Bulatov <kirill@zed.dev>
CharlesChen0823 and Kirill Bulatov created
b139407
markdown preview: Ignore inline HTML tags in text (#19804)
Follow up to #19785 This PR ensures that we explicitly ignore inline HTML tags so that we can still extract the text between the tags and show them to the user Release Notes: - N/A
Bennet Bo Fenner created
db61711
ci: Don't run GitHub Actions workflows on forks (#19789)
- Closes: https://github.com/zed-industries/zed/issues/19351 Release Notes: - N/A
Peter Tripp created
c12a9f2
Add fold_at_level test (#19800)
Joseph T. Lyons created
0798c64
Restore horizontal scrollbar checks (#19767)
Closes https://github.com/zed-industries/zed/issues/19637 Follow-up of https://github.com/zed-industries/zed/pull/18927 , restores the condition that removed the horizontal scrollbar when panel's items are not long enough. Release Notes: - Fixed horizontal scrollbar not being hidden ([#19637](https://github.com/zed-industries/zed/issues/19637))
Kirill Bulatov created
2e32f1c
Restore horizontal scrollbar checks (#19767)
Closes https://github.com/zed-industries/zed/issues/19637 Follow-up of https://github.com/zed-industries/zed/pull/18927 , restores the condition that removed the horizontal scrollbar when panel's items are not long enough. Release Notes: - Fixed horizontal scrollbar not being hidden ([#19637](https://github.com/zed-industries/zed/issues/19637))
Kirill Bulatov created
03a1c8d
markdown preview: Fix infinite loop in parser when parsing list items (#19785)
Release Notes: - Fixed an issue with the markdown parser when opening a markdown preview file that contained HTML tags inside a list item
Bennet Bo Fenner created
d7a2776
Fix a few Windows tests (#19773)
Kirill Bulatov created
fc8a72c
WIP: ssh remoting: Add `upload_binary` field to SshConnections (#19748)
This removes the old `remote_server { "download_binary_on_host": bool }`
field and replaces it with a `upload_binary: bool` on every
`ssh_connection`.
@ConradIrwin it compiles, it connects, but I haven't tested it really
yet
Release Notes:
- N/A
---------
Co-authored-by: Conrad <conrad@zed.dev>
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Thorsten Ball , Conrad , and Conrad Irwin created
1acebb3
Remove another false-positive Danger message (#19769)
Follow-up of https://github.com/zed-industries/zed/pull/19151 Ignores any URLs aftrer `Release Notes:` (if present) and after `Follow-up of` and `Part of` words. Release Notes: - N/A
Kirill Bulatov created
78ed0c9
vim: Copy comment to new lines with o/O (#19766)
Co-Authored-By: Kurt Wolf <kurtwolfbuilds@gmail.com> Closes: #4691 Closes #ISSUE Release Notes: - vim: o/O now respect `extend_comment_on_newline`
Conrad Irwin created
6281df9
Update outline panel representation when a theme is changed (#19747)
Release Notes: - N/A
Kirill Bulatov created
c248d15
Properly deserialize active pane in the workspace (#19744)
Without setting the active pane metadata, no center pane events are emitted on start before the pane is focused manually, which breaks deserialization of other components like outline panel, which should show the active pane's active item outlines on start. Release Notes: - N/A Co-authored-by: Thorsten Ball <thorsten@zed.dev>
Kirill Bulatov and Thorsten Ball created
98d2e5f
Quote fixes (#19765)
Closes #19372 Release Notes: - Fixed autoclosing quotes when the string is already open. - Added autoclosing of rust multiline strings --------- Co-authored-by: Kurt Wolf <kurtwolfbuilds@gmail.com>
Conrad Irwin and Kurt Wolf created
4325819
Fix more failure cases of assistant edits (#19653)
* Make `description` optional (since we describe it as optional in the prompt, and we're currently not showing it) * Fix fuzzy location bug that neglected the cost of deleting prefixes of the query. * Make auto-indent work for single-line edits. Previously, auto-indent would not occur when overwriting a single line (without inserting or deleting a newline) Release Notes: - N/A
Max Brunsfeld created
c19c89e
collab: Include `checkout_complete` query parameter after checking out (#19763)
This PR updates the checkout flow to include the `?checkout_complete=1` query parameter after successfully checking out. We'll use this on the account page to adapt the UI accordingly. Release Notes: - N/A
Marshall Bowers created
507929c
Add `editor: fold at level <level>` commands (#19750)
Closes https://github.com/zed-industries/zed/issues/5142 Note that I only moved the cursor to the top of the file so it wouldn't jump - the commands work no matter where you are in the file. https://github.com/user-attachments/assets/78c74ca6-5c17-477c-b5d1-97c5665e44b0 Also, is VS Code doing this right thing here? or is it busted? https://github.com/user-attachments/assets/8c503b50-9671-4221-b9f8-1e692fe8cd9a Release Notes: - Added `editor: fold at level <level>` commands. macOS: `cmd-k, cmd-<number>`, Linux: `ctrl-k, ctrl-<number>`. --------- Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
Joseph T. Lyons and Piotr Osiewicz created
07612cf
Revert "Show invisibles in editor (#19298)"
This reverts commit 6dcec47235fa85f0e416b9230e2fedc61de510ee.
Conrad Irwin created
7d0a7af
Fix condition for re-using highlights when seeking buffer chunks iterator (#19760)
Fixes a syntax highlighting regression introduced in https://github.com/zed-industries/zed/pull/19531, which caused syntax highlighting to be missing after any block. Release Notes: - N/A
Max Brunsfeld created
92ba183
Properly deserialize active pane in the workspace (#19744)
Without setting the active pane metadata, no center pane events are emitted on start before the pane is focused manually, which breaks deserialization of other components like outline panel, which should show the active pane's active item outlines on start. Release Notes: - N/A Co-authored-by: Thorsten Ball <thorsten@zed.dev>
Kirill Bulatov and Thorsten Ball created
6de5ace
Update outline panel representation when a theme is changed (#19747)
Release Notes: - N/A
Kirill Bulatov created
c9db1b9
Add keybindings for accepting hunks (#19749)
I went with Cmd-Shift-Y on macOS (Ctrl-Shift-Y on Linux) for "yes accept this individual hunk" - both are currently unused. I went with Cmd-Shift-A on macOS (Ctrl-Alt-A on Linux) for "accept all hunks" - both are unused. (Ctrl-Shift-A on Linux was taken, as is Ctrl-Alt-Y, so although the pairing of Ctrl-Shift-Y and Ctrl-Alt-A isn't necessarily obvious, the letters seem intuitive - "yes" and "all" - and those key combinations don't conflict with anything.) Release Notes: - Added keybindings for applying hunks in Proposed Changes <img width="247" alt="Screenshot 2024-10-25 at 12 47 00 PM" src="https://github.com/user-attachments/assets/d6355621-ba80-4ee2-8918-b7239a4d29be">
Richard Feldman created
24cb694
Update placeholder text with key bindings to focus context panel and navigate history (#19447)
Hopefully, this will help people understand how easy it is to add context to an inline transformation.  @as-cii @maxdeviant @rtfeldman could somebody update this to display the actual correct key bindings and ship it. I have them hard coded for now. Release Notes: - Updated placeholder text with key bindings to focus context panel and navigate history. --------- Co-authored-by: Richard Feldman <oss@rtfeldman.com>
Nathan Sobo and Richard Feldman created
85bdd93
Revert "Show invisibles in editor (#19298)" (#19752)
Closes: #19714 This reverts commit 6dcec47235fa85f0e416b9230e2fedc61de510ee. Release Notes: - (preview only) Fixes a crash when rendering invisibles
Conrad Irwin created
d40ea8f
Make macOS bundle script compatible with GNU sed (#19745)
Closes https://github.com/zed-industries/zed/issues/19742 Release Notes: - N/A
Kirill Bulatov created
5f9a148
assistant: Make `/file` emit events as they occur (#19743)
This PR updates the `/file` command to emit its `SlashCommandEvent`s in a way that can actually be streamed. Previously it was buffering up all of the events and then returning them all at once. Note that we still don't yet support streaming in the context editor on `main`, so there won't be any visible changes just yet. Release Notes: - N/A
Marshall Bowers created
5c2238c
ssh remoting: Use matching versions of remote server binary (#19740)
This changes the download logic to not fetch the latest version, but to fetch the version matching the current version of Zed. Release Notes: - Changed the update logic of the SSH remote server to not fetch the latest version for a current channel, but to fetch the version matching the current Zed version. If Zed is updated, the server is updated too. If the server is newer than the Zed version an error will be displayed.
Thorsten Ball created
5769065
project panel: Persist full filename when renaming auto-folded entries (#19728)
This fixes a debug-only panic when processing filenames. The underflow that happens in Preview/Stable shouldn't cause any issues (other than maybe unmarking an entry in the project panel). /cc @notpeter Closes #ISSUE Release Notes: - N/A
Piotr Osiewicz created
0173479
ssh remoting: Lock file becomes stale if connection drops & no update if binary is running (#19724)
Release Notes: - Changed the update process of the remote server binary to not attempt an update if we can detect that the current binary is used by another process. - Changed the update process of the remote server binary to mark the lock file as stale in case the SSH connection of the process that created the lock file isn't open anymore.
Thorsten Ball created
08a3c54
Allow editor blocks to replace ranges of text (#19531)
This PR adds the ability for editor blocks to replace lines of text, but does not yet use that feature anywhere. We'll update assistant patches to use replace blocks on another branch: https://github.com/zed-industries/zed/tree/assistant-patch-replace-blocks Release Notes: - N/A --------- Co-authored-by: Antonio Scandurra <me@as-cii.com> Co-authored-by: Richard Feldman <richard@zed.dev> Co-authored-by: Marshall Bowers <marshall@zed.dev> Co-authored-by: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld , Antonio Scandurra , Richard Feldman , Marshall Bowers , and Nathan Sobo created
3617873
project panel: Fix interactions with auto-folded directories (#19723)
Closes https://github.com/zed-industries/zed/issues/19566 Release Notes: - N/A --------- Co-authored-by: Peter Tripp <peter@zed.dev>
Piotr Osiewicz and Peter Tripp created
6eb6788
image viewer: Reuse existing tabs (#19717)
Co-authored-by: Kirill <kirill@zed.dev> Co-authored-by: Mikayla <mikayla@zed.dev> Fixes #9896 Release Notes: - Fixed an issue where clicking on an image inside the project panel would not re-use an existing image tab Co-authored-by: Kirill <kirill@zed.dev> Co-authored-by: Mikayla <mikayla@zed.dev>
Bennet Bo Fenner , Kirill , and Mikayla created
ebc3031
Inline initialization (#19711)
This restores all the init behaviour into main again. This means we never need to call init_ui (and so we can't call it more than once). Release Notes: - (Nightly only) fixes a panic when using the cli to open another file in a running zed.
Conrad Irwin created
42a7402
assistant: Use a labeled button for the slash command menu (#19703)
This should help a bit more the discoverability of the slash commands. Release Notes: - N/A
Danilo Leal created
6cd5c9e
assistant: Tweak the model selector design (#19704)
Exploring using the UI font for it, as it is more common for dropdowns and popovers throughout the app. Feeling like it makes it lighter and also shorter in width! | Before | After | |--------|--------| | <img width="1296" alt="Screenshot 2024-10-24 at 16 39 04" src="https://github.com/user-attachments/assets/0412f922-77a9-4d83-adf9-5632534d6c5b"> | <img width="1296" alt="Screenshot 2024-10-24 at 16 38 26" src="https://github.com/user-attachments/assets/8bf52ba7-fda7-4437-b53e-903c282f2931"> | Release Notes: - N/A
Danilo Leal created
d45b830
SSH connection pooling (#19692)
Co-Authored-By: Max <max@zed.dev> Closes #ISSUE Release Notes: - SSH Remoting: Reuse connections across hosts --------- Co-authored-by: Max <max@zed.dev>
Conrad Irwin and Max created
7ad9f1b
Fix partial downloads of ssh remote server (#19700)
Release Notes: - SSH Remoting: fix a bug where inerrrupting ssh connecting could leave your local binary cached in an invalid state
Conrad Irwin created
3a9c071
Fix partial downloads of ssh remote server (#19700)
Release Notes: - SSH Remoting: fix a bug where inerrrupting ssh connecting could leave your local binary cached in an invalid state
Conrad Irwin created
ca861bb
ui: Fix swapped element background colors (#19701)
This PR fixes an issue introduced in https://github.com/zed-industries/zed/pull/18768 where the element backgrounds colors for `ElevationIndex::ElevatedSurface` and `ElevationIndex::Surface` were swapped. Release Notes: - N/A
Marshall Bowers created
c1fedde
Fix ssh project history (#19683)
Use `Fs` instead of `std::fs` and do entry existence checks better: * first, check the worktree entry existence without any FS checks * then, only for local cases, use `Fs` to check for abs_path existence of items, in case those came from single-filed worktrees that got closed and removed. Remote entries do not get file existence checks, so might try opening previously removed buffers for now. Release Notes: - N/A
Kirill Bulatov created