49e736d
ruby: Recognize `Steepfile`s as Ruby (#15762)
Click to expand commit body
Release Notes: - N/A
Reese is on Codeberg created
49e736d
ruby: Recognize `Steepfile`s as Ruby (#15762)
Release Notes: - N/A
Reese is on Codeberg created
f8234ae
repl: Add ctrl-alt-enter binding to run in place (#15743)
Release Notes: - Added `ctrl-alt-enter` keybinding for `repl::RunInPlace` (`ctrl-option-enter` on MacOS). Keeps your screen position and cursor in place when running any block.
Kyle Kelley created
b7eae7f
repl: Render markdown output from kernels (#15742)
<img width="1268" alt="image" src="https://github.com/user-attachments/assets/73e03a28-f5e3-4395-a58c-cabd07f57889"> Release Notes: - Added markdown rendering for Jupyter/REPL outputs. Push Markdown from Deno/Typescript with `Deno.jupyter.md` and in IPython use `IPython.display.Markdown`.
Kyle Kelley created
36b61a8
repl: Process display IDs for updatable displays (#15738)
Release Notes: - Added `update_display_data` support for REPL. https://github.com/user-attachments/assets/d618e457-e314-482e-954a-6384f185629a
Kyle Kelley created
68446d2
Use lowercase command names in initial settings files (#15717)
Release Notes: - N/A Making these two comments match what I see in the command palette: <img width="629" alt="Xnapper-2024-08-03-08 09 26" src="https://github.com/user-attachments/assets/f3eab05b-1560-4b0a-8df2-0eaf5746e422">
Adam Johnson created
4528e9d
repl: Create better terminal output for REPL stdio (#15715)
Rely on our implementation of a GPUI powered alacritty terminal to render stdout & stderr from the repl. Release Notes: - Fixed ANSI escape code and carriage return handling in repl outputs (https://github.com/zed-industries/zed/issues/15640, https://github.com/zed-industries/zed/issues/14855) https://github.com/user-attachments/assets/bd3f1584-863a-4afa-b60b-9d222a830ff8 --------- Co-authored-by: Mikayla <mikayla@zed.dev>
Kyle Kelley and Mikayla created
b6a3556
repl: Rely on block decorations to size according to content (#15713)
We no longer have to use line height calculations now that https://github.com/zed-industries/zed/pull/15536 is in. Blocks resize according to their content. This fixes up some of the rendering issues on plaintext outputs as well. Release Notes: - Fix repl plain text output wrapping around and covering editor text (https://github.com/zed-industries/zed/issues/15491, https://github.com/zed-industries/zed/issues/14855)
Kyle Kelley created
5c54596
theme: Use a non-transparent color for the fallback `title_bar.inactive_background` (#15709)
This PR changes the fallback color for the `title_bar.inactive_background` theme property so that the title bar doesn't just disappear when a theme doesn't have a value set. You're welcome, @naomieow. Release Notes: - linux: Changed the fallback color of `title_bar.inactive_background` to a non-transparent value.
Marshall Bowers created
91bbf0e
assistant: Normalize line endings for prompts loaded from the prompt library (#15708)
This PR makes it so we normalize the line endings for prompts to LFs (`\n`) when we load a prompt from the library. In some cases, prompts could end up with CRLF (`\r\n`) line endings. When these prompts were used with the `/prompt` slash command and summarily run, the prompt text would be converted into a rope, causing the line endings to be normalized to LFs. However, this would happen _after_ the ranges for the `SlashCommandOutputSection`s were computed based on the text that still contained the CRLFs. This would then cause these ranges to be invalid for the text with the normalized endings, resulting in a panic when converting them to anchors. Fixes https://github.com/zed-industries/zed/issues/15652. Release Notes: - N/A Co-authored-by: Max <max@zed.dev>
Marshall Bowers and Max created
3755f0d
docs: Fix links to "Backend dependencies" setup (#15706)
This PR fixes the links to the "Backend dependencies" section from the local collaboration docs. We now provide links to the section in the platform-specific development docs. Release Notes: - N/A
Marshall Bowers created
c6580da
assistant: Don't unwrap built-in step resolution prompt (#15704)
This PR removes some `unwrap`s while loading the built-in step resolution prompt. While these `unwrap`s are safe today, they are relying on some implicit contracts that might change in the future. We're using this in a context where it's easy to propagate an error upwards, so we may as well avoid the `unwrap`s entirely and use a `Result`. Release Notes: - N/A
Marshall Bowers created
24afe7c
Change the terminal assistant settings icon (#15702)
Change the terminal assistant settings icon so its consistent with the one we're using on the inline assistant. --- Release Notes: - N/A
Danilo Leal created
d6e558e
copilot: Colocate `copilot_chat_config_path` with the rest of the Copilot code (#15703)
This PR moves the `copilot_chat_config_path` out of `paths` and into `copilot` with the rest of the Copilot code. Since this doesn't actually return a Zed path, it doesn't belong in `paths`. Release Notes: - N/A
Marshall Bowers created
e2eb68a
chore: Remove leftover code from #15646 (#15697)
Release Notes: - N/A
Piotr Osiewicz created
ad11d83
Skip over folded regions when iterating over multibuffer chunks (#15646)
This commit weaves through new APIs for language::BufferChunks, multi_buffer::MultiBufferChunks and inlay_map::InlayChunks that allow seeking with an upper-bound. This allows us to omit doing syntax highligting and looking up diagnostics for folded ranges. This in turn directly improves performance of assistant panel with large contexts. Release Notes: - Fixed poor performance when editing in the assistant panel after inserting large files using slash commands --------- Co-authored-by: Max <max@zed.dev> Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Piotr Osiewicz , Max , and Max Brunsfeld created
390815d
assistant panel: Tab-less configuration view (#15682)
TODOs for follow-up: - [ ] When opening panel: nudge user to sign in if they're not signed-in and have no provider configured (or if they're not signed-in and have Zed AI configured) - [ ] Configuration page is not scrollable - [ ] Design tweaks Current status: https://github.com/user-attachments/assets/d26d65ea-43e8-481b-81a3-b3cba01704a8 Release Notes: - N/A
Thorsten Ball created
35a3b00
Add link to docs for configuring ruff
Joseph T Lyons created
69cefb3
docs: Add brief R/Ark instructions (#15357)
Added brief instructions for [`Ark`](https://github.com/posit-dev/ark) kernel for `R`. Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Egor Kotov and Marshall Bowers created
55fbafe
docs: Fix Ruff-related links (#15511)
Release Notes: - N/A
Vladimir Kukushkin created
61365e0
Relax "test" runnable check (#15647)
This commit updates the Tree-sitter query to match Rust attributes containing the word "test". The previous query only matched attributes with the exact string "test", which was too restrictive for custom test macros like https://docs.rs/test-log/0.2.10/test_log/# Discussion - https://github.com/zed-industries/zed/discussions/15580
Mayank Jikadara created
b88b9dc
Extend symbol ranges by their annotation range when suggesting edits (#15677)
Release Notes: - N/A --------- Co-authored-by: Nathan <nathan@zed.dev>
Antonio Scandurra and Nathan created
e4608e7
assistant panel: Intermediate fix for focus problems (#15674)
This is an intermediate fix for the focus problems in the assistant panel. Intermediate because I'm going to shred the whole ConfigurationView now and replace the tabs inside with a list. Release Notes: - N/A
Thorsten Ball created
b4dcd6d
Update model selector (#15665)
Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Nate Butler and Marshall Bowers created
5e011ab
language_model: Denote the availability of language models (#15660)
This PR updates the `LanguageModel` trait with a new method for denoting the availability of a model. Right now we have two variants: - `Public` for models that have no additional restrictions (other than their respective setup/authentication requirements) - `RequiresPlan` for models that require a specific Zed plan Release Notes: - N/A
Marshall Bowers created
906d973
gleam: Update Tree-sitter grammar for label shorthand syntax (#15659)
This PR updates the Gleam Tree-sitter grammar to support label shorthand syntax. Release Notes: - N/A
Marshall Bowers created
771424e
extension: Make `worktree` argument to `run_slash_command` optional (#15658)
This PR updates the extension API to make the `worktree` argument to `run_slash_command` optional. We may not always have a worktree, and not all slash commands need them, so by making it optional we can allow individual slash commands to decide what to do when there is no worktree. Release Notes: - N/A
Marshall Bowers created
88f29c8
assistant: Don't require a worktree to run slash commands (#15655)
This PR fixes an issue where slash commands were not able to run when Zed did not have any worktrees opened. This requirement was only necessary for slash commands originating from extensions, and we can enforce the presence of a worktree just for those: <img width="378" alt="Screenshot 2024-08-01 at 5 01 58 PM" src="https://github.com/user-attachments/assets/38bea947-e33b-4c64-853c-c1f36c63d779"> Release Notes: - N/A
Marshall Bowers created
55fc1f0
docs: Remove wrongly documented secrets portals (#15303)
- The secrets portal is only used if the application is sandboxed without access to the org.freedesktop.secrets on the host but as zed is not really working correctly if sandboxed as is, it is better to completely omit that part - The org.freedestkop.secrets is not a portal but a spec file that is implemented by both gnome in gnome-keyring, kde in kwallet but also by other password managers like keepassxc and it is a requirement for a "correctly" set up linux desktop so just remove that wrongly documented bit Release Notes: - N/A
Bilal Elmoussaoui created
1fa4cc3
Use the right `max_token_count` for Qwen
Co-Authored-By: Nathan <nathan@zed.dev>
Antonio Scandurra and Nathan created
1b85793
Fix inline assist deletion blocks (#15651)
After the changes in #15536, block decorations need to be given an explicit height if their content doesn't consume height on its own. We missed that inline transformation deletion decorations didn't do this, creating weird results. This fixes the issue and prevents block decorations from ever having a zero height. That helps avoid major weirdness, but this still a bit of a gotcha. We need to back port this to Preview Channel (0.147.x) Release Notes: - N/A --------- Co-authored-by: Antonio <antonio@zed.dev>
Nathan Sobo and Antonio created
0799dfb
assistant: Only insert the host's default prompt when creating a new context (#15650)
This PR fixes an issue where creating a new context as a guest would insert multiple default prompts: one for the host and one for the guest. When creating a new context as a guest while collaborating, we should only use the host's default prompt. Release Notes: - N/A
Marshall Bowers created
21816d1
Add Qwen2-7B to the list of zed.dev models (#15649)
Release Notes: - N/A --------- Co-authored-by: Nathan <nathan@zed.dev>
Antonio Scandurra and Nathan created
60127f2
Fix `.env.toml` paths (#15645)
This PR fixes the `.env.toml` paths, since we inadvertently broke them in https://github.com/zed-industries/zed/pull/15557. There's likely a better way we can do this, but I wanted to restore the previous behavior, for now. Release Notes: - N/A
Marshall Bowers created
4bfb8fd
Rename `zed.dev/settings` to `zed.dev/account` (#15636)
This PR renames the links to the `zed.dev/settings` page to the `zed.dev/account`. Some of these spots will likely link out to a marketing page later. Release Notes: - N/A
Marshall Bowers created
7652045
Remove primary/secondary distinction for `CachedLspAdapter` (#15634)
This PR removes the primary/secondary distinction for `CachedLspAdapter`s. After #15624 we weren't relying on the `is_primary` field anywhere, so we can remove it. Release Notes: - N/A
Marshall Bowers created
80594cc
docs: Fix ordering of language servers in Ruby docs (#15633)
Follow-up to https://github.com/zed-industries/zed/pull/15624. Since #15624 introduced a fix for the language server ordering, this fixes the ordering in the Ruby docs. Release Notes: - N/A
Thorsten Ball created
5afa799
assistant panel: Add button to open new context to configuration page (#15628)
This adds a button to the `Configuration` page for providers so it's easy to start a new context _with the given provider_ selected.  Obviously not the most beautiful form this button can have, but works! cc @iamnbutler Release Notes: - N/A Co-authored-by: Bennet <bennet@zed.dev>
Thorsten Ball and Bennet created
70b2da7
Update assistant config UI (#15630)
 - Remove assisstant_description for now. - Updates assistant config UI - Updates Ollama and zed.dev provider UIs - Updates download icon Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com> Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Nate Butler , Marshall Bowers , and Marshall Bowers created
3bd9a3f
Respect the `language_servers` setting's order when determining the primary language server (#15624)
This PR updates how we determine the "primary" language server for a buffer to make it respect the order specified by the `language_servers` setting. Previously we were relying on the language servers to be registered in the right order in order to select the primary one effectively. However, in my testing I observed some cases where a native language server (e.g., `tailwindcss-language-server`) could end up first in the list of language servers despite not being first in the `language_servers` setting. While this wasn't a problem for the Tailwind or ESLint language servers on account of them being defined natively with the designation of "secondary" language servers, this could cause problems with extension-based language servers. To remedy this, every time we start up language servers we reorder the list of language servers for a given language to reflect the order in the `language_servers` setting. This ordering then allows us to treat the first language server in the list as the "primary" one. Related issues: - https://github.com/zed-industries/zed/issues/15023 - https://github.com/zed-industries/zed/issues/15279 Release Notes: - The ordering of language servers will now respect the order in the `language_servers` setting. - The first language server in this list will be used as the primary language server.
Marshall Bowers created
0b175ac
Give edit steps multibuffer a title (#15625)
Release Notes: - N/A Co-authored-by: Nathan <nathan@zed.dev>
Antonio Scandurra and Nathan created
ed7952f
assistant panel: Update active tab in config panel when provider changes (#15621)
Release Notes: - N/A Co-authored-by: Bennet <bennet@zed.dev>
Thorsten Ball and Bennet created
6c83c79
assistant panel: Ensure always active tab is shown (#15618)
Small bug that snuck in with #15490. When closing the configuration tab explicitly and then activating the assistant tab again, it wouldn't show the configuration page. Release Notes: - N/A Co-authored-by: Bennet <bennet@zed.dev>
Thorsten Ball and Bennet created
ac1a15f
assistant: Report all worktree entries in /file completions (#15617)
We were reporting file count as worktree entry count, which led to us missing some of the entries in /file command completion. /cc @bennetbo The other components that used `PathMatchCandidateSet` are `/diagnostics` and file finder. File finder is unaffected, as it used `Candidates::Files` - thus previously reported count was correct for it; `/diagnostics` were using `::Entries` as well, so it could miss entries just like `/files`. Release Notes: - Fixed /file and /diagnostics slash commands omitting entries in it's completions menu.
Piotr Osiewicz created
a9c6e43
Bundle editing workflow prompt as a read-only built-in prompt (#15615)
Built-in prompts can still be removed from the default prompt, but they can't be edited and are automatically updated with new Zed releases. Release Notes: - N/A --------- Co-authored-by: Antonio <antonio@zed.dev>
Nathan Sobo and Antonio created
be3a858
assistant: Add a Configuration page (#15490)
- [x] bug: setting a key doesn't update anything - [x] show high-level text on configuration page to explain what it is - [x] show "everything okay!" status when credentials are set - [x] maybe: add "verify" button to check credentials - [x] open configuration page when opening panel for first time and nothing is configured - [x] BUG: need to fix empty assistant panel if provider is `zed.dev` but not logged in Co-Authored-By: Thorsten <thorsten@zed.dev> Release Notes: - N/A --------- Co-authored-by: Thorsten <thorsten@zed.dev> Co-authored-by: Nate Butler <iamnbutler@gmail.com> Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Bennet Bo Fenner , Thorsten , Nate Butler , and Thorsten Ball created
7921363
assistant: Display hamburger menu even when the panel is not focused (#15612)
This commit gives tab button renderers control over the condition in which they should be displayed. Previously we displayed tab buttons only when the pane was focused. Now tab renderers can return an Option of AnyElement, which in turn makes it possible for them to control when and how they're rendered. Pane and Terminal handlers still check for self focus condition and Assistant Panel does not. Release Notes: - N/A
Piotr Osiewicz created
dc0f743
Add support for backwards compatibility in `PromptStore` (#15602)
Release Notes: - N/A --------- Co-authored-by: Nathan <nathan@zed.dev>
Antonio Scandurra and Nathan created
04065d9
Fix GitHub Copilot chat authentication on Windows (#15587)
This PR fixes Copilot chat authentication on Windows. GitHub Copilot chat in assistant panel uses auth token file generated by [copilot language server](https://github.com/zed-industries/copilot). The path to authentication token file is platform dependent. On Windows, it happens to be `~\AppData\Local\github-copilot\hosts.json`. Release Notes: - Fixed Copilot chat sign in issue on Windows ([#4673](https://github.com/zed-industries/zed/issues/4673))
Ramkumar created
1246010
Fix padding for `end_hover_slot` on `ListItem`s (#15598)
Release Notes: - N/A Co-authored-by: Nathan <nathan@zed.dev>
Antonio Scandurra and Nathan created
c98918a
Properly calculate y offsets for multi buffer context menus (#15594)
Follow-up of https://github.com/zed-industries/zed/pull/14727 Release Notes: - Fixed multi buffer context menus not showing properly Co-authored-by: Max Brunsfeld <max@zed.dev>
Kirill Bulatov and Max Brunsfeld created