a36706a
Fix up/down project_id confusion (#18099)
Click to expand commit body
Release Notes: - ssh remoting: Fix LSP queries run over collab
Conrad Irwin created
a36706a
Fix up/down project_id confusion (#18099)
Release Notes: - ssh remoting: Fix LSP queries run over collab
Conrad Irwin created
35a80f0
docs: Split vim mode documentation into two pages, edit for clarity (#17614)
Closes #17215 Release Notes: - N/A --- This PR builds upon the vim mode documentation page and aims bring the following improvements: - Separate vim mode-specific configuration from introducing vim mode. - Reformat some lists of provided commands and keymaps from code blocks to sub-sections containing tables. - Flesh out the text a little bit to make it more explicit in some parts. - Generally format notes and a couple of other things closer to some other docs pages. Checking the diff doesn't give a good idea of the changes, so here are some before after images for quick examples of the kinds of changes brought by this PR. **Introducing the key differences of Zed's vim mode** Before  After  --- **Zed-specific vim key bindings** Before  After 
Nathan Lovato created
2ff8dde
Use fenix toolchain in nix shell (#18227)
In #17974 we explicitly depend on rustc/cargo for the nix devShell, however the fenix overlay that contains the latest stable versions was not being applied to that shell. This led to the shell inheriting whatever rustc/cargo was on nixos-unstable from nixpkgs, which sometimes lags behind. This change fixes that, and also restructures the flake to ensure that all outputs rely on the overlaid `pkgs`. Release Notes: - N/A
jvmncs created
d784e72
docs: Add Rego language (#18217)
Release Notes: - N/A --------- Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> Co-authored-by: Charlie Egan <charlieegan3@users.noreply.github.com> Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Charlie Egan , Charlie Egan , and Marshall Bowers created
8a36278
docs: Fix long code blocks overflow (#18208)
Closes #18207 Release Notes: - N/A | Before | After | |--------|-------| | <img width="1640" alt="image" src="https://github.com/user-attachments/assets/b7c76ec9-85bd-4001-b19f-6a8e26d04254"> | <img width="1640" alt="image" src="https://github.com/user-attachments/assets/cd932e33-0429-43b1-9b4b-25df5890a3cf"> |
moshyfawn created
05d1832
Resolve completions properly (#18212)
Related to https://github.com/rust-lang/rust-analyzer/pull/18167 * Declare more completion item fields in the client completion resolve capabilities * Do resolve completions even if their docs are present * Instead, do not resolve completions that could not be resolved when handling the remote client resolve requests * Do replace the old lsp completion data with the resolved one Release Notes: - Improved completion resolve mechanism
Kirill Bulatov created
bb7d9d3
docs: Remove `default_dock_anchor` in `configuring-zed.md` (#18210)
Removed the deprecated option `default_dock_anchor` in `configuring-zed.md` Note: https://zed.dev/blog/new-panel-system Release Notes: - N/A
Junseong Park created
75cb199
project: Fix typo error cause remove worktree not stop lsp (#18198)
Release Notes: - N/A
CharlesChen0823 created
0f4ebdf
docs: Add missing `ui_font_size` option in `configuring-zed.md` (#18189)
Added `ui_font_size`, an option that works in the editor but is missing from the documentation. Release Notes: - N/A
Junseong Park created
37c93d8
docs: Add missing `base_keymap` option in `configuring-zed.md` (#18190)
Added `base_keymap`, an option that works in the editor but is missing from the documentation. Release Notes: - N/A
Junseong Park created
e7fcf83
docs: Fix misordered headings (#18192)
1. Raised the `Indent Guides` heading to level 2, which is completely unrelated to `Git`. 2. the `Git` heading now only contains `Git Gutter` and `Inline Git Blame` as subheadings. 3. The `Indent Guides` heading is now located directly after the `Git` heading. Release Notes: - N/A
Junseong Park created
1f35c8d
Fix tooltip of `always_treat_brackets_as_autoclosed` (#18191)
Fixed a bug where the `always_treat_brackets_as_autoclosed` option would not display the message in the tooltip that appears when hovering. Release Notes: - N/A
Junseong Park created
3ca18af
docs: Fix typo in `configuring-zed.md` (#18178)
Fix typo in `configuring-zed.md` Release Notes: - N/A
Junseong Park created
4f227fd
Use LanguageServerName in more places (#18167)
This pushes the new LanguageServerName type to more places. As both languages and language servers were identified by Arc<str>, it was sometimes hard to tell which was intended. Release Notes: - N/A
Conrad Irwin created
743feb9
Add the ability to propose changes to a set of buffers (#18170)
This PR introduces functionality for creating *branches* of buffers that can be used to preview and edit change sets that haven't yet been applied to the buffers themselves. Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com> Co-authored-by: Marshall <marshall@zed.dev>
Max Brunsfeld , Marshall Bowers , and Marshall created
e309fbd
Add a slash command for automatically retrieving relevant context (#17972)
* [x] put this slash command behind a feature flag until we release embedding access to the general population * [x] choose a name for this slash command and name the rust module to match Release Notes: - N/A --------- Co-authored-by: Jason <jason@zed.dev> Co-authored-by: Richard <richard@zed.dev> Co-authored-by: Jason Mancuso <7891333+jvmncs@users.noreply.github.com> Co-authored-by: Richard Feldman <oss@rtfeldman.com>
Max Brunsfeld , Jason , Richard , Jason Mancuso , and Richard Feldman created
5905fbb
Allow Anthropic custom models to override temperature (#18160)
Release Notes: - Allow Anthropic custom models to override "temperature" This also centralized the defaulting of "temperature" to be inside of each model's `into_x` call instead of being sprinkled around the code.
Roy Williams created
7d62fda
file_finder: Notify user when picker an non-utf8 file (#18136)
notify user when using file finder picker an file which cannot open. Release Notes: - N/A
CharlesChen0823 created
4538880
vim: gq (#18156)
Closes #ISSUE Release Notes: - vim: Added gq/gw for rewrapping lines
Conrad Irwin created
7dac559
file_finder: Display file icons (#18091)
This PR adds file icons (like in tabs, the project panel and tab switcher) to the file finder popup. It's similar to [tab_switcher icons](https://github.com/zed-industries/zed/pull/17115), but simpler, because we're only dealing with actual files. Release Notes: - Added icons to the file finder. Screenshot:  --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Daste and Marshall Bowers created
5d12e3c
preview tabs: Toggle preview tab when saving (#18158)
Release Notes: - Saving a preview tab will now mark it as a permanent tab
Bennet Bo Fenner created
6010905
Remove `system_id` from all events but `editor_events` (#18154)
Release Notes: - N/A
Joseph T. Lyons created
8bd624b
editor: Remove unneeded blank lines in rewrap test cases (#18152)
This PR removes some unneeded blank lines from some of the test cases for `editor::Rewrap`. These weren't meaningful to the test, and their presence could be confusing. Release Notes: - N/A
Marshall Bowers created
9f6ff29
Reuse OpenAI low_speed_timeout setting for zed.dev provider (#18144)
Release Notes: - N/A
jvmncs created
d97427f
chore: Update flake inputs (#18150)
Release Notes: - N/A
jvmncs created
99bef27
Add escape string highlights to JSON and JSONC files (#18138)
Release Notes: - Added escape string highlights to JSON and JSONC files
狐狸 created
f8195c4
docs: Switch proxy example to socks5h not socks5 (#18142)
Very rarely when you have a SOCKS proxy configured do you want local DNS. `socks5` does local DNS. `socks5h` does remote DNS.
Peter Tripp created
759646e
editor: Improve rewrapping when working with comments at different indentation levels (#18146)
This PR improves the `editor::Rewrap` command when working with comments that were not all at the same indentation level. We now use a heuristic of finding the most common indentation level for each line, using the deepest indent in the event of a tie. It also removes an `.unwrap()` that would previously lead to a panic in this case. Instead of unwrapping we now log an error to the logs and skip rewrapping for that selection. Release Notes: - Improved the behavior of `editor: rewrap` when working with a selection that contained comments at different indentation levels.
Marshall Bowers created
ab1d466
Remove `replica_id` from `MultiBuffer`s (#18141)
This PR removes the `replica_id` field from the `MultiBuffer` struct. We were only ever referencing this field to pass when constructing a `MultiBuffer`, and never used it outside of that. Release Notes: - N/A
Marshall Bowers created
5f1046b
Make evals handle failures more gracefully (#18082)
Now when an individual project eval fails, instead of panicking we add it to a list of failures that we collect and report at the end (and make the exit code nonzero). Release Notes: - N/A
Richard Feldman created
d6c184b
Detect 'MD' extension as Markdown (#18135)
Peter Tripp created
16d2afc
ci: Bump `nightly` tag on scheduled Nightly builds (#18134)
This PR makes it so after a scheduled Nightly build we also update the `nightly` tag to keep things in sync. It's safe to bump the tag within this Action, as it won't trigger another Nightly build due to GitHub's recursive Action protections: > When you use the repository's `GITHUB_TOKEN` to perform tasks, events triggered by the `GITHUB_TOKEN`, with the exception of `workflow_dispatch` and `repository_dispatch`, will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's `GITHUB_TOKEN`, a new workflow will not run even when the repository contains a workflow configured to run when `push` events occur. > > — [source](https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow) Release Notes: - N/A
Marshall Bowers created
90a12f5
ssh remoting: Do not double-register LspAdapters (#18132)
This fixes the bug with hover tooltips appearing multiple times. Turns out everytime we receive the `CreateLanguageServer` message we'd add a new adapter but only have a single server running for all of them. And we send a `CreateLanguageServer` message everytime you open a buffer. What this does is to only add a new adapter if it hasn't already been registered, which is also what we do locally. Release Notes: - N/A
Thorsten Ball created
ca033e6
Revert "Update nightly tag every night (#17879)" (#18133)
This PR reverts #17879, as it wasn't working. When a GitHub Action pushes a tag, it does not trigger workflows for push events for that tag: > When you use the repository's `GITHUB_TOKEN` to perform tasks, events triggered by the `GITHUB_TOKEN`, with the exception of `workflow_dispatch` and `repository_dispatch`, will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's `GITHUB_TOKEN`, a new workflow will not run even when the repository contains a workflow configured to run when `push` events occur. > > — [source](https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow) This reverts commit 761129e3739efacb7b8763eaa0fa8a109e935447. Release Notes: - N/A
Marshall Bowers created
97708fd
settings: Follow-up fix to show more errors (#18123)
The condition added in #18122 was too strict. Release Notes: - N/A
Thorsten Ball created
ace4d51
settings: Show notification when user/project settings fail to parse (#18122)
Closes #16876
We only ever showed parsing errors, but not if something failed to
deserialize.
Basically, if you had a stray `,` somewhere, we'd show a notification
for user errors, but only squiggly lines if you had a `[]` instead of a
`{}`.
The squiggly lines would only show up when there were schema errors.
In the case of `formatter` settings, for example, if someone put in a
`{}` instead of `[]`, we'd never show anything.
With this change we always show a notification if parsing user or
project settings fails.
(Right now, the error message might still be bad, but that's a separate
change)
Release Notes:
- Added a notification to warn users if their user settings or
project-local settings failed to deserialize.
Demo:
https://github.com/user-attachments/assets/e5c48165-f2f7-4b5c-9c6d-6ea74f678683
Thorsten Ball created
9373098
ssh remoting: Restore items/buffers when opening SSH project (#18083)
Demo: https://github.com/user-attachments/assets/ab79ed0d-13a6-4ae7-8e76-6365fc322ec4 Release Notes: - N/A Co-authored-by: Bennet <bennet@zed.dev>
Thorsten Ball and Bennet created
579267f
docs: Update JavaScript docs and remove TBDs (#17989)
Release Notes: - N/A
Thorsten Ball created
8103ac1
ssh-remoting: Tidy up the code a bit after #18094 (#18102)
Release Notes: - N/A
Stanislav Alekseev created
15b4130
Introduce the ability to cycle between alternative inline assists (#18098)
Release Notes: - Added a new `assistant.inline_alternatives` setting to configure additional models that will be used to perform inline assists in parallel. --------- Co-authored-by: Nathan <nathan@zed.dev> Co-authored-by: Roy <roy@anthropic.com> Co-authored-by: Adam <wolffiex@anthropic.com>
Antonio Scandurra , Nathan , Roy , and Adam created
ae34872
Fix prompt reloading in dev mode (#18095)
I think I nulled out the repo path to test the non dev mode case and then forgot to reenable it 🤦♂️ . Release Notes: - N/A
Nathan Sobo created
740803d
Bump release_notes to v2 endpoint (#18108)
Partially addresses https://github.com/zed-industries/zed/issues/17527 <img width="1608" alt="SCR-20240919-rcik" src="https://github.com/user-attachments/assets/25057731-7da6-4b36-b51b-021c67e8736b"> Release Notes: - Enhanced the `auto update: view release notes locally` feature to display release notes for each patch version associated with the installed minor version.
Joseph T. Lyons created
edf2c19
Hide GPU problems from Slack (#18087)
Release Notes: - N/A --------- Co-authored-by: Marshall <marshall@zed.dev> Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Conrad Irwin , Marshall , and Marshall Bowers created
82e6b1e
docs: Update glibc requirements for current binaries (#18101)
Peter Tripp created
28a54ce
Add diagnostic information to context of inline assistant (#18096)
Release Notes: - Added Diagnostic information to inline assistant. This enables users to just say "Fix this" and have the model know what the errors are.
Roy Williams created
fbbf039
ssh-remoting: Fix go to definition out of worktree (#18094)
Release Notes: - ssh-remoting: Fixed go to definition outside of worktree --------- Co-authored-by: Mikayla <mikayla@zed.dev>
Conrad Irwin and Mikayla created
00b1c81
context_servers: Remove context_type from ResourceContent (#18097)
This is removed in the protocol Release Notes: - N/A
David Soria Parra created
27c1106
Fix bug where copying from assistant panel appends extra newline to clipboard (#18090)
Closes https://github.com/zed-industries/zed/issues/17661 Release Notes: - Fixed a bug where copying from the assistant panel appended an additional newline to the end of the clipboard contents.
Joseph T. Lyons created
1fc391f
Make `Buffer::apply_ops` infallible (#18089)
This PR makes the `Buffer::apply_ops` method infallible for `text::Buffer` and `language::Buffer`. We discovered that `text::Buffer::apply_ops` was only fallible due to `apply_undo`, which didn't actually need to be fallible. Release Notes: - N/A
Marshall Bowers created
8074fba
Update List to support UI Density (#18079)
Tracking issue: #18078 Improve UI Density support for List. UI density is an unstable feature. You can read more about it in the above issue! | Before Normal - Before Dense - After Normal - After Dense | |--------------------------------------------------------| |  | | | | | Before Normal - Before Dense - After Normal - After Dense | |--------------------------------------------------------| |  | Release Notes: - N/A
Nate Butler created