Commit log

92066fd Use gh to edit release directly

Conrad Irwin created

0f744b0 Revert "DEBUG release-notes-script"

Click to expand commit body
This reverts commit f6d3e53f254811ca2a988c0c351bb233c781d996.

Conrad Irwin created

5d13bd0 Revert "More debugging"

Click to expand commit body
This reverts commit dab258a5be25ee009a4bd2d7fd584bd688499c52.

Conrad Irwin created

9976553 Fix space repeating in terminal (cherry-pick #20877) (#20879)

Click to expand commit body
Cherry-picked Fix space repeating in terminal (#20877)

This is broken because of the way we try to emulate macOS's
ApplePressAndHoldEnabled.

Release Notes:

- Fixed holding down space in the terminal (preview only)

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>

gcp-cherry-pick-bot[bot] and Conrad Irwin created

dab258a More debugging

Conrad Irwin created

a1a304b assistant: Fix evaluating slash commands in slash command output (like `/default`) (#20864)

Click to expand commit body
This PR fixes an issue where slash commands in the output of other slash
commands were not being evaluated when configured to do so.

Closes https://github.com/zed-industries/zed/issues/20820.

Release Notes:

- Fixed slash commands from other slash commands (like `/default`) not
being evaluated (Preview only).

Marshall Bowers created

f6d3e53 DEBUG release-notes-script

Conrad Irwin created

38abf62 Bump to 0.162.3 for @ConradIrwin

Zed Bot created

7d34400 Don't call setAllowsAutomaticKeyEquivalentLocalization on Big Sur (cherry-pick #20844) (#20846)

Click to expand commit body
Cherry-picked Don't call setAllowsAutomaticKeyEquivalentLocalization on
Big Sur (#20844)

Closes #20821

Release Notes:

- Fixed a crash on Big Sur (preview only)

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>

gcp-cherry-pick-bot[bot] and Conrad Irwin created

416243b assistant: Adjust title summarization prompt (#20822)

Click to expand commit body
Meant to avoid the excessive use of "Here's a concise 3-7 word title..."
and "Title:" instances we've been seeing lately.
Follow up to: https://github.com/zed-industries/zed/pull/19530

Release Notes:

- Improve prompt for generating title summaries, avoiding preambles

Danilo Leal created

cc5adf2 Disable signature help shown by default (#20726)

Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/20725

Stop showing the pop-up that gets an issue open every now and then.

Release Notes:

- Stopped showing signature help after completions by default

Kirill Bulatov created

c3112c5 Fix Linux rust-analyzer downloads in Preview (#20718)

Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/20408

Release Notes:

- (Preview) Fixed broken rust-analyzer downloads

Kirill Bulatov created

8fa471f zed 0.162.2

Peter Tripp created

182559a context_servers: Upgrade protocol to version 2024-11-05 (#20615)

Click to expand commit body
This updates context servers to the most recent version

Release Notes:

- N/A

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>

David Soria Parra and Marshall Bowers created

88f20bb zed_extension_api: Release v0.2.0 (#20683)

Click to expand commit body
This PR releases v0.2.0 of the Zed extension API.

Support for this version of the extension API will land in Zed v0.162.x.

Release Notes:

- N/A

Marshall Bowers created

f5f9ae1 Move `ExtensionStore` tests back to `extension_host` (#20682)

Click to expand commit body
This PR moves the tests for the `ExtensionStore` back into the
`extension_host` crate.

We now have a separate `TestExtensionRegistrationHooks` to use in the
test that implements the minimal required functionality needed for the
tests. This means that we can depend on the `theme` crate only in the
tests.

Release Notes:

- N/A

Marshall Bowers created

5832328 Use vim-like keybindings for splitting out of the file finder (#20680)

Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/20507

Release Notes:

- (breaking Preview) Adjusted file finder split keybindings to be less
conflicting

Co-authored-by: Conrad Irwin <conrad@zed.dev>

Kirill Bulatov and Conrad Irwin created

d51221e Allow base64 encoded images to be decoded with or without padding (#20616)

Click to expand commit body
The R kernel doesn't use base64 padding whereas the Python kernel (via
matplotlib) sometimes uses padding. We have to use the `base64` crate's
`Indifferent` mode.

/cherry-pick v0.161.x

Release Notes:

- N/A

Kyle Kelley created

ba1fc41 Fix completions for non-built-in slash commands (#20632)

Click to expand commit body
Release Notes:

- N/A

Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld and Marshall created

4f47278 Improve context server lifecycle management (#20622)

Click to expand commit body
This optimizes and fixes bugs in our logic for maintaining a set of
running context servers, based on the combination of the user's
`context_servers` settings and their installed extensions.

Release Notes:

- N/A

---------

Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>

Max Brunsfeld , Marshall , and Marshall Bowers created

e9f4fac Extract `ExtensionSlashCommand` to `assistant_slash_command` crate (#20617)

Click to expand commit body
This PR extracts the `ExtensionSlashCommand` implementation to the
`assistant_slash_command` crate.

The slash command related methods have been added to the `Extension`
trait. We also create separate data types for the slash command data
within the `extension` crate so that we can talk about them without
depending on the `extension_host` or `assistant_slash_command`.

Release Notes:

- N/A

Marshall Bowers created

baf0da2 Decouple extension `Worktree` resource from `LspAdapterDelegate` (#20611)

Click to expand commit body
This PR decouples the extension `Worktree` resource from the
`LspAdapterDelegate`.

We now have a `WorktreeDelegate` trait that corresponds to the methods
on the resource.

We then create a `WorktreeDelegateAdapter` that can wrap an
`LspAdapterDelegate` and implement the `WorktreeDelegate` trait.

Release Notes:

- N/A

Marshall Bowers created

0c6f5e2 zed 0.162.1

Peter Tripp created

ff3d693 Don't double-localize menu shortcuts (#20623)

Click to expand commit body
Release Notes:

- Don't have macOS localize our menu shortcuts that we already
localized.

Conrad Irwin created

f468a2b Don't send key equivalents to the input hanlder (#20621)

Click to expand commit body
Release Notes:

- Fix `cmd-backtick` to change windows

Conrad Irwin created

451409e Deadkeys 2 (#20612)

Click to expand commit body
Re-land of #20515 with less brokenness

In particular it turns out that for control, the .characters() method
returns the control code. This mostly didn't make a difference, except
when the control code matched tab/enter/escape (for
ctrl-y,ctrl-[/ctrl-c) as we interpreted the key incorrectly.

Secondly, we were setting IME key too aggressively. This led to (in vim
mode) cmd-shift-{ being interpreted as [, so vim would wait for a second
[ before letting you change tab.

Release Notes:

- N/A

Conrad Irwin created

888385d Fix bad quote in script/determine-release-channel (#20613)

Peter Tripp created

1ceb653 v0.162.x preview

Joseph T. Lyons created

9d2fc69 project panel: Don't change label color even when file has errors (#20600)

Click to expand commit body
With this PR, Git status is now the only thing that can change an item's
label color. So, the summary of how status colors operate in the project
panel is:

- Item icon color is, by default, never changed, _not_ affected by
either diagnostics or Git status
  - This should become configurable in the near future, though
- However, a little x or triangle icon shows up on top of the file type
icon to display diagnostics status
- Label color is _not_ affected by diagnostics but it _is_ affected by
Git status

This aims to reduce color noise and clarify/simplify how each element is
affected.

Release Notes:

- N/A

Danilo Leal created

b084d53 Extract `ExtensionIndexedDocsProvider` to `indexed_docs` crate (#20607)

Click to expand commit body
This PR extracts the `ExtensionIndexedDocsProvider` implementation to
the `indexed_docs` crate.

To achieve this, we introduce a new `Extension` trait that provides an
abstracted interface for calling an extension. This trait resides in the
`extension` crate, which has minimal dependencies and can be depended on
by other crates, like `indexed_docs`.

We're then able to implement the `ExtensionIndexedDocsProvider` without
having any knowledge of the Wasm-specific internals of the extension
system.

Release Notes:

- N/A

Marshall Bowers created

7832883 terminal: Fix detection of ignored python venv (#20227)

Click to expand commit body
Closes #19227

Since items listed in `.gitignore` file are not included in a worktree,
python virtual environment cannot be detected until venv directory is
unfolded from project panel and forcefully added into worktree. I didn't
come up with anything better than scanning fs directly. I'm not sure how
it will affect remote development. if at all.

Release Notes:

- Fixed detection of `detect_venv.directories` ignored by a worktree

Askar created

eb4e747 Improve terminal.working_directory for non-project files (#18251)

Peter Tripp created

27dfb48 project panel: Fix entries being marked when switching between tabs (#20596)

Click to expand commit body
This is a follow-up (or related to) #20412.

It fixes entries being marked when navigating between tabs with `cmd-[`
and `cmd-]`.

Turns out that deep in the bowels of the project panel, we check whether
a `shift` modifier was pressed - which is the case with `cmd-[` on a US
ANSI layout - and if so mark an entry.

I think that's a left-over, because all the other code paths that
select/reveal an entry mark it explicitly too.

Release Notes:

- Fixed entries in project panel being marked when navigating between
tabs with keybinding that uses `shift` modifier.

Thorsten Ball created

3a319e6 docs: Improve formatter docs. Examples for C/C++ (#20553)

Peter Tripp created

84e47fb Fix context menus not cycling over its edge when selecting items (#20592)

Kirill Bulatov created

7e82ca8 Always allow rerunning the tasks using the tab button (#20591)

Click to expand commit body
Release Notes:

- Improved task tabs to always rerun tasks on click

Kirill Bulatov created

b440787 Standardize button design in modal footers (#20585)

Click to expand commit body
- Making sure this design and properties are the same across different
places
- No need for the `ButtonLike` here, we can use `Button` as it supports
`key_binding` and makes it for a cleaner code!
- Also, that ensures the binding is always to the right of the label,
which makes more sense
- Title-case the labels for consistency with other buttons across the
app

| File finder | Project finder |
|--------|--------|
| <img width="1136" alt="Screenshot 2024-11-13 at 09 21 06"
src="https://github.com/user-attachments/assets/dd051514-d873-4b65-a08f-af0920f2c010">
| <img width="1136" alt="Screenshot 2024-11-13 at 09 21 12"
src="https://github.com/user-attachments/assets/f958e3e7-4bfb-4752-839e-2bbc01334643">
|

Release Notes:

- N/A

Danilo Leal created

3b1f12a chore: Cleanup dev_server_projects leftover files (#20581)

Click to expand commit body
Closes #ISSUE

Release Notes:

- N/A

Piotr Osiewicz created

b8cf0a1 chore: use codegen-units=1 for small crates (#20558)

Click to expand commit body
These 500ms we'll save with this change will surely pay off.

Release Notes:

- N/A

Piotr Osiewicz created

3f22427 Restore the ability to navigate into project search input with the keyboard (#20579)

Kirill Bulatov created

56cf32c Add a way to use splits when opening in file finder (#20507)

Kirill Bulatov created

90ffd65 Document use of `allow_concurrent_runs` with long-running tasks (#20539)

Markus Wüstenberg created

55cd99c Revert "macOS: Improve deadkeys (#20515)" (#20570)

Click to expand commit body
This reverts commit https://github.com/zed-industries/zed/pull/20515

I'm reverting for now to fix issues with key bindings on Nightly:
* `ctrl-c` and `ctrl-m` are being treated as `ctrl-enter`
* `ctrl-[` isn't working in vim mode
* there's a delay before `cmd-shift-[` switches tabs w/ vim mode enabled

Release Notes:

- N/A

Max Brunsfeld created

0547748 Compare explicitly to YES/NO instead relying on booliness for objc (#20567)

Click to expand commit body
Just x86_64-apple-darwin things. Fixes the build for nightly.

Release Notes:

- N/A

Kyle Kelley created

5473519 Be more explicit about BOOL (#20564)

Click to expand commit body
On x86 Macs BOOL is not the same within the `objc` crate we're using.
This only comes up on nightly builds (not on CI), so I don't think I
have a way to trigger this issue locally.

Release Notes:

- N/A

Kyle Kelley created

466d331 Fix issue with image output from Jupyter kernels that didn't use base64 padding (#20561)

Click to expand commit body
This upgrades `nbformat` and `runtimelib` to handle jupyter types with
even more validation and flexiblity. This also processes any multiline
string data coming from the kernel, including with image data (like
`image/png`). While I was at it I also fixed a longstanding issue around
images by eliminating all whitespace (something `atob` does) and using
the no pad decoder.

Fixes: #17956

Before:

<img width="741" alt="image"
src="https://github.com/user-attachments/assets/37ec2cae-ce78-4475-aaa3-4d785e4015d0">

After:

<img width="727" alt="image"
src="https://github.com/user-attachments/assets/e2431ba2-048b-4205-9898-54f357795a9c">


Release Notes:

- Fixed issue with image output from REPL kernels that didn't use base64
padding

Kyle Kelley created

3ebb64e Expose context server settings to extensions (#20555)

Click to expand commit body
This PR exposes context server settings to extensions.

Extensions can use `ContextServerSettings::for_project` to get the
context server settings for the current project.

The `experimental.context_servers` setting has been removed and replaced
with the `context_servers` setting (which is now an object instead of an
array).

Release Notes:

- N/A

---------

Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>

Marshall Bowers and Max Brunsfeld created

0a9c78a Show error and warning indicators in project panel items (#18182)

Click to expand commit body
Closes #5016

Release Notes:

- Add setting to display error and warning indicators in project panel
items.


https://github.com/user-attachments/assets/8f8031e6-ca47-42bf-a7eb-718eb1067f36

---------

Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>

Nils Koch , Thorsten Ball , and Danilo Leal created

a7eb3a9 Add "Book Onboarding" action across the app (#20503)

Click to expand commit body
This PR adds a small UI touch-up to the welcome page so we can introduce
the "Book Onboarding" over there, as well as adding it to the user menu
(both in the signed in and signed out states). The actual URL these
buttons take to will still be updated to the correct destination.

<img width="700" alt="Screenshot 2024-11-12 at 12 45 27"
src="https://github.com/user-attachments/assets/9933bf94-f57a-43e2-8da3-bfbfd9fd24d0">

Release Notes:

- N/A

Danilo Leal created

47ca340 Disable ligatures in SSH connection dialogue (#20549)

Click to expand commit body
Closes #20381

Release Notes:

- Fixed password dialog for remote server showing ligatures

Conrad Irwin created