2d34765
lsp: Retrieve links to documentation for the given symbol (#19233)
Click to expand commit body
Closes #18924
Release Notes:
- Added an `editor:OpenDocs` action to open links to documentation via
rust-analyzer
Lu Wan
created
f9990b4
Send events to Snowflake in the format they're expected by Amplitude (#20765)
Click to expand commit body
This will allow us to use the events table directly in Amplitude, which
lets us use the newer event ingestion flow that detects changes to the
table. Otherwise we'll need a transformation.
I think Amplitude's API is probably a pretty good example to follow for
the raw event schema, even if we don't end up using their product. They
also recommend a "Noun Verbed" format for naming events, so I think we
should go with this. This will help us be consistent and encourage the
author of events to think more clearly about what event they're
reporting.
cc @ConradIrwin
Release Notes:
- N/A
Nathan Sobo
created
97e9137
Update references of Ollama Llama 3.1 to model Llama 3.2 (#20757)
Click to expand commit body
Release Notes:
- N/A
Siddharth M. Bhatia
created
932c7e2
gpui: Fix SVG color render, when color have alpha (#20537)
Click to expand commit body
Release Notes:
- N/A
## Demo
- [Source
SVG](https://github.com/user-attachments/assets/1c681e01-baba-4613-a3e7-ea5cb3015406)
click here open in browser.
| Before | After |
| --- | --- |
| <img width="1212" alt="image"
src="https://github.com/user-attachments/assets/ba323b13-538b-4a34-bb64-9dcf490aface">
| <img width="1212" alt="image"
src="https://github.com/user-attachments/assets/4635926a-843e-426d-89a1-4e9b4f4cc37e">
|
---------
Co-authored-by: Floyd Wang <gassnake999@gmail.com>
Release Notes:
- N/A
---
```
cargo run -p gpui --example painting
```
I added this demo to verify the detailed support of Path drawing in
GPUI.
Because of, when we actually used GPUI to draw a 2D line chart, we found
that the straight line Path#line_to did not support `anti-aliasing`, and
the drawn line looked very bad.
As shown in the demo image, if we zoom in on the image, we can clearly
see that all the lines are jagged.
I read and tried to make some appropriate adjustments to the functions
in Path, but since I have no experience in the graphics field, I still
cannot achieve anti-aliasing support so far.
I don't know if I used it wrong somewhere. I checked `curve_to` and
found that the curves drawn have anti-aliasing effects, as shown in the
arc part of the figure below.
<img width="1136" alt="image"
src="https://github.com/user-attachments/assets/4dfb7603-e746-43e9-b737-cff56b56329f">
Release Notes:
- Added Transparency effect for Windows #19405


---------
Co-authored-by: thedeveloper-sharath <35845141+thedeveloper-sharath@users.noreply.github.com>
Gowtham K
and
thedeveloper-sharath
created
21c785e
Add more common Prettier plugin base paths (#20758)
Click to expand commit body
Closes #19024
Release Notes:
- Added some more common Prettier plugin base paths
SweetPPro
created
516f7b3
Add Loading and Fallback States to Image Elements (via StyledImage) (#20371)
Click to expand commit body
@iamnbutler edit:
This pull request enhances the image element by introducing the ability
to display loading and fallback states.
Changes:
- Implemented the loading and fallback states for image elements using
`.with_loading` and `.with_fallback` respectively.
- Introduced the `StyledImage` trait and `ImageStyle` to enable a fluent
API for changing image styles across image types (`Img`,
`Stateful<Img>`, etc).
Example Usage:
```rust
fn loading_element() -> impl IntoElement {
div().size_full().flex_none().p_0p5().rounded_sm().child(
div().size_full().with_animation(
"loading-bg",
Animation::new(Duration::from_secs(3))
.repeat()
.with_easing(pulsating_between(0.04, 0.24)),
move |this, delta| this.bg(black().opacity(delta)),
),
)
}
fn fallback_element() -> impl IntoElement {
let fallback_color: Hsla = black().opacity(0.5);
div().size_full().flex_none().p_0p5().child(
div()
.size_full()
.flex()
.items_center()
.justify_center()
.rounded_sm()
.text_sm()
.text_color(fallback_color)
.border_1()
.border_color(fallback_color)
.child("?"),
)
}
impl Render for ImageLoadingExample {
fn render(&mut self, _cx: &mut ViewContext<Self>) -> impl IntoElement {
img("some/image/path")
.id("image-1")
.with_fallback(|| Self::fallback_element().into_any_element())
.with_loading(|| Self::loading_element().into_any_element())
}
}
```
Note:
An `Img` must have an `id` to be able to add a loading state.
Release Notes:
- N/A
---------
Co-authored-by: nate <nate@zed.dev>
Co-authored-by: michael <michael@zed.dev>
Co-authored-by: Nate Butler <iamnbutler@gmail.com>
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Mikayla Maki
,
nate
,
michael
,
Nate Butler
, and
Antonio Scandurra
created
Update docs to reflect the correct path for prompt handlebars templates.
Link to git repo for prompts rather than including an out of date version inline.
Co-authored-by: Peter Tripp <peter@zed.dev>
Wes Higbee
and
Peter Tripp
created
050ce91
Rename "Overwrite" to "Save" for prompt about recreating a deleted file (#20750)
Click to expand commit body
Release Notes:
- N/A
Michael Sloan
created
369828f
Require save confirmation and prevent autosave for deleted files (#20742)
Click to expand commit body
* `has_conflict` will now return true if the file has been deleted on
disk. This is for treating multi-buffers as conflicted, and also
blocks auto-save.
* `has_deleted_file` is added so that the single-file buffer save can
specifically mention the delete conflict. This does not yet handle
discard (#20745).
Closes #9101
Closes #9568
Closes #20462
Release Notes:
- Improved handling of externally deleted files: auto-save will be
disabled, multibuffers will treat this as a save conflict, and single
buffers will ask for restore confirmation.
Co-authored-by: Conrad <conrad@zed.dev>
1235d08
Use livekit's Rust SDK instead of their swift SDK (#13343)
Click to expand commit body
See https://github.com/livekit/rust-sdks/pull/355
Todo:
* [x] make `call` / `live_kit_client` crates use the livekit rust sdk
* [x] create a fake version of livekit rust API for integration tests
* [x] capture local audio
* [x] play remote audio
* [x] capture local video tracks
* [x] play remote video tracks
* [x] tests passing
* bugs
* [x] deafening does not work
(https://github.com/livekit/rust-sdks/issues/359)
* [x] mute and speaking status are not replicated properly:
(https://github.com/livekit/rust-sdks/issues/358)
* [x] **linux** - crash due to symbol conflict between WebRTC's
BoringSSL and libcurl's openssl
(https://github.com/livekit/rust-sdks/issues/89)
* [x] **linux** - libwebrtc-sys adds undesired dependencies on `libGL`
and `libXext`
* [x] **windows** - linker error, maybe related to the C++ stdlib
(https://github.com/livekit/rust-sdks/issues/364)
```
libwebrtc_sys-54978c6ad5066a35.rlib(video_frame.obj) : error LNK2038:
mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't
match value 'MD_DynamicRelease' in
libtree_sitter_yaml-df6b0adf8f009e8f.rlib(2e40c9e35e9506f4-scanner.o)
```
* [x] audio problems
Release Notes:
- Switch from Swift to Rust LiveKit SDK 🦀
---------
Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Co-authored-by: Conrad Irwin <conrad@zed.dev>
Co-authored-by: Kirill Bulatov <kirill@zed.dev>
Co-authored-by: Michael Sloan <michael@zed.dev>
Max Brunsfeld
,
Mikayla Maki
,
Conrad Irwin
,
Kirill Bulatov
, and
Michael Sloan
created
6ff69fa
Start to send data to Snowflake too (#20698)
Click to expand commit body
This PR adds support for sending telemetry events to AWS Kinesis.
In our AWS account we now have three new things:
* The [Kinesis data
stream](https://us-east-1.console.aws.amazon.com/kinesis/home?region=us-east-1#/streams/details/zed-telemetry/monitoring)
that we will actually write to.
* A [Firehose for
Axiom](https://us-east-1.console.aws.amazon.com/firehose/home?region=us-east-1#/details/telemetry-to-axiom/monitoring)
that sends events from that stream to Axiom for ad-hoc queries over
recent data.
* A [Firehose for
Snowflake](https://us-east-1.console.aws.amazon.com/firehose/home?region=us-east-1#/details/telemetry-to-snowflake/monitoring)
that sends events from that stream to Snowflake for long-term retention.
This Firehose also backs up data into an S3 bucket in case we want to
change how the system works in the future.
In a follow-up PR, we'll add support for ad-hoc telemetry events; and
slowly move away from the current Clickhouse defined schemas; though we
won't move off click house until we have what we need in Snowflake.
Co-Authored-By: Nathan <nathan@zed.dev>
Release Notes:
- N/A
The Renovate config in this repository needs migrating. Typically this
is because one or more configuration options you are using have been
renamed.
You don't need to merge this PR right away, because Renovate will
continue to migrate these fields internally each time it runs. But later
some of these fields may be fully deprecated and the migrations removed.
So it's a good idea to merge this migration PR soon.
🔕 **Ignore**: Close this PR and you won't be reminded about config
migration again, but one day your current config may no longer be valid.
❓ Got questions? Does something look wrong to you? Please don't hesitate
to [request help
here](https://redirect.github.com/renovatebot/renovate/discussions).
---
Release Notes:
- N/A
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
renovate[bot]
,
renovate[bot]
, and
Marshall Bowers
created
da09cbd
assistant: Show more details for assist errors (#20740)
Click to expand commit body
This PR updates the Assistant to show more detailed error messages when
the user encounters an assist error.
Here are some examples:
<img width="415" alt="Screenshot 2024-11-15 at 1 47 03 PM"
src="https://github.com/user-attachments/assets/5e7c5d5f-bd78-4af3-86ed-af4c6712770f">
<img width="417" alt="Screenshot 2024-11-15 at 2 11 14 PM"
src="https://github.com/user-attachments/assets/02cb659b-1239-4e24-865f-3a512703a94f">
The notification will scroll if the error lines overflow the set maximum
height.
Release Notes:
- Updated the Assistant to show more details in error cases.
Michael Sloan
,
Richard Feldman
, and
Marshall Bowers
created
c491b75
assistant: Fix panic when using `/project` (#20733)
Click to expand commit body
This PR fixes a panic when using `/project` (which is staff-flagged).
We weren't initializing the `SemanticDb` global if the
`project-slash-command` feature flag was enabled.
Closes #20563.
Release Notes:
- N/A
This PR updates the `.mailmap` file to merge some more commit authors.
Release Notes:
- N/A
Marshall Bowers
created
6d80d5b
gpui: Add `line_through` method to `Styled` (#20728)
Click to expand commit body
This PR adds a `.line_through` method to the `Styled` trait that mirrors
the corresponding Tailwind class.
Release Notes:
- N/A
Marshall Bowers
created
7137bde
Fix scrollbar not always being on top (#20665)
Click to expand commit body
Set the elevation of the scrollbar to 1 borderless, so that the blue
outline is no longer above the scrollbar.
Closes #19875
Release Notes:
- N/A
---------
Co-authored-by: Peter Tripp <peter@zed.dev>
TOULAR
and
Peter Tripp
created
98403aa
Disable signature help shown by default (#20726)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/20725
Stop showing the pop-up that gets an issue open every now and then.
Release Notes:
- Stopped showing signature help after completions by default
Kirill Bulatov
created
794ad1a
ocaml: Improve highlighting and bracketing (#20700)
Click to expand commit body
Some small improvements to OCaml. Would happily split these into smaller
changes, discard anything, etc.
Before:
<img width="441" alt="before"
src="https://github.com/user-attachments/assets/2fb82b03-0d45-4c59-a94d-6f48d634fe19">
After:
<img width="448" alt="after"
src="https://github.com/user-attachments/assets/aa232d8f-4b1b-48f8-93e2-2147de37a20d">
OCaml highlighting and bracketing improvements
- Fixed bug where `<` was automatically closed with `>`.
- Typing `{|` now automatically closes with `|}`
- Type variables are now colored with `variable.special` instead of
`variable`.
- Argument names in function declarations and application are now
colored with `label` instead of `property`, even if they are punned.
- `[@@` and `[%` in macros are now colored as bracket punctuation to
match the closing `]`, rather than colored as `attribute`
Release Notes:
- N/A
3796b4a
project panel: Update decoration icon active color (#20723)
Click to expand commit body
Just so that the icon decoration knockout color matches the background
of a selected/market item.
<img width="600" alt="Screenshot 2024-11-15 at 10 50 24"
src="https://github.com/user-attachments/assets/0037fe5a-f42d-47e8-8559-97ca11ff2d97">
Release Notes:
- N/A
Danilo Leal
created
8c02929
pane: Fix rough edges around pinning of dropped project entries (#20722)
Click to expand commit body
Closes #20485
Release Notes:
- Fixed quirks around dropping project entries into tab bar which
might've led to tabs being pinned sometimes.
Piotr Osiewicz
created
1e14697
Fix Linux rust-analyzer downloads in Preview (#20718)
This removes the `low_speed_timeout` setting from all providers as a
response to issue #19509.
Reason being that the original `low_speed_timeout` was only as part of
#9913 because users wanted to _get rid of timeouts_. They wanted to bump
the default timeout from 5sec to a lot more.
Then, in the meantime, the meaning of `low_speed_timeout` changed in
#19055 and was changed to a normal `timeout`, which is a different thing
and breaks slower LLMs that don't reply with a complete response in the
configured timeout.
So we figured: let's remove the whole thing and replace it with a
default _connect_ timeout to make sure that we can connect to a server
in 10s, but then give the server as long as it wants to complete its
response.
Closes #19509
Release Notes:
- Removed the `low_speed_timeout` setting from LLM provider settings,
since it was only used to _increase_ the timeout to give LLMs more time,
but since we don't have any other use for it, we simply remove the
setting to give LLMs as long as they need.
---------
Co-authored-by: Antonio <antonio@zed.dev>
Co-authored-by: Peter Tripp <peter@zed.dev>
Thorsten Ball
,
Antonio
, and
Peter Tripp
created
c954607
docs: Update Zig Tree-sitter grammar link (#20708)
Click to expand commit body
lines up with
https://github.com/zed-industries/zed/blob/main/extensions/zig/extension.toml
Release Notes:
- N/A
chottolabs
created
1855a31
Use `Extension` trait in `ExtensionLspAdapter` (#20704)
Click to expand commit body
This PR updates the `ExtensionLspAdapter` to go through the `Extension`
trait for interacting with extensions rather than going through the
`WasmHost` directly.
Release Notes:
- N/A
f0882f4
vim: Enable `%` to jump between tags (#20536)
Click to expand commit body
Closes #12986
Release Notes:
- Enable `%` to jump between pairs of tags
---------
Co-authored-by: Harrison <hrouillard@sfi.com.au>
hrou0003
and
Harrison
created
189a034
docs: Document exec flags for GDScript (#20688)
Click to expand commit body
While looking up the GDScript extension docs, I noticed that the
original extension repo mentions of `{line}:{col}` placeholders too in
addition to `{project} {file}` that the Zed docs suggest adding.
This PR Improves the docs to add those missing options to the suggested
flags.
Harsh Narayan Jha
created
7f52071
Use the project env when running LSPs (#20641)
Click to expand commit body
This change ensures we always run LSPs with the project environment (in
addition to any overrides they provide). This helps ensure the
environment is
set correctly on remotes where we don't load the login shell environment
and
assign it to the current process.
Also fixed the go language to use the project env to find the go
command.
Release Notes:
- Improved environment variable handling for SSH remotes
Conrad Irwin
created
56c93be
project panel: Fix rendering of groups of dragged project panel entries (#20686)
Click to expand commit body
This PR introduces a new parameter for `on_drag` in gpui, which is an
offset from the element origin to the mouse event origin.
Release Notes:
- Fixed rendering of dragged project panel entries