e5f3a68
Fixing Missing comma (#21749)
Click to expand commit body
Fix a missing comma in the docs Release Notes: - N/A
Travis Stevens created
e5f3a68
Fixing Missing comma (#21749)
Fix a missing comma in the docs Release Notes: - N/A
Travis Stevens created
8c91eec
call: Add `test-support` feature for `livekit_client_macos` (#21748)
This PR updates the `call` crate to include the `test-support` feature for `livekit_client_macos` when `call` is used with `test-support`. This fixes running `cargo test -p copilot` and `cargo test -p editor` (and perhaps some other crates). Release Notes: - N/A
Marshall Bowers created
8fcaf8b
collab: Fix compilation error by removing dependency on livekit_client (#21744)
This fixes collab not being able to compile anymore for Linux: https://github.com/zed-industries/zed/actions/runs/12236650046/job/34130962682 Release Notes: - N/A Co-authored-by: Antonio <antonio@zed.dev>
Thorsten Ball and Antonio created
77b8296
Introduce staff-only inline completion provider (#21739)
Release Notes: - N/A --------- Co-authored-by: Thorsten Ball <mrnugget@gmail.com> Co-authored-by: Bennet <bennet@zed.dev> Co-authored-by: Thorsten <thorsten@zed.dev>
Antonio Scandurra , Thorsten Ball , Bennet , and Thorsten created
39e8944
language_tools: Split LSP log view selector into two (#21742)
This should make it easier to interact with LSP log view when there are multiple language servers. I often find the current UI clunky when I have over 5 servers running (which isn't uncommon with multiple projects open) https://github.com/user-attachments/assets/2ecaf17f-4b40-4c8f-aa6f-03b437a3d979 Closes #ISSUE Release Notes: - N/A
Piotr Osiewicz created
a7d12ee
Enhance the Vim Mode toggle discoverability (#21589)
Closes https://github.com/zed-industries/zed/issues/21522 This PR adds an info tooltip on the Welcome screen, informing users how Vim Mode can be toggled on and off. It also adds the Vim Mode toggle in the Editor Controls menu. This is all so that folks who accidentally turn it on better know how to turn it off. We're of course already able to toggle this setting via the command palette, but that may be harder to reach for beginners. So, maybe that's enough to close the linked issue? Open to feedback. (Note: I also added a max-width to the tooltip's label in this PR. I'm confident that this won't make any tooltip look weird/broken, but if it does, it may be because of this new property). | Welcome Page | Editor Controls | |--------|--------| | <img width="800" alt="Screenshot 2024-12-05 at 11 20 04" src="https://github.com/user-attachments/assets/1229f866-6be5-45cd-a6b8-c805f72144a6"> | <img width="800" alt="Screenshot 2024-12-05 at 11 12 15" src="https://github.com/user-attachments/assets/f082d7f9-7d56-41d1-bc86-c333ad6264c7"> | Release Notes: - N/A --------- Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Danilo Leal and Thorsten Ball created
ce9e462
Add go version to gopls cache key (#20922)
Closes #8071
Release Notes:
- Changed the Go integration to check whether an existing `gopls` was compiled for the current `go` version.
Previously we cached gopls (the go language server) as a file called
`gopls_{GOPLS_VERSION}`. The go version that gopls was built with is
crucial, so we need to cache the go version as well.
It's actually super interesting and very clever; gopls uses go to parse
the AST and do all the analyzation etc. Go exposes its internals in its
standard lib (`go/parser`, `go/types`, ...), which gopls uses to analyze
the user code. So if there is a new go release that contains new
syntax/features/etc. (the libraries `go/parser`, `go/types`, ...
change), we can rebuild the same version of `gopls` with the new version
of go (with the updated `go/xxx` libraries) to support the new language
features.
We had some issues around that (e.g., range over integers introduced in
go1.22, or custom iterators in go1.23) where we never updated gopls,
because we were on the latest gopls version, but built with an old go
version.
After this PR gopls will be cached under the name
`gopls_{GOPLS_VERSION}_go_{GO_VERSION}`.
Most users do not see this issue anymore, because after
https://github.com/zed-industries/zed/pull/8188 we first check if we can
find gopls in the PATH before downloading and caching gopls, but the
issue still exists.
Nils Koch created
e58cdca
Added JavaScript runnable detection for `context` and `suite` methods (#21719)
Fixes https://github.com/zed-industries/zed/pull/21246#issuecomment-2525578141 <img width="545" alt="Screenshot 2024-12-08 at 22 58 33" src="https://github.com/user-attachments/assets/2f303bfe-9718-4aa9-910e-613feca15ea8"> <img width="409" alt="Screenshot 2024-12-08 at 22 58 44" src="https://github.com/user-attachments/assets/c4576cf7-fd71-44d2-911e-3ed944c9b794"> Release Notes: - Added JavaScript runnable detection for `context` and `suite` methods for mochajs framework
Remco Smits created
4564273
Add comment explaining project panel behavior on right-click outside selection
mgsloan@gmail.com created
55ee72d
Simplify TextHighlights map (#21724)
Remove unnecessary `Option` wrapping.
JoΓ£o Marcos created
2ce01ea
Fix right click selection behavior in project panel (#21707)
Closes #21605 Consider you have set of entries selected or even a single entry selected, and you right click some other entry which is **not** part of your selected set. This doesn't not clear existing entries selection (which it should clear, as how file manager right-click logic works, see more below). This issue might lead unexpected operation like deletion applied on those existing selected entries. This PR fixes it. Release Notes: - Fix right click selection behavior in project panel
tims created
bf15255
Add .jj to default file exclusion (#21708)
Relates to #21538 Release Notes: - Added `**/.jj` to the default file exclusion list.
Hendrik created
d0e99f6
Bump x11rb version to v0.13.1 (#21723)
From diff looks like no material differences. With a local checkout of `v0.13.0` I get build errors due to warning checking when I use a `path = ...` dependency, but it is fixed with `v0.13.1`. I see mention of this in the [renovate configuration PR](https://github.com/zed-industries/zed/pull/15132) but doesn't seem like that initial batch of renovation happened. Release Notes: - N/A
Michael Sloan created
ac07b91
gpui: Don't panic on failing to set X11 cursor style (#21689)
One more panic (well, two) that should be a `log_err`. Release Notes: - N/A
Cole Miller created
4b93a5c
Make completions selector continue to show docs aside if ever shown (#21704)
In #21286, documentation fetch was made more efficient by only fetching the current completion. This has a side effect of causing the aside to disappear and reappear when navigating the list. This is particularly jarring when there isn't enough space for the aside, causing the completions list to jump to the left. The solution here is to continue to show the aside even if the current selection does not yet have docs fetched. Release Notes: - N/A
Michael Sloan created
c5b6d78
project_diff: Keep going after failing to rescan a buffer (#21673)
I ran into a case locally where the project diff view was unexpectedly empty because the first file to be scanned wasn't valid UTF-8, and the inmost loop in `schedule_worktree_rescan` currently breaks when any loading task fails. It seems like it might make more sense to continue with the rest of the buffers in this case and also when `Project::open_unstaged_changes` fails. I've left the error handling for `update` as-is. Release Notes: - Fix project diff view missing files
Cole Miller created
eb3d3ea
Adjust diagnostic in tabs behavior (#21671)
Follow up to https://github.com/zed-industries/zed/pull/21637
After discussing about this feature with the team, we've decided that
diagnostic display in tabs should be: 1) turned off by default, and 2)
only shown when there are file icons. The main reason here being to keep
Zed's UI uncluttered.
This means that you can technically have this setting:
```
"tabs": {
"show_diagnostics": "all"
},
```
...and still don't see any diagnostics because you're missing
`file_icons": true`.
| Error with file icons | Error with no file icons |
|--------|--------|
| <img width="800" alt="Screenshot 2024-12-06 at 21 05 13"
src="https://github.com/user-attachments/assets/babf9cc3-b3b0-492e-9748-3e97d96ce90e">
| <img width="800" alt="Screenshot 2024-12-06 at 21 05 24"
src="https://github.com/user-attachments/assets/5247a5f1-55a0-4c56-8aaf-a0cdd115464f">
|
Release Notes:
- N/A
Danilo Leal created
fdc7751
toolchains: Do not use as_json representation for PartialEq (#21682)
Closes #21679 Release Notes: - N/A
Piotr Osiewicz created
f561a91
lsp: Add support for didRename/willRename LSP messages (#21651)
Closes #21564 Notably, RA will now rename module references if you change the source file name via our project panel. This PR is a tad bigger than necessary as I torn out the Model<> from didSave watchers (I tried to reuse that code for the same purpose). Release Notes: - Added support for language server actions being executed on file rename.
Piotr Osiewicz created
14ba4a9
Fix zoomed terminal pane issues on split (#21668)
Closes https://github.com/zed-industries/zed/issues/21652 * prevents zooming out the panel when any terminal pane is closed * forces focus on new terminal panes, to prevent the workspace from getting odd pane events in the background Release Notes: - (Preview only) Fixed zoomed terminal pane issues on split
Kirill Bulatov created
fa7dddd
gpui: Don't panic when failing to exec system opener (#21674)
Cole Miller created
4d22a07
Remove last few alt- bindings (#21669)
Although I hoped we could keep the non-ascii alt characters, it turns
out this is not the case for all keyboards.
Fixes #21175
Release Notes:
- (breaking change) editor::ShowInlineCompetion is now `option-tab` on
macOS
(not `option-/`). editor::{Next,Previous}Completion are `option-tab` and
`option-shift-tab` (not `option-[` and `option-]`). This fixes typing
characters generated by option-{/,[,]} on keyboards like Croatian.
Conrad Irwin created
9e287b3
Update NorwegianExtended equivalents (#21665)
Release Notes: - Impoved key equivalents for Norwegian Extended layout
Conrad Irwin created
9d44ed0
Stop overriding cancelOperation (#21667)
This was added before we were handling key equivalents, and is no longer needed. Furthermore in the gpui2 re-write we stopped sending the correct modifiers so this hasn't worked for the last year. Fixes #21520 Release Notes: - Fixed a bug where cmd-escape could act like .
Conrad Irwin created
21a6664
gpui: Support animated WebP image (#20778)
Add support for decoding animated WebP images into their individual frames. Release Notes: - N/A
Matin Aniss created
e019d14
Send an event when user changes their max monthly spend limit (#21664)
Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Joseph T. Lyons and Marshall Bowers created
e5374f5
windows: Ignore WM_SIZE event when minimizing window (#21533)
Closes #21364 Release Notes: - Fixed minimize window and then reopen cause the layout changed 
feeiyu created
de939e7
Simplify livekit config so that cargo check Just Works (#21661)
Supersedes https://github.com/zed-industries/zed/pull/21653 This enables us to use `cargo test -p workspace` on macOS and Linux. Note that the line diffs in `shared_screen.rs` are spurious, I just re-ordered the `macos` and `cross-platform` modules to match the order in the call crate. Release Notes: - N/A
Mikayla Maki created
7d80d12
vim: Add delete action to HelixNormal mode (#21544)
Related issue: https://github.com/zed-industries/zed/issues/4642 Release-Notes: * N/A
geemili created
78ca297
Make use_key_equivalents opt-in (#21662)
When revamping international keyboard shortcuts I wanted to make the default to use key equivalents; in hindsight, this is not what people expect. Release Notes: - (Breaking) In keymap.json `"use_layout_keys": true` is now the default. If you want to opt-out of this behaviour, set `"use_key_equivalents": true` to have keys mapped for your keyboard. See [documentation](https://zed.dev/docs/key-bindings#non-qwerty-keyboards) --------- Co-authored-by: Peter Tripp <peter@zed.dev>
Conrad Irwin and Peter Tripp created
17448f2
docs: Add clarification in Windows build instructions (#21659)
The Bearodactyl created
e730a9d
Bump to livekit 1.1.6 (#21660)
Co-Authored-By: Mikayla <mikayla@zed.dev> This bumps to the latest v1 version of swift SDK. We could bump to 2, but it sounds like this will already have some race condition fixes (and a click around locally seems less prone to deadlocking so far...) Release Notes: - N/A
Conrad Irwin created
5142e38
editor: Add actions for inserting UUIDs (#21656)
This PR adds two new actions for generating and inserting UUIDs into the buffer: https://github.com/user-attachments/assets/a3445a98-07e2-40b8-9773-fd750706cbcc Release Notes: - Added `editor: insert uuid v4` and `editor: insert uuid v7` actions for inserting generated UUIDs into the editor.
Marshall Bowers created
7a1a792
docs: Add x.ai Grok example (#21655)
- Closes https://github.com/zed-industries/zed/issues/21635 <img width="639" alt="Screenshot 2024-12-06 at 13 57 42" src="https://github.com/user-attachments/assets/a4434edb-3c7d-40c0-9df8-7e928a9307d0"> Release Notes: - Document support for x.ai Grok
Peter Tripp created
0368fff
Update cloudflare/wrangler-action digest to 6d58852 (#21551)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [cloudflare/wrangler-action](https://redirect.github.com/cloudflare/wrangler-action) | action | digest | `05f17c4` -> `6d58852` | --- ### Configuration π **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS40Mi40IiwidXBkYXRlZEluVmVyIjoiMzkuNDIuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot] and renovate[bot] created
99c3181
docs: Correct default values (#20897)
Some default values in the doc are outdated. Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Jax Young and Marshall Bowers created
feb2d85
Add YAML/TOML frontmatter injections for markdown (#21503)
Closes #7938. Adds front-matter injections for TOML/YAML in markdown. - See: https://github.com/tree-sitter-grammars/tree-sitter-markdown/blob/split_parser/tree-sitter-markdown/queries/injections.scm. Co-authored-by: Peter Tripp <peter@zed.dev>
uncenter and Peter Tripp created
d6e11c5
Update Rust crate pathdiff to v0.2.3 (#21568)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pathdiff](https://redirect.github.com/Manishearth/pathdiff) | workspace.dependencies | patch | `0.2.2` -> `0.2.3` | --- ### Configuration π **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS40Mi40IiwidXBkYXRlZEluVmVyIjoiMzkuNDIuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot] and renovate[bot] created
8a6c2bb
Update Rust crate rsa to v0.9.7 (#21570)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rsa](https://redirect.github.com/RustCrypto/RSA) | workspace.dependencies | patch | `0.9.6` -> `0.9.7` | --- ### Release Notes <details> <summary>RustCrypto/RSA (rsa)</summary> ### [`v0.9.7`](https://redirect.github.com/RustCrypto/RSA/compare/v0.9.6...v0.9.7) [Compare Source](https://redirect.github.com/RustCrypto/RSA/compare/v0.9.6...v0.9.7) </details> --- ### Configuration π **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS40Mi40IiwidXBkYXRlZEluVmVyIjoiMzkuNDIuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot] and renovate[bot] created
b4f5928
markdown preview: Allow clicking on image to navigate to source location (#21630)
Follow up to #21082 Similar to checkboxes, you can now click on the image to navigate to the source location, cmd-clicking opens the url in the browser. https://github.com/user-attachments/assets/edaaa580-9d8f-490b-a4b3-d6ffb21f197c Release Notes: - N/A
Bennet Bo Fenner created
bffdc55
linux: Make prompt detail selectable (#21405)
Closes #21305 As Linux doesnβt have native prompts, Zed uses a custom GPU-based prompt, like the "About Zed" prompt. Currently, the detail in the prompt isnβt selectable. This PR fixes that by using the editor's multi-line selectable functionality to make the detail selectable (and thus copyable). It achieves this by disabling editing and setting the cursor to transparent. The editor also does all the heavy lifting, like double-clicking to select a word or triple-clicking to select a line, like what user expects from selectable. Before/After: <img src="https://github.com/user-attachments/assets/2012a6cc-a1ed-4efe-8bfb-440a9259f07a" alt="before" width="360px" /> <img src="https://github.com/user-attachments/assets/31922ef5-cb2d-4e90-a1a1-00843e767432" alt="after" width="360px" /> When detail is `None` or empty string: <img src="https://github.com/user-attachments/assets/2be5c921-bda1-4db3-85cd-b4b0e2df86d2" alt="none" width="360px" /> Release Notes: - N/A
tims created
9ca0d99
Update Rust crate ctor to v0.2.9 (#21561)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ctor](https://redirect.github.com/mmastrac/rust-ctor) | workspace.dependencies | patch | `0.2.8` -> `0.2.9` | --- ### Configuration π **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS40Mi40IiwidXBkYXRlZEluVmVyIjoiMzkuNDIuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot] and renovate[bot] created
e5251f4
Fix incorrect language selected in language selector (#21648)
Due to filtering after enumeration, initial candidate ids are assigned incorrectly. This later causes the wrong item to be picked up when accessed via index in the vector.
tims created
304158e
Catch panic from oo7 when reading credentials (#21617)
Cole Miller created
e8f0ebc
Refine diagnostic icons in tabs (#21637)
Follow up to https://github.com/zed-industries/zed/pull/21383 Mostly adjusting the alignment when there are no file icons. <img width="800" alt="Screenshot 2024-12-06 at 08 35 48" src="https://github.com/user-attachments/assets/6a4206cc-2af5-4317-a92e-49dffa37de99"> Release Notes: - N/A
Danilo Leal created
7b1d1bf
Update `panel.focused_border` token across themes (#21612)
Follow up to https://github.com/zed-industries/zed/pull/21593 This PR updates all built-in themes `panel.focused_border` tokens using the same HEX code used for `text_accent`. There shouldn't be any visual change here given the project panel item, when focused, was using `Color::Selected`, which maps to `text_accent`, to color its border. In the linked PR above, the project panel item was updated to use the dedicated token for that. This is good because now theme markers will be able to customize them separately (e.g., having a different `text_accent` color than `panel.focused_border`). Release Notes: - N/A
Danilo Leal created
4b16b73
Fix panel.background color override (#21559)
Closes #21266 Release Notes: - Fixes not using the `panel.background` color in the file tree See comments in https://github.com/zed-industries/zed/issues/21266 for more details. Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Nils Koch and Danilo Leal created
7e40add
markdown preview: Fix panic when parsing empty image tag (#21616)
Closes #21534 While investigating the panic, I noticed that the code was pretty complicated and decided to refactor parts of it to reduce redundancy. Release Notes: - Fixed an issue where the app could crash when opening the markdown preview with a malformed image tag
Bennet Bo Fenner created
f6b5e17
Get unstaged changes when excerpts of new buffers are added (#21619)
This fixes an error on nightly, introduced in https://github.com/zed-industries/zed/pull/21258, where diffs were not shown for buffers that were added to multi-buffers after construction. Release Notes: - N/A
Max Brunsfeld created
cf4e847
Implement session-global include_warnings in the diagnostic item (#21618)
Release Notes: - Make the include warnings toggle in the diagnostic tab global for a zed session.
Mikayla Maki created