Commit log

77932ac zed 0.166.2

Peter Tripp created

51213a2 Fix project environment not working correctly with multiple worktrees (#22246)

Click to expand commit body
Fixes https://github.com/zed-industries/zed/issues/21972

This fixes two bugs:

**Bug 1**: this bug caused us to only ever load a single environment in
a multi-worktree project, thanks to this line:

```rust
if let Some(task) = self.get_environment_task.as_ref()
```

We'd only ever run a single task per project, which is wrong.

What does code does is to cache the tasks per `worktree_id`, which means
we don't even need to cache the environments again, since we can just
cache the `Shared<Task<...>>`.

**Bug 2**: we assumed that every `worktree_abs_path` is a directory,
which lead to `Failed to run direnv` log messages when opening a project
that had a worktree with a single file open (easy to reproduce: open a
normal project, open your settings, close Zed, reopen it — the settings
faile caused environments to not load)

It's fixed by checking whether the `worktree_abs_path` is an absolute
directory. Since this is always running locally, it's fine to use
`smol::fs` here instead of using our `Fs`.

Release Notes:

- Fixed shell environments not being loaded properly to be used by
language servers and terminals in case a project had multiple worktrees.
- Fixed `Failed to run direnv` messages showing up in case Zed restored
a window that contained a worktree with a single file.
https://github.com/zed-industries/zed/issues/21972

Thorsten Ball created

01883a4 v0.166.x stable

Peter Tripp created

bb01d30 Fix panic in linked editing ranges (#21905)

Click to expand commit body
We were committing the cardinal sin of subtracting one from a column
without clipping

Closes #ISSUE

Release Notes:

- Fixed a panic in linked editing ranges

Conrad Irwin created

ee38693 Fix terminal pane tabs arrangement and closing (cherry-pick #22013) (#22017)

Click to expand commit body
Cherry-picked Fix terminal pane tabs arrangement and closing (#22013)

* Fixes the inability to drag and drop terminal tabs to reorder them;
fixed incorrect terminal tab move on drag and drop into existing pane
(follow-up of https://github.com/zed-industries/zed/pull/21238)
* Fixes save dialogue appearing when on closing terminal tabs with
running tasks (follow-up of
https://github.com/zed-industries/zed/pull/21374)

Release Notes:

- Fixed terminal pane tabs arrangement and closing

Co-authored-by: Kirill Bulatov <kirill@zed.dev>

gcp-cherry-pick-bot[bot] and Kirill Bulatov created

546b49c Bump to 0.166.1 for @ConradIrwin

Zed Bot created

6a7ef11 Revert "Resolve documentation for visible completions (#21705)"

Click to expand commit body
This reverts commit ab595b0d5575285f2351ff085c4a8862f2ddc1f2.

Conrad Irwin created

83feaaa v0.166.x preview

Joseph T. Lyons created

dfe455b zeta: Improve UI for feedback instructions (#21857)

Click to expand commit body
If the instructions are added as the input placeholder, when in a
smaller window size (like the one from the screenshot), scrolling is
needed to see them all. So, thought of extracting it out of there. Also
thought it looked more refined this way!

<img width="800" alt="Screenshot 2024-12-11 at 11 48 17"
src="https://github.com/user-attachments/assets/46974b94-6365-4a59-bf71-a6c0863aac68"
/>

Release Notes:

- N/A

Danilo Leal created

db7e384 zeta: Show keybinding on rating buttons (#21853)

Click to expand commit body
<img width="800" alt="Screenshot 2024-12-11 at 10 57 00"
src="https://github.com/user-attachments/assets/6055639c-5b38-444d-b76d-bf7584a82efc"
/>

Release Notes:

- N/A

Danilo Leal created

f8b6d71 Optimize REPL kernel spec refresh (#21844)

Click to expand commit body
Python kernelspec refresh now only performed on (known) python files. 

Release Notes:

- N/A

Kyle Kelley created

ae35129 zeta: Fixes to completion-rating modal (#21852)

Click to expand commit body
Release Notes:

- N/A

Co-authored-by: Antonio <antonio@zed.dev>

Thorsten Ball and Antonio created

664468d zeta: Invalidate completion in different buffers (#21850)

Click to expand commit body
Release Notes:

- N/A

Co-authored-by: Antonio <antonio@zed.dev>

Thorsten Ball and Antonio created

714f183 multi_buffer: optimize runnables layout (#21849)

Click to expand commit body
Related to #21481 ; it fixes a bunch of hotspots I saw while looking at
the provided profiles. MultiBuffer still takes up 100% CPU on the
foreground thread for me - this time around it's on selection updates
(when dragging the selected text towards an edge of a screen).

Release Notes:

- N/A

Piotr Osiewicz created

b36dcf3 Improve Zeta rating ergonomics (#21845)

Click to expand commit body
This PR adds keyboard shortcuts to common interactions you might want to
do in the Zeta rating panel.

This PR also adds a way to fake inline completion requests, as well as
the test data used to create this PR, to make it easier to adjust the UI
in the future.

It also changes the status bar from the text "Zeta" to "ζ", because I
thought it looked cool.

Release Notes:

- N/A

Mikayla Maki created

63e1bf0 zeta: Improve reviewing UI (#21838)

Click to expand commit body
Starting to fine-tune it.

| No edits scenario | Rated edits scenario |
|--------|--------|
| <img width="1577" alt="Screenshot 2024-12-11 at 01 57 46"
src="https://github.com/user-attachments/assets/42926e84-7a7f-4692-af44-672b52d3d377">
| <img width="1577" alt="Screenshot 2024-12-11 at 01 58 37"
src="https://github.com/user-attachments/assets/ee8ab0ef-75af-424c-b916-9f1ce8b5264d">

Release Notes:

- N/A

Danilo Leal created

62a6a75 Add `musl` package for Arch Linux (#21830)

Click to expand commit body
It seems like `musl` is required to build on Arch Linux, but it is not included in the dependencies list.

Connor Tsui created

28faba1 Recognize .C and .H as supported cpp extensions (#21647)

Click to expand commit body
Co-authored-by: Peter Tripp <peter@zed.dev>

Ethan Budd and Peter Tripp created

c255e55 assistant2: Sketch in sending file context to model (#21829)

Click to expand commit body
This PR sketches in support for sending file context attached to a
message to the model.

Right now the context is just mocked.

<img width="1159" alt="Screenshot 2024-12-10 at 4 18 41 PM"
src="https://github.com/user-attachments/assets/3ee4e86a-7893-42dc-98f9-982aa202d310">

<img width="1159" alt="Screenshot 2024-12-10 at 4 18 53 PM"
src="https://github.com/user-attachments/assets/8a3c2dd7-a466-4dbf-83ec-1c7d969c1a4b">

Release Notes:

- N/A

Marshall Bowers created

f80eb73 Update event type to conform to standard (#21827)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

faf79e5 zed_extension_api: Add a short explanation of `repo` format (#21824)

Click to expand commit body
Improved extension api documentation for latest_github_release function

Release Notes:

- N/A

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>

strowk and Marshall Bowers created

ab595b0 Resolve documentation for visible completions (#21705)

Click to expand commit body
Release Notes:

- Improved LSP resolution of documentation for completions. It now
queries documentation for visible completions and avoids doing too many
redundant queries.

---

In #21286, documentation resolution was made more efficient by only
resolving the current completion. However, this meant that single line
documentation shown inline in the menu was missing until scrolled
to. This also meant that it would wait for navigation to resolve
completion docs, leading to lag for displaying documentation.

This change resolves this by attempting to fetch all the completions
that will be shown. It also mostly avoids re-resolving completions. It
intentionally re-resolves the current selection on navigation, as some
language servers will respond with more information later on.

Michael Sloan created

ab1e9bf On windows, recreate renderer swap chain on restore from minimized (#21756)

Click to expand commit body
Closes #21688

Release Notes:

- Windows: Fix freeze after window minimize and maximize

Michael Sloan created

adc6647 gpui: Add cursor style methods of nesw nwse resize (#21801)

Click to expand commit body
Release Notes:

- N/A

---

This change adds two new methods to the cursor_style_methods function in
the gpui_macros crate (according to the Tailwind CSS documentation
https://tailwindcss.com/docs/cursor):
1. `cursor_nesw_resize`: Sets the cursor style to nesw-resize when
hovering over an element. This is useful for indicating resizing
diagonally from top-right to bottom-left.
2. `cursor_nwse_resize`: Sets the cursor style to nwse-resize when
hovering over an element. This is used for resizing diagonally from
top-left to bottom-right.

Minqi Pan created

119b5de assistant2: Change chat keybinding to just `Enter` (#21819)

Click to expand commit body
This PR changes the Assistant2 chat keybinding from `Cmd-Enter` to just
`Enter`.

Release Notes:

- N/A

Marshall Bowers created

c80ea60 assistant2: Update to match latest designs (#21818)

Click to expand commit body
This PR updates the Assistant2 panel to match the latest designs.

<img width="1159" alt="Screenshot 2024-12-10 at 11 49 14 AM"
src="https://github.com/user-attachments/assets/53739709-e7b9-4e35-8a5d-97b6560623ed">

Release Notes:

- N/A

Marshall Bowers created

bac6896 Add Dart docs for line length (#21815)

Peter Tripp created

c6932d1 zeta: Add action to clear edit history (#21813)

Click to expand commit body
Co-Authored-by: Antonio <antonio@zed.dev>

Release Notes:

- N/A

---------

Co-authored-by: Antonio <antonio@zed.dev>

Bennet Bo Fenner and Antonio created

03efd0d Stop sending data to Clickhouse (#21763)

Click to expand commit body
Release Notes:

- N/A

Conrad Irwin created

43ba0c9 zeta: Extend text in popover until EOL (#21811)

Click to expand commit body
Release Notes:

- N/A

Co-authored-by: Antonio <antonio@zed.dev>
Co-authored-by: Bennet <bennet@zed.dev>

Thorsten Ball , Antonio , and Bennet created

4300ef8 zeta: Use word-wise diff when computing edits (#21810)

Click to expand commit body
Release Notes:

- N/A

Co-authored-by: Antonio <antonio@zed.dev>
Co-authored-by: Bennet <bennet@zed.dev>

Thorsten Ball , Antonio , and Bennet created

e0f4c01 Revert "Improve project_panel diagnostic icon knockout colors (#20760)" (#21807)

Click to expand commit body
This reverts commit 571c7d4f6645528c0bf1d2bcacfd623676c69ee7.

Manually tracking the hovered entities causes issues with hightlighting:


https://github.com/user-attachments/assets/932dc022-a0ad-485c-a9db-ef03d7b86032

cc @danilo-leal @nilskch 

Release Notes:

- Fixed an issue where hovering over project panel would not update the
background correctly

Bennet Bo Fenner created

58f9301 image viewer: Allow dropping images on pane (#21803)

Click to expand commit body
Partially addresses #21484


https://github.com/user-attachments/assets/777da5de-15c3-4af3-a597-1835c0155326

Release Notes:

- Support opening images by dropping them onto a pane

Bennet Bo Fenner created

96499b7 zeta: Refresh LLM token in case it expired (#21796)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Antonio <antonio@zed.dev>
Co-authored-by: Bennet <bennet@zed.dev>

Thorsten Ball , Antonio , and Bennet created

09006aa Add option to activate left neighbour tab on tab close (#21800)

Click to expand commit body
Closes #21738

Release Notes:

- Added `left_neighbour` option to the `tabs.activate_on_close` setting
to activate the left adjacent tab on tab close.

Finn Evers created

2ca3b44 Fix a panic when drop-splitting the terminal panel (#21795)

Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/21792

Release Notes:

- (Preview only) Fixed a panic when drop-splitting the terminal panel

Kirill Bulatov created

9219b05 chore: Move more local code into LocalLspStore (#21794)

Click to expand commit body
Closes #ISSUE

Release Notes:

- N/A

Piotr Osiewicz created

bd20876 Fix git colors in image tabs (#21773)

Click to expand commit body
Note that the git coloring of the icons got removed in
https://github.com/zed-industries/zed/pull/21383

Closes #21772

Release Notes:

- N/A

Nils Koch created

44164db gpui: Update `Bounds`, `Point`, and `Axis` to be serializable (#21783)

Click to expand commit body
Makes `Bounds`, `Point`, and `Axis` be serializable, for dumping to JSON without conversion.

Release Notes:

- N/A

Jason Lee created

3c053c7 LspStore: move language_server_ids to local state too (#21786)

Click to expand commit body
Attempt to further clarify what state is present in which mode

Release Notes:

- N/A

Conrad Irwin created

48eed74 Move diagnostics to the LocalLspStore (#21782)

Click to expand commit body
This should be a no-op, but clarifies that some fields of the LspStore
were never actually used in the remote case.

Release Notes:

- N/A

Conrad Irwin created

a35ef5b Fix diagnostics randomized tests (#21775)

Click to expand commit body
These were silently passing after the delay in updating diagnostics was
added.

Co-Authored-By: Max <max@zed.dev>

cc @someonetoignore

Release Notes:

- N/A

---------

Co-authored-by: Max <max@zed.dev>

Conrad Irwin and Max created

8a85d6e collab: Make `metrics_id` required in `LlmTokenClaims` (#21771)

Click to expand commit body
This PR makes the `metrics_id` field on the `LlmTokenClaims` required,
as we always have one in practice.

Release Notes:

- N/A

Marshall Bowers created

158cdc3 collab: Attach additional properties to `Language Model Used` event (#21770)

Click to expand commit body
This PR attaches two new properties to the `Language Model Used` event:

- `has_llm_subscription` - This will tell us if a user is a paid
subscriber.
- `max_monthly_spend_in_cents` - This will indicate what their maximum
monthly spend is set to.

Release Notes:

- N/A

Marshall Bowers created

bdeac79 collab: Prevent `max_monthly_llm_usage_spending_in_cents` from being negative (#21768)

Click to expand commit body
This PR fixes an issue where the
`max_monthly_llm_usage_spending_in_cents` preference could be set to a
negative value.

Release Notes:

- N/A

Marshall Bowers created

73e0d81 Move `ContextMenu` out of editor.rs and rename `ContextMenu` to `CodeContextMenu` (#21766)

Click to expand commit body
This is a no-functionality refactor of where the `ContextMenu` type is
defined. Just the type definition and implementation is up to almost
1,000 lines; so I've moved it to it's own file and renamed the type to
`CodeContextMenu`

Release Notes:

- N/A

Mikayla Maki created

6538227 Revert "Avoid endless loop of the diagnostic updates (#21209)" (#21764)

Click to expand commit body
This reverts commit 9999c31859210654dd572d54dfa42b67c00b33b0.

Release Notes:

- Fixes diagnostics not updating in some circumstances

Conrad Irwin created

ef45eca extension_host: Fix uploading dev extensions to the remote server (#21761)

Click to expand commit body
This PR fixes an issue where dev extensions were not working when
uploaded to the remote server.

The `extension.toml` for dev extensions may not contain all of the
information (such as the list of languages), as this is something that
we derive from the filesystem at packaging time. This meant that
uploading a dev extension that contained languages could have them
absent from the uploaded `extension.toml`.

For dev extensions we now upload a serialized version of the in-memory
extension manifest, which should have all of the information present.

Release Notes:

- SSH Remoting: Fixed an issue where some dev extensions would not work
after being uploaded to the remote server.

---------

Co-authored-by: Conrad <conrad@zed.dev>

Marshall Bowers and Conrad created

803855e Add `async_task::spawn_local` variant that includes caller in panics (#21758)

Click to expand commit body
For debugging #21020. Copy-modified [from async_task
here](https://github.com/smol-rs/async-task/blob/ca9dbe1db9c422fd765847fa91306e30a6bb58a9/src/runnable.rs#L432)

Release Notes:

- N/A

Michael Sloan created

25a5ad5 Sync newly added diff hunks (#21759)

Click to expand commit body
Fixed project diff multi buffer not expanding its diff until edited

Release Notes:

- N/A

Kirill Bulatov created