Commit log

a8776f8 v0.167.x preview

Peter Tripp created

433cb99 Remove main push from `bump-zed-minor-versions` script (#22170)

Click to expand commit body
Motivation for this is to allow the `main` branch to be protected. This will enable use of auto-merge and merge queue.

Co-authored-by: Peter Tripp <peter@zed.dev>

Michael Sloan and Peter Tripp created

670ade9 extensions_ui: Don't block scrolling on disabled extension cards (#22189)

Click to expand commit body
This PR fixes an issue where disabled extension cards would block scroll
events when the mouse was over them.

Instead of using `.occlude`—which captures _all_ mouse events—we use
`.block_mouse_down` to just block mouse down events (to prevent clicking
the buttons on the disabled card). We also set the cursor style to the
default, as it was still switching to the pointer when hovered over top
of one of the buttons.

Release Notes:

- Fixed disabled extensions blocking scroll events in the extensions
list.

Marshall Bowers created

4a6f071 vim: Add support for :g/ and :v/ (#22177)

Click to expand commit body
Closes #ISSUE

Still TODO to make this feature good is better command history

Release Notes:

- vim: Add support for `:g/<pattern>/<cmd>` and `:v/<pattern>/<cmd>`

Conrad Irwin created

2ecbd97 vim: Support count with [x and ]x (#22176)

Click to expand commit body
Fixes: #21577
Fixes: #17245

Release Notes:

- vim: Add <count> support for [x/]x

Conrad Irwin created

a0a095c zeta: Show deletions when inline completion is shown in menu (#22186)

Click to expand commit body
If an inline completion isn't shown in a menu, we highlight text in the
editor as deleted.

But if it's shown in the menu, we didn't even show deleted text, which
makes it hard to understand what's going on.

This fixes it.
![screenshot-2024-12-18-14 34
55@2x](https://github.com/user-attachments/assets/579639e4-5ed9-4fe6-8e21-65166d192432)


Release Notes:

- N/A

Thorsten Ball created

4bfc107 Fix inconsistencies in "Transform" vs "Generate" tooltips for assistant v2 (#22160)

Click to expand commit body
Also makes the inline assistant and inline terminal assistant share a
bunch more code.

Release Notes:

- N/A

---------

Co-authored-by: Agus <agus@zed.dev>
Co-authored-by: Agus Zubiaga <hi@aguz.me>

Richard Feldman , Agus , and Agus Zubiaga created

6192c83 Show inline completions in menu only for supported providers (#22181)

Click to expand commit body
This changes #22093 by making the change only have an effect for the
supported provider: Zeta.

Made the change because the UX is still experimental and I don't want to
break existing workflows for Copilot/Supermaven users.

Even Zeta users can opt-out of it by setting
`"show_inline_completions_in_menu": false` in their settings, in case
they want the old show-inline-completion-or-show-lsp-completion behavior
back.

Release Notes:

- N/A

Thorsten Ball created

e8c9283 Fix the illegal JSON in the documentation (#22175)

Click to expand commit body
Release Notes:

- N/A

Hai Zhu created

2469122 Fix panic when calculating inline completion (#22180)

Click to expand commit body
Possible panic here in case we can't find the excerpt in the
multibuffer.

I thought this could happen when the inline completion references an
excerpt that disappeared from the multibuffer, but looking at the code
I'm not sure anymore - we use the same multibuffer snapshot in this
whole function and the `anchor_in_excerpt` method clips the anchors.

Still, let's be safe here.

Release Notes:

- N/A

Thorsten Ball created

6898a31 Fix panic in linked editing ranges (#21905)

Click to expand commit body
We were committing the cardinal sin of subtracting one from a column
without clipping

Closes #ISSUE

Release Notes:

- Fixed a panic in linked editing ranges

Conrad Irwin created

94bfb93 More telemetry events (#22171)

Click to expand commit body
- **Convert more events to telemetry::event**
- **And call events**

Closes #ISSUE

Release Notes:

- N/A

Conrad Irwin created

1b83020 Update collab local development instructions (#22018)

Click to expand commit body
When running the collab server locally on a new machine, I found there
were some instructions missing for setting up the Postgres database.
Namely, the user mentioned on the `.env.toml` is not created by default.

Ref: https://github.com/zed-industries/zed/issues/8260

Release Notes:

- N/A

Enrique Kessler Martínez created

613deb6 Remove panics from X11Window::set_title (#22173)

Click to expand commit body
Release Notes:

- N/A

Cole Miller created

672fc76 Fix panic in activate_pane_in_direction (#21948)

Click to expand commit body
Ah, invalid SecondaryMap key, we meet again...

Release Notes:

- Fixed panic when jumping between panes

Cole Miller created

5d7b614 Improve context menu aside layout via custom logic (#22154)

Click to expand commit body
* Presence of the aside no longer affects position or size of the
context menu.

* Prefers to fit to the right, then on same side of line, then other
side of line, within the following preference order:
  - Max possible size within text area.
  - Max possible size within window.
- Actual size within window. This is the only case that could cause it
to jump around with less stability.

A further enhancement atop this might be to dynamically resize aside
height to fit.

Release notes are N/A as they are covered by the notes for #22102.

Closes #8523

Release Notes:

* N/A

Michael Sloan created

6aad616 assistant2: Fix focus issues with opening history (#22169)

Click to expand commit body
This PR fixes some focus issues with opening the thread history, which
required that the Assistant2 panel be focused in order for the history
to open.

Release Notes:

- N/A

Marshall Bowers created

918866b assistant2: Allow creating a new thread via the command palette (#22168)

Click to expand commit body
This PR allows a new thread to be created via the command palette when
the Assistant2 panel is not focused.

Release Notes:

- N/A

Marshall Bowers created

5b2653a Improve GitHub Issue template for Environment (#22147)

Click to expand commit body
Add support for pre-filling feature request template from zed::RequestFeature action.

Co-authored-by: Agus <agus@zed.dev>

Peter Tripp and Agus created

ba44db7 gpui: Rename `GPUSpecs` to `GpuSpecs` (#22166)

Click to expand commit body
This PR renames the `GPUSpecs` type to `GpuSpecs` to match Rust naming
conventions.

Release Notes:

- N/A

Marshall Bowers created

ce97e4d assistant2: Add temporary icon for the status bar item (#22156)

Click to expand commit body
This is temporary and should be removed whenever we fully transition to
Assistant 2.

<img width="800" alt="Screenshot 2024-12-17 at 16 50 48"
src="https://github.com/user-attachments/assets/61137993-ec2c-4754-9f9a-7559d1b21d89"
/>

Release Notes:

- N/A

Danilo Leal created

63d8a43 assistant2: Fix file context picker (#22163)

Click to expand commit body
This PR fixes an issue with the Assistant2 file context picker where
files weren't being attached properly.

We needed to retrieve the files from the worktree without the worktree
root name in the file path.

Release Notes:

- N/A

---------

Co-authored-by: Max <max@zed.dev>

Marshall Bowers and Max created

81c118d Store focus handles in AppContext instead of Window (#22158)

Click to expand commit body
Previously, each window stored its own collection of focus handles. This
meant that to create a focus handle, you needed to have access to a
Window. I'm working on a simplification to gpui's context types that
removes `WindowContext` and `ViewContext` in favor of passing a window
reference explicitly when rendering or handling events. You'll still
need a window to manipulate focus, but it will be helpful to be able to
create focus handles without a window.

cc @mgsloan 

Release Notes:

- N/A

Nathan Sobo created

e1ca5ed zed: Fix formatting in workspace initialization (#22152)

Click to expand commit body
This PR fixes some formatting issues in the workspace initialization
code that stemmed from certain constructs causing `rustfmt` to bail out
of the formatting.

The bulk of the content of `initialize_workspace` has been factored out
into functions, as having nested closures within closures seems to be
the primary cause of `rustfmt` being unhappy.

Release Notes:

- N/A

Marshall Bowers created

fa1b1c6 docs: Fix indentation of JSON example lsp settings (#22162)

Peter Tripp created

0511f92 Add tooltip for Markdown Preview copy code button (#22057)

Peter Tripp created

70f82f8 telemetry: Fix license symlink (#22153)

Click to expand commit body
This PR fixes the `LICENSE-GPL` symlink in the `telemetry` crate.

Release Notes:

- N/A

Marshall Bowers created

1c48689 Allow the use of both Assistants when in the `assistant2` feature flag (#22150)

Click to expand commit body
This PR makes it so both Assistant panels are visible when in the
`assistant2` feature flag.

This way folks can continue using Assistant1 if Assistant2 isn't meeting
their needs.

Right now they are shown as two different panels shown in the status bar
(although using the same icon), but this is just a temporary state until
we can surface the Assistant1 functionality in Assistant2 somehow.

Note that the inline assist will always use the Assistant2 panel.

Release Notes:

- N/A

Marshall Bowers created

c86cf2c zeta: Refine visuals for the completion popover (#22142)

Click to expand commit body
Most notably, trying out a different icon and adding the "Completion"
word to the side of the provider name.

<img width="800" alt="Screenshot 2024-12-17 at 13 04 55"
src="https://github.com/user-attachments/assets/6dcaa699-f358-4242-9812-e1668f426207"
/>

Release Notes:

- N/A

Danilo Leal created

7425d24 Add telemetry::event! (#22146)

Click to expand commit body
CC @JosephTLyons

Release Notes:

- N/A

Conrad Irwin created

b17f208 assistant2: Sketch in directory context picker (#22148)

Click to expand commit body
This PR sketches in the structure for the directory context picker.

Waiting on implementing the actual behavior until we fix the issues with
the file context picker.

Release Notes:

- N/A

Marshall Bowers created

68e3d79 assistant2: Use `ContextKind` to match on `ContextPicker` entries (#22143)

Click to expand commit body
This PR updates the `ContextPicker` entries to match on the
`ContextKind` instead of using strings.

Release Notes:

- N/A

Marshall Bowers created

ed3e647 editor: Add horizontal scrollbar (#19495)

Click to expand commit body
![editor_scrollbars](https://github.com/user-attachments/assets/76c26776-8fe4-47f8-9c79-9add7d7d2151)

Closes #4427 

Release Notes:

- Added a horizontal scrollbar to the editor panel
- Added `axis` option to `scrollbar` in the Zed configuration, which can
forcefully disable either the horizontal or vertical scrollbar
- Added `horizontal_scroll_margin` equivalent to
`vertical_scroll_margin` in the Zed configuration

Rough Edges:

This feature seems mostly stable from my testing. I've been using a
development build for about a week with no issues. Any feedback would be
appreciated. There are a few things to note as well:

1. Scrolling to the lower right occasionally causes scrollbar clipping
on my end, but it isn't consistent and it isn't major. Some more testing
would definitely be a good idea. [FIXED]
2. Documentation may need to be modified
3. I added an `AxisPair` type to the `editor` crate to manage values
that have a horizontal and vertical variant. I'm not sure if that's the
optimal way to do it, but I didn't see a good alternative. The `Point`
type would technically work, but it may cause confusion.

---------

Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>

Carlos Kieliszewski and Piotr Osiewicz created

6fa5a17 assistant2: Only add context if it is non-empty (#22141)

Click to expand commit body
This PR fixes an issue where we were attaching empty message content
even if there was no context.

Release Notes:

- N/A

Marshall Bowers created

a6b717b assistant2: Add spacing between historical thread entries (#22140)

Click to expand commit body
This PR adds spacing between entries in the historical threads view:

<img width="1371" alt="Screenshot 2024-12-17 at 10 51 26 AM"
src="https://github.com/user-attachments/assets/f66d69e9-eb59-4c76-b3b5-c4d60190c3cc"
/>

Release Notes:

- N/A

Marshall Bowers created

228c89a Show inline documentation in menu even if documentation is disabled (#22137)

Click to expand commit body
This makes inline completions show up in the completion menu even if the
user has set `"show_completion_documentation": false` in their settings,
because there is no other way to show the Zeta completion.

Follow-up to #22093

Release Notes:

- N/A

Co-authored-by: Danilo <danilo@zed.dev>

Thorsten Ball and Danilo created

3978937 Add stray visual refinements (#22125)

Click to expand commit body
In different parts of the app, but all of them can be seen in the
screenshot below:

<img width="800" alt="Screenshot 2024-12-16 at 21 31 51"
src="https://github.com/user-attachments/assets/79c0ad5e-4e4c-469d-93a1-fd4e707d4aaa"
/>

Release Notes:

- N/A *or* Added/Fixed/Improved ...

Danilo Leal created

95334cb Show inline completions inside the completion menu if both are available (#22093)

Click to expand commit body
Screenshot:

![screenshot-2024-12-17-11 53
41@2x](https://github.com/user-attachments/assets/bace3d20-7175-4833-9326-7b859166c0e8)

Demo:


https://github.com/user-attachments/assets/70197042-4785-4e45-80fd-29d12e68333f



(Note for Joseph/Peter: this supersedes
https://github.com/zed-industries/zed/pull/22069)

Release Notes:
- Changed inline completions to show up inside the normal completions in
case LSP and inline-completions are available. In that case, the inline
completion will be the first entry in the menu and can be selected with
`<tab>`.

---------

Co-authored-by: Bennet <bennet@zed.dev>
Co-authored-by: Danilo <danilo@zed.dev>

Thorsten Ball , Bennet , and Danilo created

cc56ed7 Focus terminal when creating one after activating the terminal panel (#22133)

Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/22082

Release Notes:

- N/A

Kirill Bulatov created

4878b9b docs: Fix shortcut for select a smaller syntax node (#22135)

Click to expand commit body
Release Notes:

- N/A

lihsai0 created

e1bc48c Workspace move editor actions (#21760)

Click to expand commit body
Closes #20205

Release Notes:

- Added `MoveItemToPane` and `MoveItemToPaneInDirection` actions

---------

Co-authored-by: Kirill Bulatov <kirill@zed.dev>

Ignat S. and Kirill Bulatov created

9082a00 Revert "vim: Don't dismiss inline completion when switching to normal mode (#22075)" (#22131)

Click to expand commit body
This reverts commit 38c0aa303e8c58238bceea9ee719ef2716158e81 from
#22075.

Release Notes:

- N/A

Thorsten Ball created

ebf6804 Misc improvements to `Bounds` in gpui geometry

Click to expand commit body
* Makes `dilate` and `inset` return.

* Implements `Add<Point<T>>` and `Sub<Point<T>>`.

* Makes some trait constraints more precise.

mgsloan@gmail.com created

a062c0f Improve code context menu layout position esp visual stability (#22102)

Click to expand commit body
* Now decides whether the menu is above or below the target position
before rendering it. This causes its position to no longer vary
depending on the length of completions

* When the text area is height constrained (< 12) lines, now chooses the
side which has the most space. Before it would always display above if
height constrained below.

* Misc code cleanups

Release Notes:

- Improved completions menu layout to be more stable and use available
space better.

Michael Sloan created

fc5a810 Add Corner to geometry and make names of corner methods consistent (#22119)

Click to expand commit body
Release Notes:

- N/A

Michael Sloan created

3052fc2 Use the same `InlineAssist` action between both `assistant` and `assistant2` (#22126)

Click to expand commit body
This PR makes it so `assistant` and `assistant2` both use the same
action for inline assist (`zed_actions::InlineAssist`).

This makes it so the keybindings to deploy the inline assist seamlessly
swap based on the feature flag without needing to rebind them.

One minor caveat: if you're using `assistant2` the action name in the
command palette will be `assistant: inline assist`.

Release Notes:

- N/A

Marshall Bowers created

80431e5 assistant2: Add keybinding to toggle `ContextPicker` (#22124)

Click to expand commit body
This PR adds an action and associated keybinding
(<kbd>Cmd+Shift+A</kbd>) to toggle the context picker.

This allows for adding context via the keyboard.

Release Notes:

- N/A

Marshall Bowers created

2808793 assistant2: Add text_ellipsis to the `PastThread` label (#22117)

Click to expand commit body
To treat the case for whenever the assistant panel gets small.

<img width="360" alt="Screenshot 2024-12-16 at 20 12 34"
src="https://github.com/user-attachments/assets/5426a5b9-9baf-41e3-a2c6-2f997378c994"
/>

Release Notes:

- N/A

Danilo Leal created

5558b04 Misc geometry cleanup (#22123)

Click to expand commit body
Release Notes:

- N/A

Michael Sloan created

0ca0433 assistant2: Add keybinding to toggle `LanguageModelSelector` (#22122)

Click to expand commit body
This PR adds a keybinding to toggle the `LanguageModelSelector` in
Assistant2.

Release Notes:

- N/A

Marshall Bowers created