3179617
assistant2: Sketch in context picker (#21560)
Click to expand commit body
This PR sketches in a context picker into the message editor in
Assistant 2. Not functional yet.
<img width="1138" alt="Screenshot 2024-12-04 at 5 45 19 PM"
src="https://github.com/user-attachments/assets/053d6224-de76-4fde-914b-41fe835761eb">
Release Notes:
- N/A
Marshall Bowers
created
a30ea2f
assistant2: Factor out `ActiveThread` view (#21555)
Click to expand commit body
This PR factors a new `ActiveThread` view out of the `AssistantPanel` to
group together the state that pertains solely to the active view.
There was a bunch of related state on the `AssistantPanel` pertaining to
the active thread that needed to be initialized/reset together and it
makes for a clearer narrative is this state is encapsulated in its own
view.
Release Notes:
- N/A
Marshall Bowers
created
55ecb3c
Regenerate completion labels on resolve (#21521)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/21516
Technically, this is an LSP violation from `vtsls`, but seems that it's
not going to be fixed adequately on that side, see
https://github.com/yioneko/vtsls/issues/213 for more context.
So, we have to accommodate at least for now.
Release Notes:
- Fixed completion item labels not being updated after the resolve for
non-LSP compliant servers
Kirill Bulatov
created
8d18dfa
Add a prototype with a multi buffer having all project git changes (#21543)
Click to expand commit body
Part of https://github.com/zed-industries/zed/issues/20925
This prototype is behind a feature flag and being merged to avoid
conflicts with further git-related resturctures.
To be a proper, public feature, this needs at least:
* showing deleted files
* better performance
* randomized tests
* `TODO`s in the `project_diff.rs` file fixed
The good thing is, >90% of the changes are in the `project_diff.rs` file
only, have a basic test and already work on simple cases.
Release Notes:
- N/A
---------
Co-authored-by: Thorsten Ball <thorsten@zed.dev>
Co-authored-by: Cole Miller <cole@zed.dev>
Kirill Bulatov
,
Thorsten Ball
, and
Cole Miller
created
This addresses the editor context menu portion of #17819.
Release Notes:
- Added `editor::OpenContextMenu` action to open context menu at current
cursor position.
Michael Sloan
created
0bde0f8
assistant2: Add ability to open past threads (#21548)
Click to expand commit body
This PR adds the ability to open past threads in Assistant 2.
There are also some mocked threads in the history for testing purposes.
Release Notes:
- N/A
Marshall Bowers
created
44264ff
Revert accidental change to Rust outline files (#21545)
Click to expand commit body
Release Notes:
- Preview only: Fixed impl blocks in the rust outline view
Conrad Irwin
created
7cfc972
assistant2: Add empty state for new threads (#21542)
Click to expand commit body
This PR adds an empty state for new threads in Assistant2:
<img width="1138" alt="Screenshot 2024-12-04 at 12 17 46 PM"
src="https://github.com/user-attachments/assets/ff7b4533-d3b8-4722-bd4b-43fac6d35a77">
This is mostly just a sketch in its current state.
Release Notes:
- N/A
Marshall Bowers
created
fee0624
Force code actions to be single line (#21409)
Click to expand commit body
Addresses #21403 partially. Is consistent with the behaviour in VSCode
Before:
<img width="332" alt="391571084-1bef4ef9-b8f5-4c8f-9a32-9c0ab6c91af1"
src="https://github.com/user-attachments/assets/d4d83826-23a1-43a1-94f9-feb0b0ddd5ce">
After:
<img width="330" alt="Screenshot 2024-12-02 at 18 35 11"
src="https://github.com/user-attachments/assets/c04f0494-4f34-476a-a090-1443d61851e5">
Release Notes:
- Fixed an issue with multiline code actions' rendering by forcing them
to be single line
706372f
title_bar: Add show_user_picture setting to let users hide their profile picture (#21526)
Click to expand commit body
Fixes #21464
Closes #21464
Release Notes:
- Added `show_user_picture` setting (default: true) to allow users to
hide their profile picture in titlebar.
Piotr Osiewicz
created
5948ea2
Configure Highlight settings on yank vim (#21479)
Click to expand commit body
Release Notes:
- Add settings / config variables to control `highlight_on_yank` or
`highlight_on_copy`
---------
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Vedant Matanhelia
and
Conrad Irwin
created
207eb51
assistant2: Style inline code in Markdown (#21536)
Click to expand commit body
This PR adds some styling for inline code within the messages to
differentiate them from the surrounding text:
<img width="1138" alt="Screenshot 2024-12-04 at 10 58 14 AM"
src="https://github.com/user-attachments/assets/3bb92711-e2f7-454a-b4be-449c6a9bf591">
Release Notes:
- N/A
Marshall Bowers
created
0ee99c6
context_server: Add missing types for MCP spec to protocol 2024-11-05 (#21498)
Click to expand commit body
This commit syncs missing types for the mcp spec 2024-11-05.
Release Notes:
- N/A
David Soria Parra
created
d8732ad
Add fuzzy matching for snippets completions (#21524)
Click to expand commit body
Closes #21439
This PR uses fuzzy matching for snippet completions instead of
fixed-prefix matching. This mimics the behavior of VSCode.
<img
src="https://github.com/user-attachments/assets/68537114-c5cf-4e4d-bc5c-4bb69ce947e5"
alt="fuzzy" width="450px" />
Release Notes:
- Improved suggestions for snippets.
tims
created
196fd65
Fix panic folding in multi-buffers (#21511)
Click to expand commit body
Closes #19054
Rename `max_buffer_row()` to `widest_line_number()` to (hopefully)
prevent
people assuming it means the same as `max_point().row`.
Release Notes:
- Fixed a panic when folding in a multibuffer
Closes #4642
- Added the ability to switch to helix normal mode, with an additional
helix visual mode.
- <kbd>ctrl</kbd><kbd>h</kbd> from Insert mode goes to Helix Normal
mode. <kbd> i </kbd> and <kbd> a </kbd> to go back.
- Need to find a way to perform the helix normal mode selection with
<kbd> w </kbd>, <kbd>e </kbd>, <kbd> b </kbd> as a first step. Need to
figure out how the mode will interoperate with the VIM mode as the new
additions are in the same crate.
Related to #19424
This uses the new text object support, so will only work for languages
that have `textobjects.scm`. It does not integrate with
indentation-based folding for now, and the syntax-based folds don't have
matching fold markers in the gutter (unless they are folded).
Release Notes:
- Add an editor action to fold all function bodies
Co-authored-by: Conrad <conrad@zed.dev>
3019960
markdown: Make `cx` the last parameter to `Markdown::new_text` (#21497)
Click to expand commit body
This PR is a follow-up to
https://github.com/zed-industries/zed/pull/21487 to make sure that the
`cx` is the last parameter to `Markdown::new_text` as well.
Release Notes:
- N/A
Marshall Bowers
created
9f459ba
assistant2: Render messages as Markdown (#21496)
Click to expand commit body
This PR updates Assistant 2 to render the messages in the thread as
Markdown:
<img width="1138" alt="Screenshot 2024-12-03 at 6 09 27 PM"
src="https://github.com/user-attachments/assets/c1c44fde-1efb-43cf-b9c9-768e6974c753">
Release Notes:
- N/A
dc32ab2
Open folds containing selections when jumping from multibuffer (#21433)
Click to expand commit body
When searching within a single buffer, activating a search result causes
any fold containing the result to be unfolded. However, this didn't
happen when jumping to a search result from a project-wide search
multibuffer. This PR fixes that.
Release Notes:
- Fixed folds not opening when jumping from search results multibuffer
Cole Miller
created
aca23da
assistant2: Render messages in the thread using a `list` (#21491)
Click to expand commit body
This PR updates the rendering of the messages in the current thread to
use a `gpui::list`.
Release Notes:
- N/A
Marshall Bowers
created
db34f29
vim: Add == and fix = in the status bar (#21490)
This reverts commit 614b3b979b7373aaa6dee84dfbc824fce1a86ea8.
This conflicts with the macOS `ctrl-fn-left/right` bindings for moving
windows around (new in Sequoia).
If you want these use:
```
{
"context": "Editor",
"bindings": {
"ctrl-home": "editor::MoveToBeginning",
"ctrl-end": "editor::MoveToEnd"
}
},
```
Release Notes:
- N/A
In #20742 we added a call to remove_item that retain an item index over
an
await point. This led to a race condition that could panic if another
tab was
removed during that time. (cc @mgsloan)
This changes the API to make it harder to misuse.
Release Notes:
- Fixed a panic when closing tabs containing new unsaved files
Closes #14961
Release Notes:
- Fixed a panic when backspacing at the start of a buffer with
`always_treat_brackets_as_autoclosed` enabled.
Conrad Irwin
created
afb253b
ui: Ensure `Label` with `single_line` set does not wrap (#21444)
Click to expand commit body
Release Notes:
- N/A
---
Split from #21438, this change for make sure the `single_line` mode
Label will not be wrap.
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Fix theme json schema so `./script/import-themes print-schema` works again
Update schema to reflect current structs
([diff](https://gist.github.com/notpeter/26e6d0939985f542e8492458442ac62a/revisions?diff=unified&w=))
https://zed.dev/schema/themes/v0.2.0.json
Co-Authored-By: Max <max@zed.dev>
Release Notes:
- vim: Added motions `[[`, `[]`, `]]`, `][` for navigating by section,
`[m`, `]m`, `[M`, `]M` for navigating by method, and `[*`, `]*`, `[/`,
`]/` for comments. These currently only work for languages built in to
Zed, as they are powered by new tree-sitter queries.
- vim: Added new text objects: `ic`, `ac` for inside/around classes,
`if`,`af` for functions/methods, and `g c` for comments. These currently
only work for languages built in to Zed, as they are powered by new
tree-sitter queries.
---------
Co-authored-by: Max <max@zed.dev>
The macOS input handler assumes that you want to insert control
sequences when
you type ctrl-alt-X (you probably don't...).
Release Notes:
- (nightly only) fix ctrl-alt-X shortcuts
Conrad Irwin
created
2dd5138
docs: Add anchor links for language-specific settings (#21469)
Peter Tripp
created
a464474
Properly handle opening of file-less excerpts (#21465)
Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/20491 and
https://github.com/zed-industries/zed/pull/20469
Closes https://github.com/zed-industries/zed/issues/21369
Release Notes:
- Fixed file-less excerpts always opening instead of activating
Kirill Bulatov
created
a0f2c07
Debounce diagnostics status bar updates (#21463)
Click to expand commit body
Closes https://github.com/zed-industries/zed/pull/20797
Release Notes:
- Fixed diagnostics status bar flashing when typing
Kirill Bulatov
created
1270ef3
Enable toolchain venv in new terminals (#21388)
Click to expand commit body
Fixes part of issue #7808
> This venv should be the one we automatically activate when opening new
terminals, if the detect_venv setting is on.
Release Notes:
- Selected Python toolchains (virtual environments) are now automatically activated in new terminals.
---------
Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
Sebastian Nickels
and
Piotr Osiewicz
created
a76cd77
Disable hunk diff arrow buttons when there's only one hunk (#21437)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/20817
| One hunk | Multiple hunks |
|--------|--------|
| <img width="800" alt="Screenshot 2024-12-03 at 09 42 49"
src="https://github.com/user-attachments/assets/7c2ff80a-d4d9-4a74-84b8-891fadfd4e6c">
| <img width="800" alt="Screenshot 2024-12-02 at 23 36 38"
src="https://github.com/user-attachments/assets/60ea94b8-0b23-43a2-afad-b816b4645d1f">
|
Release Notes:
- Fixed showing prev/next hunk navigation buttons when there is only one
hunk
Danilo Leal
created
a8c7e61
Fix AI Context menu text wrapping causing overlap (#21438)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/20678
| Before | After |
| --- | --- |
| <img width="672" alt="SCR-20241203-jreb"
src="https://github.com/user-attachments/assets/411ba2a6-712f-4ab7-a320-12ac9a35c1e1">
| <img width="771" alt="SCR-20241203-jwhe"
src="https://github.com/user-attachments/assets/022c8ee9-4089-4c09-aa4b-12a0f5528822">
|
Release Notes:
- Fixed AI Context menu text wrapping causing overlap.
Also cc #21409 @WeetHet @osiewicz to use `Label`, this PR has been fixed
`Label` to ensure `whitespace_nowrap` when use `single_line`.
---------
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
It took me a couple of minutes of staring at this speaker icon to figure
out it was a speaker! I even researched whether the `.wav` file type had
a specific icon, given I thought it was a specific triangle of sorts 😅
I'm sensing audio waves, at this size, will be easier to parse.
Release Notes:
- N/A
Danilo Leal
created
b53b2c0
Run dependency review for pull requests only (#21432)
Click to expand commit body
This was an oversight in the original PR, dependency-review-action won't
work properly for `push` events
([example](https://github.com/zed-industries/zed/actions/runs/12130053580/job/33819624076)).
Release Notes:
- N/A
Cole Miller
created
e1c509e
Check for vulnerable dependencies in CI (#21424)
Click to expand commit body
This PR adds GitHub's dependency review action to CI, to flag PRs that
introduce new Cargo.lock entries for vulnerable crates according to the
GHSA database.
An alternative would be to run `cargo audit`, which checks against the
RustSec database. The state of synchronization between these two
databases seems a bit messy, but as far as I can tell GHSA has most
recent RustSec advisories on file, while RustSec is missing a larger
number of recent GHSA advisories.
The dependency review action should be smart enough not to flag PRs
because an untouched entry in Cargo.lock has a new advisory.
I've turned off the "license check" functionality since we have a
separate CI step for that.
Release Notes:
- N/A
Cole Miller
created
f4dbcb6
Use explicit sort order instead of comparison impls for gpui prims (#21430)
Click to expand commit body
Found this while looking into adding support for the Surface primitive
on Linux, for rendering video shares. In that case it would be
expensive to compare images for equality. `Eq` and `PartialEq` were
being required but not used here due to use of `Ord` and `PartialOrd`.
Release Notes:
- N/A
Bump dependencies for jupyter packages. cc @maxdeviant
Release Notes:
- N/A
Kyle Kelley
created
7c994cd
Add AutoIndent action and '=' vim operator (#21427)
Click to expand commit body
Release Notes:
- vim: Added the `=` operator, for auto-indent
Co-authored-by: Conrad <conrad@zed.dev>
Max Brunsfeld
and
Conrad
created
f3140f5
assistant2: Wire up error messages (#21426)
Click to expand commit body
This PR wires up the error messages for Assistant 2 so that they are
shown to the user:
<img width="1138" alt="Screenshot 2024-12-02 at 4 28 02 PM"
src="https://github.com/user-attachments/assets/d8a5b9bd-0cef-4304-b561-b2edadbc70ef">
<img width="1138" alt="Screenshot 2024-12-02 at 4 29 09 PM"
src="https://github.com/user-attachments/assets/0dd70841-0d5a-4de6-bebe-82c563246b65">
<img width="1138" alt="Screenshot 2024-12-02 at 4 32 49 PM"
src="https://github.com/user-attachments/assets/a8838866-fad1-43a9-8935-490dc1936016">
@danilo-leal I kept the existing UX from Assistant 1, as I didn't see
any errors in the design prototype, but we can revisit if another
approach would work better.
Release Notes:
- N/A