421974f
Use consistent casing for provider name in telemetry (#21991)
Click to expand commit body
Release Notes: - N/A
Joseph T. Lyons created
421974f
Use consistent casing for provider name in telemetry (#21991)
Release Notes: - N/A
Joseph T. Lyons created
c57cc35
assistant2: Add ability to fetch URLs as context (#21988)
This PR adds the ability to fetch URLs as context in Assistant2. In the picker we use the search area as an input for the user to enter the URL they wish to fetch: <img width="1159" alt="Screenshot 2024-12-13 at 2 45 41 PM" src="https://github.com/user-attachments/assets/b3b20648-2c22-4509-b592-d0291d25b202" /> <img width="1159" alt="Screenshot 2024-12-13 at 2 45 47 PM" src="https://github.com/user-attachments/assets/7e6bab2d-2731-467f-9781-130c6e4ea5cf" /> Release Notes: - N/A
Marshall Bowers created
19d6e06
Toggle & Switch (#21979)
 - Adds the Switch component - Updates `Selected`, `Selectable` -> `ToggleState`, `Toggleable` - Adds `checkbox` and `switch` functions to align better with other elements in our layout system. We decided not to merge Switch and Checkbox. However, in a followup I'll introduce a Toggle or AnyToggle enum so we can update `CheckboxWithLabel` -> `ToggleWithLabel` as this component will work exactly the same with either a Checkbox or a Switch. Release Notes: - N/A
Nate Butler created
2f2e7f0
Revert "Resolve documentation for visible completions (#21705)" (#21985)
This reverts commit ab595b0d5575285f2351ff085c4a8862f2ddc1f2. Release Notes: - (preview only) Fixed a panic in completions
Conrad Irwin created
2b69905
Log invariant violations in fuzzy string match iterator (#21983)
Seeing frequent inscrutable panics here Release Notes: - N/A
Michael Sloan created
01e5ac0
Maintain inline completion order, simplifying how we track pending completions (#21977)
Release Notes: - N/A
Antonio Scandurra created
306f1c6
zeta: Increase context lines to 32 (#21968)
Release Notes: - N/A Co-authored-by: Antonio <antonio@zed.dev>
Thorsten Ball and Antonio created
2f722e6
Highlight whitespace-only inline completions with background (#21954)
Noticed that whitespace-only insertions are really hard to make out, so this changes it to make them visible by giving them a green background.  Release Notes: - N/A --------- Co-authored-by: Antonio <antonio@zed.dev>
Thorsten Ball and Antonio created
6838b62
python: Refine highlighting (#21389)
Fixes: * Types in binary unions as per [PEP 604](https://peps.python.org/pep-0604/) not highlighted; * `except*` keyword not highlighted; * Classes beginning with `_` not recognized as such, however `_` is a valid first character for private classes; additionally the regex for parsing constant/class names appeared inconsistent and incomplete so was adjusted; * Builtin types such as `float`, `dict`, etc not recognized as types; * **Update:** decorators with arguments not recognized as decorators; * **Update:** docstrings after type alias assignments not recognized as docstrings; * **Update:** `and/in/is/not/or/is not/not in` not capturable as keywords; * **Update:** decorators with "nesting" (@x.y.z) not recognized as decorators; Before:  After:  Release Notes: - N/A --------- Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
Jaagup Averin and Piotr Osiewicz created
5318f52
Improve editor open URL command to open the selected portion of URL (#21825)
Closes #21718 Just like in Vim, if a URL is selected, it opens exactly that portion of the URL. Otherwise, if only the cursor is on a URL, it opens the entire URL. Zed currently does the latter. This PR also adds support for the former. https://github.com/user-attachments/assets/8bdd2952-ceec-487c-b27a-5cea4258eb03 Release Notes: - Updated the `editor: open url` to also handle the selected portion of a URL.
tims created
096bbfe
zeta: Adjust reviewing UI (#21932)
Most notably, adding a title bar-ish in the left column as so to add the "from most recent to oldest" info, which is supposed to make scanning the list of completions easier to do (at least it would've helped me figure out that was sorted that way when I was wondering about it!). <img width="800" alt="Screenshot 2024-12-12 at 16 24 36" src="https://github.com/user-attachments/assets/1acc9951-3df0-4cd2-96ff-94ed555ecae5" /> Release Notes: - N/A
Danilo Leal created
0b4495a
zeta: Adjust the "Jump To Edit" button visuals (#21933)
| One Dark | One Light | |--------|--------| | <img width="1495" alt="Screenshot 2024-12-12 at 16 27 12" src="https://github.com/user-attachments/assets/897ee786-a6f7-4d4e-8722-301ac13e6d8c" /> | <img width="1495" alt="Screenshot 2024-12-12 at 16 27 18" src="https://github.com/user-attachments/assets/a78aa5e4-f327-41da-bc9c-6e102bc67fe2" /> | | One Dark | One Light | |--------|--------| | <img width="1495" alt="Screenshot 2024-12-12 at 16 26 54" src="https://github.com/user-attachments/assets/0357468e-7b5f-4f92-bcdb-5f94e353d8b2" /> | <img width="1495" alt="Screenshot 2024-12-12 at 16 26 59" src="https://github.com/user-attachments/assets/20e0f47e-e20f-46a7-b053-8e528b0975d7" /> | Release Notes: - N/A
Danilo Leal created
636c28b
project panel: Reintroduce project panel knockout color (#21926)
Reintroduces #20760 after it was reverted in #21807 Closes #20572 /cc @danilo-leal Release Notes: - N/A --------- Co-authored-by: Cole <cole@zed.dev> Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Bennet Bo Fenner , Cole , and Danilo Leal created
6ceec5d
Fix project and buffer search input width (#21949)
Closes https://github.com/zed-industries/zed/issues/21922 Now, both the project and buffer search inputs have a min-width set so that text inside it, as well as the additional controls, are always visible even at the window's smallest possible size, which looks like this: <img width="407" alt="Screenshot 2024-12-13 at 00 35 46" src="https://github.com/user-attachments/assets/e6e2c4c6-4f75-4663-8c65-590e02141a5d" /> Release Notes: - N/A
Danilo Leal created
9f0f63f
Git panel refinements 2 (#21947)
Add entry list, scrollbar Release Notes: - N/A
Nate Butler created
b38e9e4
Fix hover popover font fallbacks (#21945)
Closes #21848 Release Notes: - Fixed Hover Popover Font Callbacks
0x2CA created
e0cbbf8
Fix opening repos when `.git` is a soft link (#21153)
Closes #ISSUE ## background If a project is big, some times it will be splited into many small git repos. [google repo](https://gerrit.googlesource.com/git-repo/) is a tool to manage a group of git repos. But, any small git repo manged by this tool, have a difference with normal git repo. That is , the path `.git` in the root of the git repo, is not a normal directory, but a soft link to real git bare dir. ### zed can not recognize the `git-repo` managed git repos you can use the procedure to genreate this problem ```bash # tested on linux mkdir -p bad_git_repo_project cd bad_git_repo_project git init echo "hello" > hi.txt git add . git commit -m "init commit" echo "hello world" >> hi.txt # modify the repo mv .git ../.real_git_repo ln -sf ../.real_git_repo .git ``` with vscode, after opening this project, git works well. but for Zed, git not work(not git status, no git blame) ## how to fix libgit2 can recognize git repo from the root of the project(dir that have `.git`). so, we can recognize the git project by opening from the project root dir, but not the `.git` dir This fix also works with normal git project. ### before fix  ### after fix  Release Notes: - Fix opening repos when .git is a soft link
Wang Can created
4eaa1c2
Only debounce the cursor position in multibuffer excerpts (#21946)
Follow up to: https://github.com/zed-industries/zed/pull/20211 Release Notes: - Improved the performance of the cursor position indicator in single buffers
Mikayla Maki created
b3de19a
editor: Add duplicate selection command (#21154)
Closes #4890 Release Notes: - Add duplicate selection command for editor
CharlesChen0823 created
241b14e
project_panel: Create items when the editor is dismissed via the mouse (#21045)
Closes #5036 Release Notes: - Created project panel items when the editor is dismissed via the mouse
CharlesChen0823 created
72d8f2e
editor: Add "selection" key context (#21927)
This change allows defining keybindings that are active when there is a
text selection.
This is especially useful, as an example, for Emacs-like keybindings
where movement keybindings expand the selection.
Here is a snippet from my keymap.json that implements Emacs movements
when selection is active:
```json
{
"context": "Editor && selection",
"bindings": {
"ctrl-f": "editor::SelectRight",
"ctrl-b": "editor::SelectLeft",
"ctrl-n": "editor::SelectDown",
"ctrl-p": "editor::SelectUp",
"ctrl-a": "editor::SelectToBeginningOfLine",
"ctrl-e": "editor::SelectToEndOfLine",
"alt-f": "editor::SelectToNextWordEnd",
"alt-b": "editor::SelectToPreviousWordStart",
"alt-<": "editor::SelectToBeginning",
"alt->": "editor::SelectToEnd"
}
}
```
What do you think about inclusion of this feature? Should I add more granular `selection=single` `selection=multi`?
Release Notes:
- Added "selection" context for keybindings that are active when there is a text selection.
Ozan created
3f6ac53
Update GitHub bug issue template to refer to bugs instead of features (#21727)
Release Notes: - N/A
Dan Dascalescu created
74d7ce2
elixir: Improve ElixirLS LSP autocomplete to show labelDetails information (#21666)
Closes https://github.com/zed-industries/zed/issues/19688 Release Notes: - Improved ElixirLS LSP autocomplete to show module, function and struct field details   
João Otávio Biondo created
6a37307
Add .prettierignore support (#21297)
Closes #11115 **Context**: Consider a monorepo setup like this: the root has Prettier installed, but the individual monorepos do not. In this case, only one Prettier instance is used, with its installation located at the root. The monorepos also use this same instance for formatting. However, monorepo can have its own `.prettierignore` file, which will take precedence over the `.prettierignore` file at the root level (if one exists) for files in that monorepo. <img src="https://github.com/user-attachments/assets/742f16ac-11ad-4d2f-a5a2-696e47a617b9" alt="prettier" width="200px" /> **Implementation**: From the context above, we should keep ignore dir decoupled from the Prettier instance. This means that even if the project has only one Prettier installation (and thus a single Prettier instance), there can still be multiple `.prettierignore` in play. This approach also allows us to respect `.prettierignore` even when the project does not have Prettier installed locally and instead relies on the editor’s Prettier instance. **Tests**: 1. No Prettier in project, using editor Prettier: Ensures `.prettierignore` is respected even without a local Prettier installation. 2. Monorepo with root Prettier and child `.prettierignore`: Confirms that the child project’s ignore file is correctly used. 3. Monorepo with root and child `.prettierignore` files: Verifies the child ignore file takes precedence over the root’s. Release Notes: - Added `.prettierignore` support to the Prettier integration.
tims created
8dd1c23
editor: Add debounce setting for triggering DocumentHighlight (#21702)
Closes https://github.com/zed-industries/zed/issues/6843 I don't see where is the logic to remove old document highlight when new one applies, ideally, old highlight should be cleared as soon as possible when cursor moves if the new position does not sits in old highlight ranges to avoid linger highlights described in https://github.com/zed-industries/zed/issues/13682#issuecomment-2498368680. So current solution is still not ideal, because only when lsp responses highlight ranges (even is a empty set) can we clear the old one. Release Notes: - Added a setting `lsp_highlight_debounce` to configure delay for querying highlights from language server. --------- Co-authored-by: mgsloan@gmail.com <michael@zed.dev>
xzbdmw and mgsloan@gmail.com created
5787471
Add metal icon (#21720)
Release Notes: - Added file icon for metal --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Evren Sen and Danilo Leal created
bab6a79
Fix audio tooltip logic (#21941)
Earlier work by @osiewicz in #21931 aims to fix audio control tooltips in the title bar to close #21929. However, its logic is not quite correct, and does not match the toggle behavior for the controls. This PR corrects the logic to match the toggle behavior for the controls. It also updates capitalization and wording for consistency. Release Notes: - N/A
Aaron Feickert created
9a806f9
Improve diff syntax highlighting queries (#21740)
Brings over the improvements made for the same grammar: https://github.com/nvim-treesitter/nvim-treesitter/pull/6619. Related to #19986 but not really- the problem brought up there is an issue of themes not supporting the `diff.plus` and `diff.minus` captures (already used before this PR). <details><summary>Theme previews (before/after)</summary> | Before | After | | --- | --- | |  |  | | Before | After | | --- | --- | |  |  | | Before | After | | --- | --- | |  |  | | Before | After | | --- | --- | |  |  | | Before | After | | --- | --- | |  |  | </details> Release Notes: - Improved diff syntax highlighting
uncenter created
e778635
search: Add ToggleRegex for buffer search (#21799)
Closes #21790 IMO, this is lost Release Notes: - Add ToggleRegex for buffer search
CharlesChen0823 created
5de0bcc
gpui: Fix for setting window titles on Windows (#21907)
Windows requires `WM_NCCREATE` to be processed by default procedure to set window title properly. Release Notes: - N/A
雨 created
9143fd2
language_model_selector: Don't recreate the `Picker` view each render (#21939)
While working on Assistant2, I noticed that the `LanguageModelSelector` was recreating its `Picker` view on every single render. This PR makes it so we create the view once and hold onto it in the parent view. Release Notes: - N/A
Marshall Bowers created
d7eba54
Add version control file icon for gitcommit files (#21935)
Closes: https://github.com/zed-industries/zed/issues/21734 <img width="976" alt="SCR-20241212-nlci" src="https://github.com/user-attachments/assets/d567e2c8-d803-4148-b159-ae781eb59b50" /> I added the same file extensions that are used in the `Git Firefly` extension. https://github.com/d1y/git_firefly/blob/b521b7132491808e3f6f0416387a9a7b5eca464a/languages/gitcommit/config.toml#L5-L9 Release Notes: - Added version control file icon for gitcommit files.
Joseph T. Lyons created
52c0d71
assistant2: Add initial support for attaching file context (#21934)
This PR adds the initial support for attaching files as context to a thread in Assistant2. Release Notes: - N/A
Marshall Bowers created
111e844
title_bar: Adjust tooltip for mute/deafen buttons (#21931)
Closes #21929 Release Notes: - N/A
Piotr Osiewicz created
0eb9922
Set User Agent for Jupyter websocket connections (#21910)
Some VPN configurations require that websockets present a user agent. This adds it in directly for the repl usage. I wish there was a way to reuse the user agent from the `cx.http_client`, but I'm not seeing a simple way to do that for the moment since it's not on the `HttpClient` trait. No release notes since this feature hasn't been announced/exposed. Release Notes: - N/A
Kyle Kelley created
573e096
More Git panel refinements (#21928)
- Add and wire through git method stubs - Organize render methods - Track modifier changes - Swap commit buttons when `option`/`alt` is held - More TODOs Release Notes: - N/A
Nate Butler created
ee6f834
Fuse LLM completion stream to avoid a panic (#21914)
`LanguageModel::stream_completion_text` can poll the `stream_completion` stream (ultimately a `futures::Unfold`) after it's returned `Ready(None)`, which leads to a panic; avoid this by fusing the stream. Release Notes: - Fixed a panic when streaming language model completions
Cole Miller created
b4c8e04
Clear completion if model doesn't produce any edit (#21925)
Release Notes: - N/A
Antonio Scandurra created
bcf8a2f
Inline terminal assistant v2 (#21888)
Follow-up to https://github.com/zed-industries/zed/pull/21828 to add it to the terminal as well. https://github.com/user-attachments/assets/505d1443-4081-4dd8-9725-17d85532f52d As with the previous PR, there's plenty of code duplication here; the plan is to do more code sharing in separate PRs! Release Notes: - N/A
Richard Feldman created
77d0662
lsp: Fill in a bunch of missing capabilities (#21924)
Also state explicitly that we do support UTF-16 encoding and nothing else. See also #19788 Release Notes: - N/A
Piotr Osiewicz created
5d0e75d
Improve emacs keybind with better home/end behavior (#21923)
Improve behavior of ctrl-a/ctrl-e home/end in emacs keybind. Follow up to #21921 to add those to Linux emacs keymap too. Release Notes: - emacs: Improved `ctrl-a` / `ctrl-e` / `home` / `end` behavior - emacs: Added for `ctrl-s` / `ctrl-r` / `ctrl-g` for navigating buffer search results
Peter Tripp created
181af78
Fix docstring for CallSettingsContent.share_on_join (#21884)
Aaron Feickert created
ad4c4af
Always let two completions race with each other (#21919)
When a user types, chances are the model will anticipate what they are about to do. Previously, we would continuously cancel the pending completion until the user stopped typing. With this commit, we allow at most two completions to race with each other (the first and the last one): - If the completion that was requested first completes first, we will show it (assuming we can interpolate it) but avoid canceling the last one. - When the completion that was requested last completes, we will cancel the first one if it's pending. In both cases, if a completion is already on-screen we have a special case for when the completions are just insertions and the new completion is a superset of the existing one. In this case, we will replace the existing completion with the new one. Otherwise we will keep showing the old one to avoid thrashing the UI. This should make latency a lot better. Note that I also reduced the debounce timeout to 8ms. Release Notes: - N/A
Antonio Scandurra created
91b02a6
Add emacs keybinds for previous/next/cancel in search (#21921)
Peter Tripp created
1f296d8
docs: Include `restore_on_startup` (#21918)
Signed-off-by: xuoe <xuoe@pm.me>
xuoe created
c204b0d
zeta: Add adjustments to the review modal UI (#21920)
Most notably, adding a current iteration of a possible logo to feel it out! :) Also, I'm hiding the input and instructions container after the review has been sent. In the future, if we allow changing an already sent review, we can change this behavior. <img width="800" alt="Screenshot 2024-12-12 at 10 42 44" src="https://github.com/user-attachments/assets/37e63d0d-d847-445e-bdf8-bf5c97d0fe4c" /> Release Notes: - N/A
Danilo Leal created
8e0ae44
Initial git panel refinements (#21912)
- Wire up settings - Update static Panel impl - Tidy up renders Release Notes: - N/A
Nate Butler created
02fbad1
toolbar: Add gap between the Kernel and REPL button (#21871)
Before:  After:  Also works with dark themes:  Release Notes: - N/A Co-authored-by: raphael.kieling <raphael.kieling-ext@ab-inbev.com>
Raphael Kieling and raphael.kieling created
227f21f
zeta: Show timestamps and latency in rating modal (#21863)
Release Notes: - N/A --------- Co-authored-by: Antonio <antonio@zed.dev> Co-authored-by: Bennet <bennet@zed.dev> Co-authored-by: Cole <cole@zed.dev>
Thorsten Ball , Antonio , Bennet , and Cole created
543a3ef
linux: Don't watch parent directory when target path already exists (#21854)
The Linux watcher was unconditionally watching the parent directory of every watched path. This is needed in the case of config files that may not exist when the watch is set up, but not in other cases. Scoping the parent watch more narrowly cuts down on the amount of error logging from irrelevant file change notifications being sent to Zed (in my case it was picking up changes to a random file in `$HOME`). Release Notes: - N/A
Cole Miller created