304158e
Catch panic from oo7 when reading credentials (#21617)
Cole Miller created
304158e
Catch panic from oo7 when reading credentials (#21617)
Cole Miller created
e8f0ebc
Refine diagnostic icons in tabs (#21637)
Follow up to https://github.com/zed-industries/zed/pull/21383 Mostly adjusting the alignment when there are no file icons. <img width="800" alt="Screenshot 2024-12-06 at 08 35 48" src="https://github.com/user-attachments/assets/6a4206cc-2af5-4317-a92e-49dffa37de99"> Release Notes: - N/A
Danilo Leal created
7b1d1bf
Update `panel.focused_border` token across themes (#21612)
Follow up to https://github.com/zed-industries/zed/pull/21593 This PR updates all built-in themes `panel.focused_border` tokens using the same HEX code used for `text_accent`. There shouldn't be any visual change here given the project panel item, when focused, was using `Color::Selected`, which maps to `text_accent`, to color its border. In the linked PR above, the project panel item was updated to use the dedicated token for that. This is good because now theme markers will be able to customize them separately (e.g., having a different `text_accent` color than `panel.focused_border`). Release Notes: - N/A
Danilo Leal created
4b16b73
Fix panel.background color override (#21559)
Closes #21266 Release Notes: - Fixes not using the `panel.background` color in the file tree See comments in https://github.com/zed-industries/zed/issues/21266 for more details. Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Nils Koch and Danilo Leal created
7e40add
markdown preview: Fix panic when parsing empty image tag (#21616)
Closes #21534 While investigating the panic, I noticed that the code was pretty complicated and decided to refactor parts of it to reduce redundancy. Release Notes: - Fixed an issue where the app could crash when opening the markdown preview with a malformed image tag
Bennet Bo Fenner created
f6b5e17
Get unstaged changes when excerpts of new buffers are added (#21619)
This fixes an error on nightly, introduced in https://github.com/zed-industries/zed/pull/21258, where diffs were not shown for buffers that were added to multi-buffers after construction. Release Notes: - N/A
Max Brunsfeld created
cf4e847
Implement session-global include_warnings in the diagnostic item (#21618)
Release Notes: - Make the include warnings toggle in the diagnostic tab global for a zed session.
Mikayla Maki created
aff1732
Detect wider variety of usernames for SSH-based remotes (#21508)
Closes #21507 Release Notes: - Fixed detection of git remotes when using SSH and username is not "git".
Nick Breaton created
28650b2
Update Rust crate blake3 to v1.5.5 (#21554)
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [blake3](https://redirect.github.com/BLAKE3-team/BLAKE3) |
workspace.dependencies | patch | `1.5.4` -> `1.5.5` |
---
### Release Notes
<details>
<summary>BLAKE3-team/BLAKE3 (blake3)</summary>
###
[`v1.5.5`](https://redirect.github.com/BLAKE3-team/BLAKE3/releases/tag/1.5.5)
[Compare
Source](https://redirect.github.com/BLAKE3-team/BLAKE3/compare/1.5.4...1.5.5)
version 1.5.5
Changes since 1.5.4:
- `b3sum --check` now supports checkfiles with Windows-style newlines.
`b3sum` still emits Unix-style newlines, even on Windows, but
sometimes text editors or version control tools will swap them.
- The "digest" feature (deleted in v1.5.2) has been added back to the
`blake3` crate. This is for backwards compatibility only, and it's
insta-deprecated. All callers should prefer the "traits-preview"
feature.
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
Release Notes:
- N/A
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS40Mi40IiwidXBkYXRlZEluVmVyIjoiMzkuNDIuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot] and renovate[bot] created
6a4cd53
Use LiveKit's Rust SDK on Linux while continue using Swift SDK on Mac (#21550)
Similar to #20826 but keeps the Swift implementation. There were quite a few changes in the `call` crate, and so that code now has two variants. Closes #13714 Release Notes: - Added preliminary Linux support for voice chat and viewing screenshares. --------- Co-authored-by: Kirill Bulatov <mail4score@gmail.com> Co-authored-by: Kirill Bulatov <kirill@zed.dev> Co-authored-by: Mikayla <mikayla@zed.dev>
Michael Sloan , Kirill Bulatov , Kirill Bulatov , and Mikayla created
0511768
project panel: Use theme token for focused border color (#21593)
Closes https://github.com/zed-industries/zed/issues/12723 This PR makes the border color of a focused project panel item use the `panel_focused_border` theme token. This allow theme makers to customize that independently of the `text_accent` color, which was the one being previously used. ### One Dark | Before | After | |--------|--------| | <img width="800" alt="Screenshot 2024-12-05 at 18 37 00" src="https://github.com/user-attachments/assets/8b21f1e3-1738-42ab-af30-ad7d589007c1"> | <img width="800" alt="Screenshot 2024-12-05 at 18 39 42" src="https://github.com/user-attachments/assets/1a424765-a1b6-48eb-ae75-1ffba2b59da3"> | | <img width="800" alt="Screenshot 2024-12-05 at 18 37 08" src="https://github.com/user-attachments/assets/d1955cf2-e194-46a5-9518-dc3af7f70cfe"> | <img width="800" alt="Screenshot 2024-12-05 at 18 39 51" src="https://github.com/user-attachments/assets/99413075-f021-4961-8f03-ad1b40503ea6"> | ### Gruvbox Hard | Before | After | |--------|--------| | <img width="800" alt="Screenshot 2024-12-05 at 18 38 05" src="https://github.com/user-attachments/assets/cf84ce75-ac8a-4cb6-aaab-81e02bfb4835"> | <img width="800" alt="Screenshot 2024-12-05 at 18 40 15" src="https://github.com/user-attachments/assets/f62b815b-8bed-41d8-85a1-7091d04bfbd2"> | | <img width="800" alt="Screenshot 2024-12-05 at 18 38 16" src="https://github.com/user-attachments/assets/fb458fa2-6ce1-4af0-a7a6-83584f3e5ed0"> | <img width="800" alt="Screenshot 2024-12-05 at 18 39 57" src="https://github.com/user-attachments/assets/8bf44fe6-7090-4ef0-8b56-b8aa2e1f314d"> | Release Notes: - N/A
Danilo Leal created
c8b3c4c
assistant2: Add ability to delete past threads (#21607)
This PR adds the ability to delete past threads in Assistant2. Release Notes: - N/A
Marshall Bowers created
1efd165
Restore project diff test (#21606)
Restores a basic project diff test Release Notes: - N/A --------- Co-authored-by: Cole Miller <cole@zed.dev>
Kirill Bulatov and Cole Miller created
787c75c
assistant2: Add thread history (#21599)
This PR adds support for thread history to the Assistant 2 panel. We also now generate summaries for the threads. <img width="986" alt="Screenshot 2024-12-05 at 12 56 53 PM" src="https://github.com/user-attachments/assets/46cb1309-38a2-4ab9-9fcc-c1275d4b5f2c"> <img width="986" alt="Screenshot 2024-12-05 at 12 56 58 PM" src="https://github.com/user-attachments/assets/8c91ba57-a6c5-4b88-be05-b22fb615ece5"> Release Notes: - N/A --------- Co-authored-by: Piotr <piotr@zed.dev>
Marshall Bowers and Piotr created
2d43ad1
git: Make worktrees work for bare git repositories (#21596)
Fixes #21210 by ensuring that Zed can open worktrees of bare git repositories. Co-authored-by: Peter Tripp <peter@zed.dev>
Thorsten Ball and Peter Tripp created
6ebd6c2
Show error and warning indicators in tabs (#21383)
Closes #21179 Release Notes: - Add setting to display error and warning indicators in tabs. <img width="454" alt="demo_with_icons" src="https://github.com/user-attachments/assets/6002b4d4-dca8-4e2a-842d-1df3e281fcd2"> <img width="454" alt="demo_without_icons" src="https://github.com/user-attachments/assets/df4b67bd-1a6c-4354-847e-d7fea95c1b7e">
Nils Koch created
92dea06
Extend filtering of backtrace frames a bit (#21573)
Both rust_begin_unwind and _rust_begin_unwind appear in practice, not sure why. Release Notes: - N/A
Cole Miller created
7335f21
Add Project Panel navigation actions in netrw mode (#20941)
Release Notes:
- Added "[ c" & "] c" To select prev/next git modified file within the
project panel
- Added "[ d" & "] d" To select prev/next file with diagnostics from an
LSP within the project panel
- Added "{" & "}" To select prev/next directory within the project panel
Note:
I wanted to extend project panel's functionality when netrw is active so
I added some shortcuts that I believe will be helpful for most users. I
tried to keep the default key mappings for the shortcuts inline with
Zed's vim mode.
## Selecting prev/next modified git file
https://github.com/user-attachments/assets/a9c057c7-1015-444f-b273-6d52ac54aa9c
## Selecting prev/next diagnostics
https://github.com/user-attachments/assets/d1fb04ac-02c6-477c-b751-90a11bb42a78
## Selecting prev/next directories (Only works with visible directoires)
https://github.com/user-attachments/assets/9e96371e-105f-4fe9-bbf7-58f4a529f0dd
Anthony Eid created
78fea0d
Defer is_staff check for the project_diff::Deploy action (#21582)
During workspace registration, it's too early to check for the `is_staff` flag due to no connection being established yet. As a compromise, allow the action to appear and be registered, but do nothing for non-staff users. Release Notes: - N/A
Kirill Bulatov created
9487fff
Fix snippet completion will be trigger, when certain symbols are pressed (#21578)
Closes #21576 This issue is caused by the fuzzy matching for snippets I added [here](https://github.com/zed-industries/zed/pull/21524). When encountering symbols such as `:`, `(`, `.`, etc., the `last_word` becomes empty, which results in an empty string being passed to `fuzzy_match`, leading to the return of all templates. This fix adds an early return when `last_word` is empty. Release Notes: - N/A
tims created
b9c390c
Revert "Open folds containing selections when jumping from multibuffer (#21433)" (#21566)
This reverts commit dc32ab25a0f76280ff0f1485333a729523840e27. This has been causing panics, backing it out while figuring out what's up. Release Notes: - N/A
Cole Miller created
31c976d
Update Rust crate cargo_metadata to v0.19.1 (#21556)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [cargo_metadata](https://redirect.github.com/oli-obk/cargo_metadata) | workspace.dependencies | patch | `0.19.0` -> `0.19.1` | --- ### Release Notes <details> <summary>oli-obk/cargo_metadata (cargo_metadata)</summary> ### [`v0.19.1`](https://redirect.github.com/oli-obk/cargo_metadata/compare/0.19.0...0.19.1) [Compare Source](https://redirect.github.com/oli-obk/cargo_metadata/compare/0.19.0...0.19.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS40Mi40IiwidXBkYXRlZEluVmVyIjoiMzkuNDIuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot] and renovate[bot] created
5b169fa
Update Rust crate anyhow to v1.0.94 (#21552)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [anyhow](https://redirect.github.com/dtolnay/anyhow) | workspace.dependencies | patch | `1.0.93` -> `1.0.94` | --- ### Release Notes <details> <summary>dtolnay/anyhow (anyhow)</summary> ### [`v1.0.94`](https://redirect.github.com/dtolnay/anyhow/releases/tag/1.0.94) [Compare Source](https://redirect.github.com/dtolnay/anyhow/compare/1.0.93...1.0.94) - Documentation improvements </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS40Mi40IiwidXBkYXRlZEluVmVyIjoiMzkuNDIuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot] and renovate[bot] created
a2115e7
Restructure git diff state management to allow viewing buffers with different diff bases (#21258)
This is a pure refactor of our Git diff state management. Buffers are no longer are associated with one single diff (the unstaged changes). Instead, there is an explicit project API for retrieving a buffer's unstaged changes, and the `Editor` view layer is responsible for choosing what diff to associate with a buffer. The reason for this change is that we'll soon want to add multiple "git diff views" to Zed, one of which will show the *uncommitted* changes for a buffer. But that view will need to co-exist with other views of the same buffer, which may want to show the unstaged changes. ### Todo * [x] Get git gutter and git hunks working with new structure * [x] Update editor tests to use new APIs * [x] Update buffer tests * [x] Restructure remoting/collab protocol * [x] Update assertions about staged text in `random_project_collaboration_tests` * [x] Move buffer tests for git diff management to a new spot, using the new APIs Release Notes: - N/A --------- Co-authored-by: Richard <richard@zed.dev> Co-authored-by: Cole <cole@zed.dev> Co-authored-by: Conrad <conrad@zed.dev>
Max Brunsfeld , Richard , Cole , and Conrad created
3179617
assistant2: Sketch in context picker (#21560)
This PR sketches in a context picker into the message editor in Assistant 2. Not functional yet. <img width="1138" alt="Screenshot 2024-12-04 at 5 45 19 PM" src="https://github.com/user-attachments/assets/053d6224-de76-4fde-914b-41fe835761eb"> Release Notes: - N/A
Marshall Bowers created
a30ea2f
assistant2: Factor out `ActiveThread` view (#21555)
This PR factors a new `ActiveThread` view out of the `AssistantPanel` to group together the state that pertains solely to the active view. There was a bunch of related state on the `AssistantPanel` pertaining to the active thread that needed to be initialized/reset together and it makes for a clearer narrative is this state is encapsulated in its own view. Release Notes: - N/A
Marshall Bowers created
55ecb3c
Regenerate completion labels on resolve (#21521)
Closes https://github.com/zed-industries/zed/issues/21516 Technically, this is an LSP violation from `vtsls`, but seems that it's not going to be fixed adequately on that side, see https://github.com/yioneko/vtsls/issues/213 for more context. So, we have to accommodate at least for now. Release Notes: - Fixed completion item labels not being updated after the resolve for non-LSP compliant servers
Kirill Bulatov created
8d18dfa
Add a prototype with a multi buffer having all project git changes (#21543)
Part of https://github.com/zed-industries/zed/issues/20925 This prototype is behind a feature flag and being merged to avoid conflicts with further git-related resturctures. To be a proper, public feature, this needs at least: * showing deleted files * better performance * randomized tests * `TODO`s in the `project_diff.rs` file fixed The good thing is, >90% of the changes are in the `project_diff.rs` file only, have a basic test and already work on simple cases. Release Notes: - N/A --------- Co-authored-by: Thorsten Ball <thorsten@zed.dev> Co-authored-by: Cole Miller <cole@zed.dev>
Kirill Bulatov , Thorsten Ball , and Cole Miller created
f0fac41
Add action `editor::OpenContextMenu` (#21494)
This addresses the editor context menu portion of #17819. Release Notes: - Added `editor::OpenContextMenu` action to open context menu at current cursor position.
Michael Sloan created
0bde0f8
assistant2: Add ability to open past threads (#21548)
This PR adds the ability to open past threads in Assistant 2. There are also some mocked threads in the history for testing purposes. Release Notes: - N/A
Marshall Bowers created
44264ff
Revert accidental change to Rust outline files (#21545)
Release Notes: - Preview only: Fixed impl blocks in the rust outline view
Conrad Irwin created
7cfc972
assistant2: Add empty state for new threads (#21542)
This PR adds an empty state for new threads in Assistant2: <img width="1138" alt="Screenshot 2024-12-04 at 12 17 46 PM" src="https://github.com/user-attachments/assets/ff7b4533-d3b8-4722-bd4b-43fac6d35a77"> This is mostly just a sketch in its current state. Release Notes: - N/A
Marshall Bowers created
fee0624
Force code actions to be single line (#21409)
Addresses #21403 partially. Is consistent with the behaviour in VSCode Before: <img width="332" alt="391571084-1bef4ef9-b8f5-4c8f-9a32-9c0ab6c91af1" src="https://github.com/user-attachments/assets/d4d83826-23a1-43a1-94f9-feb0b0ddd5ce"> After: <img width="330" alt="Screenshot 2024-12-02 at 18 35 11" src="https://github.com/user-attachments/assets/c04f0494-4f34-476a-a090-1443d61851e5"> Release Notes: - Fixed an issue with multiline code actions' rendering by forcing them to be single line
Stanislav Alekseev created
cf781df
v0.166.x dev
Peter Tripp created
706372f
title_bar: Add show_user_picture setting to let users hide their profile picture (#21526)
Fixes #21464 Closes #21464 Release Notes: - Added `show_user_picture` setting (default: true) to allow users to hide their profile picture in titlebar.
Piotr Osiewicz created
5948ea2
Configure Highlight settings on yank vim (#21479)
Release Notes: - Add settings / config variables to control `highlight_on_yank` or `highlight_on_copy` --------- Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Vedant Matanhelia and Conrad Irwin created
207eb51
assistant2: Style inline code in Markdown (#21536)
This PR adds some styling for inline code within the messages to differentiate them from the surrounding text: <img width="1138" alt="Screenshot 2024-12-04 at 10 58 14 AM" src="https://github.com/user-attachments/assets/3bb92711-e2f7-454a-b4be-449c6a9bf591"> Release Notes: - N/A
Marshall Bowers created
0ee99c6
context_server: Add missing types for MCP spec to protocol 2024-11-05 (#21498)
This commit syncs missing types for the mcp spec 2024-11-05. Release Notes: - N/A
David Soria Parra created
d8732ad
Add fuzzy matching for snippets completions (#21524)
Closes #21439 This PR uses fuzzy matching for snippet completions instead of fixed-prefix matching. This mimics the behavior of VSCode. <img src="https://github.com/user-attachments/assets/68537114-c5cf-4e4d-bc5c-4bb69ce947e5" alt="fuzzy" width="450px" /> Release Notes: - Improved suggestions for snippets.
tims created
196fd65
Fix panic folding in multi-buffers (#21511)
Closes #19054 Rename `max_buffer_row()` to `widest_line_number()` to (hopefully) prevent people assuming it means the same as `max_point().row`. Release Notes: - Fixed a panic when folding in a multibuffer
Conrad Irwin created
e231321
Fix panic in update_ime_position (#21510)
This can call back into the app, so must be done when the platform lock is not held. Release Notes: - Fixes a (rare) panic when changing tab
Conrad Irwin created
8f08787
Implement Helix Support (WIP) (#19175)
Closes #4642 - Added the ability to switch to helix normal mode, with an additional helix visual mode. - <kbd>ctrl</kbd><kbd>h</kbd> from Insert mode goes to Helix Normal mode. <kbd> i </kbd> and <kbd> a </kbd> to go back. - Need to find a way to perform the helix normal mode selection with <kbd> w </kbd>, <kbd>e </kbd>, <kbd> b </kbd> as a first step. Need to figure out how the mode will interoperate with the VIM mode as the new additions are in the same crate.
Waleed Dahshan created
c5d15fd
Add FoldFunctionBodies editor action (#21504)
Related to #19424 This uses the new text object support, so will only work for languages that have `textobjects.scm`. It does not integrate with indentation-based folding for now, and the syntax-based folds don't have matching fold markers in the gutter (unless they are folded). Release Notes: - Add an editor action to fold all function bodies Co-authored-by: Conrad <conrad@zed.dev>
Cole Miller and Conrad created
ce5f492
Update rustls and sqlx (#21506)
Release Notes: - N/A
Cole Miller created
3019960
markdown: Make `cx` the last parameter to `Markdown::new_text` (#21497)
This PR is a follow-up to https://github.com/zed-industries/zed/pull/21487 to make sure that the `cx` is the last parameter to `Markdown::new_text` as well. Release Notes: - N/A
Marshall Bowers created
9f459ba
assistant2: Render messages as Markdown (#21496)
This PR updates Assistant 2 to render the messages in the thread as Markdown: <img width="1138" alt="Screenshot 2024-12-03 at 6 09 27 PM" src="https://github.com/user-attachments/assets/c1c44fde-1efb-43cf-b9c9-768e6974c753"> Release Notes: - N/A
Marshall Bowers created
ecaf445
Fix Perplexity extension URL (#21495)
Peter Tripp created
dc32ab2
Open folds containing selections when jumping from multibuffer (#21433)
When searching within a single buffer, activating a search result causes any fold containing the result to be unfolded. However, this didn't happen when jumping to a search result from a project-wide search multibuffer. This PR fixes that. Release Notes: - Fixed folds not opening when jumping from search results multibuffer
Cole Miller created
aca23da
assistant2: Render messages in the thread using a `list` (#21491)
This PR updates the rendering of the messages in the current thread to use a `gpui::list`. Release Notes: - N/A
Marshall Bowers created
db34f29
vim: Add == and fix = in the status bar (#21490)
cc @maxbrunsfeld Release Notes: - vim: Add ==
Conrad Irwin created