af67af8
Bump to 0.173.4 for @maxdeviant
Zed Bot created
af67af8
Bump to 0.173.4 for @maxdeviant
Zed Bot created
e7f64c7
assistant_context_editor: Fix patch block not rendering due to window reborrow (cherry-pick #24461) (#24463)
Cherry-picked assistant_context_editor: Fix patch block not rendering due to window reborrow (#24461) This PR fixes an issue where the Assistant patch block was not being rendered when using "Suggest Edits". The issue was that the `BlockContext` already has a borrow of the `Window`, so we can't use `update_in` to reborrow the window. The fix is to reuse the existing `&mut Window` reference from the `BlockContext` so we don't need to `update_in`. Closes #24169. Release Notes: - Assistant: Fixed an issue where the patch block was not being rendered when using "Suggest Edits". --------- Co-authored-by: Max <max@zed.dev> Co-authored-by: Marshall Bowers <git@maxdeviant.com> Co-authored-by: Max <max@zed.dev>
gcp-cherry-pick-bot[bot] , Marshall Bowers , and Max created
95062b3
Bump to 0.173.3 for @maxdeviant
Zed Bot created
58834b4
gpui: Render SVGs at 2x size when rendered in an `img` (cherry-pick #24332) (#24336)
Cherry-picked gpui: Render SVGs at 2x size when rendered in an `img` (#24332) This PR adjusts the rendering of SVGs when used with the `img` element such that they are rendered at 2x their displayed size. This results in much crisper icons for icons loaded by icon themes: <img width="1136" alt="Screenshot 2025-02-05 at 7 39 48 PM" src="https://github.com/user-attachments/assets/47d1fcee-c54d-4717-8fca-9b9d2bc8da9a" /> <img width="1136" alt="Screenshot 2025-02-05 at 7 40 01 PM" src="https://github.com/user-attachments/assets/3061157c-8c88-41c1-a5dc-83ef9cd341cb" /> Release Notes: - Improved the resolution of icons rendered by icon themes. Co-authored-by: Marshall Bowers <git@maxdeviant.com>
gcp-cherry-pick-bot[bot] and Marshall Bowers created
d54f6f9
zed 0.173.2
Joseph T. Lyons created
0542019
Fix the worktree's repository_for_path (cherry-pick #24279) (#24292)
Cherry-picked Fix the worktree's repository_for_path (#24279) Go back to a less optimized implementation for now since the custom cursor target seems to have some bugs. Release Notes: - Fixed missing git blame and status output in some projects with multiple git repositories Co-authored-by: Cole Miller <cole@zed.dev>
gcp-cherry-pick-bot[bot] and Cole Miller created
9f825ca
edit prediction: Fix license detection error logging + check for different spellings (#24281)
Follow-up to https://github.com/zed-industries/zed/pull/24278 This PR ensures we're checking if there's a license-type file in both US & UK English spelling, and fixes the error logging again, treating for when the worktree contains just a single file or multiple. Release Notes: - N/A Co-Authored-By: Bennet Bo Fenner <53836821+bennetbo@users.noreply.github.com>
Danilo Leal and Bennet Bo Fenner created
af0f36d
Revert recent anti-aliasing improvements (cherry-pick #24289) (#24291)
Cherry-picked Revert recent anti-aliasing improvements (#24289) This reverts commit 31fa4144226fcbd140bb4f26d80001f0abd6facd. This reverts commit b9e0aae49fad996ddb0ce55225873e5c1d5abecd. `lyon` commit revert:  `MSAA` commit revert:  Release Notes: - N/A Co-authored-by: Kirill Bulatov <kirill@zed.dev>
gcp-cherry-pick-bot[bot] and Kirill Bulatov created
68b4f9e
edit prediction: Improve UX around `disabled_globs` and `show_inline_completions` (#24207)
Release Notes: - N/A --------- Co-authored-by: Danilo <danilo@zed.dev> Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Bennet Bo Fenner , Danilo , and Danilo Leal created
8ed71b2
Implement character index for point (cherry-pick #23989) (#24284)
Cherry-picked Implement character index for point (#23989) Fixes #22939 Fixes #23970 Supersedes https://github.com/zed-industries/zed/pull/23469 Release Notes: - Fixed a bug where Zed could crash with certain input sources on macOS --------- Co-authored-by: Louis Brunner <louis.brunner.fr@gmail.com> Co-authored-by: ben <ben@zed.dev> Co-authored-by: Mikayla Maki <mikayla@zed.dev> Co-authored-by: Louis Brunner <louis.brunner.fr@gmail.com> Co-authored-by: ben <ben@zed.dev>
gcp-cherry-pick-bot[bot] , Mikayla Maki , Louis Brunner , and ben created
79714fc
Fix panic when deleting an empty line after a deleted hunk (cherry-pick #24255) (#24282)
Cherry-picked Fix panic when deleting an empty line after a deleted hunk (#24255) Release Notes: - Fix a panic when deleting text after a deletion hunk Co-authored-by: Cole Miller <cole@zed.dev>
gcp-cherry-pick-bot[bot] and Cole Miller created
eafad7d
Accept edit predictions with `alt-tab` in addition to `tab` (#24272)
When you have an edit prediction available, you can now also accept it with `alt-tab` (or `alt-enter` on Linux) even if you don't have an LSP completions menu open. This is meant to lower the mental load when going from one mode to another. Release Notes: - N/A
Agus Zubiaga created
45f9192
edit predictions: Onboarding funnel telemetry (#24237)
Release Notes: - N/A
Agus Zubiaga created
1748fbe
edit prediction: Allow enabling OSS data collection with no project open (#24265)
This was an leftover from when we were persisting a per-project setting. Release Notes: - N/A
Agus Zubiaga created
57d09d2
zed 0.173.1
Agus Zubiaga created
bc67f99
edit prediction: Fix jump cursor position when scrolled (#24230)
We were looking up line layouts without subtracting start row so we would get the wrong one when scrolled Release Notes: - N/A
Agus Zubiaga created
722fd59
edit prediction: Do not render jump cursor until line layout is ready (#24226)
This is pretty rare but I found a case where `line_layouts` didn't have the requested line yet, so we now skip rendering the cursor for that period and avoid panicking. Release Notes: - N/A
Agus Zubiaga created
cf4e294
v0.173.x preview
Peter Tripp created
f8c436f
Fix prediction preview binding: `Alt + Preview` -> `Alt Preview` (#24220)
Release Notes: - N/A
Michael Sloan created
b5d4b17
Fix showing "enter Accept" for prediction with LSP menu open (#24218)
Release Notes: - N/A
Michael Sloan created
3e68f7f
Revert "Skip COMMIT_EDITMSG contents when opening the file (#24146)" (#24216)
Kirill Bulatov created
e768eb0
Replace `Window::parent_view_id()` with `Window::current_view()` (#24212)
Chatted with @as-cii about limitations in the `Window::parent_view_id()` API (see: https://github.com/zed-industries/zed/pull/24182/commits/662153dcfdd80804f4041761c09c4a309d79f6d4) and realized that I shouldn't be using the dispatch tree's data structures as they are layout dependent. I've introduced a new stack to `Window`, `rendered_entity_stack`, that tracks exactly which view's elements are being drawn. As such, I've also been able to remove the `Option<>` around the previous API. Release Notes: - N/A
Mikayla Maki created
667396c
Use the term "edit prediction" over "inline completion" (#24211)
Note that this does *not* involve any breaking code changes. cc @0xtimsb - I didn't change any settings or anything here. That can happen separately! Release Notes: - N/A
Richard Feldman created
c64b261
Revert "edit prediction: Try to expand context to parent treesitter region" (#24214)
Reverts zed-industries/zed#24186
Antonio Scandurra created
8c7096f
Rename `model` based variable names to `entity` (#24198)
## Context While looking through the client crate, I noticed that some of the old functions and variables were still using gpui::model name that was deprecated during the gpui3 transition. This PR renames those instances of model to entity to be more inline with gpui3. In addition, I also renamed `model` to `entity` in cases found by the below search terms given by @someone13574 - model = cx. - model: Entity - model: &Entity - OpenedModelHandle - model.update - model.upgrade - model = .*\.root (regex) - parent_model - model = cx.new - cx.spawn(move |model Release Notes: - N/A
Anthony Eid created
27d1c68
Avoid subtraction overflow when excerpt primary is outside of excerpt… (#24213)
This fixes a "subtract with overflow" error that could happen in debug mode when viewing the project diagnostics. From git bisecting, I think that this behavior was introduced by https://github.com/zed-industries/zed/pull/21942. It seems like it's possible in some cases for the excerpt-expansion heuristic to cause the excerpt's `context` range to start *after* the excerpt's `primary` range. We should probably revisit that heuristic at some point, but it also seems reasonable to handle that situation at this layer, rather than overflowing. Release Notes: - N/A
Max Brunsfeld created
4ab4e87
Fix a bug in GPUI, where AsyncApp::update wouldn't kick off a flush effects loop (#24208)
Release Notes: - N/A
Mikayla Maki created
4f98157
edit predictions: Make Zed bar at least as wide as menu (#24206)
Release Notes: - N/A --------- Co-authored-by: Ben <ben@zed.dev>
Agus Zubiaga and Ben created
9b031d7
edit prediction: Use thin cursor for jump preview and gradients instead of ellipsis (#24202)
https://github.com/user-attachments/assets/06e14893-c285-4cea-927c-75e82a378b15 Release Notes: - N/A --------- Co-authored-by: Ben <ben@zed.dev>
Agus Zubiaga and Ben created
aea36f0
Prevent requesting more than 3 edit predictions per second (#24203)
Release Notes: - N/A Co-authored-by: Marshall <marshall@zed.dev>
Antonio Scandurra and Marshall created
cae712e
edit prediction: Try to expand context to parent treesitter region (#24186)
Also send the `speculated_output` (which is just the editable region) to the llm backend Closes #ISSUE Release Notes: - N/A --------- Co-authored-by: Antonio Scandurra <me@as-cii.com>
Bennet Bo Fenner and Antonio Scandurra created
bce9a9a
windows: Use setup-dev-driver.ps1 to create dev driver (#24196)
Closes #ISSUE Release Notes: - N/A
张小白 created
c50cb90
Revert "Upgrade to rustls v0.23.22" (#24197)
Reverts zed-industries/zed#24138 Nightly build failed, I believe because of this. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95189  CC: @ConradIrwin Release Notes: - N/A
Peter Tripp created
a0269ab
theme_selector: Add a button to open the extension store (#24195)
Adds a button to the theme selector to help people find more themes in the extension store.  Release Notes: - Added a way to access the extension store from the theme selector to make it easier to find new themes.
Nate Butler created
88b485f
Update license year (#24191)
Angelk90 created
2853649
copilot: Correct o3-mini context length (#24152)
It should be 200k (with 100k output). I can't find anything that puts it at 20k and the changeover in https://github.com/zed-industries/zed/commit/2f8237492641b4c97f61977a39f8a10225578a6d only changed the name from o1-mini to o3-mini References: * https://docs.github.com/en/copilot/using-github-copilot/asking-github-copilot-questions-in-github#ai-models-for-copilot-chat * https://github.com/marketplace/models/azure-openai/o3-mini * https://platform.openai.com/docs/models#o3-mini Release Notes: - Corrected Github Copilot o3-mini context length --------- Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Jacob Chapel and Marshall Bowers created
cc2ebb9
Revert "inline completion: Respect `disabled_globs` when manually requesting completions (#24121)" (#24189)
This reverts commit eb820ab800ea2a0023667b5c0eb91daa7c9ab084. The previous PR broke manual completions. Turns out there is more confusing behavior then i realized, will follow up with another PR soon. Closes #ISSUE Release Notes: - N/A
Bennet Bo Fenner created
d400bde
Add example compilation to CI (#24182)
Stop https://github.com/zed-industries/zed/pull/24165 from happening Release Notes: - N/A
Mikayla Maki created
71f2cbe
Git Panel: separate new and changed (#24181)
Release Notes: - N/A --------- Co-authored-by: conrad <conrad@zed.dev> Co-authored-by: nate <nate@zed.dev>
Mikayla Maki , conrad , and nate created
6659aea
Disallow multiple quit confirmations (#24180)
Closes https://github.com/zed-industries/zed/issues/10192 , again. Release Notes: - Fixed multiple save modals appearing when app is being closed multiple times
Kirill Bulatov created
386cfac
zeta: Fix data collection display on the status bar menu (#24177)
Follow-up to: https://github.com/zed-industries/zed/pull/24031 This PR adds a new function that allows the UI also to display the state of the data collection. Previously, we only showed that if the project adhered to the `is_open_source` condition. Now, we show it for all projects. Release Notes: - N/A
Danilo Leal created
e5c3273
status_bar: Only show divider for left dock (#24178)
Follow up to https://github.com/zed-industries/zed/pull/24114 Just fixing the UI so that the divider only shows for the left-positioned items. Release Notes: - N/A
Danilo Leal created
556b0eb
Show larger jump target preview + add ellipsii to indicate truncation (#24179)
Release Notes: - N/A
Michael Sloan created
93f8cca
zeta: Revised data-collection onboarding experience (#24031)
Release Notes: - N/A --------- Co-authored-by: Danilo <danilo@zed.dev> Co-authored-by: Danilo Leal <daniloleal09@gmail.com> Co-authored-by: João Marcos <marcospb19@hotmail.com>
Agus Zubiaga , Danilo , Danilo Leal , and João Marcos created
29e559d
Fix display of `+` between modifiers on linux and windows (#24173)
Regressions in #24024: * `+` was no longer included between modifiers and key * Multi-character keys like "control" were displayed all lowercase, whereas before they were all uppercase like "CONTROL". Now they are capitalized, so "Control". * Brings back icon for tab key. Release Notes: - N/A
Michael Sloan created
9a22ef2
Don't save deleted files (#24171)
We now treat new files that have no content as not-dirty. This fixes the git diff view when deleted files are present. It also fixes a long-standing bug where `zed RAEDME` and then closing the tab would prompt for "unsaved changes" when there were none. Release Notes: - Fixed a bug where closing an empty, named, file would warn about unsaved content.
Conrad Irwin created
66e0898
Fix corner case where edit prediction preview and docs aside overlap (#24170)
+ add docs and simplify logic around popover order Release Notes: - N/A
Michael Sloan created
cf4539e
Handle empty diff excerpts (#24168)
Release Notes: - Fix display, revert and undo of deleted hunks when the file is empty.
Conrad Irwin created
8bce896
Invalidate GPUI views regardless of draw phase (#24164)
We think this could fix issues around view invalidation during focus handling. I want to run CI on this and see. cc @mikayla-maki @maxbrunsfeld Release Notes: - N/A
Nathan Sobo created
ea66a54
Skip COMMIT_EDITMSG contents when opening the file (#24146)
Kirill Bulatov created