Commit log

15d041c Document elm-language-server not supporting linked_edits correctly (#23616)

Peter Tripp created

ed54af3 Support `yaml-language-server` as formatter without `lsp` settings (#23612)

Click to expand commit body 
- Closes: https://github.com/zed-industries/zed/issues/20183

Peter Tripp created

d5c7e0b git_ui: Add keybinding for focusing the git panel (#23613)

Click to expand commit body 
Adds a keybinding for opening/toggling focus to the git panel

Release Notes:

- N/A

Nate Butler created

77e9d01 task: Always use untruncated label if it is short (#23611)

Click to expand commit body 
Also changed rust tasks to be less mouthful.

Release Notes:

- Shortened Rust task labels.
- Task modal will now use full task label when it does not require
truncation.

Piotr Osiewicz created

7c2b175 assistant2: Adjust empty state when there is no provider (#23609)

Click to expand commit body 
This PR add a "Configure a Provider" button if the user gets to the
assistant panel with no provider configured. Then, upon configuring it,
they'll see a similar welcome message.

| No provider | Empty state |
|--------|--------|
| <img width="1233" alt="Screenshot 2025-01-24 at 12 25 48 PM"
src="https://github.com/user-attachments/assets/2f3c602f-9e46-4c79-95cd-4bb3717f68a3"
/> | <img width="1233" alt="Screenshot 2025-01-24 at 12 26 01 PM"
src="https://github.com/user-attachments/assets/a4a204dd-9531-45ab-89a2-f1d84f375a7b"
/> |

Release Notes:

- N/A

Danilo Leal created

fc3a871 assistant2: Adjust spacing and icons on the context picker (#23607)

Click to expand commit body 
Just fine-tuning spacing, icon size and color, and ensure they're are
consistent throughout.

Release Notes:

- N/A

Danilo Leal created

8efed4c search: Move invalid UTF-8 errors to debug level (#23602)

Click to expand commit body 
Closes #ISSUE

Release Notes:

- N/A

Piotr Osiewicz created

7b69c42 title_bar: Use an `IconButton` for the user menu (#23601)

Click to expand commit body 
That's specifically when we're not rendering the user menu with an
Avatar. We were previously rendering a `ButtonLike` with unnecessary
flex styles there. Just a little fine-tune.

Release Notes:

- N/A

Danilo Leal created

ad63bdf assistant2: Disable the Submit button when missing requirements (#23598)

Click to expand commit body 
This PR disables the Assistant 2 Submit button when either there is no
message written in the editor or there's no model selected. To guide the
user, there will be a tooltip displayed on top of the button to indicate
what to do.

Release Notes:

- N/A

Danilo Leal created

802d742 assistant: Adjust the ToS acceptance card design (#23599)

Click to expand commit body 
Just fine-tuning the copywriting and design here.

| Before | After |
|--------|--------|
| <img width="1233" alt="Screenshot 2025-01-24 at 9 28 30 AM"
src="https://github.com/user-attachments/assets/ca91a985-8a20-4ece-b0e4-3a6779db2fda"
/> | <img width="1233" alt="Screenshot 2025-01-24 at 9 27 49 AM"
src="https://github.com/user-attachments/assets/edc9c2ef-4ae0-4caf-a496-9887748673c9"
/> |

Release Notes:

- N/A

Danilo Leal created

f2c2ed0 Allow the context menu to take an `icon_color` (#23600)

Click to expand commit body 
Doing this to enable customization in the Assistant 2 context picker.

Release Notes:

- N/A

Danilo Leal created

813bbec Fix terminal memory leak by deduping alacritty events on background thread (#23593)

Click to expand commit body 
Closes #23008

Release Notes:

- Fixed case where the terminal can leak memory when it produces events
at a faster rate than could be processed.

Michael Sloan created

dd8ee76 docs: context_servers json example (#23588)

Shivam Mishra created

c55cdd0 assistant2: Add thread persistence (#23582)

Click to expand commit body 
This PR adds persistence for threads in Assistant2.

Threads are now persisted to an LMDB database.

Release Notes:

- N/A

Marshall Bowers created

fb63f61 search: Add heuristic for discarding matching of binary files (#23581)

Click to expand commit body 
Fixes #23398 
Closes #23398

We'll bail on searches of files that we know are binary (thus even if we
were to find a match in them, they'd be thrown away by buffer loader).

Release Notes:

- Improved project search performance in worktrees with binary files

Piotr Osiewicz created

35ddb43 assistant_context_editor: Put `use`s in the right spot (#23579)

Click to expand commit body 
This PR cleans up some `use` statements that weren't at the very top of
the module.

Release Notes:

- N/A

Marshall Bowers created

ec91a8d assistant2: Expose `ActiveThread::thread` via a getter (#23577)

Click to expand commit body 
This PR exposes the `thread` file on the `ActiveThread` via a getter
rather than exposing the field directly.

Release Notes:

- N/A

Marshall Bowers created

52494f3 Update some editor methods to instead take immutable references (#23578)

Click to expand commit body 
Makes the signatures more informative and can be more convenient as
multiple immutable borrows are allowed.

Release Notes:

- N/A

Michael Sloan created

9665336 Disable zeta predictions in assistant completion menu (#23573)

Click to expand commit body 
We don't want the zeta predictions entry to show in the assistant
context editor when completing slash commands. Zeta will still make
suggestions in the rest of the context editor, like the other providers
do.

Release Notes:

- N/A

Agus Zubiaga created

06f0f07 Autoscroll when running `editor: swap selection ends` (#23575)

Click to expand commit body 
Closes https://github.com/zed-industries/zed/issues/23512

Release Notes:

- Improved `editor: swap selection ends` by always scrolling the cursor
into view

Joseph T. Lyons created

d8c9fdd project: Revert project tree impl (again) (#23572)

Piotr Osiewicz created

2a2c332 docs: Document `ZED_DEVELOPMENT_AUTH` (#23571)

Click to expand commit body 
This PR adds documentation for the `ZED_DEVELOPMENT_AUTH` environment
variable, in the hopes that it helps folks find it sooner.

Release Notes:

- N/A

Marshall Bowers created

76bf468 ui: Don't add an `on_click` handler for disabled `ListItem`s (#23569)

Click to expand commit body 
This PR updates the `ListItem` component to not register an `on_click`
handler for `ListItem`s that are disabled.

When working on #23350 I noticed that even when the context menu entry
was disabled you could still click on the entry to fire the action.

Release Notes:

- Fixed some instances of disabled list items still registering clicks.

Marshall Bowers created

5ef5b75 Disable Copy Permalink context menu item when not in git repo (#23350)

Click to expand commit body 
Closes #13979

Please review this approach to hide the permalink, or alternatively to
disable it instead?

Release Notes:

- The Copy Permalink menu item is now disabled when not in a Git
repository.

---------

Co-authored-by: Marshall Bowers <git@maxdeviant.com>

Swiftaff and Marshall Bowers created

0ef53bf vim: Add support for ctrl-g (#23562)

Click to expand commit body 
Co-Authored-By: Jon Walstedt <jon@walstedt.se>

Closes #22094

Release Notes:

- vim: Added support for ctrl-g

Co-authored-by: Jon Walstedt <jon@walstedt.se>

Conrad Irwin and Jon Walstedt created

f38d0ff ollama: Set default max_tokens for llama3.3 (#23558)

Peter Tripp created

3dee32c inline completion: Add syntax highlighting for edit prediction (#23361)

Click to expand commit body 
Closes #ISSUE

Release Notes:

- N/A

---------

Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Agus <agus@zed.dev>

Bennet Bo Fenner , Antonio Scandurra , and Agus created

75ae4da Remove unwrap in GitTraversal::synchronize_statuses (#23555)

Click to expand commit body 
Release Notes:

- Fixed a potential panic in handling of Git statuses.

Co-authored-by: Marshall <marshall@zed.dev>

Cole Miller and Marshall created

1ac7da8 terraform: Bump to v0.1.2 (#23546)

Click to expand commit body 
Includes:
- https://github.com/zed-industries/zed/pull/22268

Peter Tripp created

469bfa7 scheme: Bump to v0.0.2 (#23545)

Click to expand commit body 
Includes:
- https://github.com/zed-industries/zed/pull/18728
- https://github.com/zed-industries/zed/pull/20206

Peter Tripp created

fb332a0 git_panel: Toggle stage all when clicking changes label (#23548)

Click to expand commit body 
When clicking the checkbox label fire the toggle action.

At first I wasn't sure this is what we wanted, but after looking at a
few existing implementations of checkboxes with labels it seems like
this is reasonably standard.

Eventually this piece of UI will be updated to a CheckboxWithLabel, but
for now it is custom due to some specific style requirements.

Release Notes:

- N/A

Nate Butler created

9e6b100 project: Bring back language servers in detached worktrees (#23530)

Click to expand commit body 
Closes #ISSUE

Release Notes:

- N/A

Piotr Osiewicz created

bb937b6 zig: Bump to v0.3.3 (#23547)

Click to expand commit body 
Includes:
- https://github.com/zed-industries/zed/pull/22609

Peter Tripp created

ea1a6a6 php: Bump to v0.2.4 (#23543)

Click to expand commit body 
Includes:
- https://github.com/zed-industries/zed/pull/23532
- https://github.com/zed-industries/zed/pull/22268

Peter Tripp created

63c5141 purescript: Bump to v0.1.0 (#23544)

Click to expand commit body 
Includes:
- https://github.com/zed-industries/zed/pull/15181
- https://github.com/zed-industries/zed/pull/16955
- https://github.com/zed-industries/zed/pull/22609

Peter Tripp created

26453a0 csharp: Bump to v0.1.1 (#23539)

Click to expand commit body 
Includes:
- https://github.com/zed-industries/zed/pull/22936

Peter Tripp created

a328c81 html: Bump to v0.1.5 (#23542)

Click to expand commit body 
Includes:
- https://github.com/zed-industries/zed/pull/20752
- https://github.com/zed-industries/zed/pull/22268

Peter Tripp created

9d6d98e haskell: Bump to v0.1.3 (#23541)

Click to expand commit body 
Includes:
- https://github.com/zed-industries/zed/pull/22609

Peter Tripp created

7d7db4d elixir: Bump to v0.1.4 (#23540)

Click to expand commit body 
Includes:
- https://github.com/zed-industries/zed/pull/22055
- https://github.com/zed-industries/zed/pull/22268

Peter Tripp created

79683eb php: Add nowdoc language injection (#23532)

Click to expand commit body 
We already have heredoc injection support, so this just extends it to also cover
[nowdoc](https://www.php.net/manual/en/language.types.string.php#language.types.string.syntax.nowdoc).

Ollie Beckwith created

0cb4175 llm: Sample ~10% of staff members inputs/outputs to LLM (#23537)

Click to expand commit body 
Release Notes:

- N/A

Thorsten Ball created

95c045a Fix LSP violation when dismissing server notifications (#23531)

Click to expand commit body 
Part of https://github.com/zed-industries/zed/issues/22606
Closes https://github.com/zed-industries/zed/issues/23509

When a user sees an odd notification from the language server like

<img width="508" alt="image"
src="https://github.com/user-attachments/assets/6f5ef1aa-0f09-4705-a02a-aaf81dd8620c"
/>

they usually dismiss that.

Zed uses channels to wait and handle user interactions with such
notifications, and, due to `?`, sends back
```json
{"jsonrpc":"2.0","id":1,"error":{"message":"receiving from an empty and closed channel"}}
```

which is not spec-compliant:
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showMessageRequest

> Response:
>
> * result: the selected
[MessageActionItem](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#messageActionItem)
| null if none got selected.
> * error: code and message set in case an exception happens during
showing a message.

Unfortunately, vtsls (and, potentially, others) crash if receive such
non-compliant requests, and do not get back.

After the fix, the message is correct:
```json
{"jsonrpc":"2.0","id":1,"result":null}
```


Release Notes:

- Fixed vtsls crashing on notification dismiss

Co-authored-by: Piotr Osiewicz <piotr@zed.dev>

Kirill Bulatov and Piotr Osiewicz created

f9e354e theme: Add version control colors (#23529)

Click to expand commit body 
This PR adds version control-specific theme tokens to the them to allow
styling entries in the git ui and elsewhere.

Release Notes:

- N/A

Nate Butler created

828b5ab project: Reorder LSP Adapters within LanguageRegistry (#23528)

Click to expand commit body 
Closes #ISSUE

Release Notes:

- N/A

Piotr Osiewicz created

11bb906 terminal: Check for script existence properly before activating it (#23476)

Click to expand commit body 
We were not covering a variant where the returned metadata was Ok(None)

Closes #ISSUE

Release Notes:

- Fixed venv activation script path showing up in terminal for
non-existant scripts.

Piotr Osiewicz created

91b0ca0 Omit `tsdk_path` from the servers' options if it does not exist (#23525)

Click to expand commit body 
Part of https://github.com/zed-industries/zed/issues/22606

Before, `tsdk_path` for vtsls and typescript-language-server
unconditionally set a `tsdk`/`tsserver` property for the corresponding
language server, even if there were no such directory at all.
Instead, make the corresponding code to omit such property if it was not
found on the FS.

Release Notes:

- Fixed "The path /.../tsserver.js doesn't point to a valid tsserver
install. Falling back to bundled TypeScript version." pop-up appearing

Kirill Bulatov created

d1be419 Fix panics on opening repositories with empty remotes (#23520)

Click to expand commit body 
Uses a newer `git2` version with
https://github.com/rust-lang/git2-rs/pull/1120 fix

Closes https://github.com/zed-industries/zed/issues/23453

Release Notes:

- Fixed panics on opening repositories with empty remotes

Kirill Bulatov created

70f8224 Update cloudflare/wrangler-action digest to 7a5f8bb (#23487)

Click to expand commit body 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[cloudflare/wrangler-action](https://redirect.github.com/cloudflare/wrangler-action)
| action | digest | `6d58852` -> `7a5f8bb` |

---

### Configuration

📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

Release Notes:

- N/A

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMDcuMCIsInVwZGF0ZWRJblZlciI6IjM5LjEwNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

renovate[bot] and renovate[bot] created

29b57de Update actions/stale digest to 5bef64f (#23486)

Click to expand commit body 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/stale](https://redirect.github.com/actions/stale) | action |
digest | `28ca103` -> `5bef64f` |

---

### Configuration

📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

Release Notes:

- N/A

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMDcuMCIsInVwZGF0ZWRJblZlciI6IjM5LjEwNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

renovate[bot] and renovate[bot] created

36c62bc Update Rust crate metal to 0.31 (#23508)

Click to expand commit body 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [metal](https://redirect.github.com/gfx-rs/metal-rs) |
workspace.dependencies | minor | `0.30` -> `0.31` |

---

### Configuration

📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

Release Notes:

- N/A

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMDcuMCIsInVwZGF0ZWRJblZlciI6IjM5LjEwNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

renovate[bot] and renovate[bot] created