8c7096f
Rename `model` based variable names to `entity` (#24198)
Click to expand commit body
## Context
While looking through the client crate, I noticed that some of the old
functions and variables were still using gpui::model name that was
deprecated during the gpui3 transition. This PR renames those instances
of model to entity to be more inline with gpui3.
In addition, I also renamed `model` to `entity` in cases found by the
below search terms given by @someone13574
- model = cx.
- model: Entity
- model: &Entity
- OpenedModelHandle
- model.update
- model.upgrade
- model = .*\.root (regex)
- parent_model
- model = cx.new
- cx.spawn(move |model
Release Notes:
- N/A
Anthony Eid
created
27d1c68
Avoid subtraction overflow when excerpt primary is outside of excerpt… (#24213)
Click to expand commit body
This fixes a "subtract with overflow" error that could happen in debug
mode when viewing the project diagnostics.
From git bisecting, I think that this behavior was introduced by
https://github.com/zed-industries/zed/pull/21942. It seems like it's
possible in some cases for the excerpt-expansion heuristic to cause the
excerpt's `context` range to start *after* the excerpt's `primary`
range. We should probably revisit that heuristic at some point, but it
also seems reasonable to handle that situation at this layer, rather
than overflowing.
Release Notes:
- N/A
Max Brunsfeld
created
4ab4e87
Fix a bug in GPUI, where AsyncApp::update wouldn't kick off a flush effects loop (#24208)
Click to expand commit body
Release Notes:
- N/A
Mikayla Maki
created
4f98157
edit predictions: Make Zed bar at least as wide as menu (#24206)
Click to expand commit body
Release Notes:
- N/A
---------
Co-authored-by: Ben <ben@zed.dev>
Agus Zubiaga
and
Ben
created
9b031d7
edit prediction: Use thin cursor for jump preview and gradients instead of ellipsis (#24202)
Click to expand commit body
https://github.com/user-attachments/assets/06e14893-c285-4cea-927c-75e82a378b15
Release Notes:
- N/A
---------
Co-authored-by: Ben <ben@zed.dev>
Agus Zubiaga
and
Ben
created
aea36f0
Prevent requesting more than 3 edit predictions per second (#24203)
cae712e
edit prediction: Try to expand context to parent treesitter region (#24186)
Click to expand commit body
Also send the `speculated_output` (which is just the editable region) to
the llm backend
Closes #ISSUE
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Bennet Bo Fenner
and
Antonio Scandurra
created
bce9a9a
windows: Use setup-dev-driver.ps1 to create dev driver (#24196)
Click to expand commit body
Closes #ISSUE
Release Notes:
- N/A
张小白
created
c50cb90
Revert "Upgrade to rustls v0.23.22" (#24197)
Click to expand commit body
Reverts zed-industries/zed#24138
Nightly build failed, I believe because of this.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95189

CC: @ConradIrwin
Release Notes:
- N/A
Peter Tripp
created
a0269ab
theme_selector: Add a button to open the extension store (#24195)
Click to expand commit body
Adds a button to the theme selector to help people find more themes in
the extension store.

Release Notes:
- Added a way to access the extension store from the theme selector to
make it easier to find new themes.
It should be 200k (with 100k output). I can't find anything that puts it
at 20k and the changeover in
https://github.com/zed-industries/zed/commit/2f8237492641b4c97f61977a39f8a10225578a6d
only changed the name from o1-mini to o3-mini
References:
*
https://docs.github.com/en/copilot/using-github-copilot/asking-github-copilot-questions-in-github#ai-models-for-copilot-chat
* https://github.com/marketplace/models/azure-openai/o3-mini
* https://platform.openai.com/docs/models#o3-mini
Release Notes:
- Corrected Github Copilot o3-mini context length
---------
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
This reverts commit eb820ab800ea2a0023667b5c0eb91daa7c9ab084.
The previous PR broke manual completions. Turns out there is more
confusing behavior then i realized, will follow up with another PR soon.
Closes #ISSUE
Release Notes:
- N/A
Closes https://github.com/zed-industries/zed/issues/10192 , again.
Release Notes:
- Fixed multiple save modals appearing when app is being closed multiple
times
Kirill Bulatov
created
386cfac
zeta: Fix data collection display on the status bar menu (#24177)
Click to expand commit body
Follow-up to: https://github.com/zed-industries/zed/pull/24031
This PR adds a new function that allows the UI also to display the state
of the data collection. Previously, we only showed that if the project
adhered to the `is_open_source` condition. Now, we show it for all
projects.
Release Notes:
- N/A
Danilo Leal
created
e5c3273
status_bar: Only show divider for left dock (#24178)
Click to expand commit body
Follow up to https://github.com/zed-industries/zed/pull/24114
Just fixing the UI so that the divider only shows for the
left-positioned items.
Release Notes:
- N/A
Danilo Leal
created
556b0eb
Show larger jump target preview + add ellipsii to indicate truncation (#24179)
Agus Zubiaga
,
Danilo
,
Danilo Leal
, and
João Marcos
created
29e559d
Fix display of `+` between modifiers on linux and windows (#24173)
Click to expand commit body
Regressions in #24024:
* `+` was no longer included between modifiers and key
* Multi-character keys like "control" were displayed all lowercase,
whereas before they were all uppercase like "CONTROL". Now they are
capitalized, so "Control".
* Brings back icon for tab key.
Release Notes:
- N/A
We now treat new files that have no content as not-dirty. This fixes the
git diff view when deleted files are present.
It also fixes a long-standing bug where `zed RAEDME` and then closing
the tab would prompt for "unsaved changes" when there were none.
Release Notes:
- Fixed a bug where closing an empty, named, file would warn about
unsaved content.
Conrad Irwin
created
66e0898
Fix corner case where edit prediction preview and docs aside overlap (#24170)
Click to expand commit body
+ add docs and simplify logic around popover order
Release Notes:
- N/A
Release Notes:
- Fix display, revert and undo of deleted hunks when the file is empty.
Conrad Irwin
created
8bce896
Invalidate GPUI views regardless of draw phase (#24164)
Click to expand commit body
We think this could fix issues around view invalidation during focus
handling.
I want to run CI on this and see.
cc @mikayla-maki @maxbrunsfeld
Release Notes:
- N/A
Nathan Sobo
created
ea66a54
Skip COMMIT_EDITMSG contents when opening the file (#24146)
daf09fa
Fix issue where changing the case of a vim object would be clipped at the end of the line (#24163)
Click to expand commit body
Co-authored-by: Conrad Irwin <conrad@zed.dev>
Closes #24124
Release Notes:
- Fixed an issue in vim mode where changing the case of an object at the
end of the line would not change the case of the last character in the
object
Co-authored-by: Conrad Irwin <conrad@zed.dev>
Ben Kunkle
and
Conrad Irwin
created
8742c18
Allow auto-indenting with syntax errors when using regex-based indent matches to improve bash auto-indent behavior (#24160)
Click to expand commit body
- Fixes auto-indent issues around `elif` caused by auto-indent being prevented due to syntax errors generated before `elif` clause completed
Release Notes:
- Fixed an issue where inserting an elif before an else in bash would
not properly auto-indent
---------
Co-authored-by: Conrad Irwin <conrad@zed.dev>
Closes #ISSUE
Release Notes:
- vim: Add `ctrl-w a` to close all items in the current pane
Conrad Irwin
created
e17f307
vim: Load keymap after base keymap (#24161)
Click to expand commit body
Closes #22562
Release Notes:
- vim: Load vim keymap after a user-configured keymap
Conrad Irwin
created
3d3ac2c
vim: Fix `ctrl-w ctrl-q` and `ctrl-w ctrl-c` to close active pane instead of all panes (#24018)
Click to expand commit body
According to vim `ctrl-w ctrl-q` should close the active tab or pane
similar to :q

Release Notes:
- vim: fix `ctrl-w ctrl-q` to close active pane instead of all panes
Saurabh
created
0919f10
chore: Remove moot file from #23901 (#24159)
Creates an indents.scm file for bash and adds regexes for
`{increase,decrease}_indent_pattern` in
`crates/languages/src/bash/config.toml`
so that autoindent works as expected in bash
Note that this PR does not attempt to handle all cases where indenting
might be desired in bash. I am aiming to support ~80% of what people
want while avoiding the more gnarly/edge cases like indented blocks in
case statements and indenting for associative arrays.
This is done with the explicit hope that someone (possibly from the
community) more familiar with and passionate about bash can come through
at a later date and handle those cases
Closes #23628
Release Notes:
- Add basic support for autoindent functionality in bash/shell files
Ben Kunkle
created
dfd11c3
docs: Add docs for icon theme extensions (#24155)
Click to expand commit body
This PR adds docs for icon themes.
Release Notes:
- N/A
Marshall Bowers
created
28b8045
Fix missing modifier changed events on Linux X11 (#24154)
Click to expand commit body
Release Notes:
- Fixed some modifier changed events not being present on Linux X11.
This affected things like the project search palette, where holding ctrl
would not cause the split options to appear.
Michael Sloan
created
13b7be1
themes: Make background colors partly transparent by default (#24151)
Click to expand commit body
Certain themes define the `created` and `deleted` status colors, but not
`created_background` and `deleted_background`. Previously, Zed would use
`created` and `deleted` colors, and apply a hard-coded opacity change,
but *not* use `created_background` and `deleted_background`, but that
behavior was inadvertently changed in
https://github.com/zed-industries/zed/pull/22994.
This PR restores the old behavior as a fallback. If a theme defines a
status color, but not the corresponding background color, we'll use a
75% transparent version of the foreground color as a fallback.
Release Notes:
- Fixed an issue in certain themes where diffs would render with the
wrong red and green colors for deletions and insertions.
Max Brunsfeld
created
e2d6d4b
docs: Update link to Scheme extension (#24148)
Click to expand commit body
This PR updates the link to the Scheme extension in the docs, as it was
moved to a separate repo in #24078.
Release Notes:
- N/A
Marshall Bowers
created
1ec91a8
Clip points when searching for `@` in the Assistant 2 panel (#24147)
Click to expand commit body
Release Notes:
- N/A
Kirill Bulatov
created
11e095b
Fix editor edited event property field name (#24145)
This adds a new version of the project diff editor to go alongside the
new git panel.
The basics seem to be working, but still todo:
* [ ] Fix untracked files
* [ ] Fix deleted files
* [ ] Show commit message editor at top
* [x] Handle empty state
* [x] Fix panic where locator sometimes seeks to wrong excerpt
Release Notes:
- N/A
This will help us debug a panic we're seeing in their internals.
In order to make this work, I've temporarily forked async-tls with:
https://github.com/async-rs/async-tls/pull/59/files
Closes #ISSUE
Release Notes:
- N/A
Conrad Irwin
created
a8741dc
Migrate more events to telemetry::event! macro (#24102)
Click to expand commit body
I believe this takes care of the remaining events running through the
old flow that requires transformation at the collab server level. I
think all events are now going through `telemetry::event!()`.
For anyone curious where the new telemetry names are coming from, you
can check the `for_snowflake` function within
`crates/collab/src/api/events.rs`, to see how collab is currently
transforming the events going through the old flow.
Release Notes:
- N/A
Joseph T. Lyons
created
a864168
Enable collaborating editing of the commit message input inside the git panel (#24130)
Click to expand commit body
https://github.com/user-attachments/assets/200b88b8-249a-4841-97cd-fda8365efd00
Now all users in the collab/ssh session can edit the commit input
collaboratively, observing each others' changes live.
A real `.git/COMMIT_EDITMSG` file is opened, which automatically enables
its syntax highlight, but its original context is never used or saved on
disk — this way we avoid stale commit messages from previous commits
that git places there.
A caveat: previous version put some effort into preserving unfinished
commit messages on repo swtiches, but this version would not do that
— instead, it will be blank on startup, and use whatever
`.git/COMMIT_EDITMSG` contents on repo switch
Release Notes:
- N/A
---------
Co-authored-by: Cole Miller <cole@zed.dev>
Kirill Bulatov
and
Cole Miller
created
6b48a6e
workspace: Respect minimized state when deserializing workspaces (#24127)
Click to expand commit body
Fixes a regression from #24015 pointed out in #24093
Closes #24093
Release Notes:
- N/A
Add support for go fuzz tests.
Closes #23809
Release Notes:
- N/A
---------
Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>