3cfaadd
zed 0.181.2
Joseph T. Lyons created
3cfaadd
zed 0.181.2
Joseph T. Lyons created
b69219e
agent: Add token count in the thread view (#28037)
This PR adds the token count to the active thread view. It doesn't behaves quite like Assistant 1 where it updates as you type, though; it updates after you submit the message. <img src="https://github.com/user-attachments/assets/82d2a180-554a-43ee-b776-3743359b609b" width="700" /> --- Release Notes: - agent: Add token count in the thread view --------- Co-authored-by: Agus Zubiaga <hi@aguz.me>
Danilo Leal and Agus Zubiaga created
0ae3518
Fix soft-wrapping with fold creases (#28029)
Release Notes: - Fixed a rendering bug that caused context in the agent to not wrap properly. --------- Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com> Co-authored-by: Zed AI <ai+claude-3.7@zed.dev>
Antonio Scandurra , Conrad Irwin , and Zed AI created
7396435
agent: Handle tool use without text (#28030)
### Context The Anthropic API fails if a request message contains a tool use and no `Text` segments or it only contains empty `Text` segments. These are cases that the model itself produces, but the API doesn't support sending them back. #27917 fixed this by appending "Using tool..." in the thread's message, but this causes the actual conversation to include it, so it would appear in the UI (we would actually display a gap because we never rendered its markdown, but "Using tool..." would show up when the thread was restored). ### Solution We'll now only append this placeholder when we build the request, so the API still sees it, but the UI/Thread doesn't. Another issue we found is that the model starts mimicking these placeholders in later tool uses which is undesirable. So unfortunately, we had to add logic to filter them out. Release Notes: - agent: Improved rendering of tool uses without text --------- Co-authored-by: Bennet <bennet@zed.dev>
Agus Zubiaga and Bennet created
bf6e7cb
agent: Add button to continue iterating once all reviews are done (#28027)
This PR adds a button on the review tab empty state that toggles the focus back to the agent panel so that users can keep iterating on the thread that's active in the panel. <img src="https://github.com/user-attachments/assets/ace5cf93-8869-49bb-8106-e03a9e3c90f2" width="700"/> Release Notes: - N/A
Danilo Leal created
36c4f60
zed 0.181.1
Joseph T. Lyons created
3d032bc
agent: Fix thinking step showing up as pending when completion is cancelled (#28019)
Previously the "Thinking..." step would show up as pending, even though the user cancelled the generation: <img width="672" alt="image" src="https://github.com/user-attachments/assets/c9cdce0a-d827-4e23-96f5-b150465911a7" /> Release Notes: - Fixed an issue where the thinking step would show up as pending even when the generation was cancelled
Bennet Bo Fenner created
3e28fa2
agent: Include active file in recent history (#27914)
This happened because of two reasons: - `Workspace::recent_navigation_history` didn't include the current file - The context picker added the current file to a exclude list The latter was actually intentional because we already show the file in the suggested context, but now that we actually have mentions, it's just inconvenient not to have it there. Release Notes: - N/A
Agus Zubiaga created
c424429
workspace-hack: remove openssl from remote_server (#27990)
This was accidentally getting added due to increased feature unification. We've manually excluded reqwest to go back to the desired behavior: remote_server, doesn't depend on openssl. Release Notes: - N/A Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
Julia Ryan and Mikayla Maki created
f23b972
Add workspace-hack (#27277)
This adds a "workspace-hack" crate, see [mozilla's](https://hg.mozilla.org/mozilla-central/file/3a265fdc9f33e5946f0ca0a04af73acd7e6d1a39/build/workspace-hack/Cargo.toml#l7) for a concise explanation of why this is useful. For us in practice this means that if I were to run all the tests (`cargo nextest r --workspace`) and then `cargo r`, all the deps from the previous cargo command will be reused. Before this PR it would rebuild many deps due to resolving different sets of features for them. For me this frequently caused long rebuilds when things "should" already be cached. To avoid manually maintaining our workspace-hack crate, we will use [cargo hakari](https://docs.rs/cargo-hakari) to update the build files when there's a necessary change. I've added a step to CI that checks whether the workspace-hack crate is up to date, and instructs you to re-run `script/update-workspace-hack` when it fails. Finally, to make sure that people can still depend on crates in our workspace without pulling in all the workspace deps, we use a `[patch]` section following [hakari's instructions](https://docs.rs/cargo-hakari/0.9.36/cargo_hakari/patch_directive/index.html) One possible followup task would be making guppy use our `rust-toolchain.toml` instead of having to duplicate that list in its config, I opened an issue for that upstream: guppy-rs/guppy#481. TODO: - [x] Fix the extension test failure - [x] Ensure the dev dependencies aren't being unified by Hakari into the main dependencies - [x] Ensure that the remote-server binary continues to not depend on LibSSL Release Notes: - N/A --------- Co-authored-by: Mikayla <mikayla@zed.dev> Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
Julia Ryan , Mikayla , and Mikayla Maki created
07d9cd7
agent: Update thread label to use plural form (#27971)
Update thread label to match the other contexts. |Before|After| |--|--| ||| Release Notes: - N/A
5brian created
a482387
agent: Allow editing previous messages (#27965)
This PR adds the ability to edit previous user messages in the thread. Release Notes: - Agent: Added the ability to edit previous user messages (Preview-only).
Marshall Bowers created
d17d747
agent: Change loading label if command is waiting on permission (#27955)
If there's a command pending confirmation, the label changes from "Generating" to "Waiting for confirmation". <img src="https://github.com/user-attachments/assets/d804e382-5315-40b0-9588-c257cca2430c" width="600"/> Release Notes: - N/A
Danilo Leal created
bc08df2
agent: Refine feedback message input (#27948)
<img src="https://github.com/user-attachments/assets/cde37a88-9973-4c27-80b7-459f5e986c74" width="650" /> Release Notes: - N/A --------- Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Danilo Leal and Bennet Bo Fenner created
0f4b734
aws_http_client: Copy response headers (#27941)
Preemptive fixes required for #26734 Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Shardul Vaidya and Marshall Bowers created
6df29d3
agent: Do some cleanup of feedback comments submission (#27940)
This PR does some stylistic cleanup of the feedback comments submission code. Release Notes: - N/A
Marshall Bowers created
647cca8
Use worktree qualified paths in agent file context + some code cleanup (#27943)
Release Notes: - N/A
Michael Sloan created
1f81674
v0.181.x preview
Joseph T. Lyons created
e1a8a31
Fix flickering when staging and unstaging files (#27931)
This fixes a bug in #27568 that caused flickering in the git panel's checkbox state when staging and unstaging entire files. The problem is that that stage/unstage action first saves the target path (if it's open as a buffer), and we do a targeted git status scan in response to that filesystem event, which makes its way to the git panel and causes it to clear its pending state before the actual stage or unstage has gone through. The fix is to not clear the panel's pending state for git repository events that originated from a targeted scan (i.e. one that was triggered by FS events for repo paths, as opposed to events inside `.git` which cause all statuses to be recomputed). Release Notes: - N/A
Cole Miller created
0be8bf1
agent: Improve action confirmation UX (#27932)
This PR makes the command permission prompt part of the tool card and allow users to straight away change the `always_allow_tool_actions` setting via the "Always Allow" button from that card. If that button is clicked, that setting is turned on, and any command that requires permission from that point on will auto-run. Additionally, if a bash command spans multiple lines, we show the line count at the end of the command string. (Note: this is not perfect yet because it can likely be not visible by default, but we didn't think this was a major blocker for now. We'll work on improving this next). ### Thread View <img src="https://github.com/user-attachments/assets/00f93c39-990f-4b79-84ec-0427b997167f" width="500"/> ### Settings View <img src="https://github.com/user-attachments/assets/52d32435-7c8d-4ab4-a319-6cabc007267b" width="500"/> Release Notes: - N/A --------- Co-authored-by: Thomas Mickley-Doyle <tmickleydoyle@gmail.com> Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de> Co-authored-by: Nathan Sobo <nathan@zed.dev> Co-authored-by: Antonio Scandurra <me@as-cii.com>
Danilo Leal , Thomas Mickley-Doyle , Bennet Bo Fenner , Nathan Sobo , and Antonio Scandurra created
3e2ac3e
Log error and proceed when failing to load repo environment (#27938)
Closes #ISSUE Release Notes: - N/A
Cole Miller created
646f655
agent: Add newtype for profile IDs (#27939)
This PR adds an `AgentProfileId` newtype for profile IDs that we can use instead of `Arc<str>` everywhere. Release Notes: - N/A
Marshall Bowers created
b2904e5
file_finder: Prioritize file name matches over path matches (#27937)
Closes https://github.com/zed-industries/zed/issues/27936 Adds additional comparison after the existing history-based comparison. This comparison checks whether the first position matched via fuzzy search is in the file name. If so, we prioritize this match over one in the path. If both items match either the file name or the path, the existing comparison logic is used. - [x] Tests Before: <img width="580" alt="image" src="https://github.com/user-attachments/assets/011fdd01-3dfa-4950-abb1-dfda10885664" /> After: <img width="614" alt="image" src="https://github.com/user-attachments/assets/9c4944b0-83dc-4611-94bb-aae1758fab23" /> Release Notes: - Fixed an issue where fuzzy matching in file finder did not properly prioritize matches in file names.
Smit Barmase created
45e7cd1
Add comment box to negative feedback reaction (#27934)
Release Notes: - N/A
Thomas Mickley-Doyle created
889bc13
language_model: Remove `use_any_tool` method from `LanguageModel` (#27930)
This PR removes the `use_any_tool` method from the `LanguageModel` trait. It was not being used anywhere, and doesn't really fit in our new tool use story. Release Notes: - N/A
Marshall Bowers created
da3383b
agent: Fix thinking step showing up as pending even though it is completed (#27926)
Release Notes: - N/A
Bennet Bo Fenner created
9c4e61e
agent: Add more guidelines to system prompt (#27927)
Release Notes: - N/A
Agus Zubiaga created
b413605
Fix bug that prevented deletion-only hunks from being kept correctly (#27921)
Release Notes: - N/A
Antonio Scandurra created
961bfad
agent: Return an error to the model when trying to use a tool that is disabled (#27928)
This PR makes it so we return an error to the model if it tries to use a tool that is not currently enabled: <img width="628" alt="Screenshot 2025-04-02 at 11 10 55 AM" src="https://github.com/user-attachments/assets/e4bdf01c-f0ea-4c9c-805a-11868bd9c771" /> This allows the model to adapt based on that: <img width="637" alt="Screenshot 2025-04-02 at 11 08 38 AM" src="https://github.com/user-attachments/assets/41016b47-933c-4dcb-b791-847be0548c8a" /> Release Notes: - N/A
Marshall Bowers created
2eed94f
agent: Include context with first message that introduced it (#27925)
We were including the context at the end which meant it never got cached. We'll now include it with the first message that introduced it so it's cached as long as it doesn't change. This is an improvement, but we probably still need to think of ways to optimize caching for cases where files in context change. Release Notes: - N/A
Agus Zubiaga created
7a54dd7
Avoid requiring confirmation for tools that edit buffers (#27923)
It's super easy to undo those changes. In a future PR, we should also avoid requiring confirmation in the batch tool if all the underlying tools don't require confirmation. Release Notes: - N/A
Antonio Scandurra created
8ac4cbc
Don't create repos for invisible worktrees (#27894)
Closes #ISSUE Release Notes: - Fixed git repositories being added for files outside the project
Cole Miller created
d82bf13
agent: Remove unneeded branch in `use_pending_tools` (#27922)
This PR removes an unneeded `else if` branch that was the same as the previous branch in the conditional. Doesn't seem necessary to run this twice. Release Notes: - N/A
Marshall Bowers created
0f58d4f
agent: Remove duplicate `OpenConfiguration` action registration (#27918)
I had introduced the same thing a few days ago without noticing there was one in place already! Release Notes: - N/A
Danilo Leal created
d340670
Ensure rejecting a hunk dismisses the diff (#27919)
Release Notes: - N/A
Antonio Scandurra created
ad42a8a
agent: Adjust permission card design (#27911)
<img src="https://github.com/user-attachments/assets/76ae380c-6d5b-4ed6-9b47-9a4c44b00042" width="500" /> Release Notes: - N/A
Danilo Leal created
2846c55
agent: Account for tool use messages without any corresponding text (#27917)
This PR makes it so if we receive a tool use from the model without any corresponding text, we'll insert some placeholder text to keep the conversation in a well-structured format. This aims to fix an error that Antonio was seeing:  Release Notes: - N/A
Marshall Bowers created
5dcd0d3
language_models: Denote Copilot Chat as not supporting tools (#27909)
This PR updates the Copilot Chat language model to indicate it does not yet support tool use in Zed. Release Notes: - N/A
Marshall Bowers created
a70daa4
agent: Update tool names in default profiles to reflect snake_cased rename (#27907)
This PR updates the tool names in the default profiles, as they were not updated after the tool names were changed to snake_case in #27903. Release Notes: - N/A
Marshall Bowers created
b158ee6
Fix Gemini function calling (#27905)
This seems to improve the performance of `gemini-2.5-pro-exp-03-25`
significantly.
We know define a single `Tool` that has multiple `FunctionDeclaration`s,
instead of defining multiple `Tool`s with a single
`FunctionDeclaration`.
Oddly enough the `flash` models seemed to work perfectly fine with the
multiple `Tool { ... }` definitions
Release Notes:
- N/A
Bennet Bo Fenner created
9b7b4a9
assistant2: Use snake_case for tool names (#27903)
The [Gemini docs](https://ai.google.dev/gemini-api/docs/function-calling?example=weather#function_declarations) state that function names should be in `snake_case` or `camelCase`. Release Notes: - N/A
Bennet Bo Fenner created
c1d6dfd
Update selection when keeping/rejecting hunks (#27902)
Release Notes: - N/A
Antonio Scandurra created
57d7bc2
vim: Add `g?` convert to `Rot13`/`Rot47` (#27824)
Release Notes: - Added `g?` convert to `Rot13`/`Rot47` --------- Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
0x2CA and Conrad Irwin created
7bc0dd1
Don't unwrap on bad zstd data (#27891)
Closes #ISSUE Release Notes: - N/A
Conrad Irwin created
dc83f1a
Rename `assistant2` to `agent` (#27887)
This PR renames the `assistant2` crate to `agent`. Release Notes: - N/A
Marshall Bowers created
8e0f70f
Bump revision for `livekit-rust-sdks` (#27886)
This PR bumps the revision of the `livekit-rust-sdks` crate. I was running into issue where Cargo was stuck on "Updating git submodule `https://chromium.googlesource.com/libyuv/libyuv`". I resolved the issue by forking `libyuv` to https://github.com/zed-industries/libyuv and updating our `livekit-rust-sdks` fork to use it in https://github.com/zed-industries/livekit-rust-sdks/pull/4. Release Notes: - N/A
Marshall Bowers created
6262a46
Fix a bug that prevented repositories from being deduplicated (#27884)
Closes #ISSUE Release Notes: - Ensure that only one repository is shown in the git UI when two subdirectories of a repository root are open in Zed
Cole Miller created
8321e65
Bump tree-sitter-rust to 0.24 (#27875)
Release Notes: - Added correct syntax highlighting for use bounds and async closures in Rust.
Max Brunsfeld created
4110928
nix: Clean up build (#27881)
- bump our livekit version to include a fix for a crane bug (TODO: add link when an issue is filed on crane) - switch to a clang stdenv for both linux and macos - manually unify versions of our notify crate - remove old linker flags which were only needed for livekit - fix an issue where RUSTFLAGS shadowed the rustflags from cargo configs Release Notes: - N/A
Julia Ryan created
a1b53e9
git: Use doc comments for `ResetMode` variants (#27882)
This PR updates the `ResetMode` enum to use doc comments for its variants instead of line comments. Release Notes: - N/A
Marshall Bowers created