17a271d
Revert to fix panic in inline assistant (#28428)
Click to expand commit body
This reverts commit f12a554f86fa1e2b9b937a9dd103aa7c9a019db9, which
introduced a panic in inline assistant (cc @mgsloan) - I'm not sure what
the motivation was for that change, but I figure we can revert to fix
the inline assistant now and deal with that later. 😄
Panic was:
> Thread "main" panicked with "cannot read workspace::Workspace while it
is already being updated" at
/Users/rtfeldman/code/zed/crates/gpui/src/app/entity_map.rs:139:32
Release Notes:
- N/A
b9aa296
Add reminder message about system prompt (#28344)
Click to expand commit body
Trying out sending the model a reminder message about code blocks in the
system prompt. If this seems to work well, we can include more specific
reminder messages, e.g. tool-specific ones.
Release Notes:
- N/A
A small addition for those coming from JetBrain's IDEs. A behavioral
detail: when any upper case character is detected, the command defaults
to toggling to lower case.
> Note that when you apply the toggle case action to the CamelCase name
format, IntelliJ IDEA converts the name to the lower case.
https://www.jetbrains.com/help/idea/working-with-source-code.html#edit_code_fragments
Release Notes:
- Added an `editor: toggle case` command. Use `cmd-shift-u` for macOS
and `ctrl-shift-u` for Linux, when using the `JetBrains` keymap.
Joseph T. Lyons
created
c441b65
debugger: Add support for CodeLLDB (#28376)
Click to expand commit body
Closes #ISSUE
Release Notes:
- N/A
Piotr Osiewicz
created
61ddcd5
chore: Add workspace-hack dependency to agent_rules (#28412)
Click to expand commit body
Closes #ISSUE
Release Notes:
- N/A
Piotr Osiewicz
created
f12a554
Use `Project` instead of `Workspace` in `ContextStore` (#28402)
Click to expand commit body
Release Notes:
- N/A
Michael Sloan
created
9dae4d8
Remove references to SSH remoting beta (#28399)
Click to expand commit body
Release Notes:
- N/A
Cole Miller
created
f0b7f35
Clean up environment loading a bit (#28356)
Click to expand commit body
Closes #ISSUE
Release Notes:
- N/A
Cole Miller
created
b687a5e
git: Always reload current branch after pushing (#28327)
Click to expand commit body
Closes #27347
Release Notes:
- Fixed a bug causing the git panel to not update after pushing to a
remote
Cole Miller
created
e66a24e
format: Re-implement support for formatting with code actions that contain commands (#28392)
Click to expand commit body
Closes #27692
Closes #27935
Release Notes:
- Fixed a regression where code-actions used when formatting on save
were rejected if they contained commands
Ben Kunkle
created
301fc7c
Pull out plain rules file loading code into a new `agent_rules` crate (#28383)
Click to expand commit body
Also renames for rules file templated into the system prompt
Release Notes:
- N/A
Michael Sloan
created
020a107
Add the project search as an item in the status bar (#28388)
Click to expand commit body
Was chatting with @wilhelmklopp, he pointed out that our current
UI-accessible way to access the project search was pretty obscure.
<img width="393" alt="Screenshot 2025-04-08 at 6 57 51 PM"
src="https://github.com/user-attachments/assets/636053cd-5a88-4a5e-8155-6d41d189b7db"
/>
Release Notes:
- Added a button to open the project search to the status bar
Follow-up of https://github.com/zed-industries/zed/pull/28359
Release Notes:
- N/A
Kirill Bulatov
created
c05bf09
Merge `Component` and `ComponentPreview` trait (#28365)
Click to expand commit body
- Merge `Component` and `ComponentPreview` trait
- Adds a number of component previews
- Removes a number of stories
Release Notes:
- N/A
Nate Butler
created
b15ee1b
Add dedicated actions for `LSP` completions insertion mode (#28121)
Click to expand commit body
Adds actions so you can have customized keybindings for `insert` and
`replace` modes.
And add `shift-enter` as a default for `replace`, this will override the
default setting
`completions.lsp_insert_mode` which is set to `replace_suffix`, which
tries to "smartly"
decide whether to replace or insert based on the surrounding text.
For those who come from VSCode, if you want to mimic their behavior, you
only have to
set `completions.lsp_insert_mode` to `insert`.
If you want `tab` and `enter` to do different things, you need to remap
them, here is
an example:
```jsonc
[
// ...
{
"context": "Editor && showing_completions",
"bindings": {
"enter": "editor::ConfirmCompletionInsert",
"tab": "editor::ConfirmCompletionReplace"
}
},
]
```
Closes #24577
- [x] Make LSP completion insertion mode decision in guest's machine
(host is currently deciding it and not allowing guests to have their own
setting for it)
- [x] Add shift-enter as a hotkey for `replace` by default.
- [x] Test actions.
- [x] Respect the setting being specified per language, instead of using
the "defaults".
- [x] Move `insert_range` of `Completion` to the Lsp variant of
`.source`.
- [x] Fix broken default, forgotten after
https://github.com/zed-industries/zed/pull/27453#pullrequestreview-2736906628,
should be `replace_suffix` and not `insert`.
Release Notes:
- LSP completions: added actions `ConfirmCompletionInsert` and
`ConfirmCompletionReplace` that control how completions are inserted,
these override `completions.lsp_insert_mode`, by default, `shift-enter`
triggers `ConfirmCompletionReplace` which replaces the whole word.
João Marcos
created
0459b1d
Fix panic when a file in a path-based multibuffer excerpt is renamed (#28364)
Click to expand commit body
Closes #ISSUE
Release Notes:
- Fixed a panic that could occur when paths changed in the project diff.
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Cole Miller
and
Conrad Irwin
created
246013c
tab_switcher: Add keybind to close tab tooltip (#27212)
(and any other LSP server in theory, if it exposes any LSP-ext endpoint
for the same)
Closes https://github.com/zed-industries/zed/issues/16160
* adds a way to disable tree-sitter tasks (the ones from the plugins,
enabled by default) with
```json5
"languages": {
"Rust": "tasks": {
"enabled": false
}
}
}
```
language settings
* adds a way to disable LSP tasks (the ones from the rust-analyzer
language server, enabled by default) with
```json5
"lsp": {
"rust-analyzer": {
"enable_lsp_tasks": false,
}
}
```
* adds rust-analyzer tasks into tasks modal and gutter:
<img width="1728" alt="modal"
src="https://github.com/user-attachments/assets/22b9cee1-4ffb-4c9e-b1f1-d01e80e72508"
/>
<img width="396" alt="gutter"
src="https://github.com/user-attachments/assets/bd818079-e247-4332-bdb5-1b7cb1cce768"
/>
Release Notes:
- Added tasks from rust-analyzer
Kirill Bulatov
created
763cc6d
Tell the model not to act on TODO type comments (#28358)
Click to expand commit body
Release Notes:
- Adjusted system prompt to direct it to never act on TODO-type comments
it encounters, unless the user directly asked it to do so or they relate
to the current task at hand.
Joseph T. Lyons
created
0b75c13
chore: Replace as_any functions with trait upcasting (#28221)
Click to expand commit body
Closes #ISSUE
Release Notes:
- N/A
Piotr Osiewicz
created
38ec450
project: Workaround invalid code action edits from pyright (#28354)
Click to expand commit body
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-authored-by: Piotr Osiewicz <piotr@zed.dev>
fixes issue where:
In a two line python file like so
```
Path()
```
If the user asks for code actions on `Path` and they select (`From
pathlib import path`)
the result they get is
```
Pathfrom pathlib import Path
Path()
```
Instead of
```
from pathlib import Path
Path()
```
This is due to a non-lsp-spec-compliant response from pyright below
```json
{"jsonrpc":"2.0","id":40,"result":[{"title":"from pathlib import Path","edit":{"changes":{"file:///Users/neb/Zed/example-project/pyright-project/main.py":[{"range":{"start":{"line":2,"character":0},"end":{"line":2,"character":4}},"newText":"Path"},{"range":{"start":{"line":2,"character":0},"end":{"line":2,"character":0}},"newText":"from pathlib import Path\n\n\n"}]}},"kind":"quickfix"}]}
```
Release Notes:
- Fixed an issue when using auto-import code actions provided by pyright
(or basedpyright) where the import would be jumbled with the scoped
import resulting in an invalid result
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Ben Kunkle
,
Max Brunsfeld
, and
Anthony Eid
created
97641c3
Use tree-sitter when returning symbols to the model for a given file (#28352)
Click to expand commit body
This also increases the threshold for when we return an outline during
`read_file`.
Release Notes:
- Fixed an issue that caused the agent to fail reading large files if
the LSP hadn't started yet.
Antonio Scandurra
created
ca8f6e8
Tell the model not to remove tests (#28349)
Click to expand commit body
Release Notes:
- Adjusted system prompt to direct it to never remove tests as a way to
have the test suite pass, unless the user directly asks for test
removal.
Joseph T. Lyons
created
db53da4
debugger: Respect initialize_args from user profiles (#28347)
Click to expand commit body
Closes #ISSUE
Release Notes:
- N/A
Co-authored-by: Ben Kunkle <ben.kunkle@gmail.com>
Piotr Osiewicz
and
Ben Kunkle
created
df94dcd
ci: Only run workspace_hack when tests run (#28346)
Click to expand commit body
Skip `workspace_hack` for PRs that don't trigger tests (docs-only,
.github issue templates, etc).
Release Notes:
- N/A
Peter Tripp
created
1c85901
Tell the model not to create .bak files (#28244)
Click to expand commit body
Release Notes:
- Adjusted system prompt to avoid having the agent create backup files
unnecessarily.
Make various improvements to our github issue templates.
- Adjust line lengths to not wrap in constrained new issue view (85
cols) not just full screen view (95 columns)
- Remove reference to drag/drop logs to upload (recently multiple issues
with dead upload links)
- Cleanup list view
Release Notes:
- N/A
Peter Tripp
created
feafad2
Improve comments on shader code for dashed borders (#28341)
Click to expand commit body
Improvements from going over the code with @as-cii
Release Notes:
- N/A
Michael Sloan
created
86ef000
pylsp: Upgrade existing installation if possible (#28338)
Click to expand commit body
Closes #ISSUE
Release Notes:
- Zed-managed pylsp installations will now correctly upgrade themselves
Piotr Osiewicz
created
9e8afa8
Fix local task dropped on the wrong thread (#28290)
Click to expand commit body
Release Notes:
- Fixed a panic during shutdown of the remote server
Conrad Irwin
created
698cdc4
agent: Display "generating" label in the active thread (#28297)
Click to expand commit body
Release Notes:
- N/A
---------
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
The bash tool will now truncate its output to 8192 bytes (or the last
newline before that).
We also added a global limit for any tool that produces a clearly large
output that wouldn't fit the context window.
Release Notes:
- agent: Truncate bash tool output
---------
Co-authored-by: Michael Sloan <mgsloan@gmail.com>