6220b86
Write panics and crashes to snowflake (#28284)
Click to expand commit body
This will let us create a better crashes dashboard, using Hex.
Release Notes:
- N/A
Max Brunsfeld
created
448db20
Fix bad unicode calculations in do_completion (#28259)
Click to expand commit body
Co-authored-by: João Marcos <marcospb19@hotmail.com>
Release Notes:
- Fixed a panic with completions around non-ASCII code
---------
Co-authored-by: João Marcos <marcospb19@hotmail.com>
Conrad Irwin
and
João Marcos
created
e4a6943
Update Rust crate tokio to v1.44.2 [SECURITY] (#28277)
Click to expand commit body
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [tokio](https://tokio.rs)
([source](https://redirect.github.com/tokio-rs/tokio)) | dependencies |
patch | `1.44.1` -> `1.44.2` |
| [tokio](https://tokio.rs)
([source](https://redirect.github.com/tokio-rs/tokio)) |
workspace.dependencies | patch | `1.44.1` -> `1.44.2` |
### GitHub Vulnerability Alerts
####
[GHSA-rr8g-9fpq-6wmg](https://redirect.github.com/tokio-rs/tokio/pull/7232)
The broadcast channel internally calls `clone` on the stored value when
receiving it, and only requires `T:Send`. This means that using the
broadcast channel with values that are `Send` but not `Sync` can trigger
unsoundness if the `clone` implementation makes use of the value being
`!Sync`.
Thank you to Austin Bonander for finding and reporting this issue.
---
### Release Notes
<details>
<summary>tokio-rs/tokio (tokio)</summary>
###
[`v1.44.2`](https://redirect.github.com/tokio-rs/tokio/releases/tag/tokio-1.44.2):
Tokio v1.44.2
[Compare
Source](https://redirect.github.com/tokio-rs/tokio/compare/tokio-1.44.1...tokio-1.44.2)
This release fixes a soundness issue in the broadcast channel. The
channel
accepts values that are `Send` but `!Sync`. Previously, the channel
called
`clone()` on these values without synchronizing. This release fixes the
channel
by synchronizing calls to `.clone()` (Thanks Austin Bonander for finding
and
reporting the issue).
##### Fixed
- sync: synchronize `clone()` call in broadcast channel ([#​7232])
[#​7232]: https://redirect.github.com/tokio-rs/tokio/pull/7232
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "" in timezone America/New_York,
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
Release Notes:
- N/A
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMjcuMyIsInVwZGF0ZWRJblZlciI6IjM5LjIyNy4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot]
and
renovate[bot]
created
f03efed
Try to identify dSYMs by UUID not channel (#28268)
Click to expand commit body
This should make it possible to more reliably symbolicate crash reports
from nightly, and from users with pending auto-updates.
Release Notes:
- N/A
---------
Co-authored-by: Ben Kunkle <ben.kunkle@gmail.com>
Conrad Irwin
and
Ben Kunkle
created
862d0c0
debugger: Fix gdb adapter and logger (#28280)
Click to expand commit body
There were two bugs that caused the gdb adapter not to work properly,
one on our end and one their end.
The bug on our end was sending `stopOnEntry: null` in our launch request
when stop on entry had no value. I fixed that bug across all dap
adapters
The other bug had to do with python's "great" type system and how we
serialized our unit structs to json; mainly,
`ConfigurationDoneArguments` and `ThreadsArguments`. Gdb seems to follow
a pattern for handling requests where they pass `**args` to a function,
this errors out when the equivalent json is `"arguments": null`.
```py
@capability("supportsConfigurationDoneRequest")
@request("configurationDone", on_dap_thread=True)
def config_done(**args): ### BUG!!
...
```
Release Notes:
- N/A
Anthony Eid
created
56ed5dc
agent: Add the history button back in the toolbar and make it a toggle (#28275)
Click to expand commit body
Release Notes:
- agent: The history view is now more easily accessible via the icon
button in the Agent Panel toolbar.
---------
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Closes #ISSUE
Release Notes:
- N/A *or* Added/Fixed/Improved ...
---------
Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Co-authored-by: Anthony <anthony@zed.dev>
Piotr Osiewicz
,
Anthony Eid
, and
Anthony
created
fdaf2a2
agent: Adjust the thread generation design (#28193)
Click to expand commit body
This PR simplifies the button to send a new message as well as the
"generation" display design.
Release Notes:
- N/A
---------
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Danilo Leal
and
Bennet Bo Fenner
created
0414908
markdown: Move `open_url` to the `MarkdownElement` as `on_url_click` (#28269)
Click to expand commit body
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Marshall Bowers
and
Antonio Scandurra
created
d3abc61
breadcrumbs: Update multibuffer to match singleton (#28267)
e7a0f0e
terminal: Fix misaligned mouse selection when inline assist is active (#26112)
Click to expand commit body
This PR fixes an issue where mouse selection in the terminal would be
offset when the Terminal Inline Assistant was active. The problem was
caused by incorrect coordinate translation when handling mouse events
with an active inline assistant.
The fix adjusts mouse event coordinates by properly accounting for the
terminal view's `scroll_top` value when the inline assistant is present,
ensuring that text selection precisely follows the mouse cursor
position.
Closes #26111
Release Notes:
- Fixed text selection misalignment in terminal when the inline
assistant is active
Co-authored-by: Peter Tripp <peter@zed.dev>
Require a newer Node version to make Copilot work
Closes #27908
Release Notes:
- Breaking Change: If using system node Zed now requires Node >= v20.
Previously Node >= v18 was required. (Node v18 EOL date is 2025-04-30;
Node v19 EOL since 2023-06-01). Note: This does not change the Zed
bundled Node runtime version (still v23).
Thorben Kröger
created
b6ee367
markdown: Don't retain `MarkdownStyle` in favor of using `MarkdownElement` directly (#28255)
Click to expand commit body
This PR removes the retained `MarkdownStyle` on the `Markdown` entity in
favor of using the `MarkdownElement` directly and passing the
`MarkdownStyle` to it.
This makes it so switching themes will be reflected live in the code
block styles.
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Agus Zubiaga <hi@aguz.me>
Marshall Bowers
,
Antonio Scandurra
, and
Agus Zubiaga
created
aa02615
chore: Make objc a workspace level crate (#28258)
Click to expand commit body
Make objc a workspace level crate to unify version control
Release Notes:
- N/A
a577a72
Add support for `insert_text_mode` of a completion (#28171)
Click to expand commit body
I wanted this for CONL (https://conl.dev )'s nascent langauge server,
and it seems like most of the support was already wired up on the LSP
side, so this surfaces it into the editor.
Release Notes:
- Added support for the `insert_text_mode` field of completions from the
language server protocol.
Conrad Irwin
created
5a7222e
prompt_store: Remove additional code for /project (#27981)
Click to expand commit body
Found leftover from https://github.com/zed-industries/zed/pull/27660
Release Notes:
- N/A
Neo Nie
created
097aefe
agent: Display keybinding to delete Prompt Editor item (#28168)
Click to expand commit body
This PR makes the keybinding to remove Prompt Editor items visible in
the icon button tooltip.
Release Notes:
- N/A
Danilo Leal
created
99a9647
editor: Fix excerpt down scroll behavior to only scroll when there are enough lines (#28231)
Click to expand commit body
Follow up for https://github.com/zed-industries/zed/pull/27058
Improves excerpt down button to only scroll when there exists lines more
than equal to `expand_excerpt_lines`. This prevents weird shift at end
of the file.
Before:
https://github.com/user-attachments/assets/244a3bd6-d813-4cc8-9dcb-3addba2b652f
After:
https://github.com/user-attachments/assets/a9a9ba62-a454-4b56-9c8a-d8e6931b270b
Release Notes:
- N/A
656302e
Stop centering when selecting larger syntax nodes (#28172)
Click to expand commit body
With #27295, the cursor would center upon running
`SelectLargerSyntaxNode`. This was done to provide more context when
making large selections, but when making small selections (such as a
single parameter in an argument list) it was confusing that the scroll
position jumped.
This change makes that behavior slightly more conservative: now when the
selection is small enough to fit on the screen scrolling will only occur
to keep the cursor position on the screen (including respecting
`vertical_scroll_margin`).
Release Notes:
- N/A
Co-authored-by: João Marcos <marcospb19@hotmail.com>
Julia Ryan
and
João Marcos
created
956f359
project_panel: Add warning error for leading or trailing whitespace when creating file or directory (#28215)
Click to expand commit body
- Show yellow warning (instead or error) for leading/trailing
whitespace.
- Do not block user from creating it.
- If you rename existing file/dir which contains leading/trailing
whitespace, it will show error right away.
<img width="250" alt="image"
src="https://github.com/user-attachments/assets/562895ee-3a86-4ecd-bb38-703d1d8b8599"
/>
Release Notes:
- Added warning for leading or trailing whitespace while renaming or
creating new file or directory in Project Panel.
Use px over rem for positioning as rem is dependent on font
size.
Release Notes:
- N/A
Smit Barmase
created
d6d9c38
project_panel: Show error when file or directory already exists while renaming or creating new one (#28177)
Click to expand commit body
Closes #14425
<img width="289" alt="image"
src="https://github.com/user-attachments/assets/2994c401-23e3-419a-90fc-1a83959fdf21"
/>
Release Notes:
- Improved the project panel to show an error when a file or directory
already exists while renaming or creating a new one.
Smit Barmase
created
8cfb9be
Reapply support for X11 screenshare (#28160)
Click to expand commit body
Reapplies #27807 after [revert due to not building on
ARM](https://github.com/zed-industries/zed/pull/28141) by updating scap
to include [a fix to its build on
ARM](https://github.com/zed-industries/scap/commit/08f0a01417505cc0990b9931a37e5120db92e0d0)
Release Notes:
- N/A
---------
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
57669b4
agent: Refresh UI when context or thread history changes (#28188)
Click to expand commit body
I found a few more cases where the UI wasn't updated immediately after
an interaction.
Release Notes:
- agent: Fixed delay after removing threads from "Past Interactions"
- agent: Fixed delay after adding/remove context via keyboard
Agus Zubiaga
created
b1f7133
agent: Refresh UI when sending first message (#28180)
Click to expand commit body
Release Notes:
- Agent Beta: Fixed a delay when sending the first message in a new
thread
Agus Zubiaga
created
ac9e2f3
Try to improve behavior when agent is stuck (#28169)
Click to expand commit body
Currently, it's pretty common that when the agent gets stuck, it deletes
whatever it's stuck on and replaces it with a TODO comment, then
cheerfully reports that it has "simpified" the implementation. This is
worse than leaving the broken code, because at least a human could take
over and try to get it across the finish line.
This system prompt adjustment attempts to make the agent do something
more useful when in this situation: report that it's stuck, explain why
it's stuck, and ask the user what to do.
Release Notes:
- N/A
Richard Feldman
created
a2fbe82
If file is too big, provide the outline and suggest a follow-up tool (#28158)
Click to expand commit body
<img width="622" alt="Screenshot 2025-04-05 at 5 48 14 PM"
src="https://github.com/user-attachments/assets/24b9c7d4-d3e2-4929-bca8-79db5b4e5748"
/>
Release Notes:
- The `read_files` tool now reads only the symbol outline files above a
certain size, to conserve context window space. Then it suggests that
the agent call `read_files` again with the relevant line ranges it saw
in the outline.
Richard Feldman
created
57d8c99
copilot: Create Copilot directory if it does not exist (#28157)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/27966
Issue:
- Copilot is failing to launch because the copilot directory is missing
<img width="497" alt="image"
src="https://github.com/user-attachments/assets/af35eb66-7e91-4dc6-a862-d1575da33b5b"
/>
<img width="943" alt="image"
src="https://github.com/user-attachments/assets/0b195c8c-52eb-42b9-bf36-40086398cc3f"
/>
Release Notes:
- copilot: Fixed an issue where GitHub Copilot would not install
properly if the directory was not present.
---------
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Richard Hao
and
Marshall Bowers
created
4182737
Revert "Add a next_mode to vim::Paste instead of hard-coding Normal mode (#27897) (#28162)
Click to expand commit body
This PR reverts #27897, as it is causing a number of Helix-related tests
to fail:
```
Summary [ 84.324s] 1796 tests run: 1793 passed, 3 failed, 0 skipped
FAIL [ 0.434s] vim helix::test::test_delete
FAIL [ 0.562s] vim helix::test::test_delete_character_end_of_buffer
FAIL [ 0.537s] vim helix::test::test_delete_character_end_of_line
```
This reverts commit 9949512b64ab2f472fc3426d853bc9bd0f6d94e2.
Release Notes:
- Community: Reverted https://github.com/zed-industries/zed/pull/27897.