05596ab
Revert "Stop generating in the Agent panel when the user edits a previous message (#29915)" (#30092)
Click to expand commit body
This reverts commit ce053c9bff0699c922e62c0b3618249e0b9801b9.
Closes #ISSUE
Release Notes:
- N/A
Ben Brandt
created
83c1787
agent: Fix reinsertion of creases when editing past messages (#30417)
Click to expand commit body
Just noticed this got lost when main was merged in #29828.
Release Notes:
- agent: Fixed the rendering of added context when editing past messages
in a thread.
Cole Miller
created
73ca707
Fix agent panel scroll while editing a past message (cherry-pick #30394) (#30400)
Click to expand commit body
Cherry-picked Fix agent panel scroll while editing a past message
(#30394)
This is similar to the `block_mouse_down` method added in #20649 (which
has a very similar motivation), but is more comprehensive in stopping
mouse events. Since I want to cherry-pick this to the releases, keeping
this change just to the agent panel. In a follow-up will replace
existing use of `block_mouse_down` to instead use this.
Release Notes:
- N/A
Co-authored-by: Michael Sloan <michael@zed.dev>
gcp-cherry-pick-bot[bot]
and
Michael Sloan
created
d158360
assistant_context_editor: Register `ContextEditor` actions that were lost (#30428)
Click to expand commit body
This PR restores the `ContextEditor` actions that were lost in
https://github.com/zed-industries/zed/pull/30168.
Closes https://github.com/zed-industries/zed/issues/30356.
Release Notes:
- agent: Added back some missing actions, including `assistant: quote
selection`.
Marshall Bowers
created
5f055f5
Wait to locate system-installed Node until the shell environment is loaded (#30416)
Click to expand commit body
Release Notes:
- Fixed a race condition that sometimes prevented a system-installed
`node` binary from being detected.
- Fixed a bug where the `node.path` setting was not respected when
invoking npm.
Max Brunsfeld
created
2843b5a
agent: Fix layout shift due to the "Generating" label (#30422)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/30238
Release Notes:
- agent: Fixed layout shift happening in the toolbar (both in the
singleton and multibuffers) due to the "Generating" label that appeared
while the agent is still generating a response.
Danilo Leal
created
3a716b1
agent: Thread history update improvements (#30415)
Click to expand commit body
- Try to preserve previously selected item on update
- Do not clear list items while updating to avoid a frame with no items
rendered
Release Notes:
- agent: Preserve previously selected item in Thread History on update
---------
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Richard Feldman <oss@rtfeldman.com>
Agus Zubiaga
,
Danilo Leal
, and
Richard Feldman
created
a20e7e4
Revert "Load Profile state from Thread and tie visibility to the thread's model" (#30413)
Click to expand commit body
This reverts commit 3615d6d96c5d1c8fd0ccb1ee0bc176e9c94ac730.
Ultimately, we want to restore the ability to store a profile
per-thread, but for now reverting this fixes a fairly disruptive bug.
Release Notes:
- Fixed a bug causing the agent to use the wrong profile in some cases.
Cole Miller
created
de4c309
agent: write latest profile change to default setting (#30408)
Click to expand commit body
Reverts back to previous behavior where we update your settings so we
can load a new thread from your last configuration.
Release Notes:
- agent: Persist profile changes for new threads
Ben Brandt
created
29e3264
agent: Show delete thread icon buttons on hover/focus (#30370)
Click to expand commit body
This PR's main goal is to show the delete thread button when the list
item is either focused or hovered. In order to do that, we ended up
refactoring (i.e., merging) the `PastThread` and `PastContext` elements
into a single `HistoryElementEntry` that already matches to the entry
type (i.e., context or thread).
Release Notes:
- agent: Simplify the UI by showing the delete thread icon button only
on hover or focus.
---------
Co-authored-by: Agus Zubiaga <hi@aguz.me>
Danilo Leal
and
Agus Zubiaga
created
466d63d
Fix agent panel scroll while editing a past message (#30394)
Click to expand commit body
This is similar to the `block_mouse_down` method added in #20649 (which
has a very similar motivation), but is more comprehensive in stopping
mouse events. Since I want to cherry-pick this to the releases, keeping
this change just to the agent panel. In a follow-up will replace
existing use of `block_mouse_down` to instead use this.
Release Notes:
- N/A
Michael Sloan
created
cb30afa
Misc improvement of code for agent markdown codeblock (#30388)
Click to expand commit body
Release Notes:
- N/A
Michael Sloan
created
805678b
Fix text overlap with markdown code block in list in agent response (cherry-pick #30377) (#30391)
Click to expand commit body
Cherry-picked Fix text overlap with markdown code block in list in agent
response (#30377)
Seems that `h_full` was causing it to use the height of the overall list
item for some reason.
Closes #30002
Release Notes:
- Agent Panel: Fixed text overlap for code blocks nested in lists in
agent response.
Co-authored-by: Michael Sloan <michael@zed.dev>
gcp-cherry-pick-bot[bot]
and
Michael Sloan
created
- Fix `ctrl-p` not working in the model selector
- Select first entry when opening the context picker
Release Notes:
- Fixed `menu::SelectPrevious` keybindings not working in the agent
panel's model selector.
76b2955
editor: Use default gutter margin instead of `horizontal_padding` for horizontal content padding (#30138)
Click to expand commit body
This PR changes the way a horizontal margin is added in editors. It
removes the possibility to set a custom `horizontal_padding` for an
editor and utilizes the default `gutter_dimension` instead.
This change is made to ensure that no issues with soft-wrapping occurs
for any editor that has a `horizontal_margin` set (see #26893 for more
context on the implications here`. Furthermore, it ensures that the text
actually renders properly when scrolling horizontally and is not
cut-off.
### Horizontal padding:
| `main` | This PR |
| --- | --- |
| 
| 
|
### Editor horizontally scrolled:
| `main` | This PR |
| --- | --- |
| 
| 
|
Notice the difference at the horizontal borders.
The margin added for the `edit_file_tool` was 4 pixels. The `descent`,
whilst not exactly, is roughly the same here and also scales with the
font size nicely. Furthermore, it seems that the
`gutter_dimensions.margin` should be present anyway, given the following
comment
https://github.com/zed-industries/zed/blob/0b00256f5884fd17b4f834730b31f365613f3683/crates/editor/src/element.rs#L6887-L6889
so ensuring this property is actually set and not 0 seems to be
reasonable given the circumstances.
Please note though that this will apply to all editors in the app.
Again, this seems like it should be the case anyway, just wanted to
mention this again.
Should the fix like this not be wanted, I can change this here so that
the `horizontal_margin` is better accounted for when soft-wrapping in an
editor. Feel free to let me know in this case.
Release Notes:
- N/A
Finn Evers
created
5ba44fe
agent: Fuzzy search in model selector (#30281)
Click to expand commit body
This change enables fuzzy search on model providers and names. For
example, the query "z41" will match "zed/gpt-4.1".
Release Notes:
- Agent: Improved model selection with fuzzy search support
Oleksiy Syvokon
created
db79f4f
agent: Render edit tool error as markdown (#30325)
Click to expand commit body
Release Notes:
- agent: Render edit tool error as markdown and allow selecting it
Agus Zubiaga
created
2940962
agent: Fix autoscrolling to history entry (#30321)
Click to expand commit body
We were still using entry indexes to scroll, but the list now includes
the separators as items, so the indexes need to be translated
Release Notes:
- agent: Fix autoscrolling to history entry when navigating via keyboard
Agus Zubiaga
created
c09d53b
agent: Fix message editor's button positions when expanded (#30311)
Click to expand commit body
Fixes an issue introduced by #29959 which caused the message editor to
overflow from the agent panel bounds, making the bottom buttons
invisible when the editor was expanded (cmd+esc).
Fixing this required changing the base structure of the agent panel, but
things seem to work as expected:
https://github.com/user-attachments/assets/fc4c97fb-f7cb-4f54-a268-c30fbcb1649f
Release Notes:
- agent: Fix message editor's button positions when expanded
Closes #29072, #28390,
Release Notes:
- AWS Bedrock: Fixed case where user couldn't delete manually added AWS
credentials.
---------
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Co-authored-by: Peter Tripp <peter@zed.dev>
Shardul Vaidya
,
Marshall Bowers
, and
Peter Tripp
created
cd0ef6f
Add a divider below "Usage" in the Edit Prediction menu (#30284)
Click to expand commit body
As it felt untidy without it.
Release Notes:
- N/A
Danilo Leal
created
a9e5bed
Fix error when Copilot calls tools without arguments (cherry-pick #30371) (#30375)
Click to expand commit body
Cherry-picked Fix error when Copilot calls tools without arguments
(#30371)
Fixes https://github.com/zed-industries/zed/issues/30346
The model can output an empty string to indicate the absence of
arguments, which can't be parsed as a `serde_json::Value`. When that
happens, we now create an empty object instead on behalf of the model.
Release Notes:
- Fixed a bug that prevented Copilot models from calling the
`diagnostic` tool.
Co-authored-by: Antonio Scandurra <me@as-cii.com>
gcp-cherry-pick-bot[bot]
and
Antonio Scandurra
created
c0e128e
Include `EditAgent`'s raw output when inspecting thread (cherry-pick #30337) (#30342)
Click to expand commit body
Cherry-picked Include `EditAgent`'s raw output when inspecting thread
(#30337)
This allows us to debug the raw edits that were generated when people
report feedback, when running evals and when opening the thread as
Markdown.
Release Notes:
- Improved debug output for agent threads.
Co-authored-by: Antonio Scandurra <me@as-cii.com>
gcp-cherry-pick-bot[bot]
and
Antonio Scandurra
created
3c22ad9
Make `copilot::SignIn` open sign-in modal when needed (cherry-pick #30239) (#30349)
Click to expand commit body
Cherry-picked Make `copilot::SignIn` open sign-in modal when needed
(#30239)
Also:
* Makes sign out show status notifications and errors.
* Reinstall now prompts for sign-in after start.
Addresses some of #29250, but not all of it.
Release Notes:
- N/A
Co-authored-by: Michael Sloan <michael@zed.dev>
gcp-cherry-pick-bot[bot]
and
Michael Sloan
created
eff23ab
agent: Show checkmark for current profile, not default profile (cherry-pick #30314) (#30333)
Click to expand commit body
Cherry-picked agent: Show checkmark for current profile, not default
profile (#30314)
Closes #ISSUE
Release Notes:
- agent: Fixed a bug that caused the profile selector to display a
checkmark next to the wrong profile.
Co-authored-by: Cole Miller <cole@zed.dev>
f143227
language_models: Improve subscription states in the Agent configuration view (#30252)
Click to expand commit body
This PR improves the subscription states in the Agent configuration view
to the new billing system.
Zed Free (legacy):
<img width="638" alt="Screenshot 2025-05-08 at 8 42 59 AM"
src="https://github.com/user-attachments/assets/7b62d4c1-2a9c-4c6a-aa8f-060730b6d7b3"
/>
Zed Free (new):
<img width="640" alt="Screenshot 2025-05-08 at 8 43 56 AM"
src="https://github.com/user-attachments/assets/8a48448e-813e-4633-955d-623d3e6d603c"
/>
Zed Pro trial:
<img width="641" alt="Screenshot 2025-05-08 at 8 45 52 AM"
src="https://github.com/user-attachments/assets/1ec7ee62-e954-48e7-8447-4584527307c9"
/>
Zed Pro:
<img width="636" alt="Screenshot 2025-05-08 at 8 47 21 AM"
src="https://github.com/user-attachments/assets/f934b2e3-0943-4b78-b8dc-0a31e731d8fb"
/>
Release Notes:
- agent: Improved the subscription-related information in the
configuration view.
Marshall Bowers
created
ce6e82c
collab: Treat staff as having usage-based pricing enabled (#30020)
Click to expand commit body
This PR makes it so staff are treated as having opted-in to usage-based
pricing.
Release Notes:
- N/A
Marshall Bowers
created
009963f
Improve token counting for OpenAI models (#30242)
Click to expand commit body
tiktoken_rs is a bit behind (and even upstream tiktoken doesn't have all
of these models)
We were incorrectly using the cl100k tokenizer for some models that
actually use the o200k tokenizers. So that is updated.
I also made the match arms specific so that we do a better job of
catching whether or not tiktoken-rs accurately supports new models we
add in.
I will also do a PR upstream to see if we can move some of this logic
back out if tiktoken better supports the newer models.
Release Notes:
- Improved tokenizer support for openai models.
Ben Brandt
created
5d49675
Reuse conversation cache when streaming edits (#30245)
Click to expand commit body
Release Notes:
- Improved latency when the agent applies edits.
Antonio Scandurra
created
5c22af3
agent: Rename a number of constructs from Assistant to Agent (#30196)
Click to expand commit body
This PR renames a number of constructs in the `agent` crate from the
"Assistant" terminology to "Agent".
Not comprehensive, but it's a start.
Release Notes:
- N/A
Closes #30056
Apparently the API supports the "default" field now, so we can remove
that transformation.
However, optional is not supported
See https://ai.google.dev/api/caching#Schema
Release Notes:
- agent: Improve tool schema compatibility for Gemini models
Bennet Bo Fenner
created
cb22acc
mistral: Add new Mistral medium model (#30171)
Click to expand commit body
Release Notes:
- Added `mistral-medium` to the Mistral provider.
versecafe
created
552382f
Load Profile state from Thread and tie visibility to the thread's model (#30090)
Click to expand commit body
When deciding if a model supports tools or not, we weren't reading from
the configured model in a given thread.
This also stores the profile on the thread, which matches the behavior
of the Model and Max Mode, which we also already store per thread.
Hopefully this helps alleviate some confusion.
Release Notes:
- agent: Save profile selection per-Agent thread
59cab2a
Allow opening the FS root dir as a remote project (#30190)
Click to expand commit body
### Todo
* [x] Allow opening `ssh://username@host:/` from the CLI
* [x] Allow selecting `/` in the `open path` picker
* [x] Allow selecting the home directory in the `open path` picker
Release Notes:
- Changed the initial state of the SSH project picker to show the full
path to your home directory on the remote machine, instead of `~`.
- Added the ability to open `/` as a project folder over SSH
---------
Co-authored-by: Agus Zubiaga <hi@aguz.me>
Max Brunsfeld
and
Agus Zubiaga
created
cd4024a
Use agent panel font size for all content in thread / history views and fix text thread font size adjust (#30041)
Click to expand commit body
Release Notes:
- N/A
Michael Sloan
created
7a37a02
Avoid empty schema in copilot dummy tool (#30178)
Click to expand commit body
Copilot chat still returns a 400 if the dummy tool uses the `{}` schema.
This is a follow-up to https://github.com/zed-industries/zed/pull/30007.
Release Notes:
- Fixed a bug where agent edits would fail when using GitHub Copilot
Chat.
Co-authored-by: Agus Zubiaga <hi@aguz.me>
cfaf16a
agent: Fix profile menu hover flicker after settings update (#30109)
Click to expand commit body
Closes #30091
Follow-up to #29958
This PR fixes the profile menu flickering due to the documentation aside
after updating the agent dock position over the settings file.
The problem arose because the `documentation_side` could get out of sync
with the actual agent panel dock position. The `documentation_side` was
only updated whenever the user changed the agent panel position using
the UI, but not when updating the position in the settings file.
You can reproduce this easily by changing the `agent.dock` position to
the opposite site in your settings, which will make the profile menu
flicker again in some scenarios due to the de-sync.
This PR fixes this behavior by computing the position during render,
thus the actual set panel position and the documentation position can
never get out of sync
Release Notes:
- Fixed the agent profile menu flickering after updating the assistant
panel dock position in the settings.
Finn Evers
created
cf30cc7
language_models: Update copy for Zed Pro subscription (#30152)
Click to expand commit body
This PR updates the copy around the Zed Pro description to be more
accurate.
Release Notes:
- agent: Updated some copy about Zed Pro in the configuration view.
Updated terms for Agent panel launch.
Release Notes:
- N/A
Peter Tripp
created
3c9d39b
Send up Zed version with edit prediction and completion requests (#30136)
Click to expand commit body
This PR makes it so we send up an `x-zed-version` header with the
client's version when making a request to llm.zed.dev for edit
predictions and completions.
Release Notes:
- N/A