Commit log

ac4bfed zed 0.189.5

Joseph T. Lyons created

a9ac373 gpui: Improve `window.prompt` to support ESC with non-English cancel text on macOS (#29538)

Click to expand commit body
Release Notes:

- N/A

----

The before version GPUI used `Cancel` for cancel text, if we use
non-English text (e.g.: "取消" in Chinese), then the press `Esc` to cancel
will not work.

So this PR to change it by use `PromptButton` to instead the `&str`,
then we can use `PromptButton::cancel("取消")` for the `Cancel` button.

Run `cargo run -p gpui --example window` to test.

---

Platform Test:

- [x] macOS
- [x] Windows
- [x] Linux (x11 and Wayland)

---------

Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>

Jason Lee , Mikayla Maki , and Mikayla Maki created

69302bc debugger: Add tooltips to the new process modal (#31953)

Click to expand commit body
Closes #ISSUE

Release Notes:

- N/A

Piotr Osiewicz created

3d272db debugger: Use new icons for quick debug/spawn button (#31932)

Click to expand commit body
This PR wires up the new icons that were added in #31784.

Release Notes:

- N/A

Cole Miller created

72d4dd6 debugger: Go back to loading task contexts asynchronously for new session modal (#31908)

Click to expand commit body
Release Notes:

- N/A

Cole Miller created

7382157 debugger: Align zoom behavior with other panels (#31901)

Click to expand commit body
Release Notes:

- Debugger Beta: `shift-escape` (`workspace::ToggleZoom`) now zooms the
entire debug panel; `alt-shift-escape` (`debugger::ToggleExpandItem`)
triggers the old behavior of zooming a specific item.

Cole Miller created

6241034 debugger: Extend `f5` binding to contextually rerun the last session (#31753)

Click to expand commit body
Release Notes:

- Debugger Beta: if there is no stopped or running session, `f5` now
reruns the last session, or opens the new session modal if there is no
previously-run session.

Cole Miller created

414b3d4 Simplify debug launcher UI (#31928)

Click to expand commit body
This PR updates the name of the `NewSessionModal` to `NewProcessModal`
(to reflect it's new purpose), changes the tabs in the modal to read
`Run | Debug | Attach | Launch` and changes the associated types in code
to match the tabs. In addition, this PR adds a few labels to the text
fields in the `Launch` tab, and adds a link to open the associated
settings file. In both debug.json files, added links to the zed.dev
debugger docs.

Release Notes:

- Debugger Beta: Improve the new process modal

Mikayla Maki created

2e0f4ac google_ai: Parse thought parts in Gemini responses (#31925)

Click to expand commit body
Fixes thinking Gemini models.

Closes #31902

Release Notes:

- Updated Google Gemini client to match the latest API

Fernando Freire created

ef301a5 Fix aggressive indent in shell scripts (#31973)

Click to expand commit body
Closes: https://github.com/zed-industries/zed/issues/31774

Release Notes:

- N/A

Co-authored-by: Ben Kunkle <ben.kunkle@gmail.com>

Peter Tripp and Ben Kunkle created

dd25fa3 zed 0.189.4

Joseph T. Lyons created

43a219a Harmonize quick action icons (#31784)

Click to expand commit body
Just ensuring they're more harmonized in size, stroke width, and overall
dimensions. Adding here two new "play" icons, too, that will be used in
the context of the debugger.

<img
src="https://github.com/user-attachments/assets/79bcf0b0-e995-4c8e-9c78-0aba32f42f2d"
width="400" />

Release Notes:

- N/A

Danilo Leal created

2926e78 Do not error on debugger server connection close (#31795)

Click to expand commit body
Start to show islands of logs in a successful debugger runs for Rust:

<img width="1728" alt="1"
src="https://github.com/user-attachments/assets/7400201b-b900-4b20-8adf-21850ae59671"
/>

<img width="1728" alt="2"
src="https://github.com/user-attachments/assets/e75cc5f1-1f74-41d6-b7aa-697a4b2f055b"
/>

Release Notes:

- N/A

Kirill Bulatov created

0283d65 debugger: Relax implementation of `validate_config` to not run validation (#31785)

Click to expand commit body
When we moved to schema-based debug configs, we've added validate_config
- a trait method
that is supposed to both validate the configuration and determine
whether it is a launch configuration
or an attach configuration.

The validation bit is a bit problematic though - we received reports on
Discords about
scenarios not starting up properly; it turned out that Javascript's
implementation was overly strict.
Thus, I got rid of any code that tries to validate the config - let's
let the debug adapter itself
decide whether it can digest the configuration or not. validate_config
is now left unimplemented for most
DebugAdapter implementations (except for PHP), because all adapters use
`request`: 'launch'/'attach' for that.
Let's leave the trait method in place though, as nothing guarantees this
to be true for all adapters.

cc @Anthony-Eid

Release Notes:

- debugger: Improved error messages when the debug scenario is not
valid.
- debugger: Fixed cases where valid configs were rejected.

Piotr Osiewicz created

619d9ea debugger: Add support for go tests (#31772)

Click to expand commit body
In the https://github.com/zed-industries/zed/pull/31559 I did not
introduce ability to debug test invocations.
Adding it here. E.g:
![Kapture 2025-05-30 at 19 59
13](https://github.com/user-attachments/assets/1111d4a5-8b0a-42e6-aa98-2d797f61ffe3)

Release Notes:
- Added support for debugging single tests written in go

Alex created

79b472b Use both language and LSP icons for LSP tasks (#31773)

Click to expand commit body
Make more explicit which language LSP tasks are used.

Before:

![image](https://github.com/user-attachments/assets/27f93c5f-942e-47a0-9b74-2c6d4d6248de)

After:

![image
(1)](https://github.com/user-attachments/assets/5a29fb0a-2e16-4c35-9dda-ae7925eaa034)


![image](https://github.com/user-attachments/assets/d1bf518e-63d1-4ebf-af3d-3c9d464c6532)


Release Notes:

- N/A

Kirill Bulatov created

771a3ac Improve LSP tasks ergonomics (#31551)

Click to expand commit body
* stopped fetching LSP tasks for too long (but still use the hardcoded
value for the time being — the LSP tasks settings part is a simple bool
key and it's not very simple to fit in another value there)

* introduced `prefer_lsp` language task settings value, to control
whether in the gutter/modal/both/none LSP tasks are shown exclusively,
if possible

Release Notes:

- Added a way to prefer LSP tasks over Zed tasks

Kirill Bulatov created

8541076 debugger: Change console text color, add tooltips (#31765)

Click to expand commit body
- Improved legibility of console text:

| Theme | Dark | Light |
|--------|--------|--------|
| Before |
![image](https://github.com/user-attachments/assets/756da36d-9ef4-495a-9cf9-7249c25d106a)
|
![image](https://github.com/user-attachments/assets/42558ec2-ee08-4973-8f7d-d7f4feb38cf8)
|
| After |
![image](https://github.com/user-attachments/assets/4469f000-b34f-4cbb-819d-4ae1f2f58a4a)
|
![image](https://github.com/user-attachments/assets/3b862114-0fd3-427c-9c76-f030d3442090)
|

Release Notes:

- debugger: Improved legibility of console text
- debugger: Added tooltips to all debugger items.

Piotr Osiewicz created

c5499f4 Add a JS/TS debug locator (#31769)

Click to expand commit body
With this, a semi-working debug session is possible from the JS/TS
gutter tasks:


https://github.com/user-attachments/assets/8db6ed29-b44a-4314-ae8b-a8213291bffc

For now, available in debug builds only as a base to improve on later on
the DAP front.

Release Notes:

- N/A

---------

Co-authored-by: Piotr Osiewicz <peterosiewicz@gmail.com>

Kirill Bulatov and Piotr Osiewicz created

8757faf Improve TypeScript task detection (#31711)

Click to expand commit body
Parses project's package.json to better detect Jasmine, Jest, Vitest and
Mocha and `test`, `build` scripts presence.
Also tries to detect `pnpm` and `npx` as test runners, falls back to
`npm`.


https://github.com/user-attachments/assets/112d3d8b-8daa-4ba5-8cb5-2f483036bd98

Release Notes:

- Improved TypeScript task detection

Kirill Bulatov created

eece726 zed 0.189.3

Joseph T. Lyons created

26b5cea debugger: Update docs with more examples (#31597)

Click to expand commit body
This PR also shows more completion items when defining a debug config in
a `debug.json` file. Mainly when using a pre build task argument.

### Follow ups
- Add docs for Go, JS, PHP
- Add attach docs

Release Notes:

- debugger beta: Show build task completions when editing a debug.json
configuration with a pre build task
- debugger beta: Add Python and Native Code debug config
[examples](https://zed.dev/docs/debugger)

Anthony Eid created

60bbaad debugger: Fix wrong path to the downloaded delve-shim-dap (#31738)

Click to expand commit body
Closes #ISSUE

Release Notes:

- N/A

Piotr Osiewicz created

fc061ab debugger: Fix delve-dap-shim path on Windows (#31735)

Click to expand commit body
Closes #ISSUE

Release Notes:

- debugger: Fixed wrong path being picked up for delve on Windows
- debugger: Fixed delve not respecting the user-provided binary path
from settings.

Piotr Osiewicz created

cf6ffab Unify the tasks modal and the new session modal (#31646)

Click to expand commit body
Release Notes:

- Debugger Beta: added a button to the quick action bar to start a debug
session or spawn a task, depending on which of these actions was taken
most recently.
- Debugger Beta: incorporated the tasks modal into the new session modal
as an additional tab.

---------

Co-authored-by: Julia Ryan <juliaryan3.14@gmail.com>
Co-authored-by: Julia Ryan <p1n3appl3@users.noreply.github.com>
Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Co-authored-by: Mikayla <mikayla@zed.dev>

Cole Miller , Julia Ryan , Julia Ryan , Anthony Eid , and Mikayla created

4932a12 go: Use delve-dap-shim for spawning delve (#31700)

Click to expand commit body
This allows us to support terminal with go sessions

Closes #ISSUE

Release Notes:

- debugger: Add support for terminal when debugging Go programs

Piotr Osiewicz created

7fef600 Fix model deduplication to use provider ID and model ID (#31752)

Click to expand commit body
Replicates https://github.com/zed-industries/zed/pull/31750 for v0.189.x
branch

Release Notes:

- Fix to make sure all provider models are shown in the model picker

Ben Brandt created

51c8e35 Revert "debugger beta: Fix bug where debug Rust main running action f… (cherry-pick #31743) (#31746)

Click to expand commit body
Cherry-picked Revert "debugger beta: Fix bug where debug Rust main
running action f… (#31743)

…ailed (#31291)"

This reverts commit aab76208b53334b85429486c7abd6f0bfcf58dc9.

Closes #31737

I cannot repro the original issue that this commit was trying to solve
anymore.

Release Notes:

- N/A

Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>

gcp-cherry-pick-bot[bot] and Piotr Osiewicz created

f556d63 Bump Tree-sitter to 0.25.5 for YAML-editing crash fix (#31603)

Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/31380

See https://github.com/tree-sitter/tree-sitter/pull/4472 for the fix

Release Notes:

- Fixed a crash that could occur when editing YAML files.

Max Brunsfeld created

4315869 Bump to 0.189.2 for @maxbrunsfeld

Zed Bot created

cab167d Fix editor rendering slowness with large folds (#31569)

Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/31565

* Looking up settings on every row was very slow in the case of large
folds, especially if there was an `.editorconfig` file with numerous
glob patterns
* Checking whether each indent guide was within a fold was very slow,
when a fold spanned many indent guides.

Release Notes:

- Fixed slowness that could happen when editing in the presence of large
folds.

Max Brunsfeld created

6c86825 Pass up intent with completion requests (cherry-pick #31710) (#31714)

Click to expand commit body
Cherry-picked Pass up intent with completion requests (#31710)

This PR adds a new `intent` field to completion requests to assist in
categorizing them correctly.

Release Notes:

- N/A

---------

Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>

Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>

gcp-cherry-pick-bot[bot] , Marshall Bowers , and Ben Brandt created

0e562f2 Bump to 0.189.1 for @SomeoneToIgnore

Zed Bot created

abea240 Introduce $ZED_CUSTOM_PYTHON_ACTIVE_ZED_TOOLCHAIN_RAW to work around (cherry-pick #31685) (#31688)

Click to expand commit body
Cherry-picked Introduce $ZED_CUSTOM_PYTHON_ACTIVE_ZED_TOOLCHAIN_RAW to
work around (#31685)

Follow up to #31674 

Release Notes:

- N/A

Co-authored-by: Kirill Bulatov <mail4score@gmail.com>

Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>

gcp-cherry-pick-bot[bot] , Piotr Osiewicz , and Kirill Bulatov created

a5b511e Introduce $ZED_CUSTOM_PYTHON_ACTIVE_ZED_TOOLCHAIN_RAW to work around (#31685)

Click to expand commit body
Follow up to #31674 

Release Notes:

- N/A

Co-authored-by: Kirill Bulatov <mail4score@gmail.com>

Piotr Osiewicz and Kirill Bulatov created

be1efa5 debugger: Add spinners while session is starting up (#31548)

Click to expand commit body
Release Notes:

- Debugger Beta: Added a spinner to the debug panel when a session is
starting up.

---------

Co-authored-by: Remco Smits <djsmits12@gmail.com>
Co-authored-by: Julia <julia@zed.dev>

Cole Miller , Remco Smits , and Julia created

ce8ff95 debugger: Disambiguate child session labels (#31526)

Click to expand commit body
Add `(child)` instead of using the same label.

Release Notes:

- Debugger Beta: Made child sessions appear distinct from their parents
in the session selector.

Cole Miller created

5ec3dff debugger: Don't open non-absolute paths from stack frame list (#31534)

Click to expand commit body
Follow-up to #31524 with a more general fix

Release Notes:

- N/A

---------

Co-authored-by: Piotr <piotr@zed.dev>

Cole Miller and Piotr created

2616466 Revert "task: Wrap programs in ""s (#31537)" (cherry-pick #31674) (#31676)

Click to expand commit body
Cherry-picked Revert "task: Wrap programs in ""s (#31537)" (#31674)

That commit broke a lot, as our one-off tasks (alt-enter in the tasks
modal), npm, jest tasks are all not real commands, but a composition of
commands and arguments.

This reverts commit 5db14d315b0822c6d261c0853a3ea039877fd8a8.

Closes https://github.com/zed-industries/zed/issues/31554

Release Notes:

- N/A

Co-authored-by: Piotr Osiewicz
<24362066+osiewicz@users.noreply.github.com>

Co-authored-by: Kirill Bulatov <kirill@zed.dev>
Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>

gcp-cherry-pick-bot[bot] , Kirill Bulatov , and Piotr Osiewicz created

0ac8774 file_finder: Reduce vertical padding in footer (cherry-pick #31632) (#31673)

Click to expand commit body
Cherry-picked file_finder: Reduce vertical padding in footer (#31632)

Follow-up to #31542

This PR reduces the vertical padding in the file finders footer. We can
remove this padding as we already apply it just above



https://github.com/zed-industries/zed/blob/a5a116439e711772190b7fb8e5507eb5dbd95237/crates/file_finder/src/file_finder.rs#L1500

This also ensures that the items on the right side have the same padding
to the border as the icon on the left side. Currently, due to the
padding being applied twice, the items on the right side have `pr_4` as
well as `py_4` in practice, which seems a little excessive.

| `main` | This PR |
| --- | --- |
|

![file_finder_main](https://github.com/user-attachments/assets/352d2ac9-04a9-487d-96ca-b009b797809b)
|

![file_finder_pr](https://github.com/user-attachments/assets/c0b44beb-ff2c-4e93-a5b1-2393652a2a58)
|


Release Notes:

- N/A

Co-authored-by: Finn Evers <dev@bahn.sh>

gcp-cherry-pick-bot[bot] and Finn Evers created

ba5c732 debugger: Fix invalid schema for `pathMappings` (#31595)

Click to expand commit body
See
https://github.com/xdebug/vscode-php-debug?tab=readme-ov-file#remote-host-debugging

Release Notes:

- Debugger Beta: Fixed invalid schema for `pathMappings`

Remco Smits created

41f944b Revert "Fix text wrapping in commit message editors (#31030)" (#31587)

Click to expand commit body
This reverts commit f2601ce52ce82eb201799ae6c4f1f92f42ccf7c8.

Release Notes:

- N/A

Cole Miller created

fc306a2 v0.189.x preview

Joseph T. Lyons created

2c4b75a Remove agent label for github issues (#31591)

Click to expand commit body
Release Notes:

- N/A

Peter Tripp created

aab7620 debugger beta: Fix bug where debug Rust main running action failed (#31291)

Click to expand commit body
@osiewicz @SomeoneToIgnore If you guys have time to look this over it
would be greatly appreciated. I wanted to move the bug fix into the task
resolution code but wasn't sure if there was a reason that we didn't
already.

The bug is caused by an env variable being empty when we send it as a
terminal command. When the shell resolves all the env variables there's
an extra space that gets added due to the empty env variable being
placed between two other variables.

Closes #31240

Release Notes:

- debugger beta: Fix a bug where debug main Rust runner action wouldn't
work

Anthony Eid created

f3f0766 assistant_tools: Remove description.md files of removed tools (#31586)

Click to expand commit body
This pull request removes orphaned description.md files for tools that
were deleted in [PR
#29808](https://github.com/zed-industries/zed/pull/29808). These
descriptions are no longer needed as their corresponding tools no longer
exist
Closes #ISSUE

Release Notes:

- N/A

Umesh Yadav created

148e9ad Revert "agent: Namespace MCP server tools" (#31588)

Click to expand commit body
Reverts zed-industries/zed#30600

Ben Brandt created

e314963 agent: Add max mode on text threads (#31361)

Click to expand commit body
Related discussions #30240 #30596

Release Notes:

- Added the ability to use max mode on text threads.

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>

Alvaro Parker and Danilo Leal created

957e4ad Fix lag when interacting with `MarkdownElement` (#31585)

Click to expand commit body
Previously, we forgot to associate the `Markdown` entity to
`MarkdownElement` during `prepaint`. This caused calls to
`Context<Markdown>::notify` to not invalidate the view cache, which
meant we would have to wait for some other invalidation before seeing
the results of that initial notify.

Release Notes:

- Improved responsiveness of mouse interactions with the agent panel.

Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>

Antonio Scandurra and Ben Brandt created

fee6f13 debugger: Fix go locator creating false scenarios (#31583)

Click to expand commit body
This caused other locators to fail because go would accept build tasks
that it couldn't actually resolve

Release Notes:

- N/A

Anthony Eid created