Commit log

d5cc3fe Implement Debug for keymap::MatchResult

Click to expand commit body 
Helpful when debugging issues with keystroke dispatch.

Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

Nathan Sobo and Max Brunsfeld created

92f411f Extract generic forward_project_request function on server

Click to expand commit body 
All these methods did the same thing with different message types.

Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

Nathan Sobo and Max Brunsfeld created

e822c6a Handle project-wide search on guests

Click to expand commit body 
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

Nathan Sobo and Max Brunsfeld created

1278f54 Add project search RPC messages

Max Brunsfeld created

8dce91b Upgrade time crates to silence warning on Rust 1.59

Max Brunsfeld created

9a97588 Eliminate RwLock around LanguageServer's outbound message channel

Click to expand commit body 
We observed a deadlock when quitting zed. The main thread was attempting
to acquire a write lock to this outbound message sender. We weren't able
to understand exactly how this occurred, but we removed the use of a
lock there, so this shouldn't happen anymore.

Co-Authored-By: Antonio Scandurra <me@as-cii.com>

Max Brunsfeld and Antonio Scandurra created

368301f Reuse a previous project find whenever possible

Click to expand commit body 
Co-Authored-By: Max Brunsfeld <max@zed.dev>

Antonio Scandurra and Max Brunsfeld created

e278c42 Don't assume that cloning on split will reuse the same underlying model

Click to expand commit body 
Co-Authored-By: Max Brunsfeld <max@zed.dev>

Antonio Scandurra and Max Brunsfeld created

7123407 Don't share query editor state after project find has been split

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

1e04411 Don't focus query editor if there are matches on tab switch

Antonio Scandurra created

b506db7 Use the new split pane's navigation history when cloning an item

Antonio Scandurra created

88bfe5a Allow splitting project find and maintain the searches in sync

Antonio Scandurra created

29e035a Don't report a buffer when it doesn't contain any matches

Antonio Scandurra created

2611b54 Always `sync` before clearing or removing excerpts from `MultiBuffer`

Click to expand commit body 
We don't have any test that proves this is needed but seems good nonetheless.

Antonio Scandurra created

ff0fa0e Gracefully handle passing an empty set of ranges to `push_excerpts`

Antonio Scandurra created

f649074 Refine project find's UX

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

51c645f Toggle focus between query editor and results on cmd-shift-F

Nathan Sobo created

2147db9 Open searched buffers in parallel

Antonio Scandurra created

5be9304 Focus results editor when project find matches are updated

Antonio Scandurra created

561123d Avoid extra `smol::channel` when iterating through snapshot paths

Antonio Scandurra created

6a0cca7 Add a fast path for when the search query is empty

Antonio Scandurra created

a077210 Focus query editor when deploying project-find

Antonio Scandurra created

7aacb63 Respect field editor background, color and selection styling

Antonio Scandurra created

0bf944e Use `Project::search` in `ProjectFind` and show search results

Antonio Scandurra created

5644336 Merge branch 'main' into project-find

Max Brunsfeld created

fb1103e Merge pull request #482 from zed-industries/c-support

Click to expand commit body 
Add C support with clangd

Max Brunsfeld created

826a458 Merge pull request #492 from zed-industries/editor-settings

Click to expand commit body 
Provide editor styling information separately from editor settings

Max Brunsfeld created

47b6540 Provide editor styling information separately from editor settings

Click to expand commit body 
* Since regular editors' font sizes and families are controlled by
  the settings and not the theme, don't store a dummy text style in
  the theme. Instead, only store a font color, and synthesize
  the text style for regular editors using both the theme and the
  settings.
* Style single-line and auto-height editors (now called "field
  editors") using a single function that takes the entire theme and
  selects a relevant sub-object.

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

6d9b003 WIP: Start sketching in `ProjectFindView`

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Max Brunsfeld <max@zed.dev>

Antonio Scandurra , Nathan Sobo , and Max Brunsfeld created

e83d1fc Start on a regex implementation of `SearchQuery`

Antonio Scandurra created

76cc9b3 Extract a `search` module

Antonio Scandurra created

6a323ce Implement a basic project-wide search using Aho-Corasick

Antonio Scandurra created

26f7f4f WIP: Remove ripgrep and start matching query for paths ourselves

Antonio Scandurra created

119bfaa WIP

Antonio Scandurra created

fed6f70 Start on project-wide find

Antonio Scandurra created

39ebaeb Merge pull request #486 from zed-industries/background-highlights

Click to expand commit body 
Move `GetDocumentHighlights` to the background and fix collaboration race conditions

Antonio Scandurra created

d929819 Fix warning

Antonio Scandurra created

8fa23c7 Store ops if buffer handle can't be upgraded and buffer requests are in-flight

Antonio Scandurra created

a6613d5 Store operations for unknown buffers when there are outstanding buffer RPC requests

Max Brunsfeld created

f1921c8 Open buffers from definitions request in random collab test

Click to expand commit body 
Don't try to open buffers from the weak worktrees directly, as this is
expected to fail if the host drops the buffer for that worktree.

Max Brunsfeld created

51e2e9e Make client log message format more consistent

Max Brunsfeld created

6060077 Remove unused pending_updates field from RemoteWorktree

Max Brunsfeld created

e9009d4 Tweak logging in random collaboration test

Max Brunsfeld created

e714b00 Improve logging around handling RPC requests on client

Max Brunsfeld created

170487a Fix race conditions with LSP requests that return buffers

Click to expand commit body 
* Avoid panic when registering a buffer that was previously open,
  and whose weak handle was still present in the open_buffers map.
* Avoid releasing any buffers while a request is outstanding which
  could return a reference to a buffer.

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

17c9aa1 Remove ShareWorktree message

Click to expand commit body 
Instead, create an empty worktree on guests when a worktree is first *registered*, then update it via an initial UpdateWorktree message.

This prevents the host from referencing a worktree in definition RPC responses that hasn't yet been observed by the guest. We could have waited until the entire worktree was shared, but this could take a long time, so instead we create an empty one on guests and proceed from there.

We still have randomized test failures as of this commit:

SEED=9519 MAX_PEERS=2 ITERATIONS=10000 OPERATIONS=7 ct -p zed-server test_random_collaboration

Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-Authored-By: Antonio Scandurra <me@as-cii.com>

Nathan Sobo , Max Brunsfeld , and Antonio Scandurra created

d1b4384 WIP

Antonio Scandurra created

8440644 Remove update_id from worktree update messages

Click to expand commit body 
We don't need this anymore because worktree updates are foreground
messages.

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Max Brunsfeld <max@zed.dev>

Antonio Scandurra , Nathan Sobo , and Max Brunsfeld created

f3c6320 Move document highlights RPC message to the background

Antonio Scandurra created

9e17356 Pass an `AsyncAppContext` to fake language server request handlers

Antonio Scandurra created