aedf31e
Manually refresh code action when `data` is not present
Antonio Scandurra created
Commit log
9ce3b1a
Send `DidCloseTextDocument` when dropping buffer
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/434
Antonio Scandurra created
17114cc
Merge branch 'main' into assists
Antonio Scandurra created
050f951
Clear test db pool whenever no dbs are in use
Max Brunsfeld created
30e8709
Merge pull request #437 from zed-industries/fix-server-hangs
Click to expand commit body
Use an unbounded channel for peer's outgoing messages
Max Brunsfeld created
c245356
Try another hacky approach for tearing down DBs after all tests
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
b0ed58a
Run multiple iterations of all integration tests
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
e3f055d
Use a pool of databases to speed up integration tests
Click to expand commit body
Also, use env_logger consistently in the tests for each crate. Only initiallize the logger at all if some RUST_LOG env var is set. Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
8a2613d
Preserve ordering between responses and other incoming messages
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
d4fe111
Use an unbounded channel for peer's outgoing messages
Click to expand commit body
Using a bounded channel may have blocked the collaboration server from making progress handling RPC traffic. There's no need to apply backpressure to calling code within the same process - suspending a task that is attempting to call `send` has an even greater memory cost than just buffering a protobuf message. We do still want a bounded channel for incoming messages, so that we provide backpressure to noisy peers - blocking their writes as opposed to allowing them to buffer arbitrarily many messages in our server. Co-Authored-By: Antonio Scandurra <me@as-cii.com> Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld , Antonio Scandurra , and Nathan Sobo created
8f3ff15
Apply edits received from LSP code actions and open all touched buffers
Antonio Scandurra created
7a35ea7
Tolerate language servers reporting non-monotonic buffer versions
Click to expand commit body
This isn't perfect but we'll retain up to 10 old versions just in case there are race conditions in the language server. We haven't seen this in the wild but we're concerned about diagnostic reporting racing with code action resolution. Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
a172c3c
Apply file-system operations coming from an LSP code action
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
982e905
WIP: Start on applying code actions
Antonio Scandurra created
dc20be2
Start on code action confirmation
Nathan Sobo created
ba99b01
Generalize showing and hiding of context menus
Click to expand commit body
We still cancel pending completions when hiding the context menu so its not perfectly general, but I think this is ok.
Nathan Sobo created
025e83c
Render code actions context menu
Nathan Sobo created
93a3f4b
Move rendering and select prev/next into ContextMenu enum
Click to expand commit body
This prepares the way to have a code actions context menu.
Nathan Sobo created
ee66151
Start generalizing the completions menu into a context menu
Click to expand commit body
This will let us render the code actions menu in a way that's mutually exclusive with completions.
Nathan Sobo created
83d4fe8
Start work on code actions
Click to expand commit body
Just print out the returned code actions for now Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
4900019
Add a ToPointUtf16 trait in text and multibuffer
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
16acbd2
Handle appkit's cancelOperation: message to allow binding `cmd-.`
Max Brunsfeld created
82afacd
Merge pull request #425 from zed-industries/refine-select-larger-node
Click to expand commit body
Refine behavior of select_larger_syntax_node
Max Brunsfeld created
7fc9518
Adjust assertion to reflect rust grammar upgrade
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
3e232f7
Refine behavior of select_larger_syntax_node
Click to expand commit body
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
Max Brunsfeld and Antonio Scandurra created
fe1729f
Merge pull request #424 from zed-industries/fix-goal-column-on-cut
Click to expand commit body
Clear selection goal column when cutting a full line
Antonio Scandurra created
01f702a
Merge pull request #423 from zed-industries/line-selection
Click to expand commit body
Refine line-oriented selection and deletion
Nathan Sobo created
3f897ed
Clear selection goal column when cutting a full line
Click to expand commit body
Co-Authored-By: Antonio Scandurra <me@as-cii.com> Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Nathan Sobo , Antonio Scandurra , and Max Brunsfeld created
3ef3f30
Merge pull request #401 from zed-industries/fail-ci-on-warnings
Click to expand commit body
Cause tests to fail on CI when there are warnings
Nathan Sobo created
a9d2abe
Merge pull request #400 from zed-industries/libc++
Click to expand commit body
Use -stdlib=libc++ in script/bundle to avoid errors on Monterey
Nathan Sobo created
c38fe47
Delete to hard line boundary when deleting to start/end of line
Click to expand commit body
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nathan Sobo and Antonio Scandurra created
90a780a
Improve moving to start or end of soft-wrapped lines
Click to expand commit body
When moving to end, stop at the soft-wrap line boundary first, then move to the end of the hard line. Vice versa when moving to the beginning. Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nathan Sobo and Antonio Scandurra created
4eb2b97
Fix warning when not building in test mode
Click to expand commit body
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nathan Sobo and Antonio Scandurra created
aa12eb6
Span across soft-wraps when triple clicking a line
Click to expand commit body
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nathan Sobo and Antonio Scandurra created
6ac3a44
Cause tests to fail on CI when there are warnings
Click to expand commit body
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nathan Sobo and Antonio Scandurra created
ed37ad3
Merge pull request #399 from zed-industries/unbounded-fs-events
Click to expand commit body
Buffer all incoming file-system events
Antonio Scandurra created
dad3ddb
Use -stdlib=libc++ in script/bundle to avoid errors on Monterey
Click to expand commit body
I was unable to run script/bundle my local machine without this change.
Nathan Sobo created
a2aa844
Buffer all incoming file-system events
Click to expand commit body
This avoids a problem where the operating system would drop events on the floor and tell us to rescan the entire directory, which in turn would cause a flicker in the project browser. Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
1e186d7
Merge pull request #398 from zed-industries/refine-find
Click to expand commit body
Refine find
Antonio Scandurra created
807049a
Always populate find bar on `cmd-f`
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
bf043fe
Merge pull request #396 from zed-industries/fix-autocomplete-bugs
Click to expand commit body
Refine autocomplete
Antonio Scandurra created
7a8765a
Dismiss the focused find bar on `escape`
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
55f0933
Show completions as soon as possible
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
625beaa
Finish writing test for the new autocompletion behavior
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
f8dce23
Merge pull request #394 from zed-industries/fix-selections-after-format
Click to expand commit body
Fix selection positions after typing with old selection anchors
Nathan Sobo created
0f266cf
WIP: Start refactoring completion test
Click to expand commit body
The idea is to write more assertions related to how autocompletion behaves with multiple cursors, prefixes that don't match, etc.
Antonio Scandurra created
99d0100
Remove unused `bytes_at` method
Antonio Scandurra created
32859a3
Refine autocompletion when text matches a prefix of the suggestion
Antonio Scandurra created
ad13bcd
Merge pull request #395 from zed-industries/fix-show-next-diagnostic
Click to expand commit body
Move cursor to diagnostic even if the only diagnostic is currently shown
Antonio Scandurra created
8d17287
Move cursor to diagnostic even if the only diagnostic is currently shown
Antonio Scandurra created