ff0060a
Remove unnecessary result in line shaping (#30721)
Click to expand commit body
Updates #29879 Release Notes: - N/A
Conrad Irwin created
ff0060a
Remove unnecessary result in line shaping (#30721)
Updates #29879 Release Notes: - N/A
Conrad Irwin created
d791c6c
vim: Add `g M` motion to go to the middle of a line (#30227)
Adds the "g M" vim motion to go to the middle of the line. --------- Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Alex Shen and Conrad Irwin created
c7725e3
terminal: Implement basic Japanese IME support on macOS (#29879)
## Description This PR implements basic support for Japanese Input Method Editors (IMEs) in the Zed terminal on macOS, addressing issue #9900. Previously, users had to switch input modes to confirm Japanese text, and pre-edit (marked) text was not displayed. With these changes: - **Marked Text Display:** Pre-edit text (e.g., underlined characters during Japanese composition) is now rendered directly in the terminal at the cursor's current position. - **Composition Confirmation:** Pressing Enter correctly finalizes the IME composition, clears the marked text, and sends the confirmed string to the underlying PTY process. This allows for a more natural input flow similar to other macOS applications like iTerm2. - **State Management:** IME state (marked text and its selected range within the marked text) is now managed within the `TerminalView` struct. - **Input Handling:** `TerminalInputHandler` has been updated to correctly process IME callbacks (`replace_and_mark_text_in_range`, `replace_text_in_range`, `unmark_text`, `marked_text_range`) by interacting with `TerminalView`. - **Painting Logic:** `TerminalElement::paint` now fetches the marked text and its range from `TerminalView` and renders it with an underline. The standard terminal cursor is hidden when marked text is present to avoid visual clutter. - **Candidate Window Positioning:** `TerminalInputHandler::bounds_for_range` now attempts to provide more accurate bounds for the IME candidate window by using the actual painted bounds of the pre-edit text, falling back to a cursor-based approximation if necessary. This significantly improves the usability of the Zed terminal for users who need to input Japanese characters, bringing the experience closer to system-standard IME behavior. ## Movies https://github.com/user-attachments/assets/be6c7597-7b65-49a6-b376-e1adff6da974 --- Closes #9900 Release Notes: - **Terminal:** Implemented basic support for Japanese Input Method Editors (IMEs) on macOS. Users can now see pre-edit (marked) text as they type Japanese and confirm their input with the Enter key directly in the terminal. This provides a more natural and efficient experience for Japanese language input. (Fixes #9900) --------- Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Gen Tamura and Conrad Irwin created
e26620d
gpui: Add a standard text example (#30747)
This is a dumb first pass at a standard text example. We'll use this to start digging in to some text/scale rendering issues. There will be a ton of follow-up features to this, but starting simple. Release Notes: - N/A
Nate Butler created
9dabf49
agent: Only focus on the context strip if it has items to display (#30379)
Ben Brandt created
f2dcc98
agent: Improve layout shift in the previous message editor (#30825)
This PR also moves the context strip to be at the top, so it matches the main message editor, making the arrow-up keyboard interaction to focus on it to work the same way. Release Notes: - agent: Made the previous message editing UX more consistent with the main message editor.
Danilo Leal created
23bbfc4
Run ignored test when running single test (#30830)
Release Notes: - languages: Run ignored test if user wants to run one specific test
Jakob Herpel created
98aefcc
windows: Some refactor (#30826)
Release Notes: - N/A
张小白 created
9be1e9a
debugger: Prevent pane context menu from showing on secondary mouse click in list entries (#30781)
This PR prevents the debug panel pane context menu from showing when you click your secondary mouse button in **stackframe**, **breakpoint** and **module** list entries. Release Notes: - N/A
Remco Smits created
33b60bc
debugger: Fix inline values panic when selecting stack frames (#30821)
Release Notes: - debugger beta: Fix panic that could occur when selecting a stack frame - debugger beta: Fix inline values not showing in stack trace view Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de> Co-authored-by: Remco Smits <djsmits12@gmail.com>
Anthony Eid , Bennet Bo Fenner , and Remco Smits created
0355b9d
editor: Fix line comments not extending when adding new line immediately after slash (#30824)
This PR fixes a bug where comments don't extend when cursor is right next to the second slash. We added `// ` as a prefix character to correctly position the cursor after a new line, but this broke comment validation by including that trailing space, which it shouldn't. Now both line comments and block comments (already handled in JSDoc PR) can extend right after the prefix without needing an additional space. Before: https://github.com/user-attachments/assets/ca4d4c1b-b9b9-4f1b-b47a-56ae35776f41 After: https://github.com/user-attachments/assets/b3408e1e-3efe-4787-ba68-d33cd2ea8563 Release Notes: - Fixed issue where comments weren't extending when adding new line immediately after comment prefix (`//`).
Smit Barmase created
6bec76c
agent: Allow dismissing previous message by clicking on the backdrop (#30822)
Release Notes: - agent: Improved UX for dismissing an edit to a previous message.
Danilo Leal created
d4f47aa
client: Add support for HTTP/HTTPS proxy (#30812)
Closes #30732 I tested it on my machine, and the HTTP proxy is working properly now. Release Notes: - N/A
张小白 created
5112fce
evals: Make LLMs configurable in edit_agent evals (#30813)
Release Notes: - N/A
Oleksiy Syvokon created
dcf7f71
Revert "Revert "python: Enable subroot detection for pylsp and pyright (#27364)" (#29658)" (#30810)
Revert "Revert "python: Enable subroot detection for pylsp and pyright (#27364)" (#29658)" This reverts commit 59708ef56c569737db3876e6073b9657c6d25c03. Closes #29699 Release Notes: - N/A
Ben Kunkle created
16f668b
editor: Add astrick on new line in multiline comment for Go, Rust, C, and C++ (#30808)
Add asterisk on new line in multiline comments for Go, Rust, C, and C++. While `*` is entirely for style. There's no actual need for it. It can be disabled from setting. More: https://doc.rust-lang.org/rust-by-example/hello/comment.html <img width="491" alt="image" src="https://github.com/user-attachments/assets/385b1eb5-be81-446c-b7cf-34165d6b384a" /> Release Notes: - Added automatic asterisk insertion for new lines in multiline comments for Go, Rust, C, and C++. This can be disable by setting `extend_comment_on_newline` to `false`.
Smit Barmase created
0f4e52b
agent: Ensure background color is the same even while zoomed in (#30804)
Release Notes: - agent: Fixed the background color of the agent panel changing if you zoomed it in.
Danilo Leal created
dfe37b0
agent: Make Markdown codeblocks expanded by default (#30806)
Release Notes: - N/A
Danilo Leal created
2da3798
fix bedrock name in assistant settings schema (#30805)
Closes #30778 Release Notes: - Fixed an issue with the assistant settings where `amazon-bedrock` was incorrectly called `bedrock` in the settings schema
Ben Kunkle created
05955e4
keymap: Move 'project_panel::NewSearchInDirectory' to a dedicated bind (#29681)
Previously cmd-shift-f / ctrl-shift-f had different behavior when invoked from the project panel context than from an editor (for project panel `include` field was populated from the currently select project panel directory). Change this so that it has it's own keybind of cmd-alt-shift-f / ctrl-alt-shift-f so cmd-shift-f and ctrl-shift-f has consistent behavior (`pane::DeploySearch`) everywhere. Release Notes: - Add dedicated keybind for "Find in Folder..." from the project panel (cmd-alt-shift-f, ctrl-alt-shift-f).
Peter Tripp created
1d043b3
askpass: Workaround rust lang 69343 (#30774)
Closes #ISSUE Work around https://github.com/rust-lang/rust/issues/69343 in askpass Release Notes: - linux: Fixed an issue with askpass where the Zed binary path would be incorrect after an auto-update is installed but not yet applied
Ben Kunkle created
18d39e3
editor: Improve JSDoc extend comment on newline to follow convention (#30800)
Follow up for https://github.com/zed-industries/zed/pull/30768 This PR makes JSDoc auto comment on new line lot better by: - Inserting delimiters regardless of whether previous delimiters have trailing spaces or not - When on start tag, auto-indenting both prefix and end tag upon new line This makes it correct as per convention out of the box. No need to manually adjust spaces on every new line. https://github.com/user-attachments/assets/81b8e05a-fe8a-4459-9e90-c8a3d70a51a2 Release Notes: - Improved JSDoc auto-commenting on newline which now correctly indents as per convention.
Smit Barmase created
cc3a28a
agent: Fix unnecessary "tool result too long" (#30798)
Release Notes: - N/A
Oleksiy Syvokon created
0f17e82
chore: Bump Rust to 1.87 (#30739)
Closes #ISSUE Release Notes: - N/A
Piotr Osiewicz created
a316428
docs: Update Claude 3.5 Sonnet context window (#30518)
Release Notes: - N/A --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
morgankrey and Danilo Leal created
3552669
extension: Update wasi preview adapter (#30759)
Replace dynamic downloading of WASI adapter with the provided crate. More importantly, this makes sure we are using the same adapter version as our version of wasmtime, which includes several fixes. Arguably we could also at this point update to wasm32-wasip2 target and remove this dependency as well if we want, but that might need further testing. Release Notes: - N/A
Ben Brandt created
72007c9
docs: Polish AI content (#30770)
Release Notes: - N/A
Danilo Leal created
c2feffa
editor: Add prefix on newline in documentation block (e.g. JSDoc) (#30768)
Closes #8973 - [x] Tests https://github.com/user-attachments/assets/7fc6608f-1c11-4c70-a69b-34bfa8f789a2 Release Notes: - Added auto-insertion of asterisk (*) prefix when creating new lines within JSDoc comment blocks.
Smit Barmase created
4b7b5db
windows: Remove unnecessay helper function (#30764)
Release Notes: - N/A
张小白 created
58ba833
windows: Fix keystroke (#30753)
Closes #22656 Part of #29144, this PR completely rewrites the key handling logic on Windows, making it much more consistent with how things work on macOS. However, one remaining issue is that on Windows, we should be using `Ctrl+Shift+4` instead of `Ctrl+$`. That part is expected to be addressed in #29144. Release Notes: - N/A
张小白 created
f021b40
Fix command casing in issue templates (#30761)
Release Notes: - N/A
Joseph T. Lyons created
47f6d4e
Fix rejecting overwritten files if the agent previously edited them (#30744)
Release Notes: - Fixed rejecting overwritten files if the agent had previously edited them.
Antonio Scandurra created
e60f029
agent: Add adjustments to settings view (#30743)
- Make provider blocks collapsed by default - Fix sections growing unnecessarily when there's available space Release Notes: - N/A
Danilo Leal created
d7b5c61
ui_macros: Remove unused module (#30741)
This PR removes an unused module from the `ui_macros` crate. Release Notes: - N/A
Marshall Bowers created
23d42e3
agent: Use `inventory` for `AgentPreview` (#30740)
This PR updates the `AgentPreview` to use `inventory` instead of `linkme`. Release Notes: - N/A
Marshall Bowers created
b2fc406
gpui: Avoid dereferencing null pointer (#30579)
as [comments](https://github.com/zed-industries/zed/pull/24545#issuecomment-2872833658), I really don't known why, But IMO, add this code is not harm. If you think this is not necessary, can close. Release Notes: - N/A
CharlesChen0823 created
bba3db9
docs: Add minimap configuration section (#30724)
This PR adds some documentation about the minimap to the official docs. **Please note:** The [current preview release notes](https://zed.dev/releases/preview/0.187.0) refer to the minimap PR for configuration options. However, `font_size` and `width` were removed as settings after some discussion but are still referenced in the PR description, which might be misleading. On the other hand, some of the available configuration options are not listed in the PR description. It might be better to refer to the docs or the default settings in order to avoid confusion. Release Notes: - N/A
Finn Evers created
5078f0b
client: Remove extra clone, pass big struct by reference (#30716)
Commit titles explain all of the changes Release Notes: - N/A
tidely created
607bfd3
component: Replace `linkme` with `inventory` (#30705)
This PR replaces the use of `linkme` with `inventory` for the component preview registration. Release Notes: - N/A
Marshall Bowers created
87cb498
debugger: Make the stack frame list and module list keyboard-navigable (#30682)
- Switch stack frame list and module list to `UniformList` to access scrolling behavior - Implement `menu::` navigation actions Release Notes: - Debugger Beta: Added support for menu navigation actions (`ctrl-n`, `ctrl-p`, etc.) in the stack frame list and module list.
Cole Miller created
6420df3
eval: Count execution errors as failures (#30712)
- Evals returning an error (e.g., LLM API format mismatch) were silently skipped in the aggregated results. Now we count them as a failure (0% success score). - Setting the `VERBOSE` environment variable to something non-empty disables string truncation Release Notes: - N/A
Oleksiy Syvokon created
83498eb
Improve error message around failing to install dev extensions (#30711)
Closes #ISSUE Release Notes: - N/A *or* Added/Fixed/Improved ...
Ben Kunkle created
1fb1fec
rust: Add injection for leptos view macro (#30710)
Closes #ISSUE Release Notes: - N/A *or* Added/Fixed/Improved ...
Ben Kunkle created
bc99a86
Reduce allocations (#30693)
Removes a unnecessary string conversion and some clones Release Notes: - N/A
tidely created
fcfe4e2
Reuse existing language servers for invisible worktrees (#30707)
Closes https://github.com/zed-industries/zed/issues/20767 Before: https://github.com/user-attachments/assets/6438eb26-796a-4586-9b20-f49d9a133624 After: https://github.com/user-attachments/assets/b3fc2f8b-2873-443f-8d80-ab4a35cf0c09 Release Notes: - Fixed external files spawning extra language servers
Kirill Bulatov created
ef51197
Add a separator before Quit in the application menu (#30697)
macOS applications should have a separator between “Show All” and “Quit” in the application menu.
Rob McBroom created
c80aaca
zed_extension_api: Format `dap.wit` (#30701)
This PR formats the `dap.wit` file. Release Notes: - N/A
Marshall Bowers created
234d6ce
agent: Fix Markdown codeblock header buttons (#30645)
Closes https://github.com/zed-industries/zed/issues/30592 Release Notes: - agent: Fixed Markdown codeblock header buttons being pushed by long paths/file names.
Danilo Leal created
96a0568
Add setting to disable the sign in button (#30450)
Designed to pair with #30444 to enable enterprises to make it harder to sign into the collab server and perhaps accidentally end up sending code to Zed. Release Notes: - N/A Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Tristan Hume and Mikayla Maki created
b6828e5
agent: Don't duplicate recommended models in all models list (#30692)
Release Notes: - N/A
Oleksiy Syvokon created