7c6fe56
Merge pull request #624 from zed-industries/fix-broken-syntax-highlighting
Click to expand commit body
Make all `HighlightStyle` properties optional
Nathan Sobo
created
fbf7cdf
Make all `HighlightStyle` properties optional
Click to expand commit body
Previously, some of those properties such the font weight, style and color
would be mandatory: when the theme didn't specify them, Zed would use a default
value during deserialization. This meant that those default properties would
unconditionally override the base text style, causing a rendering bug when
combining syntax highlights with diagnostic styles.
This commit fixes that by making `HighlightStyle`s more additive: each property
can be set independently and only the properties that theme specifies get
overridden in the base text style.
Antonio Scandurra
created
72692f1
Merge pull request #622 from zed-industries/guest-settings-file
Click to expand commit body
Open settings file in new window if current window isn't local
Max Brunsfeld
created
3a439f1
Open settings file in new window if current window isn't local
e7835ca
Merge pull request #621 from zed-industries/autoclose-before-punctuation
Click to expand commit body
Autoclose brackets before a language-specific set of characters
Max Brunsfeld
created
325e6c3
Autoclose brackets before a language-specific set of characters
Click to expand commit body
Fixes #588
Max Brunsfeld
created
2c25e61
Respect theme's background color when rendering field editors
Max Brunsfeld
created
7bdb91f
Merge pull request #619 from zed-industries/project-entry-ids
Click to expand commit body
Ensure that worktree entry ids are unique across the project
Max Brunsfeld
created
5822b47
Ensure that worktrees' entry ids are unique across the project
Click to expand commit body
Fixes #512
Max Brunsfeld
created
91b33e4
Merge pull request #618 from zed-industries/fix-block-layout-panic
Click to expand commit body
Fix layout panic on empty editors with blocks
Max Brunsfeld
created
e392368
Fix layout panic on empty editors with blocks
Click to expand commit body
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Max Brunsfeld
and
Antonio Scandurra
created
40a4c18
Merge pull request #604 from zed-industries/set-selections-assertion
Click to expand commit body
Ensure there's at least one selection in `Editor::set_selections`
Antonio Scandurra
created
21eebed
Add more assertions to investigate #503 in the future
Antonio Scandurra
created
a3ea6a3
Ensure there's at least one selection in `Editor::set_selections`
Click to expand commit body
This commit introduces an assertion that will cause Zed to panic as
soon as the invariant gets violated. This will be useful to investigate
issue #503.
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra
and
Nathan Sobo
created
be3bfb2
Merge pull request #603 from zed-industries/fix-presenter-panic
Click to expand commit body
Re-render workspace when removing an inactive pane
This eliminates a whole class of errors where the `ChildView` could
be referring to a view that doesn't exist anymore. That probably still
indicates that there's an underlying bug, but at least we won't panic.
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra
and
Nathan Sobo
created
bae44d8
Re-render workspace when removing an inactive pane
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra
and
Nathan Sobo
created
e62781a
Merge pull request #602 from zed-industries/fix-atlas-panic
Click to expand commit body
Don't draw scene elements if their size is zero
Antonio Scandurra
created
47b40e3
Don't draw scene elements if their size is zero
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra
and
Nathan Sobo
created
e7d0bf1
Merge pull request #574 from zed-industries/settings-file
9f629fa
Improve selection handling when pending rename is taken
Click to expand commit body
- Set selection to the intuitive cursor position when moving up rather than restoring the full selection of the rename editor.
- When cancelling, restore the original selection.
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nathan Sobo
and
Antonio Scandurra
created
33bcd6d
Merge remote-tracking branch 'origin/main' into select-on-rename
Nathan Sobo
created
4f086b8
Refresh document highlight after rename, but not during
Click to expand commit body
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nathan Sobo
and
Antonio Scandurra
created
965f82e
Merge pull request #589 from zed-industries/fold-map-test-failures
Click to expand commit body
Avoid re-using excerpt IDs in `MultiBuffer`
Antonio Scandurra
created
dd1711d
Account for all excerpts ever inserted when determining new excerpt ID
Antonio Scandurra
created
cd4a9f3
Fix bug in selection position maintenance while renaming symbol
Click to expand commit body
We were resolving the selection with the wrong buffer, which now
causes a panic because we don't check the anchor's `buffer_id` anymore.
Antonio Scandurra
created
20fed59
Start work on relaying settings to language servers
Max Brunsfeld
created
48848de
Store settings as a global via a gpui app_state
Max Brunsfeld
created
c50be72
Format including missing formatting changes from previous PR
Keith Simmons
created
16afb3d
Add some tests for global events and fix potential bug in subscriptions when subscription is dropped inside of it's own callback
Click to expand commit body
Co-authored-by: Nathan Sobo <nathan@zed.dev>
Keith Simmons
and
Nathan Sobo
created
c35a96c
On rename, replace background highlights with transparent text highlights