c9b4bb7
Merge branch 'project-diagnostics-pinned-tab' into style-project-diagnostics
Max Brunsfeld created
Commit log
78b57e4
Scale diagnostic header and message text with editor font
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
0c6fd15
Scale diagnostic headers icons with editor font and right align w/ line numbers
Click to expand commit body
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Nathan Sobo and Max Brunsfeld created
121b45e
Sanitize language server diagnostics coming from Rust
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
7250974
Style block decorations
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
65d4c33
Format messages within backticks using bold instead of with a background
Antonio Scandurra created
7e55353
Show error code in diagnostic header
Antonio Scandurra created
ec0ca2a
Display icon next to primary message
Antonio Scandurra created
e7ec016
Restyle diagnostic headers
Antonio Scandurra created
b319bda
Merge pull request #363 from zed-industries/remote-go-to-definition
Click to expand commit body
Make go-to-definition work for guests
Max Brunsfeld created
0cfb9ff
Add random delays in FakeFs
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
2b8685c
Insert random delays when sending and receiving websocket messages in tests
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
d241ab6
Don't store operations for remote buffers we haven't yet opened
Click to expand commit body
This used to be needed, but we think with our improvements to message ordering that we'll never miss operations that were applied after opening a remote buffer. Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Nathan Sobo and Max Brunsfeld created
afa33c9
Clear shared buffers when unsharing projects
Click to expand commit body
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Nathan Sobo and Max Brunsfeld created
469ee55
Get most tests passing when respecting wake order for foreground tasks in Deterministic executor
Click to expand commit body
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Nathan Sobo and Max Brunsfeld created
b7314ef
WIP: Start restructuring executor
Antonio Scandurra created
96b66dc
Fix race condition when opening a buffer and getting a definition to it
Antonio Scandurra created
93125cb
Remove `executor::Foreground::Test`
Click to expand commit body
All code paths have already transitioned to `Foreground::Deterministic`.
Antonio Scandurra created
dabab6e
Verify simultaneously opening buffers via `definition` and `open_buffer`
Click to expand commit body
This fails because we don't yet handle this scenario.
Antonio Scandurra created
a762f57
Add remote worktree to project before it is fully deserialized
Click to expand commit body
This prevents a race condition where the host will send us messages and responses about a worktree that we have seen but haven't yet finished loading.
Antonio Scandurra created
245490f
Implement `Project::definition` when the buffer is remote
Antonio Scandurra created
528a4dd
Fix regression causing guests to miss operations while opening a buffer
Antonio Scandurra created
5403ab3
Merge pull request #360 from zed-industries/improve-files
Click to expand commit body
Improve remote file handling
Antonio Scandurra created
f859d44
Don't show conflict indicator on remote buffer after a reload
Antonio Scandurra created
4372fe1
Maintain remote buffers via `UpdateBufferFile` messages sent by host
Antonio Scandurra created
da13d02
Send File protos as part of Buffer protos
Click to expand commit body
Use the File proto to build the File associated with the buffer rather than relying on the local entry.
Nathan Sobo created
66fce5e
Introduce LocalFile trait
Click to expand commit body
If you want to call `abs_path` or `load`, the file needs to be local. You call `as_local` which returns `Option<dyn LocalFile>` with those local-only methods. I think this makes it more explicit what works only locally vs everywhere.
Nathan Sobo created
ea9c5b0
💄
Nathan Sobo created
506ce8e
Introduce LocalSnapshot
Click to expand commit body
This allows us to remove the absolute path and scan-related state from the Snapshot. None of this data is relevant or valid on guests.
Nathan Sobo created
d192b6e
Remove Worktree::abs_path
Click to expand commit body
I'd like to only have methods related to absolute paths on local worktrees, because it's not really possible to implement them on remote worktrees since we don't know the full path being shared and wouldn't have anything to do with it anyway if we did.
Nathan Sobo created
e2a2073
Remove worktree_path from File struct
Nathan Sobo created
2a6f06f
Merge pull request #359 from zed-industries/defer
Click to expand commit body
Fix panic in ProjectDiagnosticsEditor::open_excerpts by introducing new defer feature to GPUI
Nathan Sobo created
e61a5b1
Defer pane interaction when opening excerpts in diagnostics view
Click to expand commit body
Activating a new item causes the current item to be deactivated. We're the current item, but we're on the stack, so we panic if we try to do this synchronously. If we use defer to wait until we're off the stack it works.
Nathan Sobo created
b755b2d
Add ViewHandle::defer
Click to expand commit body
It's like update, but happens after the current effect instead of synchronously. Also, it doesn't allow the callback to return a value because there would be nothing to do with it.
Nathan Sobo created
8b04c5d
Add a ViewContext::defer
Click to expand commit body
This takes a closure that will be enqueued as an effect to ensure there are no entities on the stack.
Nathan Sobo created
b1931fb
Merge pull request #358 from zed-industries/move-buffers-to-project
Click to expand commit body
Move buffers to project
Nathan Sobo created
8341820
Assign diagnostics on buffer even if it doesn't have a language
Click to expand commit body
This shouldn't be necessary in practice but makes testing easier.
Nathan Sobo created
8bf628c
Update new buffers with existing diagnostics in Project – after assigning language
Nathan Sobo created
2773cab
Simplify opening buffers in the Project and assign language synchronously
Antonio Scandurra created
31dfd01
Make `add_local_worktree` private and use `find_or_create_local_worktree`
Click to expand commit body
The former always adds a worktree, even if we have one already in the project and that could be misused. The public API should always search for a local worktree containing the requested path first so that the project can uphold invariants about which worktrees it has.
Antonio Scandurra created
622aff3
Get diagnostics crate's tests passing
Click to expand commit body
Update diagnostics on project instead of on worktree Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
2712cad
Get integration tests passing
Click to expand commit body
* Fix misuse of guest buffer's id as its remote id Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
f1fc0bd
Flush effects after every spawned future completes
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
34e42c0
Remove worktree_id from buffer-related RPC messages
Max Brunsfeld created
03dc1e5
Move main worktree structs adjacent to each other
Max Brunsfeld created
bd49a02
Move buffers from worktree to project
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
7de2630
Remove UserStore from Worktree
Max Brunsfeld created
6751bd9
Change integration tests to open buffers via the project
Max Brunsfeld created
a578d71
v0.13.0
Click to expand commit body
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Nathan Sobo and Max Brunsfeld created
9506f21
Merge pull request #354 from zed-industries/go-to-definition
Click to expand commit body
Go to definition
Nathan Sobo created