399d059
onboarding: Remove accept AI ToS from within Zed (#36612)
Click to expand commit body
Users now accept ToS from Zed's website when they sign in to Zed the
first time. So it's no longer possible that a signed in account could
not have accepted the ToS.
Release Notes:
- N/A
---------
Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
Anthony Eid
and
Mikayla Maki
created
e96612f
themes: Implement Bright Black and Bright White colors (#36761)
Click to expand commit body
Before:
<img width="356" height="50" alt="image"
src="https://github.com/user-attachments/assets/c4f4ae53-8820-4f22-b306-2e5062cfe552"
/>
After:
<img width="340" height="41" alt="image"
src="https://github.com/user-attachments/assets/8e69d9dc-5640-4e41-845d-f299fc5954e3"
/>
Release Notes:
- Fixed ANSI Bright Black and Bright White colors
Oleksiy Syvokon
created
8550b27
thread view: Add more UI improvements (#36750)
Click to expand commit body
Release Notes:
- N/A
Danilo Leal
created
6d7add4
thread view: Inform when editing previous messages is unavailable (#36727)
Click to expand commit body
Release Notes:
- N/A
Danilo Leal
created
c975846
ai: Auto select user model when there's no default (#36722)
Click to expand commit body
This PR identifies automatic configuration options that users can select
from the agent panel. If no default provider is set in their settings,
the PR defaults to the first recommended option. Additionally, it
updates the selected provider for a thread when a user changes the
default provider through the settings file, if the thread hasn't had any
queries yet.
Release Notes:
- agent: automatically select a language model provider if there's no
user set provider.
---------
Co-authored-by: Michael Sloan <michael@zed.dev>
Anthony Eid
and
Michael Sloan
created
d53dedc
acp: Support calling tools provided by MCP servers (#36752)
Click to expand commit body
Release Notes:
- N/A
Antonio Scandurra
created
6b4c911
acp: Fix panic with edit file tool (#36732)
Click to expand commit body
We had a frequent panic when the agent was using our edit file tool. The
root cause was that we were constructing a `BufferDiff` with
`BufferDiff::new`, then calling `set_base_text`, but not waiting for
that asynchronous operation to finish. This means there was a window of
time where the diff's base text was set to the initial value of
`""`--that's not a problem in itself, but it was possible for us to call
`PendingDiff::update` during that window, which calls
`BufferDiff::update_diff`, which calls
`BufferDiffSnapshot::new_with_base_buffer`, which takes two arguments
`base_text` and `base_text_snapshot` that are supposed to represent the
same text. We were getting the first of those arguments from the
`base_text` field of `PendingDiff`, which is set immediately to the
target base text without waiting for `BufferDiff::set_base_text` to run
to completion; and the second from the `BufferDiff` itself, which still
has the empty base text during that window.
As a result of that mismatch, we could end up adding `DeletedHunk` diff
transforms to the multibuffer for the diff card even though the
multibuffer's base text was empty, ultimately leading to a panic very
far away in rendering code.
I've fixed this by adding a new `BufferDiff` constructor for the case
where the buffer contents and the base text are (initially) the same,
like for the diff cards, and so we don't need an async diff calculation.
I also added a debug assertion to catch the basic issue here earlier,
when `BufferDiffSnapshot::new_with_base_buffer` is called with two base
texts that don't match.
Release Notes:
- N/A
---------
Co-authored-by: Conrad <conrad@zed.dev>
Prep work for deduping tool names
Release Notes:
- N/A
Ben Brandt
created
52d14c4
thread view: Add small refinements to tool call UI (#36723)
Click to expand commit body
Release Notes:
- N/A
Danilo Leal
created
14a50e2
acp: Fix `MessageEditor::set_message` for sent messages (#36715)
Click to expand commit body
The `PromptCapabilities` introduced in previous PRs were only getting
set on the main message editor and not for the editors in user messages.
This caused a bug where mentions would disappear after resending the
message, and for the completion provider to be limited to files.
Release Notes:
- N/A
Agus Zubiaga
created
3d80be6
acp: Allow editing of thread titles in agent2 (#36706)
Click to expand commit body
Release Notes:
- N/A
---------
Co-authored-by: Richard Feldman <oss@rtfeldman.com>
Antonio Scandurra
and
Richard Feldman
created
22dd7ac
thread view: Add improvements to the UI (#36680)
Click to expand commit body
Release Notes:
- N/A
Danilo Leal
created
48f51c0
acp: Remove invalid creases on edit (#36708)
Click to expand commit body
Release Notes:
- N/A
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Agus Zubiaga
and
Bennet Bo Fenner
created
2107274
acp: Hide loading diff animation for external agents and update in place (#36699)
Click to expand commit body
The loading diff animation can be jarring for external agents because
they stream the diff at the same time the tool call is pushed, so it's
only displayed while we're asynchronously calculating the diff. We'll
now only show it for the native agent.
Also, we'll now only update the diff when it changes, which avoids
unnecessarily hiding it for a few frames.
Release Notes:
- N/A
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Agus Zubiaga
and
Bennet Bo Fenner
created
39b6558
acp: Move ignored integration tests behind e2e flag (#36711)
Click to expand commit body
Release Notes:
- N/A
Ben Brandt
created
ca897fc
Avoid suspending panicking thread while crashing (#36645)
Click to expand commit body
On the latest build @maxbrunsfeld got a panic that hung zed. It appeared
that the hang occured after the minidump had been successfully written,
so our theory on what happened is that the `suspend_all_other_threads`
call in the crash handler suspended the panicking thread (due to the
signal from simulate_exception being received on a different thread),
and then when the crash handler returned everything was suspended so the
panic hook never made it to the `process::abort`.
This change makes the crash handler avoid _both_ the current and the
panicking thread which should avoid that scenario.
Release Notes:
- N/A
Julia Ryan
created
c5d96e1
Use Tokio::spawn instead of getting an executor handle (#36701)
Click to expand commit body
This was causing panics due to the handles being dropped out of order.
It doesn't seem possible to guarantee the correct drop ordering given
that we're holding them over await points, so lets just spawn on the
tokio executor itself which gives us access to the state we needed those
handles for in the first place.
Fixes: ZED-1R
Release Notes:
- N/A
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Julia Ryan
,
Conrad Irwin
, and
Marshall Bowers
created
e42a0da
Upload telemetry event on crashes (#36695)
Click to expand commit body
This will let us track crashes-per-launch using the new minidump-based
crash reporting.
Release Notes:
- N/A
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Julia Ryan
,
Conrad Irwin
, and
Marshall Bowers
created
ca0a20f
acp: Refactor agent2 `send` to have a clearer control flow (#36689)
e436b82
acp: Use `ResourceLink` for agents that don't support embedded context (#36687)
Click to expand commit body
The completion provider was already limiting the mention kinds according
to `acp::PromptCapabilities`. However, it was still using
`ContentBlock::EmbeddedResource` when
`acp::PromptCapabilities::embedded_context` was `false`. We will now use
`ResourceLink` in that case making it more complaint with the
specification.
Release Notes:
- N/A
Agus Zubiaga
created
20710a4
Fix more improper uses of the `buffer_id` field of `Anchor` (#36636)
Click to expand commit body
Follow-up to #36524
Release Notes:
- N/A
Cole Miller
created
ca67e06
Show excerpt dividers in `without_headers` multibuffers (#36647)
Click to expand commit body
Release Notes:
- Fixed diff cards in agent threads not showing dividers between
disjoint edited regions.
Cole Miller
created
7f95310
acp: Detect gemini auth errors and show a button (#36641)
Click to expand commit body
Closes #ISSUE
Release Notes:
- N/A
Conrad Irwin
created
bb32d45
acp: Hide history unless in native agent (#36644)
Click to expand commit body
Release Notes:
- N/A
Conrad Irwin
created
79064d1
acp: Use file icons for edit tool cards when ToolCallLocation is known (#36684)
This PR adds a temporary workaround to supress "Aborted" errors from
Gemini when cancelling generation. This won't be needed once
https://github.com/google-gemini/gemini-cli/pull/6656 is generally
available.
Release Notes:
- N/A
8e57f63
acp: Hide feedback buttons for external agents (#36630)
Click to expand commit body
Release Notes:
- N/A
Agus Zubiaga
created
1ee07a4
acp: Rename `assistant::QuoteSelection` and support it in agent2 threads (#36628)
Click to expand commit body
Release Notes:
- N/A
Cole Miller
created
b070dc6
acp: Suggest installing gemini@preview instead of latest (#36629)
Click to expand commit body
Release Notes:
- N/A
Agus Zubiaga
created
15e451c
thread_view: Add recent history entries & adjust empty state (#36625)
Click to expand commit body
Release Notes:
- N/A
Danilo Leal
created
401a604
acp thread view: Do not go into editing mode if unsupported (#36623)
Click to expand commit body
Release Notes:
- N/A
Agus Zubiaga
created
e9a1404
agent2: Clean up tool descriptions (#36619)
Click to expand commit body
schemars was passing along the newlines from the doc comments. This
should make these closer to the markdown file versions we had in the old
agent.
Release Notes:
- N/A