8989756
Fix crash when opening files with a BOM on macOS (#40419)
Click to expand commit body
Closes #40359
We were segfaulting when opening a UTF-8 file starting with a byte order
mark due to a mismatch in our UTF-16 indexing calculations caused by
Core Foundations `replace_str` stripping the BOM internally. This PR
fixes the crash by replacing one of our manual calculations by calling
the Core Foundations API to get the length of a string.
Release Notes:
- Fixed a crash on macOS when opening a file that starts with a UTF-8
byte order mark (BOM).
Co-authored-by: HactarCE <6060305+HactarCE@users.noreply.github.com>
55ffc41
file_finder: Fix open path prompt creating wrong highlight indices (#40488)
Click to expand commit body
Fixes ZED-28R
Release Notes:
- Fixed open path prompt panicking on certain inputs
Lukas Wirth
created
b631e81
vim: Fix hang in visual block motion (#40723)
Click to expand commit body
The `vim::visual::Vim.visual_block_motion` method was recently updated
(https://github.com/zed-industries/zed/pull/39355) in order to jump
between buffer rows instead of display rows. However, with this now
being the case, the `break` condition was never met when the motion was
horizontal rather than vertical and soft wrapped lines were used. As
such, this commit udpates the condition to ensure it's always reached,
preventing the hanging from happening.
Release Notes:
- Fixed hang in Vim's visual block motions when updating selections
---------
Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
Dino
and
Piotr Osiewicz
created
5e64237
Make `kotlin-lsp` the default language server (#40776)
Click to expand commit body
Following a conversation with the maintainer/owner of
kotlin-language-server, he recommended switching to the official
language server, which is better in many aspects and also more actively
maintained.
Release Notes:
- Made the official Kotlin Language Server the default language server
for Kotlin.
Finn Evers
created
e82a6b5
acp: Fix following for agents that only provide locations (#40710)
Click to expand commit body
We were dropping the entities once we created the buffers, so the weak
entities could never be upgraded. This treats new locations we see the
same as we would for a read/write call and stores the entity so that we
can follow like we normally would.
Release Notes:
- acp: Fix following not working with certain tool calls.
Ben Brandt
created
8ae6903
editor: Toggle diff hunk based on current mouse position (#40773)
Click to expand commit body
This fixes an issue where we would search for the hovered diff hunk
based on the mouse hit test computed during (or prior) editor paint
instead of the mouse hit test computed prior to the mouse event
invocation.
That in turn could lead to cases where moving the mouse from the editor
to the project panel and then clicking a file shortly after would expand
a diff hunk when actually nothing should happen in that case.
Release Notes:
- Fixed an issue where diff hunks would sometimes erroneously toggle
upon mouse clicks.
This feels a bit dangerous as long as we have the split releases problem
Release Notes:
- N/A
Cole Miller
created
3eb1952
Fix inlay hint cleanup on excerpts removal (#40738)
Click to expand commit body
A cherry-pick of
https://github.com/zed-industries/zed/pull/40183/commits/f5188d55fbcbb3856038967bce8e824ddb42bdba
This fixes a hard-to-reproduce crash caused excerpts removal not
updating previous snapshot data after corresponding inlay data was
removed.
Same branch has a test:
https://github.com/zed-industries/zed/pull/40183/commits/8783a9eb4fbc60e3fbe0654c2d330bddfaa7ef0a
that does not fail on `main` due to different way inlays are queried, it
will be merged later.
Release Notes:
- N/A
b69d0ab
ai onboarding: Add dismiss button to the sign in banner (#40660)
Click to expand commit body
Release Notes:
- N/A
Danilo Leal
created
eb33d30
Set the minimum log level to `info` for the remote server (#40543)
Click to expand commit body
`env_logger` defaults to only showing error-level logs, but we show
info-level logs and above for the main Zed process, so I think it makes
sense for the remote server to behave the same way.
Release Notes:
- N/A
Cole Miller
created
caa5d62
Disallow rename/copy/delete on unshared files (#40540)
Updates #40212
v0.9.0 is now stable and contains the fix for the line endings bug, so
we can return to installing from the stable channel as usual. This also
bumps the minimum version on Windows to v0.9.0 so that anyone on v0.8.x
or v0.9.0-preview.4 will be upgraded automatically.
Release Notes:
- N/A
fe00b6c
Revert deprecate code actions on format (#40409)
Click to expand commit body
Closes #40334
This reverts the change made in #39983, and includes a replacement
migration that will transform formatter settings values consisting of
only `code_action` format steps into the previously deprecated
`code_actions_on_format` in an attempt to restore the behavior to what
it was before the migration that deprecated `code_actions_on_format`.
This PR will result in a modified order in the `code_actions_on_format`
setting if it existed, however the decision was made to explicitly
ignore this for now, as this PR is primarily targeting users who have
already had the deprecation migration run, and no longer have the
`code_actions_on_format` key
Release Notes:
- Fixed an issue with a settings migration that deprecated the
`code_actions_on_format` setting. The `code_actions_on_format` setting
has been un-deprecated, and affected users will have the bad migration
rolled back with an updated migration
---------
Co-authored-by: Cole Miller <cole@zed.dev>
Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
Co-authored-by: HactarCE <6060305+HactarCE@users.noreply.github.com>
Ben Kunkle
,
Cole Miller
,
Mikayla Maki
, and
HactarCE
created
70d1978
editor: Fix `SelectionsCollection::disjoint` not being ordered correctly (#40249)
Click to expand commit body
We've been seeing the occasional `cannot seek backwards` panic within
`SelectionsCollection` without means to reproduce.
I believe the cause is one of the callers of
`MutableSelectionsCollection::select` not passing a well formed
`Selection` where `start > end`, so this PR enforces the invariant in
`select` by swapping the fields and setting `reversed` as required as
the other mutator functions already do that as well.
We could also just assert this instead, but it callers usually won't
care about this so its the less user facing annoyance to just fix this
invariant up internally.
Fixes ZED-253
Fixes ZED-ZJ
Fixes ZED-23S
Fixes ZED-222
Fixes ZED-1ZV
Fixes ZED-1SN
Fixes ZED-1Z0
Fixes ZED-10E
Fixes ZED-1X0
Fixes ZED-12M
Fixes ZED-1GR
Fixes ZED-1VE
Fixes ZED-13X
Fixes ZED-1G4
Release Notes:
- Fixed occasional panics when querying selections
Lukas Wirth
created
10c540b
windows: Fix panic when quitting dialogs that do not have a cancel button (#40348)
Click to expand commit body
`TaskDialogIndirect` may return `IDCANCEL` when the user quits the
dialog via escape or alt+f4, so we need to account for that.
Fixes ZED-25H
Release Notes:
- Fixed panic when hitting escape in dialogs on windows
This will automatically open PRs against the winget package registry to
bump our version there when we do a release.
Release Notes:
- N/A
Julia Ryan
created
66112d8
acp: Add nicer WSL warning for Codex (#40354)
Click to expand commit body
Moves the Codex warning into the thread so that we can render it nicer,
as well as provide an option to open the folder in WSL.
Release Notes:
- N/A
---------
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Ben Brandt
and
Bennet Bo Fenner
created
c3eaa75
settings_ui: Scale window size based on UI font size (#40257)
2adb979
acp: Fix /logout for agents that support it (#40248)
Click to expand commit body
We were clearing the message editor too early. We only want to clear the
message editor if we are going to short circuit and return early before
submitting.
Otherwise, the agents that can handle this themselves won't have the
ability to do so.
Release Notes:
- acp: Fix /logout not working for some agents
Ben Brandt
created
bec6cd9
acp: Allow updating default mode for Codex (#40238)
Click to expand commit body
Release Notes:
- acp: Save default mode for codex
Ben Brandt
created
f6c0fa4
Avoid gap between titlebar and body on linux
Click to expand commit body
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-authored-by: John Tur <john-tur@outlook.com>
Conrad Irwin
,
Max Brunsfeld
, and
John Tur
created
62da0dc
Fix triggers for debugger thread and session lists not rendering (#40227)
Click to expand commit body
Release Notes:
- N/A
Cole Miller
created
154405f
Fix a couple of bugs in remote browser debugging implementation (#40225)
Click to expand commit body
Follow-up to #39248
- Correctly forward ports over SSH, including the port from the debug
scenario's `url`
- Give the companion time to start up, instead of bailing if the first
connection attempt fails
Release Notes:
- Fixed not being able to launch a browser debugging session in an SSH
project.
f348240
Don't probe for local workspaces pointing to WSL filesystem on startup (#40142)
Click to expand commit body
We automatically delete a local workspace if the folders comprising it
no longer exist.
If a local workspace points to folders in the WSL filesystem, checking
whether those folders exist will make us wait for the WSL VM and file
server to boot up. This can block Zed startup for many seconds.
Supported scenarios use remote workspaces, so delete these local
workspaces to ensure that we don't try to access their folders on the
startup path.
Release Notes:
- N/A
Release Notes:
- Fixes bug were typing `9999999999999999999j` (19 9's) would go up
instead of down
- Max Vim count is now isize::MAX - 1
AidanV
created
1bd34e0
zeta2 cli: Export retrieval stats data frame (#40145)
Click to expand commit body
Retrieval stats will now use polars to build a big data frame for
references with the cartesian product of LSP declarations and retrieved
declaration candidates (with all their score components) and rebuilds
the stats summary on top of it.
This data frame is written to a `.parquet` file, which we can load into
advanced analytics tools (such as Metabase), so we can explore our
scoring distributions and find ways to improve retrieval, and then train
the decision tree.
Release Notes:
- N/A
Agus Zubiaga
created
ce696c1
Remove ping/unwrap from crash handler (#39870)
Click to expand commit body
Release Notes:
- N/A
---------
Co-authored-by: Julia Ryan <juliaryan3.14@gmail.com>
Fix issue where Zed would unconditionally override user's custom shell
with system default from passwd entry.
Closes https://github.com/zed-industries/zed/issues/40171
Release Notes:
- Fix issue where Zed would unconditionally override user's custom shell
with system default from passwd entry.
---------
Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
8c7fb26
acp tools: Add button to copy all observed messages (#40076)
Click to expand commit body
Added a "Copy All Messages" button to the ACP logs toolbar that copies
all messages in the watched stream to the clipboard as structured JSON.
## Motivation
When troubleshooting ACP protocol implementations, it's helpful to
provide the entire message thread to an LLM for analysis. Previously, I
had to copy individual messages one at a time, which was tedious and
time-consuming. This feature allows copying the entire conversation
history in a single click.
Release Notes:
- Added: Copy All Messages button to ACP logs view
---------
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Co-authored-by: Agus Zubiaga <agus@zed.dev>
Yordis Prieto
and
Agus Zubiaga
created
867b5df
settings_ui: Only allow to reset a setting to default in the file in which it was customized (#40182)
Click to expand commit body
Plus some other tiny visual adjustments.
Release Notes:
- N/A
Danilo Leal
created
c5bbd55
Add rust-analyzer support for musl linux (#40108)
Click to expand commit body
Release Notes:
- Added rust-analyzer support for musl remotes
localcc
created
4a84b78
collab_ui: Make collaboration panel label responsive on resize (#40157)