170487a
Fix race conditions with LSP requests that return buffers
Click to expand commit body
* Avoid panic when registering a buffer that was previously open,
and whose weak handle was still present in the open_buffers map.
* Avoid releasing any buffers while a request is outstanding which
could return a reference to a buffer.
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Instead, create an empty worktree on guests when a worktree is first *registered*, then update it via an initial UpdateWorktree message.
This prevents the host from referencing a worktree in definition RPC responses that hasn't yet been observed by the guest. We could have waited until the entire worktree was shared, but this could take a long time, so instead we create an empty one on guests and proceed from there.
We still have randomized test failures as of this commit:
SEED=9519 MAX_PEERS=2 ITERATIONS=10000 OPERATIONS=7 ct -p zed-server test_random_collaboration
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nathan Sobo
,
Max Brunsfeld
, and
Antonio Scandurra
created
8440644
Remove update_id from worktree update messages
Click to expand commit body
We don't need this anymore because worktree updates are foreground
messages.
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Max Brunsfeld <max@zed.dev>
Antonio Scandurra
,
Nathan Sobo
, and
Max Brunsfeld
created
f3c6320
Move document highlights RPC message to the background
Antonio Scandurra
created
9e17356
Pass an `AsyncAppContext` to fake language server request handlers
c752383
Merge pull request #459 from zed-industries/spurious-macro-errors
Click to expand commit body
Download language servers dynamically on startup
Nathan Sobo
created
9959433
Log an error instead of panicking when there's no LSP download dir
Nathan Sobo
created
03ec6e1
Assign language server download directory on startup
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld
and
Nathan Sobo
created
79910ba
Show more information in lsp status bar item
Click to expand commit body
* Distinguish between checking for updates and downloading
* Show dismissable error message when downloading failed and there
is no cached server.
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
This reverts commit fc3bccc1a1cd1411cb4be7b8400a6d5816e8bb17.
Antonio Scandurra
created
fc3bccc
WIP: avoid code-signing rust-analyzer to prevent proc macro errors
Click to expand commit body
If this works, I think we should set the permissions asynchronously,
maybe as part of starting the language server, so that we avoid doing
synchronous I/O.