3dc100a
Reset receive timeout only on reads from websocket connection, not writes
Click to expand commit body
Also, increase the receive timeout to 30 seconds. We'll still respond immediately
to explicit disconnection, but when there are temporary network blips that
delay pings, we think we should err on the side of keeping the connection
alive. This is in response to a false positive 'host disconnected' state
that we observed when pairing today, while the host (Keith) still clearly
had a working internet connection, because we were screen sharing.
Co-Authored-By: Keith Simmons <keith@zed.dev>
Max Brunsfeld
and
Keith Simmons
created
508c4df
Merge pull request #565 from zed-industries/eager-theme-selector
Click to expand commit body
Make theme selector eagerly display the selected theme
We added this because we thought it would save some allocations when
sending operations given that we could move them to the delegate upon
notifying it, but the reality is that we serialize operations and that
only requires a reference.
Antonio Scandurra
created
0a9595b
Notify all language servers only when a buffer is saved
Click to expand commit body
Other notifications such as opening, closing or changing a document
are still tied to the buffer's language.
Antonio Scandurra
created
b440a51
Make theme selector eagerly display the selected theme
Keith Simmons
created
4cb4b99
Assign buffer's completion triggers from LSP capabilities
Click to expand commit body
Also, make LanguageServer::new() async. The future resolves
once the server is initialized.
Max Brunsfeld
created
fc36c70
Add missing mouse button events and mouse history navigation
Click to expand commit body
Co-Authored-By: Max Brunsfeld
Co-Authored-By: Nathan Sobo
Keith Simmons
,
Max Brunsfeld
, and
Nathan Sobo
created
Co-Authored-By: Keith Simmons <keith@zed.dev>
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld
,
Keith Simmons
, and
Nathan Sobo
created
bb6ab83
Merge pull request #542 from zed-industries/guest-disconnections
Click to expand commit body
Send heartbeats in both directions so the server can detect when clients disconnect
Max Brunsfeld
created
1f5eab3
Reset peer's receive timeout when a message is received
Click to expand commit body
* Make advance_clock more realistic by waking timers in order,
instead of all at once.
* Don't advance the clock when simulating random delays.
Co-Authored-By: Keith Simmons <keith@zed.dev>
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld
,
Keith Simmons
, and
Nathan Sobo
created
00ba5df
Merge pull request #545 from zed-industries/halt-global-actions
Click to expand commit body
Halt keystroke dispatch when a global action is dispatched
Nathan Sobo
created
40c0b9e
Halt keystroke dispatch when a global action is dispatched
Nathan Sobo
created
34bbc05
Merge pull request #543 from zed-industries/fix-closing-items
Click to expand commit body
Ensure `active_item_index` doesn't go off the end when closing items
Antonio Scandurra
created
711de5e
Ensure `active_item_index` doesn't go off the end when closing items
Click to expand commit body
This fixes a bug introduced in #538, where closing the current tab would hide
all the other tabs, if the current tab was the last one.
Also, this commit manually sets the active item index instead of calling
`Pane::activate_item`: even though this introduces a little bit of duplication,
it prevents us from mistakenly calling `deactivate` on the wrong item. This would
happen because `activate_item` looks at `self.active_item_index` to determine
which item to deactivate before setting the new one. However, that index is
potentially invalid because `::close_items` manipulates the `item_views` vector,
so `activate_item` could end up calling `deactivate` on an item view that was
not active in the first place.
Antonio Scandurra
created
c7ddb66
Merge pull request #538 from zed-industries/close-inactive-items
Click to expand commit body
Implement close inactive items
Antonio Scandurra
created
4124308
Fix errors from conditional compilation in timer functions
Max Brunsfeld
created
fab115e
Adjust test connection to treat the half-open state more realistically
Click to expand commit body
When a network connection is lost without being explicitly closed by the
other end, writes to that connection will error, but reads will just wait
indefinitely.
This allows the tests to exercise our heartbeat logic.
Max Brunsfeld
created
9017a13
Send websocket pings from both the client and the server
Click to expand commit body
Remove the client-only logic for sending protobuf pings.
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Max Brunsfeld
,
Nathan Sobo
, and
Antonio Scandurra
created
c61a1bd
Make timer method available on both foreground and background executors
Click to expand commit body
Also, make it return a static future.
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld
and
Nathan Sobo
created
1982a8c
Put vector clock serialization logic alongside other serialization logic
Click to expand commit body
This way, the `clock` crate doesn't depend on the `rpc` crate.
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld
and
Nathan Sobo
created
28bacab
Move Network test helper from util crate into text crate
Click to expand commit body
This way, `util` does not depend on `clock`.
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld
and
Nathan Sobo
created
9b8c782
Merge pull request #537 from zed-industries/disconnected-status
Click to expand commit body
Render overlay after remote project becomes read-only
Nathan Sobo
created
8b9f411
Use the macOS standard binding instead of VS Code's
Click to expand commit body
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Nathan Sobo
,
Antonio Scandurra
, and
Max Brunsfeld
created