4b142ea
acp_thread: Fix @mention file path format (#41310)
Click to expand commit body
After #38882 we were always including file/directory mentions as
`zed:///agent/file?path=a/b/c.rs`.
However, for most resource links (files/directories/symbols/selections)
we want to use a common format, so that ACP servers don't have to
implement custom handling for parsing `ResourceLink`s coming from Zed.
This is what it looks like now:
```
[@index.js](file:///Users/.../projects/reqwest/examples/wasm_github_fetch/index.js)
[@wasm](file:///Users/.../projects/reqwest/src/wasm)
[@Error](file:///Users/.../projects/reqwest/src/async_impl/client.rs?symbol=Error#L2661:2661)
[@error.rs (23:27)](file:///Users/.../projects/reqwest/src/error.rs#L23:27)
```
Release Notes:
- N/A
---------
Co-authored-by: Cole Miller <cole@zed.dev>
Bennet Fenner
and
Cole Miller
created
d13c841
lsp: Fix workspace diagnostics when registered statically (#41386)
Click to expand commit body
Closes #41379
Release Notes:
- Fixed diagnostics for Ruff and Biome
Piotr Osiewicz
created
4e8a6fc
ci: Bump target directory size limit for mac runners (#41375)
Click to expand commit body
Release Notes:
- N/A
Piotr Osiewicz
created
0b8b7f9
ui: Properly update scrollbar track color (#41354)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/41334
This comes down to a caching issue..
Release Notes:
- Fixed an issue where the scrollbar track color would not update in
case the theme was changed.
cbb803c
lsp: Support tracking multiple registrations of diagnostic providers (#41096)
Click to expand commit body
Closes #40966
Closes #41195
Closes #40980
Release Notes:
- Fixed diagnostics not working with basedpyright/pyright beyond an
initial version of the document
---------
Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Co-authored-by: dino <dinojoaocosta@gmail.com>
Piotr Osiewicz
,
Smit Barmase
,
Anthony Eid
, and
dino
created
2be70b7
fix: Edit predictions using stale snapshot
Click to expand commit body
Co-authored-by: David Kleingeld <davidsk@zed.dev>
Lukas Wirth
and
David Kleingeld
created
9a01c7e
acp: Start sending Client Info to the Agent (#41265)
Click to expand commit body
Updates to acp crate 0.7, which allows us to send information about the
client to the Agent.
In the future, we can also use the AgentInfo on the response for
internal metrics.
Release Notes:
- N/A
1d06e26
editor: Fix panics in `CursorPosition::update_position` (#41237)
Click to expand commit body
Fixes a regression introduced in
https://github.com/zed-industries/zed/pull/39857. As for the exact
reason this causes this issue I am not yet sure will investigate (as per
the todos in code)
Fixes ZED-23R
Release Notes:
- N/A *or* Added/Fixed/Improved ...
fade121
gpui: Fix `TextLayout::layout` producing invalid text runs (#41224)
Click to expand commit body
The issues is that the closure supplied to `request_measured_layout`
could be run multiple times with differing `known_dimensions`. This in
turn will mean we truncate the font runs once, inserting a multibyte
char at the end but then in the next iteration use those truncated runs
for possible the original untruncated string which has multibyte
characters overlapping the now truncated run end resulting in a faulty
utf8 boundary index.
Solution to this is simple, truncate a clone of the runs when needed
instead of modifying the original.
Fixes https://github.com/zed-industries/zed/issues/36925
Fixed ZED-2FF
Fixes ZED-2KM
Fixes ZED-2KK
Fixes ZED-1FF
Fixes ZED-255
Fixes ZED-2JD
Fixes ZED-2FX
Fixes ZED-2K2
Fixes ZED-2JX
Fixes ZED-2GE
Fixes ZED-2FC
Fixes ZED-2GD
Fixes ZED-2HY
Fixes ZED-2HR
Fixes ZED-2FN
Fixes ZED-2GT
Fixes ZED-2FK
Fixes ZED-2EY
Fixes ZED-27E
Fixes ZED-272
Fixes ZED-2EM
Fixes ZED-2CC
Fixes ZED-29V
Fixes ZED-25B
Fixes ZED-257
Fixes ZED-24R
Fixes ZED-24Q
Fixes ZED-23Z
Fixes ZED-227
Release Notes:
- Fixed a crash in text shaping when truncating rendered text
780d60b
Fix include ignored migration rerunning (#41114)
Click to expand commit body
Closes #ISSUE
Release Notes:
- Fixed an issue where having a correct `file_finder.include_ignored`
setting would result in failed to migrate errors
Ben Kunkle
created
08ba193
Revert: Spawn terminal process on background executor (#41060)
Click to expand commit body
Reverts https://github.com/zed-industries/zed/pull/40774 and
https://github.com/zed-industries/zed/pull/40824 since they introduce a
bug where Nushell processes are leaked and Ctrl+C doesn't kill the
current process.
Release Notes:
- Fix a bug where nushell processes wouldn't get killed after closing a
terminal tab
Agus Zubiaga
created
c4858f8
Revert "Round the scroll offset in editor to fix jumping text (#40401)" (#40982)
Click to expand commit body
This reverts commit 3da4cddce205d71dcad760c6af66a8985b16ffbe.
The scrolling is ~30% less for the same gesture, and I'm not using
anything lodpi:
https://github.com/user-attachments/assets/b19521fc-9e29-4bfd-9660-dc1e4c8ae846
Release Notes:
- N/A
Kirill Bulatov
created
f3768cf
acp_thread: Fix panic when following acp agents across buffers (#40798)
Follow up for #40409
Fix for
https://github.com/zed-industries/zed/issues/40874#issuecomment-3433759849
Release Notes:
- Fixed an issue where having an empty formatter array in your settings
`"formatter": []` would result in an erroneous prompt to migrate
settings
Ben Kunkle
created
00a1434
Revert "keymaps: Update defaults for inline assist and signature help" (#40903)
88bac4d
docs: Change tab character representation in docs (#40667)
Click to expand commit body
The suggested `→` appears tiny, and almost looks like just a dot on my
monitor, and I got quite confused for a while thinking the
`whitespace_map.tab` setting wasn't working properly.
<img width="630" height="105" alt="Image"
src="https://github.com/user-attachments/assets/98feced2-39b3-4734-83e4-b4573b4e52c2"
/>
I think it would be really helpful if `⟶` was suggested instead since
that displays properly.
<img width="625" height="104" alt="Image"
src="https://github.com/user-attachments/assets/176886ab-cf88-4079-90a8-91a8e8182092"
/>
---
I am using `Fira Code` as my font on windows, however when I remove that
config to get the default font, it also still appears the same size. So
I don't believe this is just a font issue on my machine.
Thought I am using Windows, so I would be willing to believe this a
render issue specific to windows
Release Notes:
- N/A
Ajani Bilby
created
d53efe4
Revert "gpui: Fix uniform list scrolling with vertical padding present" (#40891)
Click to expand commit body
Reverts zed-industries/zed#40719
This unveiled some bigger issues with the UniformList size computations,
which are more crucial than what was fixed here.
Release Notes:
- NOTE: BUGFIX "Fixed a rare issue where the extension page would
stutter while scrolling." was reverted due to some other issues
Closes #39382
Release Notes:
- Fixed Windows specific ssh jumphost connection issues
localcc
created
98c7e01
Add new action and handler for opening a specific setting (#40739)
Click to expand commit body
Co-authored-by: Ben Kunkle <ben@zed.dev>
Cameron Mcloughlin
and
Ben Kunkle
created
c81ffaf
editor: Use unbounded shifts for chunk bitmaps (#40879)
Click to expand commit body
This simplifies some code and is also more correct in some others (I
believe some of these might've overflowed causing panics in sentry)
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Lukas Wirth
created
bd69124
Add option to disable crash handler (#40799)
Click to expand commit body
Extra info needed for #39289. To be tested out next nightly build...
Release Notes:
- N/A
Co-authored-by: Cole Miller <m@cole-miller.net>
Nia
and
Cole Miller
created
77dbe08
project_panel: Fix buffer focus when canceling filename edit (#40747)
Click to expand commit body
Closes #37726
Release Notes:
- Fixed an issue where the buffer would not regain focus when clicked
while a filename edit was in progress in the project panel.
---------
Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
Samuel Oldham
and
Smit Barmase
created
252b75e
Disable slang-server for verilog extension (#40442)
Click to expand commit body
Should be merged with
https://github.com/zed-industries/extensions/pull/3584, which adds
`slang-server` as a new language server, but should be disabled by
default due to an issue with it not initializing on Windows and being a
relatively new language server in general.
Release Notes:
- N/A
Closes https://github.com/zed-industries/zed/discussions/40763
<img width="867" height="1088" alt="Screenshot 2025-10-21 at 23 14 47"
src="https://github.com/user-attachments/assets/d691fb2a-afc6-4445-a335-054ef164e0d3"
/>
Also improves error handling on image open failure:
<img width="864" height="1083" alt="Screenshot 2025-10-21 at 23 14 30"
src="https://github.com/user-attachments/assets/d5388b61-995f-441b-b375-ad5136d1533b"
/>
Release Notes:
- Added basic ico support, improved unsupported image handling
Kirill Bulatov
created
8ceb2f2
Add more tweaks to the troubleshooting docs (#40870)
Click to expand commit body
Release Notes:
- N/A
Joseph T. Lyons
created
25de2ac
Correct workspace db directory paths (#40868)
Click to expand commit body
Release Notes:
- N/A
Joseph T. Lyons
created
8bad2cb
Add another informational blog post to docs (#40865)
Click to expand commit body
Release Notes:
- N/A
Joseph T. Lyons
created
762af09
Add more troubleshooting information (#40864)
Click to expand commit body
Release Notes:
- N/A
Joseph T. Lyons
created
3d3e913
collab: Pin sea-orm-macro crate version together with sea-orm (#40846)
Click to expand commit body
Currently running `cargo update` on Zed will break the collab crate
because the versions of sea-orm and sea-orm-macros will not match. This
results in a bunch of noisy warnings from rust-analyzer.
Release Notes:
- N/A
John Tur
,
Mikayla Maki
, and
Conrad Irwin
created
e468edd
Fix extraction of font runs from text runs (#40840)
Click to expand commit body
Fixes a bug in https://github.com/zed-industries/zed/pull/39928
The bug caused all completions to appear in bold-face
Release Notes:
- Fixed a bug where bold-face font was applied to the wrong characters
in items in the autocomplete menu
Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
2338164
Revert "title_bar: Add configurable window controls position (#38834)" (#40839)
Click to expand commit body
This reverts commit b479d1ef49120c5b7d8a319d918ac18c398d1d3b.
This PR was accidentally merged prematurely.
https://github.com/zed-industries/zed/pull/38834#issuecomment-3424186051
cc @danilo-leal
Release Notes:
- N/A
Be
created
2deafd8
project_panel: Don't show trash dialog on remote connections (#40838)
Click to expand commit body
In remote connections, we don't detect whether trashing is possible and
generally shouldn't assume it is. This also fixes up some incomplete
logic that was attempting to do that.
Closes #39212
Release Notes:
- No longer show trash option in remote projects
Closes #ISSUE
Release Notes:
- settings_ui: Added a warning banner when the settings file you are
actively editing is in a broken or invalid state.
Ben Kunkle
created
8f3da5c
settings_ui: Add pickers for theme and icon themes (#40829)
Click to expand commit body
In the process of adding pickers for the theme and icon themes fields in
the settings UI, I felt like there was an improvement opportunity in
regards to where some of these components are stored. The `ui_input`
crate originally was meant only for the text field-like component, which
couldn't be in the regular `ui` crate due to the dependency with
`editor`. Given we had also added the number field there—which is
similar in also having the same dependency—it made sense to think of
this crate more like a home for form-like components rather than for
only one component.
However, we were also storing some settings UI-specific stuff in that
crate, which didn't feel right. So I ended up creating a new directory
within the `settings_ui` for components and moved all the pickers and
the custom input field there. I think this makes it for a cleaner
structure.
Release Notes:
- settings_ui: Added the ability to search for theme and icon themes in
their respective fields.
Danilo Leal
created
b519f53
Rope benchmarks: Generate random strings measured in bytes, not chars (#39951)
Click to expand commit body
Follows on from https://github.com/zed-industries/zed/pull/39949.
Again I'm not 100% sure of the intent but I think this is a fix:
`generate_random_string(rng, 4096)` would previously give you a string
of 4096 *chars* which could be anywhere between 4kB and 16kB in bytes.
This seems probably not what was intended, because Ropes generally work
in bytes not chars, including for the offsets used to index into them.
This seems to possibly cause a _regression_ in benchmark performance,
which is surprising because it should generally cause smaller test data.
But, possibly it's doing better at exercising different paths?
cc @mrnugget
Release Notes:
- N/A