fbd98c1
agent_servers: Fix panic when setting default mode (#42452) (cherry-pick to preview) (#42455)
Click to expand commit body
Cherry-pick of #42452 to preview
----
Closes ZED-35A
Release Notes:
- Fixed an issue where Zed would panic when trying to set the default
mode for ACP agents
Co-authored-by: Bennet Bo Fenner <bennet@zed.dev>
zed-zippy[bot]
and
Bennet Bo Fenner
created
50b491b
gpui: Do not panic when unable to find the selected fonts (#42212) (cherry-pick to preview) (#42456)
Click to expand commit body
Cherry-pick of #42212 to preview
----
Fixes ZED-329
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Co-authored-by: Lukas Wirth <lukas@zed.dev>
zed-zippy[bot]
and
Lukas Wirth
created
9dab0e5
remote: Add more context to error logging in wsl (#42450) (cherry-pick to preview) (#42451)
Click to expand commit body
Cherry-pick of #42450 to preview
----
cc https://github.com/zed-industries/zed/issues/40892
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Co-authored-by: Lukas Wirth <lukas@zed.dev>
zed-zippy[bot]
and
Lukas Wirth
created
b0c8952
gpui: Fix invalid unwrap in windows window creation (#42426) (cherry-pick to preview) (#42429)
Click to expand commit body
Cherry-pick of #42426 to preview
----
Fixes ZED-34M
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Co-authored-by: Lukas Wirth <lukas@zed.dev>
zed-zippy[bot]
and
Lukas Wirth
created
47bdf9f
terminal: Spawn terminal process on main thread on macos again (#42411) (cherry-pick to preview) (#42413)
Click to expand commit body
Cherry-pick of #42411 to preview
----
Closes https://github.com/zed-industries/zed/issues/42365, follow up to
https://github.com/zed-industries/zed/pull/42234
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Co-authored-by: Lukas Wirth <lukas@zed.dev>
zed-zippy[bot]
and
Lukas Wirth
created
02cc776
diagnostics: Fix panic due non-sorted diagnostics excerpt ranges (#42416) (cherry-pick to preview) (#42419)
zed-zippy[bot]
,
Lukas Wirth
, and
Smit Barmase
created
07ffb17
remote: Flush to stdin when writing to sftp (#42103) (cherry-pick to preview) (#42361)
Click to expand commit body
Cherry-pick of #42103 to preview
----
https://github.com/zed-industries/zed/issues/42027#issuecomment-3497210172
Release Notes:
- Fixed ssh remoting potentially failing due to not flushing stdin to
sftp
Co-authored-by: Lukas Wirth <lukas@zed.dev>
zed-zippy[bot]
and
Lukas Wirth
created
b8c644a
Create sentry releases in after_release (#42169)
Click to expand commit body
This had been moved to auto-release preview, and was not running for
stable.
Closes #ISSUE
Release Notes:
- N/A
Cherry-pick of #42298 to preview
----
Fixes ZED-2CQ
We were doing the binary search by buffer points, but due to await
points within this function we could end up mixing points of differing
buffer versions.
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Co-authored-by: Lukas Wirth <lukas@zed.dev>
zed-zippy[bot]
and
Lukas Wirth
created
0c64f51
acp: Fix issue with mentions when `embedded_context` is set to `false` (#42260) (cherry-pick to preview) (#42320)
Click to expand commit body
Cherry-pick of #42260 to preview
----
Release Notes:
- acp: Fixed an issue where Zed would not respect
`PromptCapabilities::embedded_context`
Co-authored-by: Bennet Bo Fenner <bennet@zed.dev>
zed-zippy[bot]
and
Bennet Bo Fenner
created
56bf1e0
agent_ui: Always allow to include symbols (#42261) (cherry-pick to preview) (#42321)
Click to expand commit body
Cherry-pick of #42261 to preview
----
We can always include symbols, since we either include a ResourceLink to
the symbol (when `PromptCapabilities::embedded_context = false`) or a
Resource (when `PromptCapabilities::embedded_context = true`)
Release Notes:
- Fixed an issue where symbols could not be included when using specific
ACP agents
Co-authored-by: Bennet Bo Fenner <bennet@zed.dev>
zed-zippy[bot]
and
Bennet Bo Fenner
created
1ce5974
Fix crash during drag-and-drop on Windows (#42227) (cherry-pick to preview) (#42301)
Click to expand commit body
Cherry-pick of #42227 to preview
----
The HGLOBAL is itself the HDROP. Do not dereference it.
Release Notes:
- windows: Fixed crashes during drag-and-drop operations
Co-authored-by: John Tur <john-tur@outlook.com>
zed-zippy[bot]
and
John Tur
created
db7d11e
terminal: Spawn terminal process on main thread on unix (#42234) (cherry-pick to preview) (#42236)
Click to expand commit body
Cherry-pick of #42234 to preview
----
Otherwise the terminal will not process the signals correctly
Release Notes:
- Fixed ctrl+c and friends not working in the terminal on macOS and
linux
Co-authored-by: Lukas Wirth <lukas@zed.dev>
17afd49
settings_ui: Use any open workspace window when opening settings links (#42106) (cherry-pick to preview) (#42196)
Click to expand commit body
Cherry-pick of #42106 to preview
----
Closes #ISSUE
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Co-authored-by: Ben Kunkle <ben@zed.dev>
zed-zippy[bot]
and
Ben Kunkle
created
6984c9b
workspace: Do not panic when the database is corruped (#42186) (cherry-pick to preview) (#42189)
Click to expand commit body
Cherry-pick of #42186 to preview
----
Fixes ZED-1NK
Release Notes:
- Fixed zed not starting when the database cannot be loaded
Co-authored-by: Lukas Wirth <lukas@zed.dev>
zed-zippy[bot]
and
Lukas Wirth
created
be8038e
project: Fetch latest lsp data in `deduplicate_range_based_lsp_requests` (#41971)
Click to expand commit body
Fixes ZED-2MK
Release Notes:
- Fixed a panic in inlay hints
Lukas Wirth
created
577467b
agent_ui: Do not show Codex wsl warning on wsl take 2 (#42096)
c21c47e
remote: Flush to stdin when writing to sftp 2 (#42126) (cherry-pick to preview) (#42187)
Click to expand commit body
Cherry-pick of #42126 to preview
----
https://github.com/zed-industries/zed/pull/42103#issuecomment-3498137130
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Co-authored-by: Lukas Wirth <lukas@zed.dev>
zed-zippy[bot]
and
Lukas Wirth
created
92142fc
diagnostics: Fix diagnostics view no clearing blocks correctly (#42179) (cherry-pick to preview) (#42181)
Click to expand commit body
Cherry-pick of #42179 to preview
----
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Co-authored-by: Lukas Wirth <lukas@zed.dev>
zed-zippy[bot]
and
Lukas Wirth
created
ed0121d
project: Remove unnecessary panic (#42167) (cherry-pick to preview) (#42168)
Click to expand commit body
Cherry-pick of #42167 to preview
----
If we are in a remote session with the remote dropped, this path is very
much reachable if the call to this function got queued up in a task.
Fixes ZED-124
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Co-authored-by: Lukas Wirth <lukas@zed.dev>
7e6cdab
language: Fix completion menu no longer prioritizes relevant items for Typescript and Python (#42065)
Click to expand commit body
Closes #41672
Regressed in https://github.com/zed-industries/zed/pull/40242
Release Notes:
- Fixed issue where completion menu no longer prioritizes relevant items
for TypeScript and Python.
Smit Barmase
created
f91f3f2
Run ACP login from same cwd as agent server (#42038)
Click to expand commit body
This makes it possible to do login via things like `cmd: "node", args:
["my-node-file.js", "login"]`
Also, that command will now use Zed's managed `node` instance.
Release Notes:
- ACP extensions can now run terminal login commands using relative
paths
Richard Feldman
created
4ebc20b
agent_ui: Fix how icons from external agents are displayed (#42034)
Click to expand commit body
Release Notes:
- N/A
Danilo Leal
created
ac6aa73
gpui: Add support for rendering SVG from external files (#42024)
d2cb9a1
Refresh zed.dev releases page after releases (#42060) (cherry-pick to preview) (#42063)
Click to expand commit body
Cherry-pick of #42060 to preview
----
Release Notes:
- N/A
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
zed-zippy[bot]
and
Conrad Irwin
created
5956489
Fix generate release notes script on first stable (#42061) (cherry-pick to preview) (#42062)
Click to expand commit body
Cherry-pick of #42061 to preview
----
Don't crash in generate-release-notes on the first stable
commit on a branch.
Release Notes:
- N/A
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
zed-zippy[bot]
and
Conrad Irwin
created
418d850
Fix corrupted characters being inserted when Alt is pressed (#42033)
Click to expand commit body
The Alt+Numpad buffer that's maintained by the input stack is getting
corrupted, leading to garbage characters being inserted on keystrokes
like Alt+Up. Disable the automatic handling of Alt+Numpad for now until
the cause of this corruption is understood. The Alt+Numpad input did not
work anyway, so this does not regress anything.
Release Notes:
- windows: Fixed corrupted characters being inserted when Alt is pressed
(preview only)
27fb109
Revert "editor: Add action to move between snippet tabstop positions" (#42008)
Click to expand commit body
Reverts zed-industries/zed#41466
This PR would add "in_snippet" context when there wasn't a completion
menu visible, causing some actions to not be hit.
Release Note:
- N/A
Anthony Eid
created
0f5a63a
agent_ui: Make "waiting confirmation" state more apparent (#41998)
Click to expand commit body
This PR changes the loading/generating indicator when in the "waiting
for tool call confirmation" state so that's a bit more visible and
discernible as needing your attention, as opposed to a regular
generating state.
<img width="400" alt="Screenshot 2025-11-05 at 10 46@2x"
src="https://github.com/user-attachments/assets/88adbf97-20fb-49c4-9c77-b0a3a22aa14e"
/>
Release Notes:
- agent: Improved the "waiting for confirmation" state visibility so
that you more rapidly know the agent is waiting for you to act.
Danilo Leal
created
c8ada5b
agent_ui: Reduce label repetitiveness on new thread menu (#42001)
Click to expand commit body
Mostly just removing "thread" from all external agent menu items; I
think we can do without it and it already becomes much better/cleaner.
Release Notes:
- N/A
Danilo Leal
created
27a1884
open_ai: Make the deltas optional (#39142)
Click to expand commit body
I am using an Azure OpenAI instance since that is what is provided at
work and with how they have it setup not all responses contain a delta,
which lead to errors and truncated responses. This is related to how
they are filtering potentially offensive requests and responses. I don't
believe this filter was made in-house, instead I believe it is provided
by Microsoft/Azure, so I suspect this fix may help other users.
Release Notes:
- N/A
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Techy
and
Bennet Bo Fenner
created
2bc1d60
remote: Fix open terminal fails when $SHELL is not set (#41990)
Click to expand commit body
Closes #41644
Release Notes:
- Fixed issue where it failed to spawn terminal on systems such as
Alpine.
Smit Barmase
created
17933f1
Update documentation on Java support (#41758)
Click to expand commit body
This brings the documentation on Java in line with the much changed
reality of the Java extension.
Note that the correctness of this is contingent on
https://github.com/zed-industries/extensions/pull/3745 being merged.
Release Notes:
- N/A
Karl-Erik Enkelmann
created
cd87307
language: Fix language detection for injected syntax layers (#41111)
Click to expand commit body
Closes #40632
**TL;DR:** The `wrap selections in tag` action was unavailable in ERB
files, even when the cursor was positioned in HTML content (outside of
Ruby code blocks). This happened because `syntax_layer_at()` incorrectly
returned the Ruby language for positions that were actually in HTML.
**NOTE:** I am not familiar with that part of Zed so it could be that
the fix here is completely incorrect.
Previously, `syntax_layer_at` incorrectly reported injected languages
(e.g., Ruby in ERB files) even when the cursor was in the base language
content (HTML). This broke actions like `wrap selections in tag` that
depend on language-specific configuration.
The issue had two parts:
1. Missing start boundary check: The filter only checked if a layer's
end was after the cursor (`end_byte() > offset`), not if it started
before, causing layers outside the cursor position to be included. See
the `BEFORE` video: when I click on the HTML part it reports `Ruby`
language instead of `HTML`.
2. Wrong boundary reference for injections: For injected layers with
`included_sub_ranges` (like Ruby code blocks in ERB), checking the root
node boundaries returned the entire file range instead of the actual
injection ranges.
This fix:
- Adds the containment check using half-open range semantics [start,
end) for root node boundaries. That ensures proper reporting of the
detected language when a cursor (`|`) is located right after the
injection:
```
<body>
<%= yield %>|
</body>
```
- Checks `included_sub_ranges` for injected layers to determine if the
cursor is actually within an injection
- Falls back to root node boundaries for base layers without sub-ranges.
This is the original behavior.
Fixes ERB language support where actions should be available based on
the cursor's actual language context. I think that also applies to some
other template languages like HEEX (Phoenix) and `*.pug`. On short
videos below you can see how I navigate through the ERB template and the
terminal on the right outputs the detected language if you apply the
following patch:
```diff
diff --git i/crates/editor/src/editor.rs w/crates/editor/src/editor.rs
index 15af61f5d2..54a8e0ae37 100644
--- i/crates/editor/src/editor.rs
+++ w/crates/editor/src/editor.rs
@@ -10671,6 +10671,7 @@ impl Editor {
for selection in self.selections.disjoint_anchors_arc().iter() {
if snapshot
.language_at(selection.start)
+ .inspect(|language| println!("Detected language: {:?}", language))
.and_then(|lang| lang.config().wrap_characters.as_ref())
.is_some()
{
```
**Before:**
https://github.com/user-attachments/assets/3f8358f4-d343-462e-b6b1-3f1f2e8c533d
**After:**
https://github.com/user-attachments/assets/c1b9f065-1b44-45a2-8a24-76b7d812130d
Here is the ERB template:
```
<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style>
/* Email styles need to be inline */
</style>
</head>
<body>
<%= yield %>
</body>
</html>
```
Release Notes:
- N/A
Vitaly Slobodin
created
11b29d6
ruby: Add note about enabling Ruby LSP for ERB files (#41851)
Click to expand commit body
Hi, this is a follow-up change for
https://github.com/zed-industries/zed/pull/41754 I think it important to
keep existing things working. So add notes to the Ruby extension doc
about enabling Ruby LSP for ERB files as well. Thanks!
Release Notes:
- N/A
Vitaly Slobodin
created
c061698
project: Fetch latest lsp data in `deduplicate_range_based_lsp_requests` (#41971)
Click to expand commit body
Fixes ZED-2MK
Release Notes:
- Fixed a panic in inlay hints
Lukas Wirth
created
b4f7af0
Work around codegen bug with GetKeyboardState (#41970)
Click to expand commit body
Works around an issue, which can be reproduced in the following program:
```rs
use windows::Win32::UI::Input::KeyboardAndMouse::{GetKeyboardState, VK_CONTROL};
fn main() {
let mut keyboard_state = [0u8; 256];
unsafe {
GetKeyboardState(&mut keyboard_state).unwrap();
}
let ctrl_down = (keyboard_state[VK_CONTROL.0 as usize] & 0x80) != 0;
println!("Is Ctrl down: {ctrl_down}");
}
```
In debug mode, this program prints the correct answer. In release mode,
it always prints false. The optimizer appears to think that
`keyboard_state` isn't mutated and remains zeroed, and folds the
`modifier_down` comparisons to `false`.
Release Notes:
- N/A