0c89ad3
Make multi-byte and surrounding_word tests more readable
Just merge multi-byte tests into the main word movement tests
Nathan Sobo created
210fa4c
Remove CharKind::Newline
This is just a character, and so it seems clearer to refer to it specifically when we want to know if a character is a newline. There was only one case where we relied on Newline being different from Whitespace, and we special-cased that instance. Changing this actually makes us match the behavior of VS Code when double-clicking runs of multiple newlines. /cc @as-cii Co-Authored-By: Keith Simmons <keith@the-simmons.net>
Nathan Sobo and Keith Simmons created
baeb7d2
Clarify word movement function names and improve test coverage
Co-Authored-By: Keith Simmons <keith@the-simmons.net>
Nathan Sobo and Keith Simmons created
06cd9ac
Match the leader's last selection when unfollowing
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Max Brunsfeld and Antonio Scandurra created
3e0bc97
Avoid infinite loop when collaborators follow each other
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Max Brunsfeld and Antonio Scandurra created
05ddd26
Merge pull request #648 from zed-industries/update-fonts-to-1-2-1
Update Zed fonts to 1.2.1
Nathan Sobo created
13a2dac
:lipstick:
Antonio Scandurra created
1c23a45
Update Zed fonts to 1.2.1
Nate Butler created
9575796
Allow unfollowing of leaders by clicking on their avatar
Antonio Scandurra created
a154e45
Implement `Workspace::unfollow`
This also changes the structure of the follow state back to be per-pane. This is because we can't share the same view state across different panes for a couple of reasons: - Rendering the same view in N different panes is almost always not something that we want due to global state such as focus. - If we allowed it and a user followed the same person in two different panes, there would be no way of unfollowing in one pane without also unfollowing in the other.
Antonio Scandurra created
a2dbebd
Hide cursor both locally and remotely when following
Antonio Scandurra created
c03eec0
Merge pull request #647 from zed-industries/fix-reopening-project-items
Pass project entry id to Pane when opening a project item
Nathan Sobo created
7cb8935
Pass project entry id to Pane when opening a project items
This fixes an oversight where we were failing to associate project items with their project entry ids, which broke the logic that prevented the same project entry from being opened twice in the same pane.
Nathan Sobo created
0e920ad
Unset follower's scroll anchor when editor is scrolled all the way up
Antonio Scandurra created
570c987
Handle view updates when following
Basic following now works. Editors' scroll positions are their only replicated view state.
Max Brunsfeld created
e338da0
Allow clicking a titlebar avatar to initiate following
Max Brunsfeld created
d860ed2
Allow FollowableItem::to_state_message to return None
This way, we can avoid a panic if we don't handle certain cases, like a non-singleton editor.
Max Brunsfeld created
df06320
:art: client
Forgot to push this yesterday night.
Max Brunsfeld created
d02ab9b
Start work on updating editors's scroll positions when following
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Max Brunsfeld and Antonio Scandurra created
2c53175
Rename FollowedItem -> FollowableItem
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Max Brunsfeld and Antonio Scandurra created
f4520d4
WIP
Antonio Scandurra created
7d7e105
Broadcast active view to followers
Antonio Scandurra created
3d81eb9
Allow accessing workspace after adding item to pane
Antonio Scandurra created
10e6d82
WIP: Start on sending view updates to followers
Antonio Scandurra created
f0b7bd6
Serialize initial follow state in leader and reflect it in follower
Antonio Scandurra created
0fdaa1d
WIP
Max Brunsfeld created
eda06ee
Add AnyWeakViewHandle
Max Brunsfeld created
5702737
Start work on an integration test for following
Max Brunsfeld created
845457e
Always read project entry id from workspace::Item
We cannot store a workspace item's project entry id separately, since buffers' entry ids can change (for example when doing a *save as*). Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Max Brunsfeld and Antonio Scandurra created
9716ff7
Set up logic for starting following
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Max Brunsfeld and Antonio Scandurra created
2b4738d
Avoid passing a closure to `workspace::register_project_item`
Co-Authored-By: Max Brunsfeld <max@zed.dev>
Antonio Scandurra and Max Brunsfeld created
4bbfd09
Start defining follow protocol
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
c8a6226
Merge pull request #640 from zed-industries/item-view
Remove `workspace::Item` and rename `workspace::ItemView` to `workspace::Item`
Antonio Scandurra created
5d14c9a
Introduce `workspace::register_project_item`
This lets downstream crates like `editor` define how project items should be opened. Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
bff414c
Remove `Editor::find_or_create`
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
6f9c378
Add `Editor::for_multibuffer` and repurpose `Editor::for_buffer`
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
44d997c
Rename `app_state` to `global` in gpui
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
84bacc5
Rename `build_editor` to `build_item` in `Pane::open_item`
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
6446660
Rename `open_buffer_for_path` to `open_buffer`
Antonio Scandurra created
e6755f4
Search only in active pane when using `Editor::find_or_create`
Antonio Scandurra created
a691c2f
Delete unused code
Antonio Scandurra created
0efce8f
Rename `ItemView` to `Item`
Antonio Scandurra created
aced1e2
Finish refactoring of how editors are opened
Antonio Scandurra created
728c708
WIP: Massage opening of editors
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Nathan Sobo and Max Brunsfeld created
1f9885e
Remove open_item_in_pane
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com> Co-Authored-By: Keith Simmons <keith@the-simmons.net>
Nathan Sobo , Max Brunsfeld , and Keith Simmons created
0036e5c
Replace ProjectEntry struct with ProjectEntryId
Previously, we tracked the worktree_id and entry_id separately, but now that entry ids are unique across all worktrees this is unnecessary. Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com> Co-Authored-By: Keith Simmons <keith@the-simmons.net>
Nathan Sobo , Max Brunsfeld , and Keith Simmons created
a88320d
Remove workspace::Item trait
Co-Authored-By: Nathan Sobo <nathan@zed.dev> Co-Authored-By: Keith Simmons <keith@zed.dev> Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
Max Brunsfeld , Nathan Sobo , Keith Simmons , and Antonio Scandurra created
e8efaed
Merge pull request #633 from zed-industries/refresh-windows-panic
Fix edge cases when calling `refresh_windows`
Antonio Scandurra created
b0afb64
Fix edge cases when calling `refresh_windows`
This commit ensures that new views are rendered for the first time. This fixes a panic that could be reproduced by dropping the `ThemeSelector` and opening the file finder during the same update. Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
17742a9
Merge pull request #632 from zed-industries/underline-unused-warning
Restore underline for warnings about unused code
Antonio Scandurra created