Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-Authored-By: Keith Simmons <keith@the-simmons.net>
Nathan Sobo
,
Max Brunsfeld
, and
Keith Simmons
created
0036e5c
Replace ProjectEntry struct with ProjectEntryId
Click to expand commit body
Previously, we tracked the worktree_id and entry_id separately, but now that entry ids are unique across all worktrees this is unnecessary.
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-Authored-By: Keith Simmons <keith@the-simmons.net>
Nathan Sobo
,
Max Brunsfeld
, and
Keith Simmons
created
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Keith Simmons <keith@zed.dev>
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
Max Brunsfeld
,
Nathan Sobo
,
Keith Simmons
, and
Antonio Scandurra
created
e8efaed
Merge pull request #633 from zed-industries/refresh-windows-panic
Click to expand commit body
Fix edge cases when calling `refresh_windows`
Antonio Scandurra
created
b0afb64
Fix edge cases when calling `refresh_windows`
Click to expand commit body
This commit ensures that new views are rendered for the first time. This fixes
a panic that could be reproduced by dropping the `ThemeSelector` and opening
the file finder during the same update.
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra
and
Nathan Sobo
created
17742a9
Merge pull request #632 from zed-industries/underline-unused-warning
Click to expand commit body
Restore underline for warnings about unused code
Antonio Scandurra
created
257601b
Add buffer method for getting the symbols containing a position
Max Brunsfeld
created
76fc9c9
Restore underline for warnings about unused code
Max Brunsfeld
created
a0224cb
Merge pull request #630 from zed-industries/fix/go-to-line-panic
Click to expand commit body
Fix go to line panic by replacing an unwrap with an and_then
Antonio Scandurra
created
7218845
fix go to line panic by replacing an unwrap with an and_then
This lets us use `next` or `prev` to decide whether to park the cursor
at the first or last filtered item.
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
45ce503
Start on implementing filtering support for `Cursor::prev`
Antonio Scandurra
created
7c6fe56
Merge pull request #624 from zed-industries/fix-broken-syntax-highlighting
Click to expand commit body
Make all `HighlightStyle` properties optional
Nathan Sobo
created
fbf7cdf
Make all `HighlightStyle` properties optional
Click to expand commit body
Previously, some of those properties such the font weight, style and color
would be mandatory: when the theme didn't specify them, Zed would use a default
value during deserialization. This meant that those default properties would
unconditionally override the base text style, causing a rendering bug when
combining syntax highlights with diagnostic styles.
This commit fixes that by making `HighlightStyle`s more additive: each property
can be set independently and only the properties that theme specifies get
overridden in the base text style.
Antonio Scandurra
created
72692f1
Merge pull request #622 from zed-industries/guest-settings-file
Click to expand commit body
Open settings file in new window if current window isn't local
Max Brunsfeld
created
3a439f1
Open settings file in new window if current window isn't local
e7835ca
Merge pull request #621 from zed-industries/autoclose-before-punctuation
Click to expand commit body
Autoclose brackets before a language-specific set of characters
Max Brunsfeld
created
325e6c3
Autoclose brackets before a language-specific set of characters
Click to expand commit body
Fixes #588
Max Brunsfeld
created
2c25e61
Respect theme's background color when rendering field editors
Max Brunsfeld
created
7bdb91f
Merge pull request #619 from zed-industries/project-entry-ids
Click to expand commit body
Ensure that worktree entry ids are unique across the project
Max Brunsfeld
created
5822b47
Ensure that worktrees' entry ids are unique across the project
Click to expand commit body
Fixes #512
Max Brunsfeld
created
91b33e4
Merge pull request #618 from zed-industries/fix-block-layout-panic
Click to expand commit body
Fix layout panic on empty editors with blocks
Max Brunsfeld
created
e392368
Fix layout panic on empty editors with blocks
Click to expand commit body
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Max Brunsfeld
and
Antonio Scandurra
created
40a4c18
Merge pull request #604 from zed-industries/set-selections-assertion
Click to expand commit body
Ensure there's at least one selection in `Editor::set_selections`
Antonio Scandurra
created
21eebed
Add more assertions to investigate #503 in the future
Antonio Scandurra
created
a3ea6a3
Ensure there's at least one selection in `Editor::set_selections`
Click to expand commit body
This commit introduces an assertion that will cause Zed to panic as
soon as the invariant gets violated. This will be useful to investigate
issue #503.
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra
and
Nathan Sobo
created
be3bfb2
Merge pull request #603 from zed-industries/fix-presenter-panic
Click to expand commit body
Re-render workspace when removing an inactive pane