d02ab9b
Start work on updating editors's scroll positions when following
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Max Brunsfeld and Antonio Scandurra created
2c53175
Rename FollowedItem -> FollowableItem
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Max Brunsfeld and Antonio Scandurra created
f4520d4
WIP
Antonio Scandurra created
7d7e105
Broadcast active view to followers
Antonio Scandurra created
3d81eb9
Allow accessing workspace after adding item to pane
Antonio Scandurra created
10e6d82
WIP: Start on sending view updates to followers
Antonio Scandurra created
f0b7bd6
Serialize initial follow state in leader and reflect it in follower
Antonio Scandurra created
0fdaa1d
WIP
Max Brunsfeld created
eda06ee
Add AnyWeakViewHandle
Max Brunsfeld created
5702737
Start work on an integration test for following
Max Brunsfeld created
845457e
Always read project entry id from workspace::Item
We cannot store a workspace item's project entry id separately, since buffers' entry ids can change (for example when doing a *save as*). Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Max Brunsfeld and Antonio Scandurra created
9716ff7
Set up logic for starting following
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Max Brunsfeld and Antonio Scandurra created
2b4738d
Avoid passing a closure to `workspace::register_project_item`
Co-Authored-By: Max Brunsfeld <max@zed.dev>
Antonio Scandurra and Max Brunsfeld created
4bbfd09
Start defining follow protocol
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
c8a6226
Merge pull request #640 from zed-industries/item-view
Remove `workspace::Item` and rename `workspace::ItemView` to `workspace::Item`
Antonio Scandurra created
5d14c9a
Introduce `workspace::register_project_item`
This lets downstream crates like `editor` define how project items should be opened. Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
bff414c
Remove `Editor::find_or_create`
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
6f9c378
Add `Editor::for_multibuffer` and repurpose `Editor::for_buffer`
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
44d997c
Rename `app_state` to `global` in gpui
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
84bacc5
Rename `build_editor` to `build_item` in `Pane::open_item`
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
6446660
Rename `open_buffer_for_path` to `open_buffer`
Antonio Scandurra created
e6755f4
Search only in active pane when using `Editor::find_or_create`
Antonio Scandurra created
a691c2f
Delete unused code
Antonio Scandurra created
0efce8f
Rename `ItemView` to `Item`
Antonio Scandurra created
aced1e2
Finish refactoring of how editors are opened
Antonio Scandurra created
728c708
WIP: Massage opening of editors
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Nathan Sobo and Max Brunsfeld created
1f9885e
Remove open_item_in_pane
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com> Co-Authored-By: Keith Simmons <keith@the-simmons.net>
Nathan Sobo , Max Brunsfeld , and Keith Simmons created
0036e5c
Replace ProjectEntry struct with ProjectEntryId
Previously, we tracked the worktree_id and entry_id separately, but now that entry ids are unique across all worktrees this is unnecessary. Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com> Co-Authored-By: Keith Simmons <keith@the-simmons.net>
Nathan Sobo , Max Brunsfeld , and Keith Simmons created
a88320d
Remove workspace::Item trait
Co-Authored-By: Nathan Sobo <nathan@zed.dev> Co-Authored-By: Keith Simmons <keith@zed.dev> Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
Max Brunsfeld , Nathan Sobo , Keith Simmons , and Antonio Scandurra created
e8efaed
Merge pull request #633 from zed-industries/refresh-windows-panic
Fix edge cases when calling `refresh_windows`
Antonio Scandurra created
b0afb64
Fix edge cases when calling `refresh_windows`
This commit ensures that new views are rendered for the first time. This fixes a panic that could be reproduced by dropping the `ThemeSelector` and opening the file finder during the same update. Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
17742a9
Merge pull request #632 from zed-industries/underline-unused-warning
Restore underline for warnings about unused code
Antonio Scandurra created
257601b
Add buffer method for getting the symbols containing a position
Max Brunsfeld created
76fc9c9
Restore underline for warnings about unused code
Max Brunsfeld created
a0224cb
Merge pull request #630 from zed-industries/fix/go-to-line-panic
Fix go to line panic by replacing an unwrap with an and_then
Antonio Scandurra created
7218845
fix go to line panic by replacing an unwrap with an and_then
Keith Simmons created
f20aaf5
v0.21.0
Antonio Scandurra created
22688c7
Merge pull request #627 from zed-industries/golden-line-height
Compute line-height as a multiple of font size
Antonio Scandurra created
447f350
Compute line-height as a multiple of font size
...instead of using the bounding box. This makes `PragmataPro` and other fonts render more cleanly. Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
8122abe
Merge pull request #626 from zed-industries/inactive-code-diagnostics
De-emphasize unnecessary code diagnostics
Antonio Scandurra created
c6c72a7
Skip over unnecessary code diagnostics when hitting `f8`
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
7155dab
Fade out unnecessary code
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
41bd58e
Only show errors and warnings in project diagnostics
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
182b2b1
Merge pull request #625 from zed-industries/go-to-prev-diagnostic
Go to previous diagnostic via `shift-f8`
Antonio Scandurra created
021699e
Implement `shift-f8` to go to previous diagnostic
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
a6d0caf
Don't seek `FilterCursor` upon creation
This lets us use `next` or `prev` to decide whether to park the cursor at the first or last filtered item. Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
f10fd6c
Randomize test `FilterCursor::prev`
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
45ce503
Start on implementing filtering support for `Cursor::prev`
Antonio Scandurra created
7c6fe56
Merge pull request #624 from zed-industries/fix-broken-syntax-highlighting
Make all `HighlightStyle` properties optional
Nathan Sobo created
fbf7cdf
Make all `HighlightStyle` properties optional
Previously, some of those properties such the font weight, style and color would be mandatory: when the theme didn't specify them, Zed would use a default value during deserialization. This meant that those default properties would unconditionally override the base text style, causing a rendering bug when combining syntax highlights with diagnostic styles. This commit fixes that by making `HighlightStyle`s more additive: each property can be set independently and only the properties that theme specifies get overridden in the base text style.
Antonio Scandurra created