Commit log

82e9f73 Use a CallbackCollection for release observations

Click to expand commit body
Co-authored-by: Kay Simmons <kay@zed.dev>

Max Brunsfeld and Kay Simmons created

fa620bf Fix logic error in dropping callback subscriptions

Click to expand commit body
Co-authored-by: Kay Simmons <kay@zed.dev>

Max Brunsfeld and Kay Simmons created

378f0c3 Restructure callback subscriptions

Click to expand commit body
Fix a callback leak that would occur when dropping a subscription
to a callback collection after triggering that callback, but before
processing the effect of *adding* the handler.

Co-authored-by: Kay Simmons <kay@zed.dev>

Max Brunsfeld and Kay Simmons created

77e322c Wait for incomplete buffers when handling incoming buffer file updates

Nathan Sobo created

f669b8a Merge pull request #2007 from zed-industries/recent-projects-prefer-first-match

Click to expand commit body
Prefer first max while fuzzy matching projects fixes unexpected behavior

Julia created

09d57d1 Prefer first max while fuzzy matching projects fixes unexpected behavior

Julia created

7a62976 Re-request incomplete remote buffers when syncing buffers

Click to expand commit body
Any buffers we requested but that haven't been fully sent will cause
outstainding open requests to hang. If we re-request them, any
waiting open requests will resume when the requested buffers finish
being created.

Co-authored-by: Max Brunsfeld <max@zed.dev>
Co-authored-by: Mikayla Maki <mikayla@zed.dev>

Nathan Sobo , Max Brunsfeld , and Mikayla Maki created

bd223f5 Merge pull request #2002 from zed-industries/appease-clippy

Click to expand commit body
Appease clippy

Joseph T. Lyons created

1006ada Update scan_id on worktree entries when there is a conflict

Click to expand commit body
Forgetting to do this meant we were unable to sync changes with reconnecting
guests in some cases.

Nathan Sobo created

79f8f08 v0.69.x dev

Mikayla Maki created

789bbf1 Update buffer files when synchronizing buffers

Click to expand commit body
It's possible that the host was disconnected when attempting to notify
guests of a file save, so we need to transmit this in order to correctly
update the file's mtime.

Next failing seed OPERATIONS=200 SEED=6894

Nathan Sobo created

1dd085f Introduce completed_scan_id to worktree

Click to expand commit body
We need to know the most recent scan id we have actually completed. This is to
handle the case where a guest disconnects when we're in the middle of streaming
worktree entries to them. When they reconnect, they need to report a scan_id
from before we started streaming the entries, because we have no record of when
the stream was interrupted.

Next failure:
SEED=5051 ITERATIONS=1 OPERATIONS=200 cargo test --release --package=collab random -- --nocapture

Nathan Sobo created

1e18480 Merge pull request #2005 from zed-industries/tsserver-include-completion-detail

Click to expand commit body
Include Typescript completion item `detail` field in completion label

Julia created

93a6349 Include Typescript completion item `detail` field in completion label

Julia created

90fb9b5 WIP

Nathan Sobo created

d0ce7b3 Merge pull request #2003 from zed-industries/correct-ra-name-key-default-settings

Click to expand commit body
Correct default settings' name key for RA in init options example

Julia created

b94c265 Correct default settings' name key for RA in init options example

Julia created

8d70a22 Record failing seed

Nathan Sobo created

a6ffcdd Track open buffers when handling sync requests

Click to expand commit body
When a host sends a buffer to a guest for the first time, they record that
they have done so in a set tied to that guest's peer id. When the guest
reconnects and syncs buffers, they do so under a different peer id, so we
need to be sure we track which buffers we have sent them to avoid sending
them the same buffer twice, which violates the guest's assumptions.

Nathan Sobo created

7484349 Assign fake fs entries' mtimes more consistently

Max Brunsfeld created

6b62ce2 Merge pull request #2001 from zed-industries/dissmis-search-button

Click to expand commit body
Add dismiss buffer search button & fix some faulty icon button styling

Julia created

2b1118f Add dismiss buffer search button & fix some faulty icon button styling

Click to expand commit body
Co-Authored-By: Nate Butler <nate@zed.dev>

Julia and Nate Butler created

233b28a Appease clippy

Joseph Lyons created

eeb21af Merge pull request #2000 from zed-industries/fix-line-seperator

Click to expand commit body
Add other line seperators to regex normalization

Mikayla Maki created

a5bccec Add other line seperators to regex normalization

Mikayla Maki created

0f818f2 Merge pull request #1996 from zed-industries/add-close-clean-items-command

Click to expand commit body
Add close clean items command

Joseph T. Lyons created

7187cc8 Merge pull request #1994 from zed-industries/add-close-all-items-command

Click to expand commit body
Add close all items command

Joseph T. Lyons created

2bc3660 Rename variable

Joseph Lyons created

60f2941 Add close clean items command

Joseph Lyons created

ca3c456 Add close all items command

Joseph Lyons created

f3dee2d Remove printlns, found a failure

Click to expand commit body
Failing seed:
SEED=416 MAX_PEERS=2 ITERATIONS=5000 OPERATIONS=159 cargo +beta test --package=collab random -- --nocapture

Nathan Sobo created

273988b Set transaction group interval to ZERO by default in tests

Click to expand commit body
We were seeing non-deterministic behavior in randomized tests when
generating backtraces took enough time to cause transactions to group
in some cases, but not group in others.

Tests will need to explicitly opt into grouping if they want it by
setting the interval explicitly. We have tests in the text module that
currently test the history grouping explicitly, but I'm not sure
it's needed elsewhere.

Nathan Sobo created

b6337f5 Merge pull request #1992 from zed-industries/add-home-and-end-key-support

Click to expand commit body
Add home and end key support

Joseph T. Lyons created

21a0df4 Add home and end key support

Joseph Lyons created

599acf0 WIP - Panic immediately when detecting non-determinism via a change to the execution trace

Max Brunsfeld created

6458a91 WIP: failing randomized test

Click to expand commit body
SEED=175 MAX_PEERS=2 ITERATIONS=1 OPERATIONS=159 cargo test --package=collab random -- --nocapture

Antonio Scandurra created

344d050 Avoid hanging waiting for operations when buffer has none

Antonio Scandurra created

75803d8 Respond with an error when client hasn't got a registered handle

Antonio Scandurra created

04e053a Merge pull request #1991 from zed-industries/add-actions-for-requesting-features-and-filing-bug-reports

Click to expand commit body
Add actions for requesting features and filing bug reports

Joseph T. Lyons created

41bff39 Add actions for requesting features and filing bug reports

Joseph Lyons created

46152c6 Merge pull request #1990 from zed-industries/add-memory-to-system-specs

Click to expand commit body
Add memory to system specs

Joseph T. Lyons created

f65fda2 Add memory to system specs

Joseph Lyons created

96ac650 Merge pull request #1989 from zed-industries/add-command-to-copy-system-information-to-the-clipboard

Click to expand commit body
add command to copy system information to the clipboard

Joseph T. Lyons created

ea16082 Factored data into a SystemSpecs struct

Click to expand commit body
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com>

Joseph Lyons and Mikayla Maki created

42e74e7 Excluded deleted entries when initially sending worktrees to guests

Click to expand commit body
Co-authored-by: Antonio Scandurra <antonio@zed.dev>

Max Brunsfeld and Antonio Scandurra created

738e161 WIP: failing test

Click to expand commit body
SEED=882 RUST_LOG=collab::tests::randomized_integration_tests=info MAX_PEERS=2 ITERATIONS=1 OPERATIONS=49 cargo test --package=collab random -- --nocapture

Antonio Scandurra created

559e147 Restructure randomized test to be a bit clearer and test more stuff

Antonio Scandurra created

eeb5b03 add command to copy system information to the clipboard

Joseph Lyons created

d750b02 Handle file and diff updates to incomplete buffers

Click to expand commit body
Co-authored-by: Antonio Scandurra <antonio@zed.dev>

Max Brunsfeld and Antonio Scandurra created

c321f5d Assert that buffers' file state matches in randomized collab test

Click to expand commit body
Co-authored-by: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created