Don't rely on contacts popover or contacts list for theming
Add metrics id to request body
Clean up some code and comments
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com>
53cb3a4
Remove GC step for callback collections, always drop callbacks asap
Max Brunsfeld
created
ef192a9
Remove dropped subscription eagerly when removing callbacks
Max Brunsfeld
created
585c23e
Match guest's reported buffers on host when synchronizing after reconnect
Click to expand commit body
If the host thinks a guest has a buffer that they don't have, the host won't
send it to them when they attempt to open it the next time. This can happen
if the guest disconnected before they received the host's response to an
initial open buffer request.
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra
and
Nathan Sobo
created
4708f5d
Add test for notifying and dropping subscriptions in an update cycle
Fix a callback leak that would occur when dropping a subscription
to a callback collection after triggering that callback, but before
processing the effect of *adding* the handler.
Co-authored-by: Kay Simmons <kay@zed.dev>
77e322c
Wait for incomplete buffers when handling incoming buffer file updates
Nathan Sobo
created
f669b8a
Merge pull request #2007 from zed-industries/recent-projects-prefer-first-match
Click to expand commit body
Prefer first max while fuzzy matching projects fixes unexpected behavior
Julia
created
09d57d1
Prefer first max while fuzzy matching projects fixes unexpected behavior
Julia
created
7a62976
Re-request incomplete remote buffers when syncing buffers
Click to expand commit body
Any buffers we requested but that haven't been fully sent will cause
outstainding open requests to hang. If we re-request them, any
waiting open requests will resume when the requested buffers finish
being created.
Co-authored-by: Max Brunsfeld <max@zed.dev>
Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Nathan Sobo
,
Max Brunsfeld
, and
Mikayla Maki
created
bd223f5
Merge pull request #2002 from zed-industries/appease-clippy
Click to expand commit body
Appease clippy
Joseph T. Lyons
created
1006ada
Update scan_id on worktree entries when there is a conflict
Click to expand commit body
Forgetting to do this meant we were unable to sync changes with reconnecting
guests in some cases.
789bbf1
Update buffer files when synchronizing buffers
Click to expand commit body
It's possible that the host was disconnected when attempting to notify
guests of a file save, so we need to transmit this in order to correctly
update the file's mtime.
Next failing seed OPERATIONS=200 SEED=6894
We need to know the most recent scan id we have actually completed. This is to
handle the case where a guest disconnects when we're in the middle of streaming
worktree entries to them. When they reconnect, they need to report a scan_id
from before we started streaming the entries, because we have no record of when
the stream was interrupted.
Next failure:
SEED=5051 ITERATIONS=1 OPERATIONS=200 cargo test --release --package=collab random -- --nocapture
Nathan Sobo
created
1e18480
Merge pull request #2005 from zed-industries/tsserver-include-completion-detail
Click to expand commit body
Include Typescript completion item `detail` field in completion label
Julia
created
93a6349
Include Typescript completion item `detail` field in completion label
a6ffcdd
Track open buffers when handling sync requests
Click to expand commit body
When a host sends a buffer to a guest for the first time, they record that
they have done so in a set tied to that guest's peer id. When the guest
reconnects and syncs buffers, they do so under a different peer id, so we
need to be sure we track which buffers we have sent them to avoid sending
them the same buffer twice, which violates the guest's assumptions.
Nathan Sobo
created
7484349
Assign fake fs entries' mtimes more consistently
Max Brunsfeld
created
6b62ce2
Merge pull request #2001 from zed-industries/dissmis-search-button