0324ca3
Be more specific about clearing (leader, follower) row
Click to expand commit body
Previously anyone unfollowing someone would clear all other rows for
other followers leading to an incorrect state, fix and test
Co-Authored-By: Max Brunsfeld <max@zed.dev>
We've noticed that the search theme struct had two fields for a tab icon width and spacing. But we already have those in the tab theme struct. We decided to remove the duplicate and reuse the tab fields.
We also wanted to move where the spacing is being used. Instead of doing it at the left of the label, we do it at the right of the icon to match how it is done in other areas of the UI.
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com>
This was 8 but we've seen areas where this was 14, like the project search tab icon. We want to match this.
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com>
Petros Amoiridis
and
Julia
created
7b55917
Merge pull request #2201 from zed-industries/save-shortcuts
Click to expand commit body
Add OS UI Keybindings
Mikayla Maki
created
d730507
Merge pull request #2198 from zed-industries/more-item-defaults
Click to expand commit body
Add more default impls to the item trait
Mikayla Maki
created
4798b72
Fixed keyboard shortcuts in mac os native panels
Click to expand commit body
co-authored-by: Antonio <antonio@zed.dev>
Mikayla Maki
and
Antonio
created
71d8ead
Introduce an OSAction that can be associated with menu items for mac platform compatibility.
Rather than overload Flex with yet another special case, add a dedicated
element to handle this overlap instead
Co-Authored-By: Max Brunsfeld <max@zed.dev>
ed2f1dd
Move workspace title into collaboration titlebar item render
Julia
created
8dd249a
Hold room lock through the entirety of a `room_transaction`
Click to expand commit body
Previously, when the host repeatedly sent `UpdateWorktree` messages,
new guests attempting to join a project would observe a severe slowdown
caused by a database serialization error (e.g., the coherence of the data
would get violated midway through `Database::join_project` due to worktree
entries being mutated as the user joined). Writing entries is pretty fast,
whereas reading all of them for a project can take more than 100ms.
Transactions that failed due to a serialization error are retried, but the guest
would keep retrying until the host finished writing because the guest's read
was slow.
This commit changes the semantics of `room_transaction` to acquire a room
lock before even starting the transaction and holding it all the way after
commit (storing it, as before, in the `RoomGuard`). This ensures that a fast
writer (the host) can't starve a slow reader (the guest), allowing the latter
to make progress by temporarily pausing writes by the former.
Antonio Scandurra
created
24fcad3
Merge pull request #2189 from zed-industries/labeled-tasks