5eb1719
Re-send worktree if reconnecting while initial scan isn't finished yet
Click to expand commit body
Previously, if the client was disconnected while the initial worktree
state was being sent, it would not see the remaining state after reconnecting.
This was due to `scan_id` and `completed_scan_id` both being initialized to
`0`, so the client would ask for updates since `0` and get nothing.
This commit changes the worktree to initialize `scan_id` to `1` and
`completed_scan_id` to `0`, so that we get the full worktree again on reconnect.
Antonio Scandurra
created
172441a
Cancel pending calls when participant fails to reconnect
Click to expand commit body
Previously, we would only cancel pending calls when the room became
empty.
Antonio Scandurra
created
5e37c89
Ensure project is still alive by the time remote LSP request starts
0e4de87
Merge pull request #2367 from zed-industries/log-github-api-response-for-deserialize-error
Click to expand commit body
In the case of Github release deserialize error, log response text
Julia
created
189784f
In the case of Github release deserialize error, log response text
Click to expand commit body
Co-Authored-By: Joseph Lyons <joseph@zed.dev>
Julia
and
Joseph Lyons
created
e798156
Preserve ordering between UpdateProject and CreateBufferForPeer messages
Click to expand commit body
Previously, because UpdateProject messages were sent in a separately-
spawned task, they could be sent after CreateBufferForPeer messages that
were intended to be sent after them.
Co-authored-by: Antonio Scandurra <antonio@zed.dev>
Max Brunsfeld
and
Antonio Scandurra
created
9761feb
Avoid broadcasting `SaveBuffer` in response to a client's save request
Click to expand commit body
The host will send a `SaveBuffer` message anyway and this prevents re-querying
the database, which could cause two `BufferSaved` messages to race and, as a
result, cause guest to apply them in the wrong order.
Antonio Scandurra
created
3a82c04
Improve assertion message when buffer state diverges
Antonio Scandurra
created
016343e
Merge branch 'main' into randomized-tests-operation-script
Antonio Scandurra
created
7f73ebd
Apply `BufferReloaded` message to incomplete remote buffers
Antonio Scandurra
created
116d4f2
Merge pull request #2366 from zed-industries/avoid-unwrapping-on-try-send
Click to expand commit body
Don't panic if worktree was dropped before sending path changes
Antonio Scandurra
created
372e31d
Don't panic if worktree was dropped before sending path changes
Click to expand commit body
In `refresh_entry`, we send a message to the `self.path_changes_tx` channel
to notify the background thread that a path has changed. However, given that
`refresh_entry` uses `spawn_weak`, the worktree could get dropped before sending
the message, which could cause a panic.
This commit changes the code to return an error instead of panicking.
There may have been a good reason for the difference at some point, or I was
still learning Rust. But now it's just &mut AppContext vs &AppContext.
Nathan Sobo
created
aa7918c
Fix handling of redundant buffer creation messages on guests
Click to expand commit body
Check if the buffer already exists *before* overwriting it.
Ignore redundant registrations on remote projects.
Co-authored-by: Antonio Scandurra <antonio@zed.dev>
Max Brunsfeld
and
Antonio Scandurra
created
22a6a24
Move project assertions into main assertion function
Click to expand commit body
Co-authored-by: Antonio Scandurra <antonio@zed.dev>
Max Brunsfeld
and
Antonio Scandurra
created
dd00966
Merge pull request #2361 from zed-industries/add-close-items-to-left-and-right
Click to expand commit body
Add close items to left and right
Joseph T. Lyons
created
ef04dc1
Update file on incomplete buffer instead of waiting for it to be opened
Click to expand commit body
This ensures that two successive file updates coming from the host are
not applied in reverse order.
Antonio Scandurra
created
4b39df4
Merge pull request #2304 from zed-industries/bump-diff-width
Click to expand commit body
Increase git diff gutter width slightly
Julia
created
8020ea7
Wait to see guest's buffer version before converting completion anchor
Antonio Scandurra
created
4a61e2d
Save server operations that were in the middle of being applied
Click to expand commit body
Previously, if the test panicked before it had a chance to fully
apply an operation, it would end up not being saved in the plan.
With this commit we will mark the operation as applied before we
start processing it, and mark it as not applied if, once we're done,
we've found out that it couldn't be applied. This is consistent with
what we do for client operations.
Antonio Scandurra
created
f995d07
Return error if subscribing to an entity that was already subscribed to
Antonio Scandurra
created
d7f56d6
Forget which buffers were shared when host reconnects
Click to expand commit body
This fixes a bug where the host would momentarily disconnect and the guest
would close and reopen the project. This would cause the host to not observe
the guest closing the project. When the guest tried to open one of the
buffers opened prior to closing the project, the host would not send them the
buffer state because it would still remember that the buffer was shared.
The `shared_buffers` map is now cleared when the host reconnects and will slowly
get re-filled as guests issue `SynchronizeBuffers` requests.