Commits in v0.94.4 | Zed (mirror)

Commit log

`167dd1c` Support basic inlay hints (#2660)

Click to expand commit body

Part of https://github.com/zed-industries/community/issues/138
Part of https://linear.app/zed-industries/issue/Z-477/inlay-hints

Supports LSP requests for inlay hints, LSP /refresh request to reload
them.
Reworks DisplayMap and underlying layer to unite suggestions with inlay
hints into new, `InlayMap`.
Adds a hint cache inside `Editor` that tracks buffer/project/LSP request
events, updates the hints and ensures opened editors are showing up to
date text hints on top.

Things left to do after this PR:
* docs on how to configure inlay hints
* blogpost
* dynamic hints: resolve, hover, navigation on click, etc.

Release Notes:

- Added basic support of inlay hints

Kirill Bulatov created 2 years ago

`b146762` Remove a flacky test, fix the failing one

Kirill Bulatov created 2 years ago

`652909c` Post-rebase fixes

Kirill Bulatov created 2 years ago

`3445bc4` Invalidate refresh tasks better

Kirill Bulatov created 2 years ago

`98edc0f` Simplify the hint cache code

Kirill Bulatov created 2 years ago

`083e4e7` Better tests, invalidate multibuffer excerpts better

Kirill Bulatov created 2 years ago

`943c93f` Simplify hint task queueing

Kirill Bulatov created 2 years ago

`30e77aa` More inlay hint cache tests

Kirill Bulatov created 2 years ago

`429a9cd` Use fold points to go to display map's prev/next line boundary

Click to expand commit body

Co-Authored-By: Antonio Scandurra <antonio@zed.dev>

Kirill Bulatov and Antonio Scandurra created 2 years ago

`bb9ade5` Fix wrap map test

Click to expand commit body

Co-Authored-By: Antonio Scandurra <antonio@zed.dev>

Kirill Bulatov and Antonio Scandurra created 2 years ago

`2b59f27` Fix fold map tests

Click to expand commit body

Co-Authored-By: Antonio Scandurra <antonio@zed.dev>

Kirill Bulatov and Antonio Scandurra created 2 years ago

`0972766` Add more hint tests

Kirill Bulatov created 2 years ago

`15e0feb` Move highlights from fold to inlay randomized tests

Kirill Bulatov created 2 years ago

`667b70a` Move hint settings on the language level

Kirill Bulatov created 2 years ago

`480d8c5` Theme hints and suggestions differently

Kirill Bulatov created 2 years ago

`3312c91` Improve inlay hint highlights

Click to expand commit body

Co-Authored-By: Antonio Scandurra <antonio@zed.dev>

Kirill Bulatov and Antonio Scandurra created 2 years ago

`2c54d92` Test inlay hint cache

Kirill Bulatov created 2 years ago

`143a020` Update Hint Style

Click to expand commit body

zzz

Nate Butler created 2 years ago

`67214f0` Only skip /refresh inlay queries when vislble range is not updated

Kirill Bulatov created 2 years ago

`096bad1` Revert useless changes, simplify

Kirill Bulatov created 2 years ago

`f77b680` Account for inlay biases when clipping a point

Antonio Scandurra created 2 years ago

`976edfe` Add `Cursor::next_item`

Antonio Scandurra created 2 years ago

`5c21ed4` Properly filter out task hints

Kirill Bulatov created 2 years ago

`dfb3021` Remove mutex usage from *Map contents

Kirill Bulatov created 2 years ago

`acef5ff` Query hints when editors gets open and visible

Kirill Bulatov created 2 years ago

`11fee4c` Do not eagerly cancel running tasks

Kirill Bulatov created 2 years ago

`4d4544f` Split excerpts into mutliple ranges for inlay hint queries

Kirill Bulatov created 2 years ago

`2c7900e` Use excerpt visible range in query filtering

Kirill Bulatov created 2 years ago

`83b3a91` Support better inlay cache parallelization

Kirill Bulatov created 2 years ago

`890b164` Forward inlay hint refresh requests to clients, test coop inlay hints

Kirill Bulatov created 2 years ago

`a68e68a` Properly filter out new hints outside of excerpts' visible ranges

Kirill Bulatov created 2 years ago

`ba3d1e4` Deduplicate inlay hints queries with buffer versions

Kirill Bulatov created 2 years ago

`f25a09b` Avoid excessive allocations with Arc around excerpt cached inlays

Kirill Bulatov created 2 years ago

`48982c3` Filter away new hints not in excerpt range

Kirill Bulatov created 2 years ago

`316e19c` Remove stale cancelled inlay hints workaround

Kirill Bulatov created 2 years ago

`96a34ad` Use text anchors as hint position in hints cache

Click to expand commit body

co-authored-by: Max Brunsfeld <max@zed.dev>

Kirill Bulatov and Max Brunsfeld created 2 years ago

`781fa0c` Deduplicate LSP requests on multibuffer scroll

Kirill Bulatov created 2 years ago

`c61de29` Use proper anchors for remote LSP queries

Kirill Bulatov created 2 years ago

`cb4b92a` Simplify hint event management slightly

Kirill Bulatov created 2 years ago

`d59e91a` Insert new hints into cache better

Kirill Bulatov created 2 years ago

`d682858` Box the cache for better performance

Kirill Bulatov created 2 years ago

`1722d61` Mitigate odd offset calculations

Kirill Bulatov created 2 years ago

`7fddc22` Move away heavy inlay computations into background tasks

Kirill Bulatov created 2 years ago

`31f0f9f` Forbid extra inlay updates

Kirill Bulatov created 2 years ago

`97e5d40` Add snapshot version to use when avoiding wrong state updates

Kirill Bulatov created 2 years ago

`8d982a6` Finish modelling

Kirill Bulatov created 2 years ago

`4c78019` Start to model the background threads for InlayHintCache

Kirill Bulatov created 2 years ago

`2f1a276` React on multibuffer scrolls again

Kirill Bulatov created 2 years ago

`a31d3ec` Spawn cache updates in separate tasks

Kirill Bulatov created 2 years ago

`9698b51` Prevent insertion of empty inlays into `InlayMap`

Antonio Scandurra created 2 years ago

Commit log

167dd1c Support basic inlay hints (#2660)

b146762 Remove a flacky test, fix the failing one

652909c Post-rebase fixes

3445bc4 Invalidate refresh tasks better

98edc0f Simplify the hint cache code

083e4e7 Better tests, invalidate multibuffer excerpts better

943c93f Simplify hint task queueing

30e77aa More inlay hint cache tests

429a9cd Use fold points to go to display map's prev/next line boundary

bb9ade5 Fix wrap map test

2b59f27 Fix fold map tests

0972766 Add more hint tests

15e0feb Move highlights from fold to inlay randomized tests

667b70a Move hint settings on the language level

480d8c5 Theme hints and suggestions differently

3312c91 Improve inlay hint highlights

2c54d92 Test inlay hint cache

143a020 Update Hint Style

67214f0 Only skip /refresh inlay queries when vislble range is not updated

096bad1 Revert useless changes, simplify

f77b680 Account for inlay biases when clipping a point

976edfe Add `Cursor::next_item`

5c21ed4 Properly filter out task hints

dfb3021 Remove mutex usage from *Map contents

acef5ff Query hints when editors gets open and visible

11fee4c Do not eagerly cancel running tasks

4d4544f Split excerpts into mutliple ranges for inlay hint queries

2c7900e Use excerpt visible range in query filtering

83b3a91 Support better inlay cache parallelization

890b164 Forward inlay hint refresh requests to clients, test coop inlay hints

a68e68a Properly filter out new hints outside of excerpts' visible ranges

ba3d1e4 Deduplicate inlay hints queries with buffer versions

f25a09b Avoid excessive allocations with Arc around excerpt cached inlays

48982c3 Filter away new hints not in excerpt range

316e19c Remove stale cancelled inlay hints workaround

96a34ad Use text anchors as hint position in hints cache

781fa0c Deduplicate LSP requests on multibuffer scroll

c61de29 Use proper anchors for remote LSP queries

cb4b92a Simplify hint event management slightly

d59e91a Insert new hints into cache better

d682858 Box the cache for better performance

1722d61 Mitigate odd offset calculations

7fddc22 Move away heavy inlay computations into background tasks

31f0f9f Forbid extra inlay updates

97e5d40 Add snapshot version to use when avoiding wrong state updates

8d982a6 Finish modelling

4c78019 Start to model the background threads for InlayHintCache

2f1a276 React on multibuffer scrolls again

a31d3ec Spawn cache updates in separate tasks

9698b51 Prevent insertion of empty inlays into `InlayMap`

`167dd1c` Support basic inlay hints (#2660)

`b146762` Remove a flacky test, fix the failing one

`652909c` Post-rebase fixes

`3445bc4` Invalidate refresh tasks better

`98edc0f` Simplify the hint cache code

`083e4e7` Better tests, invalidate multibuffer excerpts better

`943c93f` Simplify hint task queueing

`30e77aa` More inlay hint cache tests

`429a9cd` Use fold points to go to display map's prev/next line boundary

`bb9ade5` Fix wrap map test

`2b59f27` Fix fold map tests

`0972766` Add more hint tests

`15e0feb` Move highlights from fold to inlay randomized tests

`667b70a` Move hint settings on the language level

`480d8c5` Theme hints and suggestions differently

`3312c91` Improve inlay hint highlights

`2c54d92` Test inlay hint cache

`143a020` Update Hint Style

`67214f0` Only skip /refresh inlay queries when vislble range is not updated

`096bad1` Revert useless changes, simplify

`f77b680` Account for inlay biases when clipping a point

`976edfe` Add `Cursor::next_item`

`5c21ed4` Properly filter out task hints

`dfb3021` Remove mutex usage from *Map contents

`acef5ff` Query hints when editors gets open and visible

`11fee4c` Do not eagerly cancel running tasks

`4d4544f` Split excerpts into mutliple ranges for inlay hint queries

`2c7900e` Use excerpt visible range in query filtering

`83b3a91` Support better inlay cache parallelization

`890b164` Forward inlay hint refresh requests to clients, test coop inlay hints

`a68e68a` Properly filter out new hints outside of excerpts' visible ranges

`ba3d1e4` Deduplicate inlay hints queries with buffer versions

`f25a09b` Avoid excessive allocations with Arc around excerpt cached inlays

`48982c3` Filter away new hints not in excerpt range

`316e19c` Remove stale cancelled inlay hints workaround

`96a34ad` Use text anchors as hint position in hints cache

`781fa0c` Deduplicate LSP requests on multibuffer scroll

`c61de29` Use proper anchors for remote LSP queries

`cb4b92a` Simplify hint event management slightly

`d59e91a` Insert new hints into cache better

`d682858` Box the cache for better performance

`1722d61` Mitigate odd offset calculations

`7fddc22` Move away heavy inlay computations into background tasks

`31f0f9f` Forbid extra inlay updates

`97e5d40` Add snapshot version to use when avoiding wrong state updates

`8d982a6` Finish modelling

`4c78019` Start to model the background threads for InlayHintCache

`2f1a276` React on multibuffer scrolls again

`a31d3ec` Spawn cache updates in separate tasks

`9698b51` Prevent insertion of empty inlays into `InlayMap`