any means none means false (ie there exist) unless upstream reports a reason

Stephen Paul Weber created 3 years ago

Change summary

src/main/java/eu/siacs/conversations/entities/Presences.java             | 3 
src/main/java/eu/siacs/conversations/services/XmppConnectionService.java | 3 
2 files changed, 3 insertions(+), 3 deletions(-)

Detailed changes

src/main/java/eu/siacs/conversations/entities/Presences.java

@@ -152,7 +152,8 @@ public class Presences {
     public boolean anyIdentity(final String category, final String type) {
         synchronized (this.presences) {
             if (this.presences.size() == 0) {
-                return true;
+                // https://github.com/iNPUTmice/Conversations/issues/4230
+                return false;
             }
             for (Presence presence : this.presences.values()) {
                 ServiceDiscoveryResult disco = presence.getServiceDiscoveryResult();

src/main/java/eu/siacs/conversations/services/XmppConnectionService.java

@@ -234,8 +234,7 @@ public class XmppConnectionService extends Service {
             }
         }
 
-        if (contact.getPresences().size() > 0 &&
-            contact.getPresences().anyIdentity("gateway", "pstn")) {
+        if (contact.getPresences().anyIdentity("gateway", "pstn")) {
             contact.registerAsPhoneAccount(this);
         }
     };