ConcurrentModificationException can only be triggered by (a) obviously,
multiple threads modifying the same collection or (b) one thread which
modifies the thread while iterating over it (see [here](https://docs.oracle.com/javase/8/docs/api/java/util/ConcurrentModificationException.html)). Assuming that `systemTags` doesn't alias `this.systemTags`, it must be (a). Also, the stacktrace we got comes from inside `old.equals`. consider:
```java
final JSONArray old = this.systemTags;
this.systemTags = new JSONArray();
final JSONArray old = this.systemTags;
...
this.systemTags.put(...)
!old.equal(...)
```
and we get ConcurrentModificationException bc Thread 2's `old` alias's
thread 1's `this.systemTags`

The patch fixes this bug by making suring that no references escape
function scope, so no aliasing can occur.

This can work around if your local resolver strips DNSSEC, but also it
means resolution is bonkers slow and might even take forever / fail if
DNS queries are blocked (because you're on TOR VPN or similar). So if
recursive DNSSEC fails, just fail DNSSEC and fall back to regular DNS lookups.

ticket: https://todo.sr.ht/~singpolyma/soprani.ca/502

- now `EmojiSearch.emoji` is truly immutable, in the sense that its
members are not mutated after being inserted.
- attempt to fix: https://todo.sr.ht/~singpolyma/soprani.ca/473

codepath is deleteAvatar, which is setAvatar(from, null)

If we have them

fixes NPE when using 'Return to ongoing call' context button

otherwise causes NetworkOnMainThreadException

trouble reproducing reports of failure stemming from
`WebRTCWrapper.applyDtmfTone` failing on this constructor, specifically:
```
at android.media.ToneGenerator.native_setup(Native Method)
at android.media.ToneGenerator.<init>(ToneGenerator.java:751)
```
so we log the error for next time and catch it to prevent crashing, and
instead just dont play the tone

- in CommandSession constructor, must construct a hard reference to the
  ViewPager to make garbage collection impossible until at least
  `getContext()` is called
- in setupLayoutManager, current code doesn't have a case for if mPager
  is null. Probably we wouldn't be there anyway, but in any case the
  `ctx` parameter should be equivalent, i.e., it should refer to the
  ActivityContext, so we use that instead of going through mPager

ConversationFragment.onOptionsItemSelected was using break statements
instead of return true for handled menu items. This caused the method to
return false (from super.onOptionsItemSelected), indicating the event was
not handled.

On tablets with split-pane view, this caused menu events to bubble from the
temporary fragment in ConversationsOverviewFragment to the visible
ConversationFragment, resulting in duplicate actions. For example, selecting
"Contact details" from the context menu would open contact details twice:
first for the selected conversation (correct), then for the currently active
conversation (wrong), with the wrong one appearing on top.

Fixed by changing all break statements to return true, matching the pattern
already used in onContextItemSelected. This also adds a missing return after
action_block_avatar which was previously falling through to the next case.

Fixes: https://todo.sr.ht/~singpolyma/soprani.ca/437

was causing all backup restores to fail,
service was never even created

previously, would crash whole app

`if (url != null) {` makes it seem like we were
fine with the subsequent code not running anyway

* '442-connect-via-tor-not-working' of https://git.secluded.site/cheogram-android:
  fix(settings): enable Tor conns for other flavs

Remove QuickConversationsService.isConversations() checks from
AppSettings.java (isUseTor, isExtendedConnectionOptions) to allow Tor
connections in non-Conversations flavours.

I tested by installing with a modified package ID, adding a new account,
enabling the Tor toggle, and seeing that 0 out of 1 accounts were
connected because Tor is unavailable. After installing/enabling Orbot
and waiting a bit, I had to toggle the account to get it to try again.

Fixes: https://todo.sr.ht/~singpolyma/soprani.ca/442

for better compatibility with scanners

including startconversation