e3b3618
attempt to have graphql connections implemented with generics instead of code generation. Currently fails as gqlgen can't bind to generic types.
54306a8
test(808): make build tag compatible with Go 1.16
Steve Moyer
created
99669d7
test(808): do not run golden file tests on Windows
Steve Moyer
created
1a504e0
fix(808): simplify handling of Windows line terminations
Steve Moyer
created
5982e8f
chore(808): merge in LocalStorage namespace configuration
Steve Moyer
created
8fc93d8
Merge branch 'master' into fix/778-git-bug-rm-broken
Steve Moyer
created
cd1099a
fix(808): replace Windows line terminators
Steve Moyer
created
dd8134b
Merge pull request #803 from MichaelMure/feat/configurable-local-storage
Click to expand commit body
Feat/configurable local storage
Michael Muré
created
ee0bac6
Merge pull request #813 from MichaelMure/fix-data-race2
Click to expand commit body
Github: fix data race
Michael Muré
created
c2d7b12
Merge pull request #811 from MichaelMure/fix-data-race
Click to expand commit body
graphql: fix two invalid mutex lock leading to data races
Michael Muré
created
7348fb9
github: fix data race when closing event channel
Click to expand commit body
I believe the issue was twofold:
When done importing, the calling context is likely still valid, so if the output channel is not read enough and reach capacity, some event producer down the line can be blocked trying to send in that channel. When closing it, this send is still trying to proceed, which is illegal in go.
In rateLimitHandlerClient, there was a need to 2 different type of output channel: core.ExportResult and ImportEvent. To do so, the previous code was using a single channel type RateLimitingEvent and a series of goroutines to read/cast/send to the final channel. This could result in more async goroutine being stuck trying to send in an at-capacity channel. Instead, the code now use a simple synchronous callback to directly push to the final output channel. No concurrency needed anymore and the code is simpler.
Any of those fixes could have resolved the data race, but both fixes is more correct.
Michael Muré
created
fe23123
graphql: fix two invalid mutex lock leading to data races
Michael Muré
created
eda312f
fix(778): remove extra mutex lock when resolving bug prefix
Steve Moyer
created
295da9c
cache: ensure that the default repo has a non-empty name to make js/apollo happy
Michael Muré
created
96327c3
Merge pull request #806 from MichaelMure/docs