Commit log

3605df4 Merge branch 'send-big-or-bad-mime-as-link' into 'master'

Click to expand commit body
Added method to send link via SMS on large file sizes and unsupported MIME types.

See merge request soprani.ca/sgx-bwmsgsv2!16

Stephen Paul Weber created

9595ade Added comments to new code blocks.

root root created

d5f7384 Added commented link for MIME type support

root root created

eee0826 Added method to send link via SMS on large file sizes and unsupported MIME types.

root21 created

e18e0b6 Merge branch 'allow_updating_user_registration' into 'master'

Click to expand commit body
Allow updating existing user registration

See merge request soprani.ca/sgx-bwmsgsv2!15

Christopher Vollick created

339caef Allow updating existing user registration

Stephen Paul Weber created

449c2e4 Use new blather properly

Stephen Paul Weber created

23eaf6b Merge branch 'ibr-refactor' into 'master'

Click to expand commit body
Ibr refactor

See merge request soprani.ca/sgx-bwmsgsv2!14

Stephen Paul Weber created

e144002 Refactor IBR get/form to use the IBR helpers

Stephen Paul Weber created

cf71abd Refactor IBR set code to use the IBR helpers

Stephen Paul Weber created

e74bae8 Merge branch 'error-refactor' into 'master'

Click to expand commit body
Error refactor

See merge request soprani.ca/sgx-bwmsgsv2!13

Christopher Vollick created

cddd64b Return meaningful text from bandwidth errors

Stephen Paul Weber created

7739701 Use blather error method

Stephen Paul Weber created

5c053fe Merge branch 'tests' into 'master'

Click to expand commit body
Initial test framework and some tests

See merge request soprani.ca/sgx-bwmsgsv2!12

Christopher Vollick created

f6e362c Initial test framework and some tests

Stephen Paul Weber created

bed6a72 Merge branch 'reply-to-remove' into 'master'

Click to expand commit body
Reply to IBR remove request

See merge request soprani.ca/sgx-bwmsgsv2!11

Christopher Vollick created

f770000 Reply to IBR remove request

Click to expand commit body
Otherwise caller times out waiting for it

Stephen Paul Weber created

f1e2313 Merge branch 'fix-for-older-redis' into 'master'

Click to expand commit body
Need Redis 7 for NX and GET together

See merge request soprani.ca/sgx-bwmsgsv2!10

Christopher Vollick created

44c4cd8 Need Redis 7 for NX and GET together

Stephen Paul Weber created

5c5482e Typo

Stephen Paul Weber created

b423b9e Merge branch 'sentry' into 'master'

Click to expand commit body
Instrument for sentry

See merge request soprani.ca/sgx-bwmsgsv2!9

Christopher Vollick created

778b90f Instrument for sentry

Stephen Paul Weber created

b14063e Hotfixes

Stephen Paul Weber created

57cde84 Merge branch 'allow-unregister' into 'master'

Click to expand commit body
Unregister when asked

See merge request soprani.ca/sgx-bwmsgsv2!7

Christopher Vollick created

15be6a7 Merge branch 'v1-is-dead' into 'master'

Click to expand commit body
v1 is dead, remove hacks

See merge request soprani.ca/sgx-bwmsgsv2!8

Christopher Vollick created

2c59c74 v1 is dead, remove hacks

Stephen Paul Weber created

e8530d1 Actually remove registration when asked

Stephen Paul Weber created

4217dbf Refactor knowledge of registration persistance to RegistrationRepo

Click to expand commit body
Keeps all knowledge about redis key structure, etc, in one place.

Stephen Paul Weber created

52fe3db Rack 2 breaks goliath

Stephen Paul Weber created

331f212 Get rubocop running again

Click to expand commit body
Not clean yet, but at least it runs

Stephen Paul Weber created

e786e90 Require from gem not relative

Stephen Paul Weber created

85b99a5 Merge branch 'use-empromise-gem' into 'master'

Click to expand commit body
Use new em_promise.rb gem

See merge request soprani.ca/sgx-bwmsgsv2!2

Stephen Paul Weber created

5ff13ff Merge branch 'remove-unused-usage-redis' into 'master'

Click to expand commit body
Remove unused redis usage data

See merge request soprani.ca/sgx-bwmsgsv2!6

Stephen Paul Weber created

5b38d8d Merge branch 'feature-not-implemented' into 'master'

Click to expand commit body
Simplify iq feature-not-implemented

See merge request soprani.ca/sgx-bwmsgsv2!5

Stephen Paul Weber created

df8d1af Remove unused redis usage data

Click to expand commit body
This redis key is not used anymore

Stephen Paul Weber created

8f9ed4b Simplify iq feature-not-implemented

Stephen Paul Weber created

127caeb Merge branch 'no-cheogram-hardcode' into 'master'

Click to expand commit body
Send to the correct target, do not assume cheogram

See merge request soprani.ca/sgx-bwmsgsv2!4

Stephen Paul Weber created

64a6291 Send to the correct target, do not assume cheogram

Click to expand commit body
Backport from prod hotfix

Stephen Paul Weber created

0884217 Merge branch 'support-more-delivery-failure-metadata' into 'master'

Click to expand commit body
Log the errorCode and description for deliver-failure

See merge request soprani.ca/sgx-bwmsgsv2!3

Stephen Paul Weber created

9b5d446 Give user a tiny bit more context about their failure

Click to expand commit body
Let them see the human readable failure description

Stephen Paul Weber created

c7f21dc Log the errorCode and description for deliver-failure

Click to expand commit body
deliveryCode and deliveryDescription were the v1 equivalents, but this is v2

Stephen Paul Weber created

5a2ea93 Use new em_promise.rb gem

Stephen Paul Weber created

d2e1163 copy sgx-catapult .all Deferable; not factored yet

Click to expand commit body
Specifically https://gitlab.com/ossguy/sgx-catapult/commit/583f98b is
copied here.  While there was another commit in that merge request (at
https://gitlab.com/ossguy/sgx-catapult/merge_requests/20), that commit
(https://gitlab.com/ossguy/sgx-catapult/commit/8f9e588) was already
included in 9d556e1 so we don't need to copy the entire merge request
here, only the single commit in that merge request that included the
"Allow EMPromise.all to accept both Promise and Deferable" part.

Note that this is required in sgx-bwmsgsv2 since jmp-fwdcalls uses it
and jmp-fwdcalls must be able to run with either sgx-catapult or
sgx-bwmsgsv2.  As an example, the following commit and MR require it:
https://gitlab.com/ossguy/jmp-fwdcalls/commit/405ef3c and
https://gitlab.com/ossguy/jmp-fwdcalls/merge_requests/12 .

We are doing the copy here since we haven't properly refactored the
common parts of sgx-catapult and sgx-bwmsgsv2 so they can, for
example, share one em_promise.rb file.

Denver Gingerich created

9d556e1 merge "CI and Lint" plus extra "not a script" fix

Click to expand commit body
See merge request !1 for the discussion and details behind the merge.

Denver Gingerich created

8f41b5a Add CI to run linter and also comply with the linter

Click to expand commit body
The metrics changes in .rubocop.yml definitely need to be reset to defaults, but
the required refactors are too big for this change alone so for now they were
increased to make it pass.

Other disabled rules may want to be revisited in the future also.

At least this passes its own ruleset now, and can run on sourcehut CI for every
commit.

Stephen Paul Weber created

f7d6273 fix eddafea as some bad reqs have non-empty params

Click to expand commit body
This fix is ported in from sgx-catapult, where we made the fix in
https://gitlab.com/ossguy/sgx-catapult/commit/c8fd695 - it is fairly
simple, but also fairly important.  Here is the description (with
edits made to show the corresponding commit IDs in this repo):

Sometimes HTTP requests to the port that sgx-bwmsgsv2 is running on
are slightly less naive - for example, with a path of:

  /web-meetme/conf_cdr.php?bookId=1

In this case params is indeed non-empty so we need to also catch this
case.  To be extra safe, we do so by rejecting both non-POST and
non-"root" requests.  Hopefully this will suffice for the situations
we care about, though of course the better solution would be to do
actual request validation.  We'll save that for later.

As with eddafea we have the same error/crash without this fix (if we
got an HTTP request of the above form):

  Shutting down gateway due to exception 013: no implicit conversion of nil into String

Denver Gingerich created

0349b26 fix disco code so non-:get disco <iq>s are ignored

Click to expand commit body
A copy of https://gitlab.com/ossguy/sgx-catapult/commit/a887c61 :

This is not 100% correct, but it's close enough for our purposes and
we left a TODO in case someone wants to fix it properly in the future.
This fix will at least prevent feedback loops of the type we had
previously with components like Cheogram.

Denver Gingerich created

eddafea don't crash on naive (parameter-less) HTTP request

Click to expand commit body
This fix is ported in from sgx-catapult, where we made the fix in
https://gitlab.com/ossguy/sgx-catapult/commit/300def9 - it is fairly
simple, but also fairly important.  Here is the description:

Without this fix, one will get the following error (and subsequent
crash) if the port that sgx-catapult is running on receives a naive
HTTP request, such as a "GET /" (from Wget or curl or similar):

  Shutting down gateway due to exception 013: no implicit conversion of nil into String

Denver Gingerich created

002c54c pass on to_catapult() ret val instead of ignoring

Click to expand commit body
This is a cross-merge of the fix done to sgx-catapult in
https://gitlab.com/ossguy/sgx-catapult/commit/89598a8 - it has no
effect in sgx-bwmsgsv2 for now, but will help once we cross-merge the
blocking code (to be done later).

We just have one fix left until we otherwise have fix-/feature-parity
with sgx-catapult.

Denver Gingerich created

3f11459 merge in "Clean up oob" incl. always on MMS-on-OOB

Click to expand commit body
This is a cross-merge of what we did in sgx-catapult already, in
https://gitlab.com/ossguy/sgx-catapult/commit/f95aab3 - see
https://gitlab.com/ossguy/sgx-catapult/merge_requests/19 for further
details.  The merge is not exact, as there has been some drift in
sgx-bwmsgsv2 since this was done in sgx-catapult, so indentation and
some s/next/return/ caused it to be a bit off.  But it should be fine.

This effectively removes the option to turn off MMS-on-OBB, and since
that has already been removed in sgx-catapult (per above), we can now
remove it from jmp-acct_bot as there are no further users (to be done
in a future commit).

With this commit we are getting close to feature-/fix-parity with
sgx-catapult, aside from the message blocking feature (which we won't
need to merge for a while yet).

Denver Gingerich created