d2e1163
copy sgx-catapult .all Deferable; not factored yet
Click to expand commit body
Specifically https://gitlab.com/ossguy/sgx-catapult/commit/583f98b is
copied here. While there was another commit in that merge request (at
https://gitlab.com/ossguy/sgx-catapult/merge_requests/20), that commit
(https://gitlab.com/ossguy/sgx-catapult/commit/8f9e588) was already
included in 9d556e1 so we don't need to copy the entire merge request
here, only the single commit in that merge request that included the
"Allow EMPromise.all to accept both Promise and Deferable" part.
Note that this is required in sgx-bwmsgsv2 since jmp-fwdcalls uses it
and jmp-fwdcalls must be able to run with either sgx-catapult or
sgx-bwmsgsv2. As an example, the following commit and MR require it:
https://gitlab.com/ossguy/jmp-fwdcalls/commit/405ef3c and
https://gitlab.com/ossguy/jmp-fwdcalls/merge_requests/12 .
We are doing the copy here since we haven't properly refactored the
common parts of sgx-catapult and sgx-bwmsgsv2 so they can, for
example, share one em_promise.rb file.
Denver Gingerich
created
9d556e1
merge "CI and Lint" plus extra "not a script" fix
Click to expand commit body
See merge request !1 for the discussion and details behind the merge.
Denver Gingerich
created
8f41b5a
Add CI to run linter and also comply with the linter
Click to expand commit body
The metrics changes in .rubocop.yml definitely need to be reset to defaults, but
the required refactors are too big for this change alone so for now they were
increased to make it pass.
Other disabled rules may want to be revisited in the future also.
At least this passes its own ruleset now, and can run on sourcehut CI for every
commit.
Stephen Paul Weber
created
f7d6273
fix eddafea as some bad reqs have non-empty params
Click to expand commit body
This fix is ported in from sgx-catapult, where we made the fix in
https://gitlab.com/ossguy/sgx-catapult/commit/c8fd695 - it is fairly
simple, but also fairly important. Here is the description (with
edits made to show the corresponding commit IDs in this repo):
Sometimes HTTP requests to the port that sgx-bwmsgsv2 is running on
are slightly less naive - for example, with a path of:
/web-meetme/conf_cdr.php?bookId=1
In this case params is indeed non-empty so we need to also catch this
case. To be extra safe, we do so by rejecting both non-POST and
non-"root" requests. Hopefully this will suffice for the situations
we care about, though of course the better solution would be to do
actual request validation. We'll save that for later.
As with eddafea we have the same error/crash without this fix (if we
got an HTTP request of the above form):
Shutting down gateway due to exception 013: no implicit conversion of nil into String
Denver Gingerich
created
0349b26
fix disco code so non-:get disco <iq>s are ignored
Click to expand commit body
A copy of https://gitlab.com/ossguy/sgx-catapult/commit/a887c61 :
This is not 100% correct, but it's close enough for our purposes and
we left a TODO in case someone wants to fix it properly in the future.
This fix will at least prevent feedback loops of the type we had
previously with components like Cheogram.
Denver Gingerich
created
eddafea
don't crash on naive (parameter-less) HTTP request
Click to expand commit body
This fix is ported in from sgx-catapult, where we made the fix in
https://gitlab.com/ossguy/sgx-catapult/commit/300def9 - it is fairly
simple, but also fairly important. Here is the description:
Without this fix, one will get the following error (and subsequent
crash) if the port that sgx-catapult is running on receives a naive
HTTP request, such as a "GET /" (from Wget or curl or similar):
Shutting down gateway due to exception 013: no implicit conversion of nil into String
Denver Gingerich
created
002c54c
pass on to_catapult() ret val instead of ignoring
Click to expand commit body
This is a cross-merge of the fix done to sgx-catapult in
https://gitlab.com/ossguy/sgx-catapult/commit/89598a8 - it has no
effect in sgx-bwmsgsv2 for now, but will help once we cross-merge the
blocking code (to be done later).
We just have one fix left until we otherwise have fix-/feature-parity
with sgx-catapult.
Denver Gingerich
created
3f11459
merge in "Clean up oob" incl. always on MMS-on-OOB
Click to expand commit body
This is a cross-merge of what we did in sgx-catapult already, in
https://gitlab.com/ossguy/sgx-catapult/commit/f95aab3 - see
https://gitlab.com/ossguy/sgx-catapult/merge_requests/19 for further
details. The merge is not exact, as there has been some drift in
sgx-bwmsgsv2 since this was done in sgx-catapult, so indentation and
some s/next/return/ caused it to be a bit off. But it should be fine.
This effectively removes the option to turn off MMS-on-OBB, and since
that has already been removed in sgx-catapult (per above), we can now
remove it from jmp-acct_bot as there are no further users (to be done
in a future commit).
With this commit we are getting close to feature-/fix-parity with
sgx-catapult, aside from the message blocking feature (which we won't
need to merge for a while yet).