two fixes related to eSIM nicks:

Phillip Davis created 4 months ago

1. actually expose nickanem at eSIM order-time
2. pass nickname to `SIMOrder.commit` as non-kw arg in eSIM sublcass

Change summary

lib/sim_order.rb | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)

Detailed changes

lib/sim_order.rb

@@ -119,7 +119,14 @@ protected
 		end
 
 		def self.fillable_fields
-			[]
+			[
+				{
+					type: "text-single",
+					var: "nickname",
+					label: "Nickname",
+					required: false
+				}
+			]
 		end
 
 		# @param [Blather::Stanza::Iq] iq the stanza
@@ -127,7 +134,7 @@ protected
 		def complete(iq)
 			EMPromise.resolve(nil).then {
 				commit(
-					nickname: iq.form.field("nickname")&.value.presence || self.class.label
+					iq.form.field("nickname")&.value.presence || self.class.label
 				)
 			}.then do |sim|
 				ActivationCode.new(sim).complete